- 14 Sep, 2018 40 commits
-
-
Dave Tapuska authored
Current scroll chain was incorrectly using a deque of ints as opposed to a DOMNodeId chain (which is a 64 bit field) Use wtf_size_t when dealing with WTF containers. BUG=588506 Change-Id: I4f9e45062c931bee5014c9f3efad80147cf8a79c Reviewed-on: https://chromium-review.googlesource.com/1226363Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#591464}
-
Robbie McElrath authored
As more classes get migrated from NetworkChangeManager to NetworkConnectionTracker, more and more tests need a TestNetworkConnectionTracker instance set up, including many tests that are pulling in the NetworkConnectionTracker indirectly, so shouldn't need to set up the test instance themselves. To make sure all tests have access to the test instance, this CL makes TestNetworkConnectionTracker a singleton that is setup at the beginning of each test suite, which ensures only one instance is ever created, and it's torn down at the right time. Bug: 868015 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I90ca6ddfa1669f476b03fa7e27230288dfc4101e Reviewed-on: https://chromium-review.googlesource.com/1214081Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#591463}
-
Mitsuru Oshima authored
ImmersiveFullscreenController replaces the targeter to ResizeHandleWindowTargeter, which will make the input hit test not considering Chrome caption. BUG=b:113815571 TEST="Manual tests. exo_unittests." Change-Id: I9de803b24cf64034f2c0f60e04acf147a230ec95 Reviewed-on: https://chromium-review.googlesource.com/1226812Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#591462}
-
Xiaohan Wang authored
Bug: 883494 Test: Updated test case to make sure the value is passed through. Change-Id: I2d74978bd29c048b5aac8e51d12ef46db0009450 Reviewed-on: https://chromium-review.googlesource.com/1224597 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Rintaro Kuroiwa <rkuroiwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#591461}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c7d935899ab9..d574123c5035 git log c7d935899ab9..d574123c5035 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 buildbot@webrtc.org Roll chromium_revision 2c0c7dfd..1d75f6fc (591272:591373) 2018-09-14 sprang@webrtc.org Add hysteresis to enabling of simulcast streams. 2018-09-14 srte@webrtc.org Removes legacy PacketQueue implementation. Created with: gclient setdep -r src/third_party/webrtc@d574123c5035 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1875e88dcd3db697ee4df1f9121b7faceff0bb18 Reviewed-on: https://chromium-review.googlesource.com/1226389Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591460}
-
Dana Fried authored
This change adds an object which can access the UWP accessibility settings and listen on change events. It is used by the Windows implementation of display::Screen to listen for text zoom changes, which we have made the decision to support by changing our overall scaling by the same percentage (as anything more thorough would be prohibitively expensive in the current architecture). We achieve compliance by multiplying DPI and text zoom scaling together, the approach recommended as a stopgap by both our engineers and those working on a11y at Microsoft. Note that while this affects *most* UI within Chrome, it does not affect *all* UI - some elements (such as resize frame) are drawn by the system and are only scaled by DPI. A side effect is that all zoom factors are rounded to the nearest 25%, so for instance, a net zoom of 190% will be rounded up to 200%. This will prevent DPI * Zoom factors that are not even multiples of 25% from creating blurry or smeared Chrome rendering or similar artifacts, which we have already seen as a result of problems with DPI scaling. Another effect is to decouple physical DPI from screen scaling, which has necessitated some small changes to the Windows Glass frame as well as the handler for the DPI changed Windows event. Without these changes serious visual artifacts and DCHECK failures can occur because systems are reporting/using different measurements for DPI. Changes to the Glass frame were necessary because Windows paints the resize handle around the window and does not use the text scale factor as part of its size calculation. Bug: 866513 Change-Id: Ia99d1f3c1b2aff973d63bd7ff637b01f166cd843 Reviewed-on: https://chromium-review.googlesource.com/1214747Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#591459}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4aefea51330c..7437f9dd69ca git log 4aefea51330c..7437f9dd69ca --date=short --no-merges --format='%ad %ae %s' 2018-09-14 athilenius@google.com Revert "Add tael and tatl to default PreCQ" Created with: gclient setdep -r src/third_party/chromite@7437f9dd69ca The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3aa70e3ada29591f79ac5325d6d3a5b7afb266e9 Reviewed-on: https://chromium-review.googlesource.com/1226388Reviewed-by:
-
liberato@chromium.org authored
This CL causes D3D11VideoDecoder to refuse to play back encrypted media, unless the D3D11EncryptedMedia flag is set. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia4c01c75ee84c37e047a548af18e8fe2bc3fce91 Reviewed-on: https://chromium-review.googlesource.com/1226100Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#591457}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0f4c772ee290..6d5f1bc2e846 git log 0f4c772ee290..6d5f1bc2e846 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 31666470+s-perron@users.noreply.github.com Allow merge blocks to merge two header blocks in some cases. (#1890) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@6d5f1bc2e846 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie522f1c01182645b80851be6b61d4b60001d15a9 Reviewed-on: https://chromium-review.googlesource.com/1227150Reviewed-by:
-
Charlie Harrison authored
This API is deprecated. Bind is replaced by BindOnce which is a semantics change, but shouldn't result in a behavior change. Bug: 884057 Change-Id: I06e728a88a84ed6e042e6f2e90f5a0ad9d40eecb Reviewed-on: https://chromium-review.googlesource.com/1225994Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#591455}
-
Xida Chen authored
In this CL, we append the unique_touch_event_id to a debug string, at the time when we get ACK for touch sequence start and touch sequence end, this way we'd know their correspondences. Bug: 851644 Change-Id: I2ee486bb2a2348a14e74a17e32f495aceaaab374 Reviewed-on: https://chromium-review.googlesource.com/1226820 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591454}
-
Vikas Soni authored
Bug: 838725 Change-Id: I379b72f1c1c3e428e9892d94a6c554da74bbf5db Reviewed-on: https://chromium-review.googlesource.com/1225971Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#591453}
-
Xiaohan Wang authored
Bug: 854943 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6c53ae4eac8526117cf2485f481302020f9bf0d7 Reviewed-on: https://chromium-review.googlesource.com/1225296Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#591452}
-
Robert Ogden authored
Adds the chrome-proxy auth header plumbed from DRP and the ect header to every lite page request. Also moves around some DRP testing functions to help with the browser test for this CL. Also fixes a small DRP bug which is tickled causing the chrome-proxy-ect header to be removed on HTTPS requests. Bug: 864652, 864654 Change-Id: I215d99591c4cf29cc373183dac2db694e6e75c3e Reviewed-on: https://chromium-review.googlesource.com/1223333Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#591451}
-
James Cook authored
During OOBE and normal user login, when SessionController::SetUserSessionOrder() is called there is an existing user session, so last_active_account_id.is_valid() returns true and the observer never fires. I suspect this breaks some accessibility features in kiosk mode (magnifier keyboard control) and for hotrod (long-press for spoken feedback). It's probably been broken since the observer was added in May: https://chromium-review.googlesource.com/c/chromium/src/+/1070771 Bug: 884275 Test: added to ash_unittests Change-Id: Idbe4f20b7426742703995a05c7ebb1c5c8f1a7c8 Reviewed-on: https://chromium-review.googlesource.com/1226876Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#591450}
-
Xianzhu Wang authored
The new name is the same as the existing name used in cc::EffectNode. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3eb99897797e849a4e6fd3a96181473d5eb03bf9 Reviewed-on: https://chromium-review.googlesource.com/1226018Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591449}
-
kylechar authored
When using InProcessCommandBuffer for OOP-D we weren't tracking texture memory correctly as there was no MemoryTracker instance created along with the ContextGroup. This CL fixes that by pulling GpuCommandBufferMemoryTracker out of CommandBufferStub into it's own header. GpuCommandBufferMemoryTracker is generalized a bit not to require a GpuChannel* on construction but otherwise functions the same. For platforms other than WebView, InProcessCommandBuffer will create a GpuCommandBufferMemoryTracker. Unfortunately just implementing MemoryTracker doesn't fix memory reporting. MemoryAllocatorDumps for the same texture from multiple instances of TextureManager aren't linked together. This is because ShareGroupTracingGUID() doesn't return a share group id, it returns a command buffer id, so TextureManagers for different command buffers won't generate the same GUID. Fix this by removing ShareGroupTracingGUID(). All contexts are expected to be in the same share group, or virtualized to the same context in ANGLE, so differentiating between share groups isn't necessary. Add CommandBufferId() for when the command buffer id is desired. Bug: 876508 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie084061d321ffa49ca7c31619707e60dfca3dd97 Reviewed-on: https://chromium-review.googlesource.com/1211955Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#591448}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b5e878155404..53f9d8726afd git log b5e878155404..53f9d8726afd --date=short --no-merges --format='%ad %ae %s' 2018-09-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@53f9d8726afd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I46d93d3a8fe5b24e0542a4f356905364aa9c0990 Reviewed-on: https://chromium-review.googlesource.com/1227230Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7f2329398fe8..4230d4847fdc git log 7f2329398fe8..4230d4847fdc --date=short --no-merges --format='%ad %ae %s' 2018-09-14 jmadill@chromium.org Finish fixing EGL enums. 2018-09-14 jmadill@chromium.org Vulkan: Fix cube map attachment clears and readpixels. Created with: gclient setdep -r src/third_party/angle@4230d4847fdc The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I76d85fbf89bdb85ec154df1c7c2f96b5dc1f00e4 Reviewed-on: https://chromium-review.googlesource.com/1226029Reviewed-by:
-
Chris Harrelson authored
To do this, use the base::Optional pattern instead of a scoped_refptr. Bug: 459810 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I64ada0722e1e04b1f0402c6d3e9d2ed4879164dd Reviewed-on: https://chromium-review.googlesource.com/1226072 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591445}
-
Vladimir Levin authored
My previous patch missed one spot where we can unalias a node which is actually null. This patch fixes up that spot. R=pdr@chromium.org, chrishtr@chromium.org Bug: 884081, 884083, 884084, 884186 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic12a21c429c4984cb18f92f6beac8c18c0f51f87 Reviewed-on: https://chromium-review.googlesource.com/1227147Reviewed-by:
-
Steven Holte authored
This is a simple macro rename, with no functional changes. The old name was deprecated, this is just cleaning up usage. TBR=creis Bug: 737689 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2b985990eb3c4fd13b4af6aa832c99834790ef78 Reviewed-on: https://chromium-review.googlesource.com/1173327Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#591443}
-
Stephen McGruer authored
This is an obsolete prefixed alias of TransitionEvent. An intent-to-remove has been sent, and has got LGTM*3. Blink intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/0Szv8vDQh_c/flTY7ZClBwAJ Bug: 695504 Change-Id: Ibf8083fabac8cab474e64bb37e99e62b39b3616d TBR=timvolodine@chromium.org Change-Id: Ibf8083fabac8cab474e64bb37e99e62b39b3616d Reviewed-on: https://chromium-review.googlesource.com/1221689Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#591442}
-
agrieve authored
Change-Id: Id8f0973b8a9abac411053401cc47b3db136618b5 Reviewed-on: https://chromium-review.googlesource.com/1226386Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#591441}
-
Vikas Soni authored
Add a new pixel test which creates and rasterizes multiple tiles. This test is meant to check if all tiles are drawn correctly without overwriting each other contents. Bug: 883500 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I83190b6f887122aaf76cfd74533650e732391cdf Reviewed-on: https://chromium-review.googlesource.com/1222890Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#591440}
-
Scott Violet authored
PerformWmAction was provided as a way to have the window manager perform an action not known to the window service. The window-service defined this api so that a window's id could be passed, which is unique to the client. A more generic approach is to allow the environment hosting the window service to supply arbitrary associated interfaces that are not known to the window service. It's important the interface is associated so that we can know the ordering. That's what this patch does. This adds WindowTree::BindWindowManagerInterface() that takes a name and handle. The name is the name of the interface (every mojom interface has a name). The function is typed to associated WindowManager& window_manager, but that is just a necessity of the mojom. It's used to request *any* interface. In fact requesting ws::mojom::WindowManager won't work at all. An interface needs to be named here as there is no way in a mojom to say *any* associated interface. This also converts the one use of PerformWmAction to an interface defined by ash, AshWindowManager. BUG=883947 TEST=covered by tests Change-Id: I21870a1d173352b596716cd1a807b591385f8a2b Reviewed-on: https://chromium-review.googlesource.com/1225693Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#591439}
-
rbpotter authored
These tests are flaky on the Chrome OS MSAN bot. Bug: 882606 Change-Id: Ia4a8eaf07b4f0d649f197a89290595a3250a9f3d Reviewed-on: https://chromium-review.googlesource.com/1217715 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#591438}
-
Artur Khachatryan authored
Adding a comma at the end of the newly added entry Change-Id: I3d3fb4f86fbedea46489737abb602321f07a67dc Reviewed-on: https://chromium-review.googlesource.com/1227189Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#591437}
-
Raymond Toy authored
When the document goes away while the audio thread is running and trying to notify the document that audible audio has started, we can't create the necessary mojom interface. Just return because the document is gone. Bug: 882734, 882639 Change-Id: I168318fb0c44ceb564edeee223aa5f7ee46d43ef Reviewed-on: https://chromium-review.googlesource.com/1220568Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#591436}
-
Dave Tapuska authored
PointerEvent's types didn't match the IDL definitions. Use wtf_size_t when iterating WTF types. BUG=588506 Change-Id: Ic208216e5559f3eb43d90f95712b45b22d38dd2f Reviewed-on: https://chromium-review.googlesource.com/1227143Reviewed-by:
-
Chris Palmer authored
Bug: None Change-Id: I5f2b326a1b7b6c73156edfb43ceae6356433f4f2 Reviewed-on: https://chromium-review.googlesource.com/1226454 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Bailey Berro authored
Previously, if there were no valid NetworkInterfaces we would exit out of NetBios discovery, but the discovery timer would still be set causing a moved-from callback to be run twice. The crash was especially subtle becuase it required having no valid network interfaces, which is uncommon because both Wifi and Ethernet are valid interfaces. Bug: chromium:882972 Test: verified manually on Elm device Change-Id: I2e7a28aded718845a08669f464b60bba2bbc6174 Reviewed-on: https://chromium-review.googlesource.com/1226364 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#591433}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7557e7b0efc0..4dc8c50f81bd git log 7557e7b0efc0..4dc8c50f81bd --date=short --no-merges --format='%ad %ae %s' 2018-09-14 tsepez@chromium.org Make ContentParam::m_Name be a ByteString. 2018-09-14 thestig@chromium.org Initialize CBC_OneDimWriter members in the header. Created with: gclient setdep -r src/third_party/pdfium@4dc8c50f81bd The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I597af98c9ae8e0f5ce5489df6ece55db9a78bdd0 Reviewed-on: https://chromium-review.googlesource.com/1227151Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Only iOS makes use of image data for offline viewing. Skip image fetching to avoid network activity, and save memory usage in InMemoryContentStore. Bug: 864015 Change-Id: Ieda9e1155bcb96d9e01442af9898df8547c7af13 Reviewed-on: https://chromium-review.googlesource.com/1226520Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#591431}
-
David Bokan authored
Since rotation used to be supported only on Android, where windows can't be resized, we made the assumption that if the width changes it must be a rotation. This changes in ChromeOS where entering tablet mode enables rotation but also resizes the window (when entering tablet mode). This caused inappropriate rotation anchoring. The underlying issue has been fixed in other patches linked to this bug, the rotation trigger should be improved to check that the width and height are swapped. Bug: 831473 Change-Id: I0acd39d16319d8cb7819faac4c4ce54b6f7a2e46 Reviewed-on: https://chromium-review.googlesource.com/1224711Reviewed-by:
-
liberato@chromium.org authored
SequenceBound<T> allows for easy creation, posting, and destruction objects of type T on a designated Sequence. It does not expose the underlying pointer to T, so it's hard to accidentally pass them around in callbacks that are then run on the wrong thread. A SequenceBound<> may be created anywhere, passed (moved) between threads, etc., safely. Destruction of the SequenceBound schedules destruction of the underlying instance of T on the appropriate thread. Not implemented here (but prototyped elsewhere) are weak pointers to these objects that may be passed and used between threads safely; utility functions to generate thread-hopping callbacks; support for strong shared ownership semantics. Tests: sequence_bound_unittest.cc Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3bbf7e975884fce8e18f3bb15a0d211ead58a619 Reviewed-on: https://chromium-review.googlesource.com/875241 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#591429}
-
Tatiana Buldina authored
Make ExecuteSetAlertText() return kInvalidArgument according W3C standard Bug: chromedriver:2003 Change-Id: Ibd65e8861f0a3f17bb21b54b0d031b88de7dc05c Reviewed-on: https://chromium-review.googlesource.com/1226794Reviewed-by:
-
Edward Jung authored
Removed the fixed height of the blue button and corrected the icon alignment. Bug: 883316 Change-Id: I2928b0c45e4f4d7873105cddc9fa6b2a1aff6b7d Reviewed-on: https://chromium-review.googlesource.com/1222727Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#591427}
-
Wei-Yin Chen (陳威尹) authored
In DistillerTest.DistillMultiplePages, the images were added in an incorrect way, so that there were actually no images in the distilled results. Therefore, the image data matching in function VerifyArticleProtoMatchesMultipageData() were never executed. This was discovered when working on https://crbug.com/864015, and the lack of coverage was identified here: https://chromium-coverage.appspot.com/reports/590937/linux/chromium/src/components/dom_distiller/core/distiller_unittest.cc.html This CL fixes this by constructing the expected distillation correctly in CreateMultipageDistillerDataWithImages(). Bug: None Change-Id: Iaf6a1fc81ac956f362ee584d691b066dcde2dab7 Reviewed-on: https://chromium-review.googlesource.com/1226517Reviewed-by:
-
Christian Biesinger authored
It's more efficient (avoids a copy), as confirmed by inspecting the generated assembly. R=eae@chromium.org,ikilpatrick@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I55a0d9edded65545b2e7404e941f776a3e9978da Reviewed-on: https://chromium-review.googlesource.com/1226306 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#591425}
-
