GitLab

Nearly all instances of BindToLoop() can be replaced with BindToCurrentLoop(). The three instances of BindToLoop() that can't be replaced with BindToCurrentLoop() are better off not using BindToLoop() in the first place.

BUG=167240
TBR=jam

Review URL: https://codereview.chromium.org/66953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243983 0039d316-1c4b-4281-b951-d872f2087c98

R=kalman@chromium.org
BUG=293681

Review URL: https://codereview.chromium.org/93743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243980 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: Reverting on Canary to maintain port selection there.  Will land on Dev branch.

TBR=wtc@chromium.org,rch@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=329255

Review URL: https://codereview.chromium.org/132603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243979 0039d316-1c4b-4281-b951-d872f2087c98

Remove platform-specific handling for dictionary.

R=rlp@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/121523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243978 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314976
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/112663005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243977 0039d316-1c4b-4281-b951-d872f2087c98

This is to help debugging and make various failures less mysterious.

R=darin@chromium.org, abarth@chromium.org

Review URL: https://codereview.chromium.org/132283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243976 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Temporary staged doc: http://ypd-ubiq182.dls.corp.google.com:8009/sdk/release-notes.html

R=binji@chromium.org

Review URL: https://codereview.chromium.org/129793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243975 0039d316-1c4b-4281-b951-d872f2087c98

ui::TouchEvents now know the id of their source device.

The target of a touch can't be effected by a touch on another display.

BUG=315651
TEST=GestureRecognizerTest.GestureEventTouchLockIgnoresOtherScreens

Review URL: https://codereview.chromium.org/103173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243974 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/132213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243973 0039d316-1c4b-4281-b951-d872f2087c98

empty object rather than skipping them altogether. This is more consistent with
the expected behaviour of extension APIs.

BUG=330559
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/129153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243972 0039d316-1c4b-4281-b951-d872f2087c98

There are 2 scenarios when the GLHelper becomes invalid:

1. On lost context. In this case, the OwnedMailbox is reset and the
pointer is destroyed. However, the copy request result code would
continue trying to use the OwnedMailbox regardless. Instead we can
use this as a hint that the mailbox is no longer valid and abort the
readback.

2. On shutdown. Once the RenderWidgetHostViewAura is shutdown, there
is no way to easily tell if the GLHelper attached to the OwnedMailbox
being stored in copy request callbacks is still alive. Since a readback
on the RenderWidgetHostViewAura can not complete once the RWHVA class
is destroyed anyways, we can destroy the contents of the OwnedMailboxes
in flight at that time. This way when the readback is later aborted,
the OwnedMailbox does not try to clean itself up with a potentially
destroyed GLHelper.

R=piman@chromium.org
BUG=270918

Review URL: https://codereview.chromium.org/120913004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243971 0039d316-1c4b-4281-b951-d872f2087c98

LauncherItem adding/removing is repeated when a Window is dragged because
it is reparented to DockedContainer during the dragging.
ShelfWindowWatcher should prevent this removing when window is dragging.

R=sky@chromium.org
BUG=NONE
TEST=ash_unittests --gtest_filter=ShelfWindowWatcherTest*.*

Review URL: https://codereview.chromium.org/108313006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243970 0039d316-1c4b-4281-b951-d872f2087c98

Update directories for resource files

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/62873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243969 0039d316-1c4b-4281-b951-d872f2087c98

Also increase the states stored in the register to prevent
the setup code from running multiple times per version if
it fails to start one time.

BUG=329023

Review URL: https://codereview.chromium.org/120963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332410
TBR=kaznacheev@chromium.org

Review URL: https://codereview.chromium.org/125593006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243966 0039d316-1c4b-4281-b951-d872f2087c98

This is third CL for adding an item for dialog.
This cl adds new LauncherItemType, TYPE_DIALOG, and 
implements a context menu of item created by ShelfWindowWatcher.

R=sky@chromium.org
BUG=121242
TEST=NONE

Review URL: https://codereview.chromium.org/107163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243965 0039d316-1c4b-4281-b951-d872f2087c98

BUG=292238
TEST=ash_unittests --gtest_filter=*ShelfLayoutManagerTest*

Review URL: https://codereview.chromium.org/23591049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243964 0039d316-1c4b-4281-b951-d872f2087c98

As discussed - it's time to get rid of the GetDefaultProfile now.

BUG=322682
TEST=covered by existing unit tests

Review URL: https://codereview.chromium.org/128583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243963 0039d316-1c4b-4281-b951-d872f2087c98

The PixelBufferRasterWorkerPool checks whether raster tasks were
throttled to avoid notifying the client that all pending tasks were
completed too early. The current logic for this fails if tasks from the
previous graph were still active when we schedule a new graph. In these
situations we end up thinking some tasks were throttled and will not
schedule the final sentinel task to indicate work completion. This can
lead to delayed tree activation.

The fix is to only consider tasks from the new work queue when seeing if
any got throttled.

BUG=331534

Review URL: https://codereview.chromium.org/131763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243962 0039d316-1c4b-4281-b951-d872f2087c98

Production AppEngine doesn't emit the proper mimetype for SVG automaticallly, requiring handling it in app code. To fix this bug, I just converted the CC logo to PNG.

BUG=330040
NOTRY=true

Review URL: https://codereview.chromium.org/119983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243961 0039d316-1c4b-4281-b951-d872f2087c98

rather than automatically; this allows them to be treated like web contexts
rather than extension contexts, which allows the more complex bindings rules
for making the messaging APIs (chrome.runtime.connect/sendMessage) available.
Make them available.

BUG=326250
R=koz@chromium.org

Review URL: https://codereview.chromium.org/114803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243959 0039d316-1c4b-4281-b951-d872f2087c98

Based on initial patch by rdevlin.cronin@chromium.org

BUG=308355

Review URL: https://codereview.chromium.org/130393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243958 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313716

Review URL: https://codereview.chromium.org/123383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243957 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a second test case for inbox_app's navigation drawer that toggles
the drawer open and closed using the toolbar button.

R=nduca@chromium.org
BUG=332439

Review URL: https://codereview.chromium.org/130433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243956 0039d316-1c4b-4281-b951-d872f2087c98

> Enable all ESC-Fullscreen tests (Chrome Apps) for all platforms.
> 
> There were three issues:
> 1. a silly bug in the fullscreen change check;
> 2. there was no guarantee that the window would be actually focused;
> 3. changing the fullscreen state might come with an animation during which key events will not be received.
> 
> Note that 2 and 3 are a problem on MacOS only.
> 
> BUG=None
> 
> Review URL: https://codereview.chromium.org/116023002

TBR=mlamouri@chromium.org

Review URL: https://codereview.chromium.org/131343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243955 0039d316-1c4b-4281-b951-d872f2087c98

We're now enabling unwind tables for all linux architectures rather than just
x64. Update the performance expectations for ia32 linux.

TEST=none
BUG=180975
NOTRY=True
TBR=dtu@chromium.org

Review URL: https://codereview.chromium.org/132443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243953 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327999

Review URL: https://codereview.chromium.org/116363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243952 0039d316-1c4b-4281-b951-d872f2087c98

BUG=323847
TEST=browser_tests.exe
TBR=lushnikov
NOTRY=TRUE

Review URL: https://codereview.chromium.org/131973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243950 0039d316-1c4b-4281-b951-d872f2087c98

instead of notifications in server_thread. Testing only.

Merge internal change: 59322530

Reversed pause/resume changes of server_thread in the following CL:
https://codereview.chromium.org/127503002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/132073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243948 0039d316-1c4b-4281-b951-d872f2087c98

This is mostly boilerplate to get the OnSessionRouteChange notification up to the web-app. The web-app then includes it in the stats panel. In the common case where all channels have the same type, it displays it as "connection: <type>"; if the types differ they are displayed individually.

BUG=134528

Review URL: https://codereview.chromium.org/126123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243947 0039d316-1c4b-4281-b951-d872f2087c98

LanguageUsageMetrics is moved to its own component because it is used
both in the translate component and directly in the browser.

TranslateBrowserMetrics is moved to the translate component.

BUG=331509
TBR=jochen

Review URL: https://codereview.chromium.org/131203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243946 0039d316-1c4b-4281-b951-d872f2087c98

Now metrics are recorded only when a state of a particular network is
changed. If several consecutive checks indicate the same state for a
network, only the first one is recorded. The purpose of this fix is to
remove noize from so-called "lazy detection" from metrics.

BUG=231758
TEST=unit_tests:NetworkPortalDetectorImplTest*

Review URL: https://codereview.chromium.org/99223009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243945 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243944 0039d316-1c4b-4281-b951-d872f2087c98

Includes the following change:

r243334 | agl@chromium.org | 2014-01-07 13:08:41 -0500
OpenSSL: add support for the TLS padding extension.

This works around a bug in some versions of F5 devices that causes the
connection to hang when the ClientHello record is between 256 and 511 bytes
long.

https://tools.ietf.org/html/draft-agl-tls-padding-02

Based on the upstream patch to do the same thing:
0467ea68624450ecece4cde0d5803499aaff19c2

BUG=none

https://codereview.chromium.org/112933006

Review URL: https://codereview.chromium.org/110523007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243942 0039d316-1c4b-4281-b951-d872f2087c98

It's MIT licensed. We'll put it at third_party/fontconfig.

See https://chromium.googlesource.com/external/fontconfig/+/master/COPYING

R=phajdan.jr@chromium.org

BUG=332244

Review URL: https://codereview.chromium.org/127213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243941 0039d316-1c4b-4281-b951-d872f2087c98

Currently it's anything equal or newer than 9.2.1

BUG=332596
TEST=
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/130153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243940 0039d316-1c4b-4281-b951-d872f2087c98

Removing GetDefaultProfileOrOffTheRecord and GetDefaultProfile(<path>) from ProfileManager's (public) functions.

BUG=322682
TEST=covered by existing unit tests

Review URL: https://codereview.chromium.org/129293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243939 0039d316-1c4b-4281-b951-d872f2087c98

There were three issues:
1. a silly bug in the fullscreen change check;
2. there was no guarantee that the window would be actually focused;
3. changing the fullscreen state might come with an animation during which key events will not be received.

Note that 2 and 3 are a problem on MacOS only.

BUG=None

Review URL: https://codereview.chromium.org/116023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243938 0039d316-1c4b-4281-b951-d872f2087c98

Some components of a 32 bit build of chrome for Windows need to be built
as Win64 Dlls.  To allow those components to use base, we make a Win64
build of the base library even when building chrome 32 bit.

This is needed by the Chrome Desk Band code. crbug.com/327435.
https://codereview.chromium.org/79173004/

BUG=327435

Review URL: https://codereview.chromium.org/103333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243936 0039d316-1c4b-4281-b951-d872f2087c98

BUG=288562, 332034

Review URL: https://codereview.chromium.org/128373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243933 0039d316-1c4b-4281-b951-d872f2087c98