- 11 Nov, 2017 40 commits
-
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/8baea3c69490..9fa5036245c3 $ git log 8baea3c69..9fa503624 --date=short --no-merges --format='%ad %ae %s' 2017-11-10 hnakashima Add FPDFSaveEmbedderTest.SaveLinearizedDoc 2017-11-10 npm Check for decoder completeness in CJBig2_GRRDProc Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2ffafd8ac4c2f64d86c36843e2373c3d82bbc144 Reviewed-on: https://chromium-review.googlesource.com/765052 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515815}
-
Bret Sepulveda authored
Reduced redundant test expectations and generally made the tests more terse in preparation for the chooser dialogs' redesign. Bug: 654137 Change-Id: Ifda8645378103d498bb869f8ab5589f6cb66e5db Reviewed-on: https://chromium-review.googlesource.com/731472Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#515814}
-
Toni Barzic authored
This adds a helper class for launching lock screen note from ash that provides a callback run when the launched note changes to active state (i.e. when the associated app window becomes visible). Note that current users of RequestNewLockScreenNote API, used to launch lock screen note, do not require launch callback - this will be needed for handling note launch due to stylus tool eject, specifically if the stylus is ejected while the display is forced off. Ejecting stylus should clear display "forced off" state, but this will be delayed if a lock screen note is launched until the note launch completes to avoid lock screen flashing before the note app UI is shown (see the linked bug). BUG=767711 Change-Id: I3f46202244c39f06ad26ce5240f28828e3e692b0 Reviewed-on: https://chromium-review.googlesource.com/758810 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#515813}
-
Philip Rogers authored
This test depends on invalidations on a specific layer. With root layer scrolls enabled, the paint invalidations for this test are on the scrolling contents layer which is not the first layer. Bug: 781419 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: I86d50174eb74c2481849752e4e506384d489c9b6 Reviewed-on: https://chromium-review.googlesource.com/764383Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515812}
-
Peter Collingbourne authored
This version of eu-strip contains a fix for a bug where the -g flag does not work correctly on certain binaries. Bug: 469376 Change-Id: I6ceedf36687ab8173326e3d6d4b34dc89913d3cc Reviewed-on: https://chromium-review.googlesource.com/765169Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#515811}
-
Fabio Tirelo authored
These strings were initially thought to be used by a separate page, but we ended up never moving them to the file where other strings for the Settings page are. Bug: 776538 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I01c8799d62564c56a8b0e4b59aaf948107afa7aa Reviewed-on: https://chromium-review.googlesource.com/762157 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#515810}
-
Philip Rogers authored
Rebaseline paint/invalidation/caret-ancestor-clip-change.html: The non-RLS baseline was recently updated in: https://chromium-review.googlesource.com/c/chromium/src/+/750041 This just needed a mac baseline update to match non-RLS: paint/invalidation/change-text-content-and-background-color.html Rebaseline paint/invalidation/flexbox/repaint-opacity-change.html: The non-RLS baseline was recently updated in: https://chromium-review.googlesource.com/c/chromium/src/+/760671 Rebaseline paint/invalidation/japanese-rl-selection-clear.html: The non-RLS win10 baseline was recently updated in: https://chromium-review.googlesource.com/c/chromium/src/+/685976 Bug: 781419 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: I62935ad508fff623f0d6f3b685dabc0eaa72802e Reviewed-on: https://chromium-review.googlesource.com/764599Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515809}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/2ee22587f921..aee17a9d0e6d $ git log 2ee22587f..aee17a9d0 --date=short --no-merges --format='%ad %ae %s' 2017-11-10 nednguyen Improve error reporting of dependency_manager Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I66b6c9d37752ba4208067d8b43a18801d8e5d028 Reviewed-on: https://chromium-review.googlesource.com/764436 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515808}
-
Alexey Kozyatinskiy authored
V8 internally uses odd numbers as task id, blink should always send even numbers only. This CL fixes ids for network related async tasks. R=pfeldman@chromium.org Bug: none Change-Id: I44a68b65f5992066bca4fb8a69566db66feaf143 Reviewed-on: https://chromium-review.googlesource.com/764514Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#515807}
-
Bettina Dea authored
We are currently considering a user new if the in-product help was made available if the first_run file was created 24 hours before or anytime after the experiment was made available. Bug: 734132 Change-Id: Ie0f29e26d0c7e9e3f49daf4e104d6dfbd0c3849d Reviewed-on: https://chromium-review.googlesource.com/753127 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Carlos Pizano <cpu@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#515806}
-
Alexander Alekseev authored
This CL adds new user preference ResolveTimezoneByGeolocationMethod (enum) that superceeds the existing boolean preference ResolveTimezoneByGeolocation. Device preference ResolveDeviceTimezoneByGeolocation is also replaced with ResolveDeviceTimezoneByGeolocationMethod. We migrate local ResolveTimezoneByGeolocation preference value to ResolveTimezoneByGeolocationMethod and store migration flag locally. This Cl should not introduce functional changes, as UI still allows to select only previously supported resolving methods. Bug: 721578 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7dd73663b99f66d63ae83538dbcaa753fd6c634d Reviewed-on: https://chromium-review.googlesource.com/746149Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#515805}
-
Troy Hildebrandt authored
Adds ability for PartnerBookmarksReader to fetch cached favicons from the ThumbnailDatabase if available, or reach out to a Google server to prefetch and cache the favicon without the user visiting the site. Adds a callback from native back into the Java code to get the result of the favicon fetching. This is so we can cache the results to avoid retrying failed favicon retrievals every time we load the partner bookmarks. The cache will come shortly in another CL. Bug: 778805,780042 Change-Id: I7a1f7f18008d17f452504037118aa0c5bb0eb3a5 Reviewed-on: https://chromium-review.googlesource.com/756193 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#515804}
-
Samuel Huang authored
This CL adds the following to llvmobjdump-$REV.tgz: - {llvm-cxxfilt, llvm-nm, llvm-objdump, llvm-readobj}, - If non-Windows, sym link llvm-readelf -> llvm-readobj. These are needed by Supersize to process LLD builds. We didn't add symlink llvm-c++filt -> llvm-cxxfilt because that's not built by default. Next steps: - Rebuild package and upload (or wait for next push). - Update Supersize to look for the package by default (if needed), and download accordingly. Bug: 723798 Change-Id: I1991f6aee1e51e9ce9ac61faea97660cc40f640a Reviewed-on: https://chromium-review.googlesource.com/763728Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#515803}
-
Ryan Hamilton authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I601dae64a0a705a928144c29ed43f66a61fa9a92 Reviewed-on: https://chromium-review.googlesource.com/764520Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#515802}
-
CJ DiMeglio authored
The VideoFrameSubmitter will signal to the VideoFrameResourceProvider to PrepareSendToCompositor resources. When the compositor is done with these resources, they must be returned. Bug: 746182 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I90ac8fded8eb74b7435cd7763e4fa1cf8e4a3a50 Reviewed-on: https://chromium-review.googlesource.com/723862 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#515801}
-
Bret Sepulveda authored
This patch also includes some minor cleanup. Bug: 605657 Change-Id: Id7670c7743929cd638e25e0991cbfde2bc6fbb4d Reviewed-on: https://chromium-review.googlesource.com/759378 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515800}
-
Wez authored
Hard faults (or "major" faults) are attempts to access memory pages which are not resident in physical RAM, and therefore incur substantial cost to make available (e.g. paging-in from disk, decompressing from in-memory compressed swap, etc). Task Manager will now offer an optional column showing the hard-fault rate in each sampling cycle. Bug: 723767 Change-Id: If3e77759e7725f6c70b2e4f163adbca600d00ba7 Reviewed-on: https://chromium-review.googlesource.com/538464Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#515799}
-
Matthew Jones authored
Since showing the promo at startup is the current behavior, this feature is enabled by default. The feature to disable is "ChromeHomePromoOnStartup". BUG=783936 Change-Id: I827f7a828a484603860e3ce8362e91b50a6d742a Reviewed-on: https://chromium-review.googlesource.com/764788Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#515798}
-
Daniele Castagna authored
GLImageNativePixmap is currently logging "Failed to flush rendering" for each frame on ARM devices. The log is harmless, but the underlying cause of failure should be eventually investigated. This CL removes the log statement in release builds. Bug: b/63364517 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I47eefd31eb02893856248f64f338fbcb78666922 Reviewed-on: https://chromium-review.googlesource.com/764670 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#515797}
-
Benjamin Pastene authored
See https://chromium-swarm-dev.appspot.com/task?id=39bce1ee054c5e10 R=jbudorick@chromium.org Bug: Change-Id: If635938d30fbe2b527ef972d5c4896b599f42642 Reviewed-on: https://chromium-review.googlesource.com/764575Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#515796}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fbb038b8..47bc08df Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3f73e5981d0087b3421a56c01614cad40d9d5881 Reviewed-on: https://chromium-review.googlesource.com/764830Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515795}
-
Jacob Dufault authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/726240, which was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/755333. TBR=jamescook@ TBR=xiyuan@ Bug: 719015 Change-Id: I55c770dcdeb338f43ad409d502aa27c80f4e65eb Reviewed-on: https://chromium-review.googlesource.com/764400 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#515794}
-
Ryan Sturm authored
PreviewsUserData is a class that lives on the URLRequest and is copied to the NavigationHandle via ChromeNavigationData. Bug: 783917 Change-Id: I7a86243bf11d764209db8bd5b8fe46423651446b Reviewed-on: https://chromium-review.googlesource.com/752623Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#515793}
-
Yuzhu Shen authored
So that the resource could be used from both WebUI and extensions. BUG=699569, 718047 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If2ce60b15e0351aba801746cd863e5a2b9e85485 Reviewed-on: https://chromium-review.googlesource.com/762393 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515792}
-
Yuly Novikov authored
This is a reland of 46aa3c25 Crashing test was fixed by https://chromium-review.googlesource.com/764688 Original change's description: > Run angle_perftests on Nexus 5X Perf bot > > Also build angle_perftests on Android builders > > BUG=675997 > TBR=eyaich@chromium.org,dpranke@chromium.org > > Change-Id: I9e73e19599e3cc435f02960839f2e780402d0188 > Reviewed-on: https://chromium-review.googlesource.com/752582 > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515462} TBR=eyaich@chromium.org,dpranke@chromium.org Bug: 675997 Change-Id: I3f9617df32186d1a80937e3f6598af75a54e851b Reviewed-on: https://chromium-review.googlesource.com/764747Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#515791}
-
Joel Einbinder authored
Bug: 668953 Change-Id: I33337f5297c5e17c24540355799d14079401cdfb Reviewed-on: https://chromium-review.googlesource.com/761261Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#515790}
-
Lucas Garron authored
The committed interstitials project uses SSLErrorNavigationThrottle to watch for failing requests that are certificate errors. It defers such requests, and then cancels with the appropriate error code and error page content HTML based on the blocking page it receives from calling SSLErrorHandler::HandleSSLError, via a "blocking page ready callback". To support this, HandleSSLError is updated to pass its constructed blocking page to the blocking page ready callback when the callback is present, *instead* of calling Show() on the blocking page. Since this passes ownership to the SSLErrorNavigationThrottle, we also create a new SSLErrorTabHelper that SSLErrorNavigationThrottle uses to associate a blocking page with its web contents for as long as it'sr needed (i.e. until its navigation has committed and the tab has subsequently navigated away). Bug: 752370 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I6525912a28e48b9268aa0f9798b5e1b276cb25a6 Reviewed-on: https://chromium-review.googlesource.com/621236 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#515789}
-
Eugene But authored
Bug: 688063 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If9b10b4e9ab8b975dbce21aec6cf287ef82a6ab9 Reviewed-on: https://chromium-review.googlesource.com/759301Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#515788}
-
Christopher Cameron authored
One of ICCProfileCache's jobs was to mainting a list of displays that had been histogrammed, for each ICCProfile. The simpler solution to this problem is to have ICCProfile's internals be a scoped_refptr that are shared by all profiles with the same data (as much as is possible), and put the set of histogrammed displays in that structure. Replace ICCProfileCache with a simple MRUCache of ICCProfiles. There are some strange acrobatics performed in this cache to ensure that behavior exactly matches previous behavior (including all idiosyncracies). The next patch will change some of these behaviors to simplify logic. Bug: 766736 Change-Id: I1fe2d52fc8b3745d73f87115965914aeec367f61 Reviewed-on: https://chromium-review.googlesource.com/753424Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#515787}
-
Jialiu Lin authored
More specifically, if user clears all their browsing history, kSafeBrowsingUnhandledSyncPasswordReuses pref should be cleared, and change password card should be gone. if user removes individual browsing hitory entries, we should remove corresponding entries in kSafeBrowsingUnhandledSyncPasswordReuses and decide whether to remove change password card based of if this pref is empty. Bug: 782897 Change-Id: I0d099fa019f6f809c573f44cd4f347e5e9670b7e Reviewed-on: https://chromium-review.googlesource.com/759425 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#515786}
-
Bret Sepulveda authored
Bug: Change-Id: Ice9ee61f692a9d8ad7dd166f777754dd4b2e147c Reviewed-on: https://chromium-review.googlesource.com/764545Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#515785}
-
Tommy Steimel authored
With the new site muting feature, "Mute tab" in the tab dropdown was replaced with "Mute site", which mutes via a content setting. There are no content settings for chrome:// urls, so this CL disables the "Mute Site" option for those pages. Bug: 782134 Change-Id: Ib95027b3124ae75e49ab6f32556e73d4f2918d04 Reviewed-on: https://chromium-review.googlesource.com/758139Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#515784}
-
Christian Biesinger authored
This reverts commit 6f252376. This fixes the regressions caused by that patch with the following changes: --- a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp +++ b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp @@ -1445,7 +1445,7 @@ void LayoutFlexibleBox::LayoutLineItems(FlexLine* current_line, relaid_out_children_.insert(child); child->LayoutIfNeeded(); - flex_item.cross_axis_size = CrossAxisIntrinsicExtentForChild(*child); + flex_item.cross_axis_size = CrossAxisExtentForChild(*child); + flex_item.cross_axis_intrinsic_size = + CrossAxisIntrinsicExtentForChild(*child); --- a/third_party/WebKit/Source/core/layout/FlexibleBoxAlgorithm.h +++ b/third_party/WebKit/Source/core/layout/FlexibleBoxAlgorithm.h @@ -115,6 +115,7 @@ class FlexItem { LayoutUnit flexed_content_size; LayoutUnit cross_axis_size; + LayoutUnit cross_axis_intrinsic_size; LayoutPoint desired_location; bool frozen; --- a/third_party/WebKit/Source/core/layout/FlexibleBoxAlgorithm.cpp +++ b/third_party/WebKit/Source/core/layout/FlexibleBoxAlgorithm.cpp @@ -323,8 +323,8 @@ void FlexLine::ComputeLineItemsPosition(LayoutUnit main_axis_offset, child_cross_axis_margin_box_extent = max_ascent + max_descent; } else { - child_cross_axis_margin_box_extent = - flex_item.cross_axis_size + flex_item.CrossAxisMarginExtent(); + child_cross_axis_margin_box_extent = flex_item.cross_axis_intrinsic_size + + flex_item.CrossAxisMarginExtent(); A test was added in crrev.com/c/759300. There's some minor cleanups I want to make, but I will do them separately to minimize the changes in this reland. R=eae@chromium.org Change-Id: I0ac09d68631242efaab38621eabbf39a0402ed48 Reviewed-on: https://chromium-review.googlesource.com/759278 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#515783}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/38d92b59c4b7..e3bfefb41065 $ git log 38d92b59c..e3bfefb41 --date=short --no-merges --format='%ad %ae %s' 2017-11-10 ynovikov Align float access in InterleavedAttributeData perf test 2017-11-09 jmadill Vulkan: Implement Buffer updates. Created with: roll-dep src/third_party/angle BUG=675997 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ied4a28e58bf1761735e0d5504882b2bf8c84ccc6 Reviewed-on: https://chromium-review.googlesource.com/764576Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515782}
-
Eric Karl authored
Certain sequences of drawing commands can lead to crashes on Intel 9th gen GPUs on MacOS. Adding a flush after framebuffer changes works around this. Bug: 783979 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I12ea134a592cf8eddd6e524d5d7d909d24640c40 Reviewed-on: https://chromium-review.googlesource.com/764584 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#515781}
-
Zhenyao Mo authored
On Win/Linux, we will fallback to rendering with SwiftShader. On other platforms, we will fallback to software rendering with no gpu process. BUG=783069 TEST=the added tests R=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9a60c71fba04ebdb46d92a5a0442a75f4f236e90 Reviewed-on: https://chromium-review.googlesource.com/764000Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#515780}
-
Joel Einbinder authored
Bug: none Change-Id: If3ecb842a31ed70f2dbea29b910c286a60d67bf3 Reviewed-on: https://chromium-review.googlesource.com/671202Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#515779}
-
rajendrant authored
Content-Length header is being updated for range responses. This header is not used in data savings calculation for data reduction proxy. So removing that from the test. Bug: 781415 Change-Id: Ia5caca173ad2bff1d2f70624ebb45bb185959170 Reviewed-on: https://chromium-review.googlesource.com/764874Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#515778}
-
Sunny Sachanandani authored
We're seeing access violation crashes in swap chain present. Aliasing the dirty rect and surface size will show these in minidumps. R=piman BUG=776403 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icd67c32b307efcbe18772d5bf036c8c0ad5ffe87 Reviewed-on: https://chromium-review.googlesource.com/764380 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#515777}
-
Joel Einbinder authored
Bug: 627874 Change-Id: I8d26a2c1d743a2b551eca0365788ed51fb81886b Reviewed-on: https://chromium-review.googlesource.com/761596Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#515776}
-