- 12 Jun, 2020 40 commits
-
-
Hazem Ashmawy authored
Also subtract one from NumHistograms on the client side in order not to skew it and keep the zero bucket in it representative of no histogram fetched. Fixed: 1093101 Test: bin/run_webview_instrumentation_test_apk -f "*MetricsBridgeServiceTest*" Change-Id: Iea4c0a2d958920ac9cf1308a942b157f3362920d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237984 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#778019}
-
Vincent Boisselle authored
Bug: 1094108 Change-Id: Ie91978405da956b5cc65bbe0ad0435c96ebee9da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244034 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#778018}
-
Tom Anderson authored
R=sky Bug: 1093715,1093265,1094376 Change-Id: I9ae640e4a9a6b2117ae43d45b6e189270ec06d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241465 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#778017}
-
Nico Weber authored
They're slow to cycle, so use the sharding settings that we already use on the linux asan bots. TBR=aeubanks Bug: 794372 Change-Id: Ibe61c7b9219dabad2f0c6099cf316bec7c094133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243996Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#778016}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0d495d2b. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" d2ee98f4 "Move manual offscreen wpt tests to own folder" 458dc853 "WPT: Migrate content-visibility tests to wpt." 84f61c81 "Exclude non relevants reports from the COOP-opener-breakage tests." e106756f "[COOP] Access reporting. Update the test." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I7b5274622e90af3835c4a4936d5dc2e93c7676a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240961Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778015}
-
John Abd-El-Malek authored
This allows histogram data to live across browser process crashes/restarts. This is implementing support that was added to Chrome in https://crbug.com/546019. WebView is not enabled until https://crbug.com/1076549 gives us more information on the required disk size. Bug: 1090682, 1025781 Change-Id: I5b74faaeee6e4718c76e3b3d9686caf5f7913675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236060 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#778014}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. CL also updates the use on all child classes, including: - RTCRtpSenderImpl - FakeRTCRtpSenderImpl - DummyRTCRtpSenderPlatform This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I8ff38b45a48df7225f3658dfc7c0296eaa181c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239929Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#778013}
-
Mitsuru Oshima authored
Bug: 1087917 Change-Id: I8eea45f20be6fe0054547fc8b0624a6a59636295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236201Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#778012}
-
Kenneth Russell authored
conformance/textures/webgl_canvas/ tex-2d-rgba-rgba-unsigned_byte.html tex-2d-rgba-rgba-unsigned_short_4_4_4_4.html tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html conformance2/textures/webgl_canvas/ tex-2d-rgb10_a2-rgba-unsigned_int_2_10_10_10_rev.html tex-2d-rgb5_a1-rgba-unsigned_byte.html tex-2d-rgb5_a1-rgba-unsigned_short_5_5_5_1.html tex-2d-rgba16f-rgba-float.html tex-2d-rgba16f-rgba-half_float.html tex-2d-rgba32f-rgba-float.html tex-2d-rgba4-rgba-unsigned_byte.html tex-2d-rgba4-rgba-unsigned_short_4_4_4_4.html tex-2d-rgba8-rgba-unsigned_byte.html are failing due to newly introduced tests. Bug: 1092734 Change-Id: I7d4689bbf53b9985873baa0cc7d1ee94363f4e96 Tbr: shrekshao@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244112Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#778011}
-
Owen Min authored
Enterprise.PolicyUpdatePeriod.MachineLevelUser Signin.ForceSigninVerification Signin.AuthenticatedLaunchUserEvent They will now expires in M88. Bug: 1072570, 1072602, 1089514 Change-Id: I31b8a00c4c8f63d6da7a4274ff5efa3522846b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243599Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#778010}
-
John Delaney authored
This CL adds a tentative string for a reload button to the details view, of the heavy ad error page which disables the intervention on the site and reloads the page. This text aligns with the existing quiet webview interstitials. The full implementation of the functionality exists on https://crrev.com/c/2242169 Change-Id: If0bba4a50f9f8c7396c90e3e9fc7061c2ced6b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242645Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#778009}
-
David Grogan authored
Previously, if a legacy abspos child of an NG flexbox had a legacy containing block, it could be positioned incorrectly. This CL copies the staticpos logic from legacy flex, with a few minor simplifications. There's little refactoring of legacy to share code. Legacy continues to mostly rely on methods in LayoutFlexibleBox that the new code can't use. I don't want to risk altering legacy's behavior here, especially considering this might be merged to 84. Bug: 845235, 1066859 Change-Id: Ic07ed9e3fe5febe72981b47b0bacbc2b33691c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222112Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#778008}
-
Sorin Jianu authored
These fixes are for: https://chromium-review.googlesource.com/c/chromium/src/+/2239764 * missing include headers * sorting headers (unit tests are not special) * use braces for multi-line ifs * remove const on return type Bug: 1068797 Change-Id: Ib5d223f82739350ee3981b1281e2a3f296343bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244114Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#778007}
-
Scott Graham authored
Not following chromium-dev or most dev in //build any more so there's probably not many changes I'm qualified to review here any more. Change-Id: Ie35015521eb18787c68b401c4ae5700ea3654f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244039 Auto-Submit: Scott Graham <scottmg@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#778006}
-
Jorge Lucangeli Obes authored
The relevant codepath hasn't been used since ~2014 (!!!) and the reporting code was removed in crrev.com/c/1183895. BUG=chromium:1088699 TEST=validate_format, pretty_print. Change-Id: Ifcc98ce794a9def469b1bb29e66955145e93a8ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243533 Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#778005}
-
Tina Wang authored
Change the UI to managed when the pref is managed by policy. Screenshots: https://screenshot.googleplex.com/5YeV4SPvq1i https://screenshot.googleplex.com/BJwV90Tv3uB Bug: 1093167 Change-Id: I10bd1ddead11e129ad9762a5d75e7cb0ab4e3012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239526 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#778004}
-
Xing Liu authored
This CL implements the download later flow logic in DownloadDialogBridge. Bug: 1078454 Change-Id: I1a0e6470a81ebda2add4a069addf21258c67c83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240544 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#778003}
-
Ken Rockot authored
This introduces a new --mojo-core-library-path Content switch which instructs Content to initialize each process with an implementation of Mojo Core found in the referenced shared library rather than using the version linked into the main binary. This allows for IPC interoperability between a Content embedder and another application which provides its own copy of Mojo Core. Fixed: 1082473 Change-Id: I1e50c505e91a53e60056a4b8c691d91728f7a5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229664Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#778002}
-
Jon Mann authored
This reverts commit 9398a65f. Reason for revert: no longer needed Original change's description: > Wi-Fi Sync: Add strings for feature announcement notification. > > Adding strings separately from implementation to give more time for > translation. > > Bug: 966270 > Change-Id: I110e960a802d5020c42ed7b65993399cef158bf9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243585 > Commit-Queue: Jon Mann <jonmann@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Cr-Commit-Position: refs/heads/master@{#777992} TBR=jonmann@chromium.org,vecore@google.com Change-Id: I3aab30f8731c1f1cada280e2b7482a1dab38f9d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 966270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244043Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#778001}
-
Dave Tapuska authored
This definition will eventually replace the content::TextInputState definition and will be sent directly from blink. Add additional typemaps for action and mode. BUG=1073560 Change-Id: Ia90592e1c8cf347053485ac6e0cf0cbc503aed4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240250Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#778000}
-
Ben Pastene authored
The Chrome OS chroot builds Chrome within a symlink'ed out dir. These relative paths don't play nicely with the symlink path and cause errors in //third_party/polymer/v3_0/components-chromium when compiling. Removing parent dirs from the paths fixes the errors, and somehow js_binary.py still appears to pick up the right path to //third_party/polymer/v3_0/components-chromium. Bug: 1093048 Change-Id: I9d4039d9022ac4d0f4767e2ab09496bee8f24823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242193 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#777999}
-
Tina Wang authored
Change the UI to managed when the pref is managed by policy. Screenshots: https://screenshot.googleplex.com/9EdXBpco5JJ https://screenshot.googleplex.com/ksvxJXWjKMO Bug: 1093168 Change-Id: I581d6a24d3fb1320bf158e4620815bf706f7bce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242180 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#777998}
-
Maxime Charland authored
Some messages in ios_google_chrome_strings had a name that was no longer referenced in code after a refactor of QR Scanner related classes. Also, both ios_chromium_strings and ios_google_chrome_strings were not sorted alphabetically, which caused confusion when trying to add new messages. This CL is fixing those two problems. Change-Id: I9cfc6bbaaaa812e6c45b0b472d8b1d48179f685a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239674Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#777997}
-
Tibor Goldschwendt authored
Logs - NewTabPage.VoiceActions - NewTabPage.VoiceErrors on chrome://new-tab-page. Fixed: 1072882 Change-Id: I1d2b6fd42c1a76d1adf2855b0f5e3743c9fdf217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241464 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#777996}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/922267825036..b919b0064c92 2020-06-12 wuwang@google.com Add instruction to update DEPS after upload file to CIPD. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1060399 Tbr: skyostil@google.com Change-Id: I79a92f764498ac404f9dc3e1a1884c0d633de91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777995}
-
Brian Liu Xu authored
Hides tooltips when windows are hidden or minimized on Windows. Previously, when a browser window was minimized by the OS, tooltips would stay open on top of other windows because they did not receive an event that the mouse left the window. This was due to a race condition between the minimize message and the WM_MOUSELEAVE message. Since Aura first receives the minimize message and makes the Aura window not "visible", the subsequent mouse exit event was thus rejected by the Aura window. Consequently, tooltips would stick around indefinitely until the window was restored and interacted with. To fix this, we make the tooltip controller respond to the WM_WINDOWPOSCHANGED message (which is also sent to us when the window is minimizing) by explicitly hiding the tooltip. Bug: 724538 Change-Id: I9e8a60e6de943230708b12f3a05b8ee03c27e54a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241631Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Brian Liu Xu <brx@microsoft.com> Cr-Commit-Position: refs/heads/master@{#777994}
-
Marc Treib authored
This CL introduces histograms PasswordManager.AccountStoreVsProfileStore.[Additional|Missing|Identical|Conflicting] that record the relative state of the account-scoped store vs. the profile-scoped store: How many credentialss are in the account store but not the profile store and vice versa, and how many identical and conflicting ones are there. Bug: 1063852 Change-Id: Idb6bdb82ca6423d224602be81f19235919e33713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218277 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#777993}
-
Jon Mann authored
Adding strings separately from implementation to give more time for translation. Bug: 966270 Change-Id: I110e960a802d5020c42ed7b65993399cef158bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243585 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#777992}
-
John Delaney authored
It is currently possible for tasks to be posted to ConversionStorageSql that run on a database which failed to initialize correctly. This can occur when impressions/conversions are received prior to database setup completing. This adds a checks to all methods called externally that return early if the database is not in a working state. Bug: 1088072 Change-Id: I3f657b40dc29ecf8246b6df2b356e6d16ad11e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235875Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#777991}
-
Anastasia Helfinstein authored
Clean up from the effort to migrate the Switch Access menu from a web-based implementation (sharing infrastructure with the ChromeVox panel) to a native views-based bubble. AX-Relnotes: n/a. Bug: 948386,1088528 Change-Id: I2f47c7e229f6042f98caf78f631b2b2b9c73198a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232836Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#777990}
-
Antonio Gomes authored
.... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I5a6e683283b9a57f642a09d0f06410d2fde95690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239973 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#777989}
-
Sinan Sahin authored
We check if the offsets are different from the previous ones in to update the prev_*_min_height_offset_pix values. This probably won't make any difference for now since the min-height offset changes are currently accompanied by offset changes. RenderWidgetHostViewAndroid: :UpdateControls(). However, I've forgotten Change-Id: I57c64c1bfcffa324b2384fad90db210bbec9db4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244012Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#777988}
-
Manuel Rego Casasnovas authored
BUG=1078401 TEST=CompositedLayerMappingTest.TransformedRasterizationForBackfaceVisibilityHidden Change-Id: I3ae4a581d247537d1211ebbc4688c6c8e1056a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238926 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#777987}
-
rajendrant authored
Bug: 1053696 Change-Id: I5888a658babb384833873b1ef54e5c9466af10e0 TBR: robertogden@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244193Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#777986}
-
James Cook authored
This reverts commit 29ca85f8. Reason for revert: Seems to cause flaky analyzer step failures on https://ci.chromium.org/p/chromium/builders/try/chromeos-amd64-generic-rel Example: https://ci.chromium.org/p/chromium/builders/try/chromeos-amd64-generic-rel/568950 Exception: Failed to open ../../out/Release/gen/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/vulcanized.html while trying to flatten ../../out/Release/gen/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/vulcanized.html. (No such file or directory) Original change's description: > [CrOS settings] Add bluetooth_pairing_dialog resource files > > Split bluetooth_pairing_dialog resources into > bluetooth_pairing_dialog_resources.grd > and bluetooth_pairing_dialog_resources_vulcanized.grd > > Bug: 1090882 > Change-Id: I0d9855aaaf21db900f27f92b7b38d7ab1daac18a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239147 > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777891} TBR=sky@chromium.org,khorimoto@chromium.org,tjohnsonkanu@google.com Change-Id: I4af97b356a782dcb6cb88472d8528c54350e9871 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243855Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#777985}
-
Dominic Mazzoni authored
Without this, they won't appear in the dashboard. Bug: 992074 Change-Id: I1792d7b2a2b1bb280fb5deef319cdc2ff46bafd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242116Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#777984}
-
sczs authored
Check Bug for more context. Bug: 1094467 Change-Id: I8e1182e83b7c0e52a05196c2821f0e33bf953c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243732 Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#777983}
-
Vincent Boisselle authored
When using the feed header menu mSectionHeader.toggleHeader() has side effects needed by the subsequent steps to set the SectionHeader data model before updating the SectionHeaderView through updateVisuals(). Bug: 1094437 Change-Id: Id539e2f060398cde9b8319bf6d791e032202a723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243601 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#777982}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I48373df609cd406f0282751e10dcf981d5879853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242744Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777981}
-
Jia authored
This is following an accessibility and UI review request. Bug: 1068851 Change-Id: I64d35e3f2254f5a597d2d67a579cc323a7c57ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241363Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#777980}
-