- 23 May, 2018 40 commits
-
-
Yoshifumi Inoue authored
This patch changes |ScopedStyleResolverTest| to use |AttachShadowRootInternal()| instead of |Element::attachShadow()| to avoid using script only functions for improving code health. Change-Id: I7f8b93fd8616a95b0f382db5931f6e403f9cdd94 Reviewed-on: https://chromium-review.googlesource.com/1068580Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560965}
-
Sasha Morrissey authored
Bug: 844391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I37f651e972e290447e1de0312b62c647bc6835e5 Reviewed-on: https://chromium-review.googlesource.com/1068585Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#560964}
-
Dmitry Skiba authored
LibraryManager indirectly passes LibraryProcessType value to the native code via getLibraryProcessType() static method, which is only invoked in the context of nativeLibraryLoaded() call. I.e. the indirection is unnecessary and only makes data flow harder to understand. This CL removes getLibraryProcessType() method and passes process type value directly to nativeLibraryLoaded(). Bug: 841403 Change-Id: Ib15d765f968029d46d1603cdc7a5d5e7d280bb06 Reviewed-on: https://chromium-review.googlesource.com/1067578 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#560963}
-
Sasha Morrissey authored
Fixed 'Share' option to open drive.google.com for files and folders in Team Drives. Previously, the URL opened was just the alternateUrl (views the file or folder in drive.google.com). Appending ?userstoinvite="" opens the sharing dialog. In the future, this URL will be returned from the Drive API. The file/folder should open in drive.google.com with the sharing dialog open. Test: Right-click on a file or folder in Team Drives and select 'Share'. Bug: 716301 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id7d738fd1b16f67af3a012426b8eea0032489450 Reviewed-on: https://chromium-review.googlesource.com/1065834 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#560962}
-
Yuichiro Hanada authored
This CL adds input_method_manager.mojom file and stub implementation for InputMethodManagerHost interface. input_method_manager.mojom file defines the bridge interface between Chrome OS's InputMethodManager and Android's InputMethodManager. Bug: 845079 Test: unit_tests Change-Id: I3d5a25c7774a1258fc0e1494fc351571327a89dd Reviewed-on: https://chromium-review.googlesource.com/1065560 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#560961}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3792c386..0e4815cd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ieb74b1c0a1a90f8ad43a38466cd166dc54a0f1c7 Reviewed-on: https://chromium-review.googlesource.com/1069179Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#560960}
-
Hayato Ito authored
It would be safe to disable Incremental Shadow DOM for M68, whose branch cut is soon. Let's defer it to M69 so that we can address http://crbug.com/845770 surely. Bug: 776656, 845770 Change-Id: I5d2efeca4b44c0b4a84948233d7b3447cdf4f64e Reviewed-on: https://chromium-review.googlesource.com/1069952Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#560959}
-
Ben Wells authored
Bug: 703927 Change-Id: If62f613aab52f8573a48d874c7bc70a720e792b9 Reviewed-on: https://chromium-review.googlesource.com/1068532 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#560958}
-
Donna Wu authored
BUG=769630 Change-Id: I30146f723275f40dbf25956f62110612be5d1a14 Reviewed-on: https://chromium-review.googlesource.com/1063567 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#560957}
-
Keishi Hattori authored
PersistentHeapCollectionBase::persistent_node_ was being copied on copy assignment. PersistentHeapCollectionBase::persistent_node_ should never change once assigned. When they get overwritten, the old PersistentNode might point to a freed PersistentHeapCollection. Bug: 843550 Change-Id: Ic2397683c346ba019a24bfe9c241f6bcd81a1c2d Reviewed-on: https://chromium-review.googlesource.com/1068557Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#560956}
-
Donna Wu authored
BUG=769630 Change-Id: If9caefc4a503430648bd6cfccb56adcc066b1f62 Reviewed-on: https://chromium-review.googlesource.com/1063554Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7f472cd8abe4..86688dea3b0d $ git log 7f472cd8a..86688dea3 --date=short --no-merges --format='%ad %ae %s' 2018-05-22 thestig Make friend RetainPtr<T> statements consistently public. 2018-05-22 thestig Fix nits in fxjs. 2018-05-22 thestig Simplify CPDF_ShadingPattern::Validate(). Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I284bf7cc2464e552f0fadf8433244cd17bd81a72 Reviewed-on: https://chromium-review.googlesource.com/1069968Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560954}
-
Yoichi Osato authored
This patch adds assert_selection tests converted from editing/selection/move-left-right.html. Here is generator: crrev.com/c/1032319 This patch includes #11-#20 tests in original 43 tests. Bug: 679977 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3551a787a53958ae7a306a1a005770e503db9f09 Reviewed-on: https://chromium-review.googlesource.com/1063450 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Bence Béky authored
Sometimes handshake_stream_ is null in PerformUpgrade(), causing a crash. These CHECKs will allow us to distinguish between the following three possible causes: * OnHandshakeStreamCreated() has never been called; * OnHandshakeStreamCreated() has been called with nullptr; * PerformUpgrade() has already been called. Bug: 842575 Change-Id: Idd0ff4fecdeadee2d8286363a3b81ca6246b709e Reviewed-on: https://chromium-review.googlesource.com/1069191 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#560952}
-
Yuta Kitamura authored
This reverts commit 3a2babeb. Reason for revert: Suspected cause of ASAN failure (bug 845687) and Mac-only flakiness (bug 845760, but 845759, bug 845690). Original change's description: > Add supports for Objective-C blocks to base::Bind* > > Add template specifialization allowing to use base::Bind* with > Objective-C block. To avoid breaking ODR, it is necessary to > use base::WrapBlock() when ARC support is disabled, but when > it is enabled, the block can be directly bound by base::Bind*. > > This also allow to use base::BindOnce() with blocks and thus > pass them move-only objects, allowing the following: > > __weak Foo* weakSelf = self; > std::unique_ptr<Bar> bar = ...; > base::OnceClosure closure = base::BindOnce( > ^(std::unique_ptr<Bar> bar) { > [weakSelf adoptBar:std::move(bar)]; > }, std::move(bar)); > > The base::BindBlock and base::BindBlockArc templates are kept for > compatibility but are now just wrapper for base::BindRepeating. > > Bug: 701275 > Change-Id: I6e5d5309bcae768b2d1e8425b27ca295098e30b1 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/977912 > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560634} TBR=thakis@chromium.org,sdefresne@chromium.org,tzik@chromium.org Change-Id: Id72a1806176f830a1887243fcd2795a927e7d638 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 701275 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1068588Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#560951}
-
Yoshifumi Inoue authored
This patch changes |ListItemOrdinal::ItemInsertedOrRemoved()| avoid to update unassigned SLOT elements to invalidate list item ordinal cache. The root cause of the issue is attempting to destroy destroyed layout object since |LayoutListItem::WillBeRemovedFromTree()| deatches layout objects by recalculation of slots in |ListItemOrdinal::ItemInsertedOrRemoved()|. Bug: 844277 Change-Id: I71a7f6d95e874756c0df76a8f2be54c301ccd55f Reviewed-on: https://chromium-review.googlesource.com/1068646 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Nate Fischer authored
Previously, destroy()'ing a WebView which had visible interstitials would violate a DCHECK (or, crash at a later point if DCHECKs are disabled). The interstitial would clean up asynchronously, after the corresponding WebContents was destroyed. This violated a DCHECK in BrowserViewRenderer's destructor, because it still had a pointer to the interstitial's SynchronousCompositorHost. This modifies RenderWidgetHostViewAndroid to cleanup these references to the interstitial compositor synchronously while the WebContents is being destroyed. The rest of the interstitial teardown will continue to be asynchronous. Bug: 837829 Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#testDestroyWebViewWithInterstitialShowing Change-Id: Ie63fcde827aee801b9e7fc1e4b62a43677133a33 Reviewed-on: https://chromium-review.googlesource.com/1045271Reviewed-by:
-
Takashi SAKAMOTO authored
We would like to see more Memory_Experimental UKM after page load. We are thinking that renderer memory usage will quickly grow after page load. However, currently Memory_Experimental UKM is reported every 30 minutes, and is not related to any page load. ProcessMemoryMetricsEmitter's change was https://chromium-review.googlesource.com/1032150 and submitted. Bug: 837498 Change-Id: I16eb5997879fb9a16b647969dc9e73503211065c Reviewed-on: https://chromium-review.googlesource.com/925987 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#560948}
-
Matt Falkenhagen authored
It is not used beyond the constructor. Change-Id: Id764b8c6889075977ffae3bde8b170871f7ab350 Reviewed-on: https://chromium-review.googlesource.com/1060773Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#560947}
-
Shakti Sahu authored
Bug: 844202 Change-Id: Ia827e40ad50eeb057d2f9c3b2f328a0d75b7487d Reviewed-on: https://chromium-review.googlesource.com/1064795 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#560946}
-
Matt Menke authored
Also remove the legacy code to create one for ProfileIOData. TBR=rhalavati@chromium.org Bug: 837776 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I94db1e1bc8d1ef74224c308950423ed3d9dc2fc0 Reviewed-on: https://chromium-review.googlesource.com/1059453Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
-
Sasha Morrissey authored
Remove OWNERS from ui/file_manager who are no longer experts in the code or actively doing code reviews. -hirono,-oka,-yawano,-yoshiki Bug: 845065 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I492a7c6fad5a916df8de4d662209036424b20652 Reviewed-on: https://chromium-review.googlesource.com/1068550Reviewed-by:
Daichi Hirono <hirono@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/31d3deb41a44..b1e913801502 $ git log 31d3deb41..b1e913801 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 jiawei.shao ES31: Implement EXT_geometry_shader framebuffer default layers on OpenGL 2018-05-21 tobine Roll fwd ANGLE chromium DEPs Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: Ib4f012780e50a0ea171015ada59b33ffe4d7e329 Reviewed-on: https://chromium-review.googlesource.com/1069841 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560943}
-
Chong Zhang authored
Consumers like Device Management Service (crbug.com/832749) need to add extra headers on redirect. This CL: 1. Adds |modified_request_headers| parameter in 'url_loader.mojom' and all |URLLoader::FollowRedirect| overrides. 2. Adds |DCHECK(!modified_request_headers.has_value())| in all non-empty override implementations. 3. Use |base::nullopt| for all call-sites. This CL doesn't have behavior change. Bug: 845683 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I45cae17220b1e4179d9617c802718f794918e535 Reviewed-on: https://chromium-review.googlesource.com/1065584 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Extension errors have associated renderers, and we half-supported opening developer tools to that error. Unfortunately, we didn't do this very well - we didn't watch for renderer destruction or navigation, either of which invalidate the ability to inspect. Given the complexity of properly monitoring these, and the limited utility this feature offered, remove this aspect of the error console. The stack trace, context, and error should be sufficient to help the developer track it down. Bug: 769978 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie0ae3d07448dc82af97315189313a9fd969b5b14 Reviewed-on: https://chromium-review.googlesource.com/1069564 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#560941}
-
Sasha Morrissey authored
Store can_share capability from Google Drive API. This is pre-work to grey-out the 'Share' button for files without Sharing permission in the Files app. Bug: 719959 Change-Id: I37281af81aeb5dfcb1a01a503ba4edb10686bf4d Reviewed-on: https://chromium-review.googlesource.com/1068551Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#560940}
-
Stuart Langley authored
This CL introduces a new pure virtual class, DriveChangeListLoader, which we can specialize to load from the users default corpus or from users team drives. The first specialziation is DefaultCorpusChangeListLoader, which now contains the existing change_list_loader, start_page_token_loader and directory_loader objects. Follow up work is to introduce a TeamDriveChangeListLoader which can load change lists and retreive directories for specific team drives. Bug: 715355 Change-Id: Ica88b2190c7d4abac6955784db7aada287f8be2c Reviewed-on: https://chromium-review.googlesource.com/1064653 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
The previous fix in r560368 didn't work, as the BrowserChildProcessHostImpl::TerminateAll removed all the UtilityProcessHost objects first. Bug: 820996, 820969 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I88ba647e911c8f7e8d9458b60021aa6d915ccfa0 Reviewed-on: https://chromium-review.googlesource.com/1069668 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#560938}
-
Andrew Grieve authored
Bug: 702625, 844600 Change-Id: Ic58c39a4fe4890fad5841763f346b49e03bdabfa Reviewed-on: https://chromium-review.googlesource.com/1069555Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#560937}
-
chromite-chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e6853c3d4b19..07dfd789cb28 $ git log e6853c3d4..07dfd789c --date=short --no-merges --format='%ad %ae %s' 2018-05-21 xixuan chromeos_config: Add non-important nyan_blaze paladin. 2018-05-18 jkop metrics: Rename cumulative distribution metric 2018-05-18 nxia Report stage failures to monarch. Created with: roll-dep src/third_party/chromite BUG=chromium:845314,chromium:None,chromium:841573 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I722e52cb1b03cda40c98b4a2b21244a043106a69 Reviewed-on: https://chromium-review.googlesource.com/1069846Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560936}
-
John Z Wu authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idefc9a0dac8437e651843c4b1d3abc20ccee4e2d Reviewed-on: https://chromium-review.googlesource.com/1069932Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#560935}
-
Abhishek Arya authored
This reverts commit 5ab205ce. Reason for revert: Broken pdfium libfuzzers Bug: 845771 Original change's description: > Roll src/third_party/pdfium/ 7f472cd8a..86688dea3 (3 commits) > > https://pdfium.googlesource.com/pdfium.git/+log/7f472cd8abe4..86688dea3b0d > > $ git log 7f472cd8a..86688dea3 --date=short --no-merges --format='%ad %ae %s' > 2018-05-22 thestig Make friend RetainPtr<T> statements consistently public. > 2018-05-22 thestig Fix nits in fxjs. > 2018-05-22 thestig Simplify CPDF_ShadingPattern::Validate(). > > Created with: > roll-dep src/third_party/pdfium > > > The AutoRoll server is located here: https://pdfium-roll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > TBR=dsinclair@chromium.org > > Change-Id: I448003d54d9cdf3c6861696a1ff2796b6adfb76d > Reviewed-on: https://chromium-review.googlesource.com/1069785 > Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#560885} TBR=dsinclair@chromium.org,pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Change-Id: I6f75f6afac96c400dcddbb3a1604d87e69d14627 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1069916Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#560934}
-
Bence Béky authored
This reverts commit 1a9f003e. Reason for revert: This CL did not fix crash, see comment on bug. Furthermore, this CL reduces the number of call sites for PerformUpgrade() to one, potentially resulting in inlining, which conceals the exact line number of failing CHECKs. Therefore reverting this CL will help further investigations. Original change's description: > Disable WebSockets over HTTP/2 support to avoid crash. > > This crash was introduced in https://crrev.com/c/940463. It seems to be > triggered by buggy servers that negotiate HTTP/2 and send 200 OK to an > HTTP/1.1 WebSocket request. This CL reverts the functional part of that > change and in effect disables WebSocket over HTTP/2 support. Behavior > is not spec-compliant if Chrome is invoked with the experimental > --enable-websocket-over-http2 command line flag. In particular, crash > might still happen when using this flag. > > Bug: 842575 > Change-Id: I8ebb60cda3e056ad37557bd1cfc92088224b80a1 > Reviewed-on: https://chromium-review.googlesource.com/1067986 > Reviewed-by: Adam Rice <ricea@chromium.org> > Commit-Queue: Bence Béky <bnc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560454} Change-Id: I8afcf6ea090f66a74b20bf79ca90f28f4418f3b6 Bug: 842575 Reviewed-on: https://chromium-review.googlesource.com/1069227 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
-
Fergal Daly authored
Before this CheckInvalidationSetsAgainstElement returns a bool and had several possible side-effects. This made it hard to document. After, CheckInvalidationSetsAgainstElement checks just that and only has side-effect on RecursionData. Also Invalidate has a more linear flow. This whole change is intended to be a no-op. The sequence of no-op steps to get to here is visible here https://drive.google.com/file/d/1gxFjYrXEwOqwP0AnlpknPLsUMZtNbPMC/view Change-Id: I97ede99c8057f948427d5e0ef71e817b4ba4d70a Reviewed-on: https://chromium-review.googlesource.com/1061833 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#560932}
-
Yoichi Osato authored
At the discussion on the line break patch, we decided not to paint block end line break selection: https://chromium-review.googlesource.com/c/chromium/src/+/896780/36/third_party/blink/renderer/core/editing/layout_selection.cc#649 This patch rebaselines image failures not painting block end line break selection following the decision. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I1f337d408a4989a072ab41255aefe25e77eee490 Reviewed-on: https://chromium-review.googlesource.com/1068640Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#560931}
-
Aga Wronska authored
It makes ActivityStorage customizable, so it can work with different pref stores. For enterprise reporintg activity is stored in local state and for consumer reporting it is kept in user prefs. Bug: 837001 Test: Run: DeviceStatusCollectorTest, ConsumerDeviceCollectorTest, UserCloudPolicyManagerChromeOSTest. Manully: Add child account to device and observe status upload after ~60s, Sign in as child user and observe status upload after ~60s. Change-Id: Id82d3b0d3b8a3486ceae38acf9499b6825fbbb00 Reviewed-on: https://chromium-review.googlesource.com/1056264 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#560930}
-
Kent Tamura authored
This CL fixes a regression by crrev.com/560505. Before r560505 such strings were converted to USVStrings implicitly because FromData::Entry stored encoded CStrings, and text encoders replace unpaired surrogates with U+FFFD. Since r560505 we don't apply text encoding in FormData::Entry, and need to convert strings to USVStrings explicitly. This CL also adds DCHECKs to FormData::Entry constructors. Bug: 845744 Change-Id: I9893848f4e32fbe3c0c7a8f787584fbbb8ba8e87 Reviewed-on: https://chromium-review.googlesource.com/1067560Reviewed-by:
-
Trent Apted authored
These fell off the waterfall in r549698. 1 file no longer exists (passwords_bubble_browsertest.mm). 6 files stay out of the build. These do not compile with mac_views_browser since they are for obsolete secondary UI. 2 files currently don't compile but should be added back: - browser_window_controller_browsertest.mm - task_manager_mac_browsertest.mm 20 files are added back. Some needed minor fixes. Some tests are disabled (and should be re-enabled): - FindBarBrowserTest.FocusOnTabSwitch - FindBarBrowserTest.EscapeKey - PermissionBubbleBrowserTest.BrowserFullscreenHasLocationBar - PermissionBubbleBrowserTest.TabFullscreenHasLocationBar Bug: 845389 Change-Id: Id3d07165fcb5c9221c82f4c71c4dfad98d513e01 Reviewed-on: https://chromium-review.googlesource.com/1068628Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#560928}
-
Tsuyoshi Horo authored
Currently when faild to verify the certificate while loading signed exchanges, only the error number is shown in DevTools. To show the error string (example: ERR_CERT_DATE_INVALID), this CL uses net::ErrorToShortString(). Bug: 830505 Change-Id: Ic93c6c9f532c67ca2ab0bfe6fbd32f0fb2359893 Reviewed-on: https://chromium-review.googlesource.com/1068950Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#560927}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2315c9a28bd5..71e81d76d2fc $ git log 2315c9a28..71e81d76d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:b/80136084 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iddc50eb534ed37ab0971e617f0987e878d0d9019 Reviewed-on: https://chromium-review.googlesource.com/1069835 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560926}
-
