- 09 Jun, 2020 40 commits
-
-
Rouslan Solomakhin authored
Before this patch, CanMakePaymentQuery would stop its timers in the destructor, which is the second phase of browser shutdown, as opposed to the KeyedService::Shutdown() method, which is the first phase, where all references should be released. This may have caused a crash when closing the browser. This is a speculative patch to have CanMakePaymentQuery stop its timers during the first phase of browser shutdown. After this patch, CanMakePaymentQuery stops its timers in the KeyedService::Shutdown() method, which is the first phase of browser shutdown. Bug: 1092472 Change-Id: Ie0b0ebb5642a4d7d80bbaee3ad4c00e48b765b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236251 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#776608}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/08328fea5ab9..68b2e15ee016 2020-06-09 rharrison@google.com Use correct type for var storing returned value (#2263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I7e99e09590cf15d937e99265285bc509be521014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237873Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776607}
-
Raphael Kubo da Costa authored
- Tuple parameter unpacking was removed in Python 3, so adjust type_order_priority() accordingly. - |cmp| as a parameter for list.sort() was removed in Python 3, use functools.cmp_to_key(). Bug: 941669 Change-Id: Icafb2024c77a335e5dd043be066f414a38f14b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236404 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#776606}
-
Thomas Anderson authored
This reverts commit 6ac4a0b6. Reason for revert: Build failure on official builder: https://ci.chromium.org/p/chrome/builders/official/linux64/1293 Original change's description: > Reland "Enable Snap package for official builds" > > This is a reland of d1bd3ffb > > Original change's description: > > Enable Snap package for official builds > > > > BUG=1055026,1090915 > > R=dpranke > > CC=goanuj > > > > Change-Id: I7009f67268fa5d35e9d41fca593248c36f6ef631 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232837 > > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#776165} > > TBR=dpranke > > Bug: 1055026, 1090915 > Change-Id: I80fd77b927b9a832b779bdb09b843016a9c3a93f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236069 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776202} TBR=dpranke@chromium.org,thomasanderson@chromium.org Change-Id: I1de497c89600c89eece335198c6fef3699422caa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055026, 1090915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238410Reviewed-by:
-
Amin Hassani authored
So system_api can be upreved. BUG=1071262 TEST=unittests Change-Id: I20eaf9671e9094eb9304eea161af6e530ab3e974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237393 Auto-Submit: Amin Hassani <ahassani@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Amin Hassani <ahassani@chromium.org> Cr-Commit-Position: refs/heads/master@{#776604}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 164 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-12-06. TBR=chromium-metrics-reviews@google.com Change-Id: Icf8bbe2d04dd2f4130faf6671cbbf1d960681a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238147Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#776603}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dffa944e0725..5ad16a50fcee 2020-06-09 danilchap@webrtc.org suppress 'Paramaterized test suite never instantiated' warning If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifb73ba9b4a59a2f69d9d64c9ec9e145ad9e23234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237871Reviewed-by:
-
Hans Wennborg authored
Since the destructor was not defined in the template definition, code referring to it would fail to link. This started happening in official windows builds when profile-guided-optimization performed virtual call promotion on a call to this function (see bug). Bug: 1092818 Change-Id: I9840e35dabc2d596b59ea5c315697ba15157542e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235826Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#776601}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2ad47493f833..2943cc478e46 2020-06-09 cbruni@chromium.org Avoid UpdateTrafficSettings when possible If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1092870 Tbr: oysteine@google.com Change-Id: I601a9acc77f90aba9e8e44b0fbe2ee619cfc5d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236728Reviewed-by:
-
Daniel Rubery authored
This reverts commit 0f871357. Reason for revert: Caused a spike in crash rate (see https://crbug.com/1092793) Original change's description: > Use IsVisualMatch in the PhishingClassifier > > This CL adds code to the PhishingClassifier to extract a screenshot of > the current page. It also sends this screenshot to the Scorer to > determine if the visual model matches the given screenshot. > > Bug: 1068617 > Change-Id: I9e4cb1ba8888fa76b116405611bf64280a87def0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226974 > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Bettina Dea <bdea@chromium.org> > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775835} TBR=vmpstr@chromium.org,bdea@chromium.org,drubery@chromium.org Bug: 1068617 Change-Id: Id0c5a638346a02bbdc33aab91b96a8e7b96ece48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237910Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#776599}
-
Anastasia Helfinstein authored
To allow Switch Access to automatically move the user's focus into the status tray when it's opened, an accessibility event must be fired when the status tray bubble is created. The event kShow was selected because, although the status tray is treated like a menu by Switch Access, ChromeVox expects that kMenuStart would only be fired on a menu item. AX-Relnotes: n/a. Bug: 866173 Change-Id: I5cd1ac908c6df473135ac2676e3ec5706577b2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231903 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#776598}
-
Hazim Mohamed authored
For drag&drop we'll need to factor out the method responsible for setting permissions for a NFSHandle. We'll also need to expose the method responsible for getting a FSURL from a path. This is done to deduplicate code responsible for and choosing permissions for SharedHandleStates, and to facilitate using the same logic when turning a NFSTransferToken into a Handle. Bug: 1080811 Change-Id: I783b6f1959e0fa03e0178466be4c07ee9d8776d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232879Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Cr-Commit-Position: refs/heads/master@{#776597}
-
Kevin Marshall authored
Mentions of `gclient runhooks` are replaced with `gclient sync`. The instructions previously stated that developers should run `gclient runhooks` after fetching. `runhooks` is not sufficient by itself for fetching all of the dependencies; some tools such as aemu are excluded by this step. Change-Id: I405e17018873fcb69d50e3ab9a49f5fb9503a6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237724 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#776596}
-
Darren Shen authored
Launching in M85. Needs to land before Feature Freeze. Bug: 1076172 Change-Id: I8e7634ae13b3dbfce066109b779ff27f6ea457db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235220 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#776595}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 33 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-12-06. TBR=chromium-metrics-reviews@google.com Change-Id: Ica45034954215a1b812c4fe18d98a050b00bca0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238146Reviewed-by:
-
Yue Li authored
Bug: b/156405987 Test: Manual Test Change-Id: I57c0c37ca7865f23df730e84167f9be6368dc33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227900 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#776593}
-
Aaron Colwell authored
- Updates directory and filenames to use more inclusive naming. - Updates header guards on renamed files. - Updates build and dependency rules. - Update #includes Bug: 1092096 Change-Id: Ie084d8f786e63c7f49d6af2a546bdf8fe813f24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236454Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#776592}
-
Rakib M. Hasan authored
Bug: 1050760, 1050754 Change-Id: I26e3b9262db6a7e7de40f3daf653d66abb959d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236496Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#776591}
-
Xi Han authored
We don't re-enable the failing tests in the reland. Original change's description: > [Instant Start] Create ToolbarManger before showing overview. > > In this CL, we introduce an additional state in InflationObserver: > onInflationComplete. This event happens between onPreInflationStartup > and onPostInflationStartup, thus provides a way to split the > implementation of onPostInflationStartup into two methods. > > In RootUiCoordinatior, the ToolbarManger is created in > onInflationComplete, and ChromeTabbedActivity calls showOverview() > after RootUiCoordinatior#onInflationComplete but before initializing > other components in onPostInflationStartup. Thus, ToolbarManager setups > an OverviewModeObserver and won't lose any early events that an > overview is shown or overview mode is changed. > > Bug: 1077022 > Change-Id: I6bc8b96906a9519a928c6490bec0ca158b3d6241 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181667 > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Ender <ender@google.com> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Xi Han <hanxi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776073} Bug: 1077022 Change-Id: Id01abc7d9ed2df245a327105e72ab25fa844daa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237646Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776590}
-
Ian Barkley-Yeung authored
Increase the detail on the CrashReport.DumpWithoutCrashingResult.FromInitSharedMemoryIfNeeded metric. In particular, record which of the two crash handlers succeeded or failed. This will allow me to distinguish "Breakpad is always failing, Crashpad is sometimes succeeding" from "Breakpad sometimes succeeds, sometimes fails". NOTE: Renamed CrashReport.DumpWithoutCrashingResult.FromInitSharedMemoryIfNeeded2 because of the new enum. BUG=chromium:1074115 Change-Id: I8bcd6e10177d23f9c7c0f8a6e1c637192406a249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236469 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#776589}
-
Bettina authored
Bug: 1038797 Change-Id: Icb3f4412796bae267cd0427ec440b49dd7c6c4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236495Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#776588}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb20-30.html BUG=412078 TBR=jschuh@chromium.org Change-Id: I4975af48096599a480342dacc3d49984be3e4bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238012Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#776587}
-
Pavel Yatsuk authored
This reverts commit 3d506040. Reason for revert: The test fails on multiple builders. E.g.: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/32695 The call stack is: android.support.test.espresso.base.DefaultFailureHandler$AssertionFailedWithCauseError: View is present in the hierarchy: MessageCardView{id=2131428697, res-name=tab_grid_message_item, visibility=VISIBLE, width=1038, height=156, has-focus=false, has-focusable=true, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=21.0, y=603.0, child-count=3} Expected: is <false> Got: <true> at dalvik.system.VMStack.getThreadStackTrace(Native Method) at java.lang.Thread.getStackTrace(Thread.java:580) at android.support.test.espresso.base.DefaultFailureHandler.getUserFriendlyError(DefaultFailureHandler.java:82) at android.support.test.espresso.base.DefaultFailureHandler.handle(DefaultFailureHandler.java:53) at android.support.test.espresso.ViewInteraction.runSynchronouslyOnUiThread(ViewInteraction.java:184) at android.support.test.espresso.ViewInteraction.check(ViewInteraction.java:158) at org.chromium.chrome.browser.tasks.tab_management.TabGridIphTest.testNotShowIPHInMultiWindowMode(TabGridIphTest.java:344) Original change's description: > Skip showing tab switcher message card in multi-window mode > > Bug: 1085630 > Change-Id: If0e6e852458aedf448647e3ab8320519c4775bd2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216630 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Mei Liang <meiliang@chromium.org> > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776308} TBR=wychen@chromium.org,meiliang@chromium.org,yuezhanggg@chromium.org Change-Id: I60c9ff0219832ccda197550ee8de92b6bb91fb54 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236502Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#776586}
-
Raphael Kubo da Costa authored
IWYU. This fixes the libstdc++ build after commit 5e47a2b2 ("[gamepad] Keep track of which buttons and axes are used"). Bug: 957519 Change-Id: I835b279a84b129c7af78ff10a42c39b90d0bd6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237253 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#776585}
-
Nazerke authored
Bug: 1072370 Change-Id: Ib3b773f01e3c2f3b3d4d0e1ea60599878efe8840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235596 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#776584}
-
Raphael Kubo da Costa authored
dict.has_key() does not exist in Python 3. Just use dict.get() to achieve the same result with fewer checks. Bug: 941669 Change-Id: Iaeec0ac1ec8efd88c796c73344fea91eaab0df7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236435 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#776583}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/6cccce4f5870..faf8b0277550 $ git log 6cccce4f5..faf8b0277 --date=short --no-merges --format='%ad %ae %s' 2020-06-08 renjietang For IETF QUIC client: When 0-RTT is rejected, check the server-sent transport params and close connection if server's limit exceeds what the client has already used. 2020-06-08 nharper Create a SessionCache for TLS resumption in QUIC HTTP EndToEndTest 2020-06-08 renjietang In IETF QUIC client: Delay retransmission of 0-RTT data to be after QuicSession config is set to the fresh server config. 2020-06-08 nharper Add support for accepting 0-RTT in TlsServerHandshaker 2020-06-08 danzh (n/a) open source quic gso batch writer. not protected. 2020-06-08 nharper Add SerializeTransportParametersForTicket 2020-06-08 fayang Deprecate gfe2_reloadable_flag_quic_change_default_encryption_level. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=dschinazi@chromium.org Change-Id: If3f80075dd3442026dd2e83d4de6fa190738e0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237769 Auto-Submit: Fan Yang <fayang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776582}
-
Philip Rogers authored
This patch unifies the grouping property logic used for stacking contexts (ComputedStyle::UpdateIsStackingContextWithoutContainment), PaintLayer creation (LayoutBox::LayerTypeRequired), 3d transform flattening (ComputedStyle::UsedTransformStyle3D), and svg isolation (SVGLayoutSupport::IsIsolationRequired). Grouping properties are specified in [1]. This patch reduces complexity and is likely to improve performance with fewer checks in LayoutBox::LayerTypeRequired. Box reflection (-webkit-box-reflect) only applies to boxes but is used to create a stacking context for all objects. To avoid changing this behavior, a parameter is used for HasGroupingProperty. By recognizing CSS clip as a grouping property, compositing reason finder is able to force layers for clips with composited descendants (CSS clip -> HasClipRelatedProperty -> kClipsCompositingDescendants), which results in some test changes. [1] https://drafts.csswg.org/css-transforms-2/#grouping-property-values Bug: 1068596 Change-Id: I86ca4a41b0324f2966c557dce6396b3bba684598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234541 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#776581}
-
Dan Harrington authored
Bug: 1092633 Change-Id: I69c0ad234c2d78216c72536ece56e2cbfb45f1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236680 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#776580}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2a9754b30e90..929d66714815 2020-06-09 aerotwist@chromium.org Adds estimated TBT to timeline 2020-06-09 alexrudenko@chromium.org Ignore changes to mutable inline stylesheets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id16e32b6a5acd7edd6a97cfed15418764932706a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237869Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9798d78dd73dfeabf6732332ed5b7dc69781a08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237872Reviewed-by:
-
Teresa Kang authored
Adding performance tests that serve to measure how much performance improvements can be obtained by the addition of willReadFrequently option. Test cases include multiple draws and multiple getImageData calls. The canvas-getImageData-smooth.html is corrected and shows that the discrepancy between cpu and gpu rendering does exist. Bug: 1090180 Change-Id: I8701f4389d8f0c9a26498d35b874453512e4669f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231808Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Teresa Kang <teresakang@google.com> Cr-Commit-Position: refs/heads/master@{#776577}
-
Adam Norberg authored
It now takes an XPC protocol as a parameter and mocks the service specified. Some type safety is lost in the process, since I had to convert id<P> to raw id in a few spots; I spend a while trying to figure out how to do this with templates and concluded that I probably couldn't (because C++ does not understand an Objective-C protocol, since it is completely outside the C++ type system), and figured the unchecked type is tolerable in test code. Bug: 1055876 Change-Id: I2fe5684b34b64245f6d9fe7716c9bdf7cd97c76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231703Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Adam Norberg <norberg@google.com> Cr-Commit-Position: refs/heads/master@{#776576}
-
Xida Chen authored
TBR=treib@chromium.org NOTRY=true Bug: 1092721 Change-Id: I680448ba7ca6926d058fb48cbca9c38c83adb8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238267Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776575}
-
Oksana Zhuravlova authored
This is a reland of a0061b0e The updated trace processor for mac has rolled in https://crrev.com/c/2236111. Original change's description: > Reland "[tools/perf] Add webview_cpu_usage metric" > > This is a reland of 5c76e821 > > The test failures that caused the revert have been fixed in > https://r.android.com/1325791 and rolled into chromium in > https://crrev.com/c/2236240. > > Original change's description: > > [tools/perf] Add webview_cpu_usage metric > > > > This change adds a metric that calculates the amount of time WebView > > spends on different frequencies. > > > > Bug: b/157855323 > > Change-Id: Ibb1fa61cc2ba1479f2b76ef642dc03c64a9a14b5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231452 > > Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> > > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#775713} > > Bug: b/157855323 > Change-Id: I45552ebb5b3ca49c05506495e16a7a20e02ade86 > TBR: khokhlov@google.com > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236055 > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776374} TBR: oksamyt@chromium.org Bug: b/157855323 Change-Id: If89eab0236486f3d09e381881cac3743d6942368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235719Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#776574}
-
Chris Lu authored
This change adds two classes: TranslateInfobarModalOverlayMediator, which serves as the mediator for Translate Infobar Overlays, and TranslateInfobarModalOverlayCoordinator, which manages the presentation of the modal. FakeInfobarTranslateModalConsumer is created for testing the mediator. Bug: 1071914 Change-Id: Ic6fe7d49966aee1426840f9bdc6033699aa7c09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233485 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#776573}
-
Manuel Rego Casasnovas authored
Change-Id: I783825bb9362df3c1a43f10ac8666f69332bd774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238106 Commit-Queue: Manuel Rego <rego@igalia.com> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776572}
-
Mohsen Izadi authored
Currently, key events set EventTimeForNow() as their time stamp if the provided time stamp is null. This CL expands this to all event types. It also sets a proper time stamp for native key events generated by ui::test::EventGenerator. Hopefully, this change makes tests that rely on event timings more reliable. Bug: 1086620 Change-Id: I79d0e91ce91da227f2c832c7044c5b9b42369af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228055Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776571}
-
Antonio Gomes authored
... instead of WebMediaStreamSource. CL is a follow up of https://crrev.com/c/2236014, where the use of MediaStreamComponent was adopted instead of WebMediaStreamTrack. BUG=704136 R=guidou@chromium.org Change-Id: Ic23327f40cc5d1e55e760943477f74723b312e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237768 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#776570}
-
Jeroen Dhollander authored
Now that the |AssistantState::READY| flag has been removed, we can rename the NEW_READY flag to READY. Bug: b/142428671 Change-Id: If874e8e856e34fefe75e0b39c937258f255261d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236289 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#776569}
-
