- 05 Nov, 2019 40 commits
-
-
Andy Paicu authored
CrElementsLottieTest.All and CrSettingsPasswordsSectionTest_Cros.All TBR=dpapad@chromium.org Bug: 1021474b Change-Id: I25d075b7fb3e99eab14e14bb443f658bf6fd2f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899609 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712534}
-
Andy Paicu authored
TBR=achuith@chromium.org Bug: 1021492 Change-Id: I92ac9a593b0fb03263c3df3cffa8f06354454f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899454 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
Pavel Shmakov authored
Change-Id: Ib9fc6ab6deaa75a4a668b4a18cfc4650a1ce69d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897655 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#712532}
-
Fredrik Söderquist authored
The ResetAnimatedType, ClearAnimatedType, ApplyResultsToTarget and CalculateAnimatedValue methods that handles calculation and application of animation values are only called on elements that has made it into a sandwich - this means that they have passed the "has valid target" check. Simplify the code accordingly by assuming there is a target and that other checks that HasValidTarget() make holds. The latter for example means dropping the null-check for the animateMotion transform transform. Also remove SVGAnimateElement::ShouldApplyAnimation() and always remove the CSS property in SVGAnimateElement::ClearAnimatedType() when animating CSS. Bug: 1017723 Change-Id: I9d184325671fae820c5718d3145228b7bd8d284e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895336Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#712531}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I6a1aa633eac896f79023c0bd64ad3f539c383538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897556 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#712530}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df415528411f..ac36a55cc2de git log df415528411f..ac36a55cc2de --date=short --no-merges --format='%ad %ae %s' 2019-11-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 48233ad3d45b..5d0e01d9e7f9 (7 commits) 2019-11-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src f1e5cd73f658..e0d5544c9864 (2 commits) Created with: gclient setdep -r src/third_party/angle@ac36a55cc2de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None,chromium:None Change-Id: I7cc20349e7af29668ac0b2d346e5178208ac73a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899395Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712529}
-
David Roger authored
The multilogin mode is currently dropped on the floor by the account reconcilor. This mode needs to be passed to the Gaia server. This CL passes it to the identity service (by passing the full MultiloginParameters structure instead of the account list). A follow-up CL will complete the plumbing to Gaia. Bug: 890321 Change-Id: I711fed0b26a60b74b976e348111029f6948b187f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893252Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#712528}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I606e443dac0a759d055172204b0dea2e8379f544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899396Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b3914918d320..0262cc7eb2a2 Created with: gclient setdep -r src-internal@0262cc7eb2a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If2963807908790e981a3d208f4cc9af7a8bb1f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899394Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712526}
-
Thomas Tangl authored
Note: No new strings are added! Bug: 1021093 Change-Id: I5963caeb11207951f2f52c8f25958b03f9ffa4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893210 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#712525}
-
Yuta Kitamura authored
We have some crash reports for Linux that tell us that processes are sometimes getting killed with SIGBUS when they write to memory mapped to shared memory file. The suspected cause is /dev/shm volume getting full. This CL is an attempt to avoid this by using posix_fallocate() instead of ftruncate(), which preallocates memory early and detects disk full before we write to memory. The code is only enabled for Linux, because we currently see the symptom happening only on Linux. Bug: 1014296 Change-Id: I45c5f4152639a742da689472b73c5e1dd717a2d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895028Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#712524}
-
Jan Wilken Dörrie authored
This change modifies base::NativeEnvironmentString to be std::wstring on Windows and updates affected code. Bug: 911896 Change-Id: Ib39c473f42a2cd3384dd6fefd11021e4636629c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891311Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
Introduce QuicTransportConnector for the creation interface between the renderer and the browser process. Introduce NetworkContext.CreateQuicTransport for the creation method called from a trusted call-site. Bug: 1011392 Change-Id: I9536064c6299ac5c1ae56f7143cd4747ff582b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869149 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#712522}
-
Andy Paicu authored
This reverts commit b9c8d354. Reason for revert: SingleClientNigoriSyncTestWithUssTests.ShouldRotateKeystoreKey fails consistently on various builders First builds * linux-chromeos-google-rel: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/8654 * Win 7 Tests x64 (1): https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/60958 * linux-chromeos-rel: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/30949 * Linux TSan Tests: https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/46542 Original change's description: > Add test for keystore key rotation > > New test mimics server-side behavior for triggering keystore key > rotation: generation of new keystore key with touching the Nigori > node. After that client should receive updated keystore keys and the > same Nigori node as it already has (modulo metadata update). The client > should commit the new Nigori node with rotated keystore key and this > verified by checking |encryption_keybag| encryption key name. > > Bug: 922900 > Change-Id: I91b86bbb0f68a55fdcc10049fa90afa70dc32155 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887611 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> > Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> > Cr-Commit-Position: refs/heads/master@{#712502} TBR=mastiz@chromium.org,mmoskvitin@google.com Change-Id: Iad001f70868944270cfbc54f77a5e68f852dc019 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899495Reviewed-by:
-
Michael Lippautz authored
Merge TraceNoWeakHandlingInCollectionHelper into regular TraceInCollectionTrait. Bug: 1019191 Change-Id: Ie958cd188bdb3cd917b7753fc1ce4803ce1fba49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899490Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712520}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/70d4ef304416..a05f421623d7 git log 70d4ef304416..a05f421623d7 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 perezju@chromium.org [Telemetry] Hand over artifact upload to Results Processor Created with: gclient setdep -r src/third_party/catapult@a05f421623d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:981349 Change-Id: Iab128083643614d7ecb477b17cf5f15f38c72997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899391Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6df81ebf1dcf..dbf9f7c39cbe git log 6df81ebf1dcf..dbf9f7c39cbe --date=short --no-merges --format='%ad %ae %s' 2019-11-05 lehoangq@gmail.com Fix conflicts between ANGLE & Dawn's spirv-cross build config Created with: gclient setdep -r src/third_party/dawn@dbf9f7c39cbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I4608c719108a1c21d6c9903173518a04f50b2563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899392Reviewed-by:
-
Bartek Nowierski authored
This enables v8-side tracking of JS function calls made within a context of a detached window. Such calls should be rare, but if our predictions are incorrect, the tracking code may impact performance of function calls. Therefore, this is implemented behind finch experiments SetDetachedWindowReasonBy* (enabled by default, but it'll give as an opportunity to disable tracking or limit % of participating users, if needed). Bug: 1018156 Change-Id: I878e6f1fabdeb229531af688fea0a5bc7412a145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895017 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712517}
-
Renato Silva authored
This commit improves the reliability of the EULA browser test EulaTest.LoadOffline. This test was disabled due to its flakiness in the past and is now enabled again. Tested locally. Ran 100 tests under stress without any errors. Bug: 1015948 Change-Id: I59bc8612da9f5be526a2aa28d13ee70400dbb01e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892775Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#712516}
-
Rune Lillesveen authored
Failing due to missing typed attr() implementation. Skip with the other tests for that feature. Bug: 246571, 931214 Change-Id: Ifa70b33ac8c82873ad9ed6a5308093cde7c23ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899491 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#712515}
-
Lei Zhang authored
This is a reland of c7dc2cd8 Original change's description: > Disable flaky ShouldKeepLocalDataOnTypeMismatch_E2ETest. > > This TwoClientPreferencesSyncTestWithSelfNotifications test case is > flaky. > > TBR=mastiz@chromium.org > > Bug: 1012688 > Change-Id: I33f1956523be55f3f77db0560aac4c3de6721341 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859635 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705625} Bug: 1012688 Change-Id: Idb70d277042bcb98a94130da3f2bab59ffaf0d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898651Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712514}
-
Maksim Moskvitin authored
Bunch of tests not passing with USS implementation of Nigori and this is expected due to the implementation of these tests. SingleClientCustomPassphraseForceDisableScryptSyncTest.* covers behavior specific for Directory implementation: disable kSyncUSSNigori. SingleClientDirectorySyncTest.DeleteDirectoryWhenCorrupted is likely not working due to having no Directory datatypes. Since Directory is subject for removal it's not worth to further invest into this test. TwoClientBookmarksSyncTest.* encryption related tests use EnableEncryption() and has no direct mapping to custom passphrase test. They also exercises EnableEncryption() logic instead of bookmarks logic. They are removed (we have / planning to add analogues whenever possible into custom passphrase tests). FirstClientEnablesEncryptionWithPassSecondChanges is an exception, because it already works with custom passphrase and actively manipulate bookmarks, so it's worth to keep as is (minor changes, to not rely on IsEncryptionComplete()). TwoClientPreferencesTest.* and TwoClientSessionsSyncTest.* encryption related tests are removed (same motivation as for bookmarks tests). Bug: 922900 Change-Id: Ib95db74830b1d5d43b20d7dfacf3045694f80014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890050 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712513}
-
Marc Treib authored
This renames some methods and updates comments. No behavior changes. Bug: 1021092 Change-Id: Iab7d289e707a86cfaa79a45a7d2cdf071dbcb87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898066 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#712512}
-
Michael Lippautz authored
Bug: 1019191 Change-Id: I4a256adc5511f4cd1cbbbd13f600aa812d87ede6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899486 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Greg Thompson authored
BUG=546640 R=guidou@chromium.org Change-Id: I7d5b4aefd1ea485d44f331d05e5e3f7b8207513a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899487 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712510}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c3a91730e33e..69dd6b02511c git log c3a91730e33e..69dd6b02511c --date=short --no-merges --format='%ad %ae %s' 2019-11-04 tsepez@chromium.org Check for NaN in CFXJSE_FormCalcContext::WordNum() 2019-11-04 dhoss@chromium.org Change variable target_type to static_component_type in //:pdfium Created with: gclient setdep -r src/third_party/pdfium@69dd6b02511c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:947876 Change-Id: I43ade48f66c0b64a4e8199dc77e404af1dd49659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899286Reviewed-by:
-
Himanshu Jaju authored
Adds SignallingMessage and IceCandidateMessage protos used for p2p connection in webrtc. Bug: 1020246 Change-Id: I4968cb73cae26169f2c6815aef1f91140ee02d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893857Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f1e5cd73f658..e0d5544c9864 git log f1e5cd73f658..e0d5544c9864 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 jmadill@chromium.org Add missing headers to GN. (#3009) 2019-11-05 chris@chris-lamb.co.uk Correct "environment" typo (#3007) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e0d5544c9864 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: I0bb09de61d7304556fad1607a28ee36532e2ee06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899354Reviewed-by:
-
Richard Townsend authored
Windows inconsistently #define's _alloca as alloca in malloc.h, the conditions required are not present on Windows on Arm. To fix, we check and (possibly redefine) alloca on all Windows targets. Bug: 1020541, 893460 Change-Id: Ife80ce3e7478d39d36e67686d70a74ff2319c714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892976Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#712506}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7f77b2e8669a..5d0e01d9e7f9 git log 7f77b2e8669a..5d0e01d9e7f9 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 johnkslang@users.noreply.github.com Merge pull request #1961 from zoddicus/fixChromiumRoll 2019-11-04 johnkslang@users.noreply.github.com Merge pull request #1953 from null77/gn-add-missing-headers 2019-11-04 johnkslang@users.noreply.github.com Merge pull request #1954 from corporateshark/master 2019-11-03 cepheus@frii.com Tests: Add more test results for the previous generator version bump. 2019-11-03 cepheus@frii.com Bump up the generator version, which is exposed in SPV test results. 2019-11-01 cepheus@frii.com Merge branch 'dneto0-dead-code' Created with: gclient setdep -r src/third_party/glslang/src@5d0e01d9e7f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: I0c02ba75ec1709fd70dfd6719100fe81b7bb01ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899360Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/835991798ff9..b3914918d320 Created with: gclient setdep -r src-internal@b3914918d320 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I48786d70431d254682c363016f237e8f63cb9264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899356Reviewed-by:
-
Hiroki Nakagawa authored
> Introduction When PlzDedicatedWorker (off-the-main-thread dedicated worker script loading) is enabled, top-level dedicated worker script is fetched on a worker thread, not on the main (or parent) thread. This causes a problem when a dedicated worker is created from blob URL registered in a sandboxed iframe. > Problem A sandboxed iframe has an opaque origin. Blob URL registered in the frame also has the same opaque origin. When sending a network request to the blob URL, requester's SecurityOrigin takes the origin from the blob URL, and then conducts security check (see SecurityOrigin::CanRequest()). However, it's not straightforward on the opaque origin because the opaque origin is serialized into the blob URL (KURL) as "null" string like "blob:null/{UUID}", and there is no direct way to rebuild the origin from the KURL. To deal with the case, in the current implementation, the pair of the blob URL and the opaque origin is stored in thread-specific BlobURLNullOriginMap, and then the security check refers to the map. This mechanism works well when PlzDedicatedWorker is disabled, but not work when PlzDedicatedWorker is enabled. This is because the pair of the blob URL and the opaque origin is stored in the thread-specific map on the main (parent) thread, but the network request and the security check are conducted on the worker thread. As a result, the security check always fails. > Solution Making BlobURLNullOriginMap thread-safe could be one of solutions, but actually it's quite hard and not practical. This is because SecurityOrigin is not thread-safe, and widely used with an assumption that it's not shared among threads. Alternatively, this CL makes SecurityOrigin::CanRequest() check the opaque origin of the blob URL using SecurityOrigin::Nonce. Nonce is uniquely assigned to SecurityOrigin when it's constructed as an opaque origin, and SecurityOrigin instances (isolated-)copied from the same opaque origin share the same nonce. The nonce is base::UnguessableToken, and shareable among thread unlike SecurityOrigin. This CL introduces BlobURLNullOriginNonceMap that is the process-global singleton object to contain pairs of blob URL and opaque origins's nonce. The map is protected by Mutex, so any threads can access it. SecurityOrigin::CanRequest() compares the nonce stored in the map to its own nonce in addition to the existing checks. This fixes the problem. > Test This enables to pass some tests that were skipped because of timeout. Several test cases are still failing even after this change, but it should be caused by https://crbug.com/1017034. Bug: 987130 Change-Id: I6bf2212aa4f4b1a37035c41866b3faeffe68c2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873831 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
New test mimics server-side behavior for triggering keystore key rotation: generation of new keystore key with touching the Nigori node. After that client should receive updated keystore keys and the same Nigori node as it already has (modulo metadata update). The client should commit the new Nigori node with rotated keystore key and this verified by checking |encryption_keybag| encryption key name. Bug: 922900 Change-Id: I91b86bbb0f68a55fdcc10049fa90afa70dc32155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887611Reviewed-by:
-
Mitsuru Oshima authored
Bug: None Change-Id: I12693287a5f005bd3b6d8e2dcb4f40e6baaad938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898133 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#712501}
-
Yifan Luo authored
Currently, frame is detected as iframe in `destination` which will be fixed in https://bugs.chromium.org/p/chromium/issues/detail?id=1019716. Bug: 1011724 Change-Id: I722bcbccac3bfc914844711fb6feb1e21f859a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886863Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@google.com> Cr-Commit-Position: refs/heads/master@{#712500}
-
Yuki Shiino authored
It's not yet been fully understood, but it seems like doubly-proxying (ReferenceType = Proxy -> RefById -> DefinitionType/TypedefType) is causing trouble. This patch fixes the trouble, and makes a ReferenceType an instance of IdlType (actually of ReferenceType). Bug: 839389 Change-Id: Iccaa3ef78a1a77318e796248a1bf92a2eac40c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892986Reviewed-by:
-
Adam Rice authored
Add use counters for the constructors of CountQueuingStrategy and ByteLengthQueuingStrategy. This will help us evaluate their usage, with a view to possibly deprecating them. See https://github.com/whatwg/streams/issues/1005#issuecomment-549184328. Change-Id: I633ab863fd93da8e74ecdd7001815d6a1728c82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899236Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#712498}
-
Dana Fried authored
" This reverts commit 9932d106. Reason for revert: Broke a test with insufficient testing (see crbug.com/1021332) - will require additional investigation. Original change's description: > Layout invalidates when child view's visibility changes. > > > > Exactly what it says on the tin. > > > > This is a fix for legacy layouts (fill, box, grid) which aren't derived > > from LayoutManagerBase and which do not benefit from the logic in that > > class which handles the invalidation. LayoutManagerBase still overrides > > this logic with something more sophisticated. > > > > If in the future a legacy layout overrides ViewVisibilitySet(), it > > should either call the base implementation or handle the invalidation on > > its own. > > > > > Bug: 1003500 > > Change-Id: I9eccef21784175820816852e1b9c05d0713ef2eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894260 > Commit-Queue: Dana Fried <dfried@chromium.org> > Reviewed-by: Siyu An <siyua@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711966} TBR=siyua@chromium.org,dfried@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1003500 Change-Id: I9f82556592e9e8db02900620085250e696ab30c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899387Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#712497}
-
Eero Häkkinen authored
Request and Response's formData() multipart/form-data parsing uses "UTF-8 decode without BOM" which should not strip BOMs. Spec issue: https://github.com/whatwg/fetch/issues/650 Spec fix: https://github.com/whatwg/fetch/pull/915 WPT fix: https://github.com/web-platform-tests/wpt/pull/17589 Bug: 796192 Change-Id: I24721899006a8c09cf657b3638f1cb17e7953171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796367 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
-
Joanmarie Diggs authored
Originally landed: crrev.com/c/1749145 Reverted: crrev.com/c/1751830 The revert was due to Trusty not supporting ATK_ROLE_STATIC. The change is something which can wait but should be made eventually. Original commit message: Text leaf nodes and line breaks were being exposed as ATK_ROLE_TEXT. However, the definition of ATK_ROLE_TEXT is: An interactive widget that supports multiple lines of text and optionally accepts user input, but whose purpose is not to solicit user input. In contrast, ATK_ROLE_STATIC is defined as: A generic non-container object whose purpose is to display a brief amount of information to the user and whose role is known by the implementor but lacks semantic value for the user. Thus text leaf nodes and line breaks should be exposed with the latter role; not the former. Bug: 984590 Change-Id: I7da4ea79dcac546a96e55d5ef57c9a052e9bd578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872409 Auto-Submit: Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#712495}
-
