- 02 Oct, 2020 40 commits
-
-
James Cook authored
It's flaky on Windows and Chrome OS. Tbr: lazyboy@chromium.org Bug: 1119807 Change-Id: I2daf1c86ca220afef0c48e204cf61a85db61eed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446189Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#813209}
-
Esmael El-Moslimany authored
Fix flaky test and reland CL. Bug: 1134274 Change-Id: I58452d5264e36eb838e4e1d413c917496f4b964a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444374 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#813208}
-
Melissa Zhang authored
Bug: 1134069 Change-Id: I72639a41bac3c6d09274d724054e8e0bbe2e8176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440334Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Melissa Zhang <melzhang@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#813207}
-
Leonid Baraz authored
ReportClient creation made fully asynchronous, and problematic test can now wait for initialization to complete. Bug: b:169427520 Change-Id: Ic6566e9973dc48de86b36c8b1180d688de84ce76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444409Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#813206}
-
Stephen Chenney authored
My team or teams I work closely with own the majority of the histograms in the directories I've added myself to. I haven't been too aggressive about owning every histogram we use. Bug: 1133371a Change-Id: Id4c488154f72fb8dec2767928fe734909c1896e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441728 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#813205}
-
Side Yilmaz authored
|IncognitoTabModelImplCreator#getOTRProfile| function always returns primary OTR profile. This CL uses OTR profile that is obtained from mWindowAndroidSupplier for Incognito CCT. Bug: 1099642 Change-Id: I63ce65ddd6727470921864cb4abc325e8437f04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440626Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#813204}
-
Mugdha Lakhani authored
Periodic Background Sync was disabled for WebView here: https://chromium-review.googlesource.com/c/chromium/src/+/2419579 The layout test needs to be updated, which this CL does. Bug: 1131660 Change-Id: Ib10f7c80ee554843c0c4a61693afeaa99a87e3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442730 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813203}
-
Liviu Tinta authored
The test passes fractional coordinates when calling test_driver.Actions pointerMove. pointerMove requires integer coordinates. Change-Id: I334e2b9586c8fb297faa61b4b926eb03eed960fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405935Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#813202}
-
Christian Dullweber authored
Espresso is occasionally failing to click() with a INJECT_EVENTS permission error. Try to use TouchCommon, which is supposed to not have this issue. Bug: 1133770 Change-Id: Iaa7084e095e01c75dc8c0b973a99c991f81b3a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445493 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#813201}
-
Stephen McGruer authored
Naming was chosen to be familiar to users of run_web_tests.py Bug: 1133692 Change-Id: If7ea9dd32034b310f3377f1203da0b7b9f2e101a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441945Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#813200}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/935a915963e1..2e66e500622a 2020-10-02 treehugger-gerrit@google.com Merge "Add memory snaphot tables." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I559f1a81a1abdf1dbbaca002f7c68252f9317c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813199}
-
George Burgess IV authored
Unless it's guaranteed that `std::forward` always turns into an rvalue ref, using `std::move(x)`, where `x`'s type is a universal reference, is generally unsafe. `std::forward` is preferred for these cases. Bug: 1134310 Change-Id: I7be8fffa71418cd9585b2eb562ffe7968aa6c753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444129 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: George Burgess <gbiv@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#813198}
-
Scott Violet authored
During a rotation, when BrowserFragment is retained and the containing activity is recreated, the following sequence of events happens: 1. destroyAttachmentState 2. createAttachmentState 3. onFragmentStart <- when this is called isAttachedToWindow() is false 4. onFragmentResume <- when this is called isAttachedToWindow() is false BrowserImpl maintained some state to avoid doing certain things during a configuration change, but that state was reset in onFragmentStart(). The problem is onFragmentStart() triggers updating the visibility of the WebContents, and at the time onFragmentStart() is called isAttachedToWindow() returns false, meaning the WebContents was hidden. Hiding the WebContents is bad for sites like youtube which stop playing video. Then fix is to delay resetting state until onViewAttachedToWindow(). There is one other subtle change to TabImpl. Specifically getViewController() is changed to return null if the BrowserViewController hasn't been updated yet. This is necessary because the code updates the active state of the tabs *and* then the BrowserViewController. This means if when updating the active state of a Tab the Tab calls back to BrowserViewController the state isn't right, and may cause NPEs. BUG=1075744 TEST=TabTest.testRotationDoesntChangeVisibility Change-Id: I14e68251541f4387338e5548d4d78daac7419935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439556Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813197}
-
Marc Treib authored
This will make manual testing much easier. Bug: 1113713 Change-Id: I44eb67a06c33e2fec9450ab00f70de10fc399e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442732 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#813196}
-
Kevin McNee authored
AppViewGuest::LaunchAppAndFireEvent rejects guest contents creation if the app to be embedded does not listen for embed requests. However, the callback has already been moved into a pending response, so this is a use-after-move. We now create the pending response after checking for the existence of the embed request listener and before sending the request. Bug: 1124060 Change-Id: I27e6e2b0752be733d3415f5dd88eae314f90572b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440266Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#813195}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 679ae353. With Chromium commits locally applied on WPT: 349ec642 "WebXR: Add dynamic viewport scaling support" 20b437f1 "Reland "FontAccess: Sort fonts in lexicographical order"" be3069fb "[LargestContentfulPaint] Ignore full viewport images" 292c16f2 "Fix that mask containing image with clip-path can not apply to client" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Iabbfa0504bfe437fbd69ac356a9f03ab20e4f3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445529Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813194}
-
Michael Hansen authored
This adds support for validating the device name that a user enters during the Nearby Share onboarding flow. Validation happens as the user types and also when they try to proceed to the next screen. If an invalid name is detected, an error message will appear and the "Next" button will be disabled. Screenshots: https://screenshot.googleplex.com/3USR7ftg7QCwJhR.png https://screenshot.googleplex.com/6Cr6pedUxWnUKju.png Bug: b:169582004 Change-Id: I07d4822e0ea099b30d23ed34a5f70f01940a3009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441150Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#813193}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/89a7ef9f2dd9..d3e40e9e1f3d 2020-10-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-02 changhaohan@chromium.org Clean up unused treeElementSymbol 2020-10-02 jacktfranklin@chromium.org Fix heap snapshot test flakes on Mac bots 2020-10-02 jacktfranklin@chromium.org Add `component_docs/README.md` 2020-10-02 jobay@google.com Typecheck quick_open/QuickPick.js with TypeScript 2020-10-02 tvanderlippe@chromium.org Remove Node.prototype.appendChildren 2020-10-02 jacktfranklin@chromium.org Component docs server only lists HTML files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia4febe404810d9e1c91276c4ff102d12a9c64ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445710Reviewed-by:
-
Kent Tamura authored
Ruby NG has been enabled since M85, and we have received no bug reports on it. - Introduce LayoutObjectFactory::CreateRubyText() for consistency This CL has no behavior changes. Bug: 1069817 Change-Id: Idbaae441a0f71d3a03767c16c08492bdd146dd5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444633 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#813191}
-
Mohamed Adel authored
Adding implementation for GetDisplayed notifications for banners. Bug: 1134575 Change-Id: I5e2ffa8d127e2e2bfef76b3c5cf596ee96fe1972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445411 Commit-Queue: Mohamed Adel <adelm@google.com> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813190}
-
Henrique Ferreiro authored
This method was introduced in https://crrev.com/c/2424066 but it missed reversing the scale factor before scaling. Bug: 1097816 Change-Id: I50231345b272028ba162dd4a69db6e0179a8612a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444320 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#813189}
-
Kent Tamura authored
This CL adds two flags, LayoutNGTextArea for <input> and LayoutNGTextField for <textarea>. They depend on EditingNG flag. SearchFieldCancelButtonElement and EditingViewPortElement refer to LayoutNGTextField flag because only <input> uses them. Both of <input> and <textarea> use TextControlInnerEditorElement. So its TypeShouldForceLegacyLayout() checks the host element type. This CL has no behavior changes. These flags are not enabled yet. Bug: 1040826 Change-Id: I1caf433edb57ab2fec21c17744eff166d0a4deee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444636Reviewed-by:
-
Nela Kaczmarek authored
This is a reland of 6a5d7abc Original change's description: > Add HashAffiliationFetcher skeleton to retrieve affiliations by hash prefix. > > This change creates HashAffiliationFetcher skeleton that extends AffiliationFetcherBase. > This fetcher will provide additional privacy layer as it will request affiliations for a larger group of facets by passing only the prefixes of hashed URLs. > > Bug: 1108279 > Change-Id: I4a2b09aa7d8c3c51f4b30ba966a17ba5afb9b09b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423883 > Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812653} Bug: 1108279 Change-Id: I21fd2060285e117bcba21d6ea48f3a8ae7048de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445172 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#813187}
-
Mohamed Adel authored
Set UNNotification not to close on default action, and handle it to close through the bridge's Close method. Added unittest for it as well. Bug: 1134175 Change-Id: Ia7cd5751fb5c245434f1f4877ae4988353080a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442970 Commit-Queue: Mohamed Adel <adelm@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
This CL renames a method in TrustedVaultConnection, to reflect that there will be authentication factors other than device key. Bug: 1113598 Change-Id: Ieb84296feac97844fb78bd09f7e3a645bca54fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437378Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#813185}
-
Jan Wilken Dörrie authored
This change drops usages of autofill::PasswordForm in //chrome/browser/password_manager in favor of password_manager::PasswordForm. Bug: 1067347 Change-Id: I3efccfb9d609fe790988f804d3e5f07562e0f400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445609 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#813184}
-
Roman Sorokin authored
Looks like it was failing because of the renderer crash. Bug: 1121422 Change-Id: Ia561febf0b6c4205c70b05779e3a8a3d51808e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445549 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813183}
-
Drew Davenport authored
The buffer contents may be uninitialized on some platforms. Ensure that it is cleared before being displayed. Change-Id: I55007e0728852d38911515019a2a7a3640ef613c Bug: b:168735625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413179 Commit-Queue: Drew Davenport <ddavenport@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#813182}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601618211-256d587047e0fd89a9b32fa8e7b7bfc10ace51d7.profdata to chrome-linux-master-1601639725-a3be427f79e9860129010f71f852fe4dbfd505c5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ie5f9ec723865103ed177c60b0142145fd0116343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445715Reviewed-by:
-
Greg Thompson authored
Failing consistently. BUG=1134571 TBR=mario@igalia.com Change-Id: Ief83e1faae2805aa914d47a93ffe0ff439c481f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445492Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#813180}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1083010, 1045668 Change-Id: Idaf6204ce7db45a91b657f27ea183f6600084c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445449 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#813179}
-
Alexandre Courbot authored
When using DMABUFs, it is preferable to use the same V4L2 buffer with the same underlying buffer, as failure to do so results in memory unmappings/remappings in the driver. Use the newly introduced buffer affinity tracker and V4L2Queue::GetFreeBufferForFrame() method to achieve this transparently in the video decoder. Furthermore, it is a requirement of the V4L2 stateful decoder interface that V4L2 buffers are always backed by the same underlying memory, lest some reference frames lifetime tracking might be incorrect. BUG=b:159688625 BUG=b:167412992 TEST=video.DecodeAccel.h264 passes on Trogdor. Change-Id: I220a321d5584f50406480c105844a82dd96e63c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415909 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#813178}
-
Roberto Moura authored
Add missing call to super from finalizeCollectionViewUpdates inside the Tab Switcher Layout. Bug: 1127604 Change-Id: I109b5bd16a64351231857f5447c940e54452d68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440609 Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#813177}
-
Henrique Ferreiro authored
Change-Id: I8a8725cc11f7c2280be0efc94f74dc28454e3bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444250Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#813176}
-
Austin Sullivan authored
extraneous parenthesis Change-Id: I2f86c577efe77895bf3b403caefc84c123f35f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443512Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#813175}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/686769e47bba..31a694a309d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC grt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: grt@google.com Change-Id: I324d3892b6ff4a5ca1d439d4b43222190b0deda8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445669Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813174}
-
Mohamed Adel authored
This CL introduces unittests that test the UNNotification builder which will be added to when the builder sees more updates. Bug: None Change-Id: I8c52cb2f5b9641dfc807ace6d9b0c8ea01eecbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440629Reviewed-by:
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/d3614de617..093cc27604 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/d3614de617..093cc27604 Bug: None Change-Id: Iaa7f3d321c0f5c2ce9e689527868d4401525966f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444249 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#813172}
-
Ioana Pandele authored
This requires changing the end margin to ensure that the text is spaced 16dp from the end when there is no button icon. Screenshot on the bug. Bug: 1134164 Change-Id: I2c24a3a2be80ed555761fcee5dc6e25e46fca286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443251Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#813171}
-
Mark Mentovai authored
In Xcode 12.2b2, strip and some other tools depend on a new library, libcodedirectory.dylib. It needs to be included in the hermetic toolchain packages, otherwise, links that request stripping will produce errors such as: [9770/76120] LINK clang_x64/symupload FAILED: clang_x64/symupload clang_x64/symupload.dSYM/Contents/Info.plist clang_x64/symupload.dSYM/Contents/Resources/DWARF/symupload TOOL_VERSION=1601523428 ../../build/toolchain/mac/linker_driver.py -Wcrl,strippath,../../build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip ../../third_party/llvm-build/Release+Asserts/bin/clang++ -B ../../build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ -Wcrl,dsym,clang_x64 -Wcrl,dsymutilpath,../../tools/clang/dsymutil/bin/dsymutil -Wl,-fatal_warnings -stdlib=libc++ -arch x86_64 -Wl,-dead_strip -Wl,-no_data_in_code_info -Wl,-no_function_starts -nostdlib++ -isysroot ../../build/mac_files/xcode_binaries/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.10.0 -Wl,-ObjC -Wcrl,strip,-x,-S -Werror -o "clang_x64/symupload" -Wl,-filelist,"clang_x64/symupload.rsp" -framework Foundation dyld: Library not loaded: @rpath/libcodedirectory.dylib Referenced from: /opt/s/w/ir/cache/builder/src/out/Release/../../build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip Reason: image not found Traceback (most recent call last): File "../../build/toolchain/mac/linker_driver.py", line 287, in <module> Main(sys.argv) File "../../build/toolchain/mac/linker_driver.py", line 103, in Main linker_driver_outputs += linker_driver_actions[name](args) File "../../build/toolchain/mac/linker_driver.py", line 137, in <lambda> lambda full_args: action(sub_arg[len(name):], full_args)) File "../../build/toolchain/mac/linker_driver.py", line 223, in RunStrip subprocess.check_call(strip_command) File "/opt/s/w/ir/cipd_bin_packages/cpython/lib/python2.7/subprocess.py", line 190, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['../../build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip', '-x', '-S', 'clang_x64/symupload']' returned non-zero exit status -6 This is relevant to the mac-arm64 official build. Bug: 1134565 Change-Id: I9b20dd6b740117056739065d35c5016567af0935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445909 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
