- 06 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/88dc2a4895c3..cc2305dd9537 2020-11-05 rharrison@chromium.org [inspector] Extract Sampler resource binding information 2020-11-05 dj2@everburning.com Fixup emitting duplicate globals in HLSL. 2020-11-04 dsinclair@chromium.org [wgsl-reader][wgsl-writer] Update storage texture type name. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I1f4200f5368a7f7b6cf94fa51941d04b59518163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522363Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824700}
-
Mark Mentovai authored
This version of Xcode updates the macOS SDK to 11.0 20A5408a (closer to 11.0 than 11.0.1). CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel Change-Id: I0bcfc826f5b64d90da8f33a9f840b3c962bce099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522003 Auto-Submit: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#824699}
-
Nidhi Jaju authored
In an effort to change the blink implementation of readable streams to better match the Web IDL descriptions in the Streams API Standard, this CL changes the return type of tee() from |any| to |sequence<ReadableStream> in readable_stream.idl, and |ScriptValue| to |HeapVector<Member<ReadableStream>>| in readable_stream.cc. This allows the code to be slightly simpler as well within CallTeeAndReturnBranchArray() in the ReadableStream class. Bug: 1093862 Change-Id: I273e9fa01c5601c578753952c1c0a4b5f8db0fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520638Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#824698}
-
Mark Mentovai authored
universalizer.py has special processing for Info.plist files, by looking for informational keys that identify the build host, toolchain, and SDK, and removing them when they differ rather than allowing such trivia to cause the merge to fail. This is important for the time being, because we’re using different toolchain and SDK versions for x86_64 and arm64 builds. This processing is enabled for any files that differ between architectures named Info.plist. One Info.plist in our bundle is not named Info.plist: the template Info.plist used for app mode loader apps. In our .app, it’s named app_mode-Info.plist. universalizer fails because of differences in this file, and does not attempt Info.plist rationalization as described above, which would allow the files to merge successfully. The differences between x86_64 and arm64 in 88.0.4316.3: DTSDKBuild (10.15 vs. 11.0), DTSDKName (macosx10.15 vs. macosx11.0), DTXcode (1210 vs. 1220), and DTXcodeBuild (12A4703 vs. 12B5035g). With this one change, universalizer completes successfully and merges each architecture’s .app into a single universal .app for that version. Code-Word: calamity Bug: 1142017 Change-Id: I11d006bc5b053483f7630970242e289a7a0b1178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522005 Auto-Submit: Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#824697}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/22775d8e1755..ec0c770ad8b1 2020-11-05 ehmaldonado@chromium.org Make LUCI_OWNERS owners of .cipd_impl.ps1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I017198c9e6fe3b9cd6f0ea7b04049e8661a16323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522364Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824696}
-
rbpotter authored
Unless the policy/pref for suppressing cloud print warnings is enabled, disable cloud print in Print Preview, as M88 Stable launch is expected to occur after December 2020, when cloud print is deprecated. Bug: 1144931 Change-Id: I5579d29be2fd122a15424362ec1d1184e8cce3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510741Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#824695}
-
Alexander Timin authored
At the moment CSP headers are stored in FrameTreeNode and reset when the document in the FTN changes. This patch: - Disables resetting CSP policies stored on RFH when it is restored from bfcache. - Copies the policies stored on RFH to FTN's replication state during bfcache restore. - Evicts the page from bfcache if it has frame policy headers. R=alexmos@chromium.org,arthursonzogni@chromium.org BUG=1146025 Change-Id: I486c9bf30670a21e631ec70f7efc2ed305c96e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519460 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824694}
-
Chan Li authored
web test runner/sink integration makes blink_web_tests on win builders slow issue (crbug.com/1141606) has been worked around - now blink_web_tests are handled be result_adapter. Bug: 1108016 Change-Id: I33ac36954db3ef54c4d99327508536b763129205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521847Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#824693}
-
Liquan (Max) Gu authored
Before: CPRService implements PaymentRequestUpdateEventListener. Changes: PRService takes over PaymentRequestUpdateEventListener, with the implementation unchanged. After: PRService implements PaymentRequestUpdateEventListener. Bug: 1146053 Change-Id: I339ab54de3b5a9138a5ccbbb1d870bec4d6f2c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518695 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824692}
-
Samuel Huang authored
Bug: 1040645 Change-Id: I5b53f8145f1d1d5c363995cef7653f882e7c351c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521052Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#824691}
-
Jeffrey Kardatzke authored
This implements slice header parsing and the rest of the overall decode flow. It does not handle POCs, DPB, ref pic lists, etc. yet, those will be added next. BUG=chromium:1141237,b:153111783 TEST=media_unittests Change-Id: Ib0173316ff8b25db9222d791e9dc8660ec282dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518132 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#824690}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3476ca348bd0..612ded0654a0 2020-11-05 srisser@google.com Merge changes I3c4f10f7,I5b7ddc75 2020-11-05 capn@google.com Fix Android.bp build after SPIRV-Tools update If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I61277cc4495a9e9af2f4af15015edd1b48dc9880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824689}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/56ea854ec5e7..d30f01144708 2020-11-05 lexa.knyazev@gmail.com Metal: Early loop exit during attachments clear 2020-11-05 syoussefi@chromium.org Vulkan: Defer clears even if following command is scissored If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Iedf09f5593ce22ea9c90ec8312ca0109d5e1430f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522359Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824688}
-
Liquan (Max) Gu authored
Changes: * Moved CPRService#mInvokedPaymentApp into PRService. * Refactored isInvokedInstrumentValidForPaymentMethodIdentifier() so as to be explicit about its dependency on mInvokedPaymentApp. Bug: 1144527 Change-Id: I605dc470b41dd191cd362986963022c0f39dbddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520097 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824687}
-
Tomasz Wiszkowski authored
This change introduces PageClassification for SearchActivity and brings back the SearchActivity suggestions. The unique ID allocated to Search Activity will help us clear up any inconsistencies in offered suggestions, address SA directly and eliminate the use of the INVALID_SPEC PageClassification (currently reported by SA). Bug: 1143557 Change-Id: I3f48074079a9046d7aea25af9f5f2dc1f84ba268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516970Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#824686}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7c8cb3b7066c2fb984c5011e526f30e2b5a20468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522351Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824685}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I016112d7c72fda76754d6f5805d2734a082ece65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522360Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824684}
-
Daniel Hosseinian authored
Collapsing the sidebar does not trigger the thumbnail bar's intersection observer. Therefore, toggling annotation mode does not cause the thumbnails to regenerate to reflect the updated PDF contents. Hide the thumbnails to trigger the intersection observer when annotation mode is turned on. Bug: 1136319 Change-Id: I778be1b28f76354a9186abc64d5e471b2ae6cb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460226 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#824683}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ac59b0e049f7..5689d6741bc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iead9447eca583213ba5627191be71e8168bf5ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521776Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824682}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d42713de7aa3..2b6b0f45ff05 2020-11-05 enrico.galli@intel.com Add support for Tint's HLSL writer as a Toggle 2020-11-05 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 77f7bb5b005d to 795bf4c71637 (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I19d761e101fd14c5993d49a6a89a6a99c80268de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522000Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824681}
-
Ilya Sherman authored
Weilun is sufficiently trained up for reviewing testing config changes. Will eventually remove this entry in favor of listing as a general metrics OWNER, but this is a stepping stone in the meantime. R=sweilun Bug: None Change-Id: If40902f38b8473b6a46eba6e08d2ed8088156838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522398 Auto-Submit: Ilya Sherman <isherman@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#824680}
-
Bettina Dea authored
Client side detection is currently enabled on Android but there was no check to prevent visual detection from being done and is causing crashes in PaintPreviewTracker on beta. Bug: 1146121 Change-Id: If37cd5abe52ebb25fa7fb7ae126cd934c6a74cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521353 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#824679}
-
Akira Baruah authored
Adds a function to CastMetricsServiceDelegate that Cast embedders can override to set platform-specific limits for local metrics storage. Also cleans up changes from https://crrev.com/c/2505741 to use `constexpr` and multiples of 1024 for default values for consistency. Bug: b/172356230 Test: metrics_unittests Test: cast_metrics_unittest Change-Id: Ib920e4438baf56dff64bcca3f9bcabca77fd354e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518833Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Akira Baruah <akirabaruah@google.com> Cr-Commit-Position: refs/heads/master@{#824678}
-
Taylor Bergquist authored
Adds a mechanism for skipping the opacity check to Label and applies it to the tab title label. Bug: 1139395 Change-Id: I1c182b735964856be971d59af1c28ab29011d99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518277 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#824677}
-
James Zern authored
with functions that can legitimately fail when under memory pressure the fuzzer should exit gracefully rather than abort(). + add some more error detail to output Bug: chromium:1140448 Change-Id: I1a8582a939e0a5b2b8631c95c0464658c99063e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521107Reviewed-by:
Urvang Joshi <urvang@chromium.org> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#824676}
-
Charlene Yan authored
http/tests/devtools/sources/debugger-ui/debugger-inline-values.js TBR=smcgruer@chromium.org Bug: 1146221 Change-Id: Ic09d947b0e8c2474cab3c0742cb5f19c211186cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522408Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824675}
-
Bailey Berro authored
This changes adds the CpuPrimeSearch Routine to the SystemRoutineController interface. Bug: 1128204 Change-Id: I281b8438227889cff8ed8439c715efc2827df6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466364 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#824674}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604555639-2f2f2fa36ecdca58ddc4d326e800aa99e915018c.profdata to chrome-win32-master-1604588329-6f5ba33f1a6962e1b0406a8222a4664471a1f39d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4d76d357005672bbd9c287fc667be06846514573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522150Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824673}
-
Collin Baker authored
The original GetSlotIndexForTabModelIndex served two purposes: getting the slot for an existing tab, and getting the insertion index for a new slot. This splits it into separate methods with common logic remaining in a shared method. The logic had a bug when requesting the first tab of a group while tabs just before it are animating closed. This bug is fixed. To help debug the associated crash, CHECKs are added. Bug: 1138748 Change-Id: I6e0d797bb70e9aa1da813dbf1fecf228290e55b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515363 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#824672}
-
Toni Barzic authored
AppUninstallDialog::InitializeCheckbox gets the app URL domain, and changes the first domain character to upper-case, assuming that the domain is non-empty. This may not be case if the app URL is an IP address. BUG=1084451 Change-Id: I5c43ff22fa3474a1c0ff0bcf79afd53de9beb26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521043Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#824671}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iab9bae069e1badd18d6a17d48ac921a564e3094f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522292Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824670}
-
Yicheng Li authored
When clicked, the help button will open a help article in a new browser window, so that it's on top of the dialog but the user can return to the dialog. Bug: b:156258540, b:144861739 Change-Id: I1ff8f49e9926ed57f27f2eaca307d5180d574091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518442 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824669}
-
Ilya Sherman authored
* Histograms measuring frequencies should typically include context via some baseline event as a comparison point. * Clean up the docs around directly measuring what you want and around naming. R=mpearson@chromium.org Bug: None Change-Id: Id6250c37a2ec499f38ae148bc1daa1a3c451a10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462373 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824668}
-
Tommy Martino authored
Greatly improves robustness of fragment generation Bug: 1136043 Change-Id: Ic424fc2548bc773c049e973c967d0152489ff765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521104 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#824667}
-
Sinan Sahin authored
Tbr: majidvp Bug: 1146218 Change-Id: Ieef5a89bc717ab4814c4ddbdba8cd11b47ba4df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522400Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#824666}
-
Peter Boström authored
Adds reference to chromium-chrome-browser-ui-views-reviews@google.com as a preference to individual reviewers. Bug: None Change-Id: I5bae9a9806315105ba389d651b78da303548cc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522495 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#824665}
-
Charlene Yan authored
Change-Id: I7cef19d51a8760ecf3ecf9c37b826adb94bc890d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522410 Auto-Submit: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#824664}
-
Erik Chen authored
This provides EMEA time-zone coverage for lacros/crosapi changes. Change-Id: Ie987fb3aec72aeb30d43ba09631c1fd84b42b93d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521870Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824663}
-
Chris Thompson authored
This changes the units from "seconds" to "ms", since the underlying histogram time functions log TimeDelta data in milliseconds. This doesn't affect the logged data, only how it displays on the dashboard, so we don' t need to create a new histogram for this and can just update the unit. Change-Id: I8df03c321e2c9f92aa0f47750715ab3e22ef234c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522331 Auto-Submit: Chris Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#824662}
-
Tom Anderson authored
This allows us to see which calls are blocking within the context of chrome://tracing. BUG=None R=sky Change-Id: I576657f4cba0f978c025202f0f10c7ac6bcc374c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522311 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#824661}
-