GitLab

BrowsingDataFilterBuilder is an abstract class that has a non-virtual
destructor. This is a mistake - since the class and its subclasses are
non-copyable, they're typically handled by pointers; calling delete on
such a pointer will only call the base class destructor, not those of
the subclasses, and thus leak any attributes of the subclasses.

This was spotted by ASan in the context of the CL implementing the task
scheduler for BrowsingDataRemover. When a task was finished processing,
its destructor did not correctly destroy the contained
BrowsingDataFilterBuilder.

BUG=630327

Review-Url: https://codereview.chromium.org/2185453004
Cr-Commit-Position: refs/heads/master@{#407765}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d07de081..99032331

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2180163003
Cr-Commit-Position: refs/heads/master@{#407764}

The benchmarks have corresponding PCv2 benchmarks running >2 weeks.

BUG=611329

Review-Url: https://codereview.chromium.org/2181223002
Cr-Commit-Position: refs/heads/master@{#407763}

The change made in r406557 caused a 12% regression on the grid layout
performance tests. The root cause is that as part of the changes
required to implement the orthogonal flows support we decided to use
physical directions to determine whether a grid item overflows its
grid area or not. Since we store the logical sizes in a HashMap, we
implemented some utility methods that, based on the grid container's
writing mode, retrieve the stored width or height from the HashMap.

Since the previous logic was reusing the already computed logical
value, the change introduced a considerable performance regression.

This patch address the issue by removing the utility methods and
determine the physical sizes directly inside the layout logic.

BUG=630448

Review-Url: https://codereview.chromium.org/2176633002
Cr-Commit-Position: refs/heads/master@{#407762}

BUG=616502

Committed: https://crrev.com/36986071183bdb219186aa9f63f9ee4b162d91b9
Review-Url: https://codereview.chromium.org/2181553003
Cr-Original-Commit-Position: refs/heads/master@{#407487}
Cr-Commit-Position: refs/heads/master@{#407761}

This patch converts "editing/pasteboard/merge-end-blockquote.html" to use w3c
test harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2181113003
Cr-Commit-Position: refs/heads/master@{#407760}

BUG=506059
TEST=build the unittest and run on Intel/ARM platform

Review-Url: https://codereview.chromium.org/2107133002
Cr-Commit-Position: refs/heads/master@{#407759}

Followup to https://codereview.chromium.org/2169063002

BUG=internal b/30003601
TBR=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2183613003
Cr-Commit-Position: refs/heads/master@{#407758}

See http://crbug.com/615908#c6 for a log from a flake.

BUG=615908
TBR=dtseng@chromium.org

Review-Url: https://codereview.chromium.org/2182973003
Cr-Commit-Position: refs/heads/master@{#407757}

Facebook fetches items on demand while scrolling. Before this patch
Nexus7v2 was timing out while waiting for items because the scroll
distance was not enough to trigger fetching of items.

This patch increases the scroll distance and updates WPR.

*** NOTE TO SHERRIF ***
Regressions are expected in browse:social:facebook story.

BUG=631022

Review-Url: https://codereview.chromium.org/2175383003
Cr-Commit-Position: refs/heads/master@{#407756}

Use identical glyph metrics based bounds in HarfBuzz callbacks as well
as ShapeResult's glyph bounds calculation, except on Mac, due to Skia
bug https://bugs.chromium.org/p/skia/issues/detail?id=5328

* Using the same glyph bounds callback in HarfBuzz shaping and in
  ShapeResult's glyph bounds calculation enables reusing of the same
  cache in Skia, as opposed to using the cached glyph metrics based
  cache vs. using a second cache for path based metrics before.

Local benchmarking of the blink_perf.layout shows 12.44%
improvements for the character_fallback test and 1.8-5%
improvements on chapter-reflow-once, line-layout and
latin-complex-test. There are also some hits on flexbox-lots of
data and flexbox-row-nowrap. I am not 100% convinced that the
local benchmarks are accurate enough and would like to observe
the results on the bot. Overall, we should see a layout speed
improvement, perhaps even in the page cyclers.

BUG=610313
R=kojii,tzik

Review-Url: https://codereview.chromium.org/1980913002
Cr-Commit-Position: refs/heads/master@{#407755}

To avoid constructor running multiple times on the same element[1],
a new "failed" custom element state[2] was added to the spec.

This patch:
1. Adds the CustomElementState::Failed.
2. Simplifies getCustomElementState().
3. Removes Element::isCustomElement() to match code conventions to the
   spec terminologies.

[1] https://github.com/w3c/webcomponents/issues/533
[2] https://dom.spec.whatwg.org/#concept-element-custom-element-state

BUG=594918

Review-Url: https://codereview.chromium.org/2173623003
Cr-Commit-Position: refs/heads/master@{#407754}

NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2185493002
Cr-Commit-Position: refs/heads/master@{#407753}

BUG=none

Review-Url: https://codereview.chromium.org/2169463003
Cr-Commit-Position: refs/heads/master@{#407752}

Rename and sort variables,
Extract function body to receive and return Position.

TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2180963005
Cr-Commit-Position: refs/heads/master@{#407751}

This reverts commit eb73fb7b.

The root cause of https://crbug.com/621730 was not related to the binding layer,
and https://crrev.com/2085983002 caused regressions as reported at
https://crbug.com/629840 , so let's revert the CL.

BUG=629840,621730

Review-Url: https://codereview.chromium.org/2177383004
Cr-Commit-Position: refs/heads/master@{#407750}

These 4 tests are often flaky since some bots have 'Yu Gothic'
while some don't. This patch avoids using 'Yu Gothic' in these tests.

Review-Url: https://codereview.chromium.org/2179383002
Cr-Commit-Position: refs/heads/master@{#407749}

This test is failing on Xcode 8 bot.

BUG=631049

Review-Url: https://codereview.chromium.org/2181693002
Cr-Commit-Position: refs/heads/master@{#407748}

BUG=611542
R=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2178813002
Cr-Commit-Position: refs/heads/master@{#407747}

Implemented KeyStorageLinux for KWallet.

BUG=602624

Review-Url: https://codereview.chromium.org/2150543002
Cr-Commit-Position: refs/heads/master@{#407746}

Revert of Disable A Few More AppBannerDataFetcherBrowserTest Failing Tests (patchset #1 id:1 of https://codereview.chromium.org/2183743002/ )

Reason for revert:
These test failures were caused by a bug in https://codereview.chromium.org/2181553003/  Re-enabling.

Original issue's description:
> Disable A Few More AppBannerDataFetcherBrowserTest Failing Tests
>
> I didn't see these failures in the original lists I checked.
>
> TBR=dominickn@chromium.org
>
> BUG=631190
>
> Committed: https://crrev.com/8945bfac334ff9b1ec226e158a1f29e3fdce5e0c
> Cr-Commit-Position: refs/heads/master@{#407707}

TBR=mpearson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=631190

Review-Url: https://codereview.chromium.org/2182973002
Cr-Commit-Position: refs/heads/master@{#407745}

This patch avoids integer-overflow when hb_glyph_position_t.y_advance is
LONG_MIN.

BUG=630227

Review-Url: https://codereview.chromium.org/2176053002
Cr-Commit-Position: refs/heads/master@{#407744}

Add a usecounter for an event listener which is registered for a slotchange event.

Review-Url: https://codereview.chromium.org/2179123003
Cr-Commit-Position: refs/heads/master@{#407743}

Its initialization is behind the BackgroundModeAllowRestart
flag, and is supported only on Windows and Linux

BUG=585080

Review-Url: https://codereview.chromium.org/1931503002
Cr-Commit-Position: refs/heads/master@{#407742}

This can be replaced by media::GpuVideoDecodeAcceleratorFactoryImpl, modulo
properly wiring GpuPreferences.

This in turns allows us to remove GpuChildThread::current() for great justice.

BUG=597150

Review-Url: https://codereview.chromium.org/2171473003
Cr-Commit-Position: refs/heads/master@{#407741}

std::to_string() is technically a number to string conversion function,
so clarify the wording to make it unambiguous.

BUG=none

Review-Url: https://codereview.chromium.org/2181573002
Cr-Commit-Position: refs/heads/master@{#407740}

This should be removed in https://codereview.chromium.org/242883002

BUG=357586,630141

Review-Url: https://codereview.chromium.org/2181263002
Cr-Commit-Position: refs/heads/master@{#407739}

Both of Firefox and Edge shows OPTIONs filtered by substring matching.  We
follow them.

It seems that Firefox shows OPTIONs with matched labels, and Edge shows OPTIONs
with matches values. We show OPTIONs with matched labels or values.

BUG=153991

Review-Url: https://codereview.chromium.org/2183773003
Cr-Commit-Position: refs/heads/master@{#407738}

Fix build when dSYM generation is enabled and output is a thin binary
by correctly informing gn and ninja of the location where the .dSYM
file is generated.

When defining "dsym_switch" in the toolchain definition, the value of
root_out_dir is not yet known (it is only known later when we know if
the toolchain is the default toolchain or not), so use {{root_out_dir}}
to lazily perform the expansion when the information is known.

When determining whether dSYM generation is enabled in the toolchain
definition, look at "toochain_os" instead of "is_ios" as "is_ios" is
defined based on target_os (i.e. is incorrect in the toolchain).

Use output_dir/output_name instead of using rebase_path() to generate
an output name containing directory information because 1. this is a
hack that output_dir was introduced to fix, 2. link tool and ninja do
not agree about the location of the .dSYM file.

BUG=630901

Review-Url: https://codereview.chromium.org/2174373002
Cr-Commit-Position: refs/heads/master@{#407737}

This patch fills in ResizeObservation functionality:
- computing/setting observation size
- determining target depth

ResizeObservation::getTargetSize is static because it will also
get used by ResizeObserverEntry

I've also included basic C++ tests.

BUG=612962

Review-Url: https://codereview.chromium.org/2173203002
Cr-Commit-Position: refs/heads/master@{#407736}

This patch converts "editing/pasteboard/8145-[1-3].html" to use w3c
test harness and consolidates into "insert_html_as_plain_text.html" to simplify
test case for ease of maintenance.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2179373002
Cr-Commit-Position: refs/heads/master@{#407735}

WebsiteSettingsUI::SetPermissionInfo doc says 'The callee is expected to take
ownership of the objects in |chosen_object_info_list|.'
Android implementations don't do anything with |chosen_object_info_list|, so
memory leaks are possible.

R=yfriedman@chromium.org
BUG=424667

Review-Url: https://codereview.chromium.org/2173773003
Cr-Commit-Position: refs/heads/master@{#407734}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/61e64edd..d07de081

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2180123002
Cr-Commit-Position: refs/heads/master@{#407733}

This patch converts "editing/inserting/typing-00[1-3].html" to use w3c
test harness and consolidates into "typing.html" to simplify test case
for ease of maintenance.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2184503003
Cr-Commit-Position: refs/heads/master@{#407732}

This patch converts "editing/typing-around-br-001.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2184603002
Cr-Commit-Position: refs/heads/master@{#407731}

TBR=kinuko, clamy
BUG=631322, 631323
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2179353002
Cr-Commit-Position: refs/heads/master@{#407730}

Cr-Commit-Position: refs/heads/master@{#407729}

Since ImageDecoder allows the same ImageRequest to be reused,
ArcWallpaperHandler can implement ImageRequest. We just need to
call ImageDecoder::Cancel() as needed (e.g. on destruction).

BUG=None
TEST=Tested setting wallpaper manually with ARC enabled device.

Review-Url: https://codereview.chromium.org/2175213002
Cr-Commit-Position: refs/heads/master@{#407728}

BUG=598902, 629735, 628496
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2174353003
Cr-Commit-Position: refs/heads/master@{#407727}

The vector of delegates_ was previously being walked on the FILE
thread. This could lead to a crash if a new delegate were to be added on
the UI thread. Now, the driver bounces back to the UI thread to send
progress updates to the delegates.

Also changes the use of scoped_refptr to be up-to-date with current
style.

BUG=none
R=pmonette@chromium.org

Review-Url: https://codereview.chromium.org/2176123002
Cr-Commit-Position: refs/heads/master@{#407726}