- 09 Mar, 2018 40 commits
-
-
Vasilii Sukhanov authored
The code is executed once per profile. As it was introduced one year ago, it's reasonable to assume that most users don't need it anymore. It's a manual revert of https://codereview.chromium.org/2714543006/ Bug: 687968 Change-Id: Ic9ef109c27ccccadc8b3fd75d156dec818cfc83c Reviewed-on: https://chromium-review.googlesource.com/955568 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#542084}
-
Takashi Toyoshima authored
Since it looks working fine on local machines, and related code base may be changed day by day for loading and PlzNavigate efforts, let me just re-enable the test to see what happens. Bug: 798121 Change-Id: I07e88b163818019ec340b3aff508191852b7d440 TBR: maxmorin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/956830Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#542083}
-
Sylvain Defresne authored
The method is no longer called nor overridden, so it can safely be removed (it was deprecated). Bug: none Change-Id: I31770bfd26e33977a4007ae50cf423196c914ebe Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/951692 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#542082}
-
Gauthier Ambard authored
This CL changes the toolbar button used to access the stack view. The button used for the clean toolbar as some specific effects which don't work on the non-adaptive toolbar. Bug: 820096 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If0bdc61050eebd1d4cb3d5230aa828444076649c Reviewed-on: https://chromium-review.googlesource.com/955573Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#542081}
-
Morten Stenshorne authored
That might cause incorrect detection of overflow, since the height of the block isn't pixel-snapped. Bug: 818873 Change-Id: I864be9dfedf6f008fe19ce02088ac6488ec274d0 Reviewed-on: https://chromium-review.googlesource.com/954022Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#542080}
-
Thomas Tangl authored
This CL changes the run type in DiceAccountsMenu to use a native menu on Mac and removes the definition of the run type ALWAYS_VIEWS as it is not used anymore. Bug: 813805 Change-Id: Ia97cba48de31bf4ed74b71982cfe8e3383a909eb Reviewed-on: https://chromium-review.googlesource.com/956463Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#542079}
-
Ulan Degenbaev authored
The heap snapshot now uses the EmbedderGraph API. Bug: 749490 Change-Id: I9d18bdf623d8b2dd9ddee8799c61b08787592445 Reviewed-on: https://chromium-review.googlesource.com/948486 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#542078}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 894211b4. With Chromium commits locally applied on WPT: 14350ac7 "[PE] Don't truncate table cell's padding" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13494 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams kojii@chromium.org: external/wpt/css/css-writing-modes TBR=qyearsley No-Export: true Change-Id: I703e0430b99222ba33803d24ad68ef87ef2477cb Reviewed-on: https://chromium-review.googlesource.com/956568 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542077}
-
https://skia.googlesource.com/skia.git/+log/dc0b12ec7a2d..66abdf665896 $ git log dc0b12ec7..66abdf665 --date=short --no-merges --format='%ad %ae %s' 2018-03-09 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 80964f97e..e8a93c6ed (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I2956d1cbd79079d6194538f78f4b87441e32e2a9 Reviewed-on: https://chromium-review.googlesource.com/955972Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542076}
-
Fredrik Söderquist authored
In preparation for adding an SVGResource subclass for external resources this splits out a LocalSVGResource subclass from SVGResource and renames usages appropriately. This is mostly to eliminate "noise" from a follow- up CL. Bug: 769774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I479ca0445e4eba5f0ba2b727460dfcda776347b8 Reviewed-on: https://chromium-review.googlesource.com/955463Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#542075}
-
Giovanni Ortuño Urquidi authored
Before this patch, tests were using the default EmbeddedTestServer, which only served HTTP pages. Desktop PWAs can only be HTTPS so tests should use HTTPS sites. Furthermore, Desktop PWAs will soon block mixed content, so test pages need to be served over HTTPS. Change-Id: I4af6850bdd851917fdeb2bf9d55fa62b6d3beff7 Reviewed-on: https://chromium-review.googlesource.com/926022 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#542074}
-
Zhuoyu Qian authored
This CL introduces canExecute() member function in |EditorInternalCommand| to replace |allowExecutionWhenDisabled|. |allowExecutionWhenDisabled| is for clipboard commands only. This CL is first step of [1], next step will replace CanExecuteWhenDisabled() with Can{Read/Write}Clipboard(). [1]: http://crrev.com/c/954773 Bug: Signed-off-by:Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I696409a1496e6c3fc2b325879ec07c1932f062b0 Reviewed-on: https://chromium-review.googlesource.com/954562Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542073}
-
Jose Dapena Paz authored
Bug: 819294 Change-Id: I8b7c0cc30161332e396a0a4ac142188cb5cf1ad1 Reviewed-on: https://chromium-review.googlesource.com/944411Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#542072}
-
tzik authored
This updates //printing to use base::OnceCallback instead of legacy base::Callback. No intended functional change is included. This reduces the number of 'base::Bind' in //printing from 2 to 0 as tracked at http://goo.gl/LUVhDj Bug: 714018 Change-Id: Ic5ba394447c20b444d238511473bbfc7abbc9669 Reviewed-on: https://chromium-review.googlesource.com/954883Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#542071}
-
Tetsui Ohkubo authored
According to UX spec, UnifiedSystemTray has a circular user avatar in the top shortcuts view. FYI, in UnifiedSystemTray, the features in UserView and TilesDefaultView (in old SystemTray) are combined into TopShortcutsView. Screenshot: http://screen/WB4k9Oinwde Design doc: go/cros-qs-restyling BUG=811660 Change-Id: I118162e0d202f040a586e256fa37747fbfb5a0c7 Reviewed-on: https://chromium-review.googlesource.com/942503 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#542070}
-
Gauthier Ambard authored
This CL changes the way the layout guides of the toolbar's buttons are constrained to the button, using the new API. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I132991628ce923ca9352b34d7631bd78d3e7dae5 Reviewed-on: https://chromium-review.googlesource.com/955203Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#542069}
-
Xiaohan Wang authored
Bug: 801245 TBR: dalecurtis@chromium.org Change-Id: I05658d14ca57daf24b012f047c3d3df13c3037a7 Reviewed-on: https://chromium-review.googlesource.com/954336 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#542068}
-
Tetsui Ohkubo authored
This CL adds a feature pod button for Bluetooth. By clicking on the button, it will show bluetooth detailed view of the existing SystemTray. This behavior is described as Development Stage 1 in the design doc: go/cros-qs-restyling TEST=manual BUG=813499 Change-Id: I130301b9a25d31a520b1a0bb8f78839aa4b91b73 Reviewed-on: https://chromium-review.googlesource.com/948164 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Kent Tamura authored
Bug: 770603 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6cb03bc3e58a38070def0fb8e927e2d7036484b5 Reviewed-on: https://chromium-review.googlesource.com/956792Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#542066}
-
Max Morin authored
This reverts commit a7c1c185. Reason for revert: Clusterfuzz reports... Original change's description: > Fix yet another AudioOutputDevice crash. > > Bug is identical to the last :/. No idea why it's much more frequent with mojo, > possibly a race is likely to happen when destroying a frame: |callback_| is > destroyed due to frame being destroyed, and authorization is failed for the > same reason. With the per process message filter, authorization wouldn't fail > due to the frame being destructed. > > Bug: 819277 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ic17dc96d2c83a08732b43094bac2f2c3fa7035ad > Reviewed-on: https://chromium-review.googlesource.com/951774 > Commit-Queue: Max Morin <maxmorin@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541801} TBR=dalecurtis@chromium.org,maxmorin@chromium.org Change-Id: I9bf3d357bd09ebd1fa60b4324d204da44b23b72a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819277,820276,820341 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/957042Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542065}
-
arthursonzogni authored
The two tests following tests are potentially flaky: * WebViewTests/WebViewTest.Shim_TestNestedSubframes/* * WebViewTests/WebViewTest.Shim_TestNestedCrossOriginSubframes/* Why are they flaky? webview.onloadstop event handler is defined. Once called, it causes a new navigation to happens in the webview. The navigation causes the handler to be called again. This is a loop. It wasn't expected to behave that way. If the nested iframe navigation happens quickly enough, the two time nested iframe navigation might not complete quickly enough and the postMessage() may not happens. The race condition may be unfavourable several time in a row and causes a test timeout. FYI: 1) This test was disabled on Mac. Maybe this CL fixes the issue? It should be verified on a device with this OS. 2) This test is flakier after enabling NavigationMojoResponse and applying this CL: https://chromium-review.googlesource.com/c/chromium/src/+/951243/6 That's understandable, this patch allows navigation to commit faster. Bug: 674904, 705744 Change-Id: Icf2debd095519221ff085cb3bacbc058c1806e86 Reviewed-on: https://chromium-review.googlesource.com/955585Reviewed-by:Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#542064}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 770603 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I627aa5218ad008854012831ec49e484dfdf72920 Reviewed-on: https://chromium-review.googlesource.com/956902Reviewed-by:
-
Oleh Prypin authored
Instead build just the targets in chromium.webrtc. Bonus: remove obsolete tryjob definitions. Bug: chromium:820041, chromium:808111 TBR: machenbach@chromium.org No-Try: True Change-Id: I133593a4e51a5e1dac4d0e24d21601cd553784a0 Reviewed-on: https://chromium-review.googlesource.com/956043Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542062}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Idb76e054c5689db7fb83ee4c308f30e5b6eae136 Reviewed-on: https://chromium-review.googlesource.com/956963 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542061}
-
Emily Hanley authored
Also updating what tests run on each shard to help debug the failing tests. Bug: 758632 Change-Id: Ib0eb60f0b9ae7e3a2cd19ae8c1f8183d4d0b7d81 Reviewed-on: https://chromium-review.googlesource.com/955676Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#542060}
-
Chih-Yu Huang authored
Originally, VEA calls the flush callback before notifying the client that the last frame buffer is ready. This CL changed the calling order to ensure all frames buffer are sent back to the client before VEA notifies the flush is completed. BUG=b:71882314 TEST=run video_encode_accelerator_unittest at device Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I235411734dff3200df3b36b1f14211fbd0d41c8f Reviewed-on: https://chromium-review.googlesource.com/956653Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542059}
-
Tatsuhisa Yamaguchi authored
Bug: 795167 Change-Id: I4223e26d23885c350337aefb8abd991427435a05 Reviewed-on: https://chromium-review.googlesource.com/828184 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#542058}
-
https://webrtc.googlesource.com/src.git/+log/8493594dc2ae..6d72c3258ff5 $ git log 8493594dc..6d72c3258 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia922556cc0419a6011b0f9fb6d2927fa38fb3101 Reviewed-on: https://chromium-review.googlesource.com/956926 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542057}
-
Emily Hanley authored
Bug: 758632 Change-Id: I33c62a8c7ce7d8afd47021dc9833bf739dd26696 Reviewed-on: https://chromium-review.googlesource.com/956089Reviewed-by:
-
Wenzhao Zang authored
There's a delay in making local state available in //ash, so we previously created |OnReadyToSetWallpaper| to notify //chrome when it's ready. However, we do not have the mechanism to prevent early ShowUserWallpaper requests. The correct behavior should be to directly ignore it, otherwise it automatically falls back to a default wallpaper as the bug shows. This problem only exists for browser restart, but not login. Because the ShowUserWallpaper requested from login is very late due to web-ui initialization. Bug: 820196 Change-Id: Ie05235b5966b14ea80a7e83aca98f8b7147cc9b7 Reviewed-on: https://chromium-review.googlesource.com/956350Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542055}
-
Oksana Zhuravlova authored
This changes adds a new target to the mojom template which depends on the parse target and is a dependency for all generation targets. A new action has been added to the mojom_bindings_generator.py script that compares the list of sources for all dependencies of a given mojom file target to the list of imports in this file. If missing dependencies are found, they are printed and the script exits with an error. This changes also fixes missing dependencies and not fully-qualified import statements. Dependency check has been disabled for //content/common:mojo_bindings and //content/public/common/interfaces since it caused multiple definitions linker errors on Windows (they have both direct and indirect dependencies on specific targets). Bug: 753219 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I64613ad14af41f1fc2a77b81ac76507e26f9dfcc Reviewed-on: https://chromium-review.googlesource.com/947384 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#542054}
-
Ned Nguyen authored
Bug:805552 Change-Id: Ifd631d785f309d9f46b401daaec44d0cf89a8631 Pinpoint tryjobs: Android: https://pinpoint-dot-chromeperf.appspot.com/job/14c63ffa440000 Linux: https://pinpoint-dot-chromeperf.appspot.com/job/10787612440000 Mac: https://pinpoint-dot-chromeperf.appspot.com/job/1499113a440000 Win: https://pinpoint-dot-chromeperf.appspot.com/job/1381251a440000 Change-Id: Ifd631d785f309d9f46b401daaec44d0cf89a8631 Reviewed-on: https://chromium-review.googlesource.com/956203 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#542053}
-
Zhuoyu Qian authored
This Cl introduces "ClipboardCommands.h", move the declarations of some static functions related to clipboard to the header file. Make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by:
-
Trent Apted authored
Move all layout to Layout() so that it updates correctly when the browser window is resized with the results dropdown open. Bug: 801583 Change-Id: I7b931ff3d3b8623e5a01b4543b441767845818ac Reviewed-on: https://chromium-review.googlesource.com/942562 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#542051}
-
Wez authored
Platform-specific IPC::Channel implementations included Chrome IPC message logging, but this was not carried into the Mojo-based Channel implementation. Chrome IPC message logging is higher-level than Mojo IPC message logs, which can be useful for certain kinds of diagnosis. Bug: 816620 Change-Id: I467857fd07b66c3d468039d6fb7c2950f931c8bb Reviewed-on: https://chromium-review.googlesource.com/956347Reviewed-by:
-
Robert Liao authored
ExtensionView::DidStopLoading() collided with content::WebContentsObserver::DidStopLoading(). BUG=818397 TBR=rdevlin.cronin@chromium.org Method rename. Change-Id: I15ea2074f7c430429d2538ef19c858cb74f549b3 Reviewed-on: https://chromium-review.googlesource.com/954065 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#542049}
-
Han Leon authored
This prototype is 'assert_equals(actual, expected, description)', we should pass 'actual' and 'expected' in order, to make the failure message be reasonable. This CL just fixes external/wpt/service-workers/service-worker/navigate-window.https.html. BUG= Change-Id: Ic11ec67f27f7a9a5ae289ddda4362af72b4737d4 Reviewed-on: https://chromium-review.googlesource.com/955282 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#542048}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/595b66866726..e0f4e29651e2 $ git log 595b66866..e0f4e2965 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibad7f06f6c5fcca4823f9497eefaabefe107bdb3 Reviewed-on: https://chromium-review.googlesource.com/956746Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542047}
-
Dale Curtis authored
Per discussion on the CL below [1], we want to move decrypting decoder creation to the standard renderer factory. To do this we need to provide the WaitingForDecryptionKeyCB to the decoders at time of Initialize() to avoid duplicate callbacks for the same functionality. This has the side effect of providing the wait for key CB in new places that should eventually make use of it (Mojo, Gpu decoder). [1]: https://chromium-review.googlesource.com/c/chromium/src/+/952207 BUG=801245 TEST=no functional changes, so builds and tests pass. TBR=bbudge Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4e6c9dc6344a798ab9a9b374acc8aff67d9dd4d1 Reviewed-on: https://chromium-review.googlesource.com/956344 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542046}
-
Josh Pratt authored
Refactor LocationBarView to move Refresh logic for some BubbleIconViews into the respective subclasses. This is initial work for adding BubbleIconViews to Chrome OS Desktop PWAs. It partially decouples BubbleIconViews from the LocationBarView so that they can also be used in HostedAppButtonContainer. Bug: 788051 Change-Id: I986951b64fb02f2d2728abbe6a3964ff97e04909 Reviewed-on: https://chromium-review.googlesource.com/923607 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#542045}
-
