- 12 Apr, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4877ef358434..6c85037d35b5 git log 4877ef358434..6c85037d35b5 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 jmadill@chromium.org Move ANGLE CQ to linux-angle-rel and mac-angle-rel. Created with: gclient setdep -r src/third_party/angle@6c85037d35b5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:822310 TBR=ynovikov@chromium.org Change-Id: Ib91cf9b609ce0b130864ab220bf1d4dd08151b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566273Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650430}
-
Gayane Petrosyan authored
Before fix, normal font size https://screenshot.googleplex.com/zkBbPrdicmG.png Before fix, large font size https://screenshot.googleplex.com/75ZKUz1CBnV.png After fix, normal font size https://screenshot.googleplex.com/UcrSRs3moZr.png After fix, large font size https://screenshot.googleplex.com/9dwWd58nDBJ.png Bug: 952165 Change-Id: Ief8a5aa5266cbd85661bd55bf94df2c2ca715a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566210Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#650429}
-
Yining Wang authored
Follow up on refactor hosted_app_browser_controller, which creates a base class (web_app_browser_controller) for it. IsForExperimentalHostedAppBrowser is checking if the PWA UI is enabled, and it could be moved to the base class. So we rename it to IsForExperimentalWebAppBrowser and move it to WebAppBrowserController class. Change-Id: Ic4e74f7abd5bfd9deff927ebd8670424706cec9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562623 Commit-Queue: Yining Wang <yiningwang@google.com> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#650428}
-
Andrew Grieve authored
Test apks are allowed to reference resources that live in the apk_under_test. We've previous supported such references via R.java constants, but this CL also adds the ability for resources in the test apk to directly reference resources in the apk_under_test (e.g. via xml @references). The need for this has come with the latest version of the support library. To accomplish this: 1. Adds a "-I UnderTest.ap_" flag when compiling test apks resources 2. Sets the test apk's arsc package name to match the apk_under_test's package name. 3. Uses --emit-ids / --stable-ids to avoid collisions between the test apk and the apk_under_test. 4. Updates incremental install manifest logic to do the same trick. Some other small tweaks to related resource code: * Removes incremental AndroidManifest.xml as an explicit build output * Moves most uses of "aapt dump" to "aapt2 dump" * Removes --check-resources-pkg-id in favor of always enabling it * Removes --optimize-resources in favor of having it implicitly set by --optimized-resources-path Bug: 896775 Change-Id: I6ea2d1ec8d1109bede4e0701eb4c7aeaa2a67503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556395 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#650427}
-
Daniel Cheng authored
Miscellaneous cleanups: - convert to a scoped enum, which reviews some additional static_casts to read/write from a bitfield - explicitly make the enum's underlying type unsigned to match the type of the bitfield - use a switch instead of an if to make it harder to forget to update IsValidPropertyInScope Bug: 842296 Change-Id: I7a6c968e7d16668d0cfbb6897d2ddfb3e7c70a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565713 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#650426}
-
Jamie Madill authored
Were missed from a couple places in luci-milo.cfg. Bug: 822310 Tbr: jbudorick@chromium.org Change-Id: I3bc20f71e6fa5ea378c6b476e10c2ea83429aa56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566116Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#650425}
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from classes in //third_party/blink/renderer/core/svg. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ia014282bded24ac105c29994973bfa85fc597576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564155 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#650424}
-
Martin Kreichgauer authored
Update description and title of UI dialog sheets for attestation permission and missing UV capabilities Bug: 870892 Change-Id: I2d96b16a89117e053f5b69ee610fd9d07b42a5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565308 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#650423}
-
Shakti Sahu authored
Fixed the padding between tabs and chips to 16dp. Bug: 951820 Change-Id: I0979d34275d037819cfefdafc4da0a66f2f11f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564904Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#650422}
-
Wez authored
Some tests comprise a package containing the test executable & resources and one or more additional packages containing the code-under-test, e.g. the web_runner_integration_tests suite has web_engine listed in its |package_deps|. The symbolizer tool supports multiple sources of debug information, so the SymbolizerFilter() wrapper is updated to support multiple build-ids files, and RunPackage() updated to make use of that capability. Bug: 772252 Change-Id: I88a499aa5fa5f6f82daeffa277409648efb4c5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565564 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#650421}
-
Chris Morin authored
List of changes: * restructure FeedbackPrivateDelegate to have a more generic interface * remove unecessary use of unique_ptrs * change instances of RepeatingCallback to OnceCallback * factor common DebugDaemonLogSource callback functionality into one callback * use move semantics to avoid large string copies BUG=None TEST=Ensure feedback report upload works Change-Id: I5b33ab60c727e2a92a08a463e9ad874e5e72b3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560516Reviewed-by:
Chris Morin <cmtm@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Chris Morin <cmtm@chromium.org> Cr-Commit-Position: refs/heads/master@{#650420}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0e3c24a3fc92..81880ac0f676 git log 0e3c24a3fc92..81880ac0f676 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 primiano@google.com Merge "traced_probes: Respect all wildcard groups" Created with: gclient setdep -r src/third_party/perfetto@81880ac0f676 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If031eb32c9e267c87994d28f1c9a05f7ca2a6857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566135Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650419}
-
Ben Joyce authored
Jacoco is a Code Coverage library for Java code coverage. Bug: 843307 Change-Id: If244800c266b6b3c5e72493972dd0e2285e4f268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531464Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#650418}
-
Scott Violet authored
ClientRoot was using floor, which doesn't match that used by the client (ceiling). This converts the two to use the same function (ceiling). BUG=952095 TEST=covered by test Change-Id: Ia0f78c63ace3987f2182adaf9783bd69ccc9171c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566157 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#650417}
-
Dominik Röttsches authored
Previously, the font lookup table was rebuilt on every Chrome product version change. This means it is rebuilt too often for Canary. Change the hashing computation to only include major version. Also, add UMA metric for recording the overall time it takes to have the font lookup table ready, independent of whether it is loaded from cache or re-built by scanning fonts. Update font lookup table specific metrics to stay until M78. Bug: 889864 Change-Id: Id4c9bc1f7d634e45b0646f3a28e7052aac56c9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565324Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#650416}
-
Matt Menke authored
Previously, HttpStreamFactory::Job::OnSpdySessionAvailable() called directly into HttpStreamFactoryJobController(), instead of sharing code with the other path (which can already handle reused SPDY sessions, in some cases). This allowed passing in some state for the received SPDY stream which arean't available otherwise. However, these values *also* aren't available in the case SpdySessionPool::FindAvailableSession() returns a stale session, so they aren't actually needed. This CL also no longer sets was_alpn_negotiated_ or negotiated_protocol_ in the OnSpdySessionAvailable() case, as they aren't set in the FindAvailableSession() case, either, and the SpdySessionPool does not know the values these fields should have. Bug: 912727 Change-Id: Ie6e2b97c1f824c34a61c01d9bb86e44fae6f7074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551902 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#650415}
-
Oleh Lamzin authored
Declare DeviceBatteryChargeMode, DeviceBatteryChargeCustomStartCharging, DeviceBatteryChargeCustomStopCharging device policies. DeviceBatteryCharge* policies dynamically control battery charging to minimize battery wear-out due to battery stress and extend battery life. BUG=b:127456312 TEST=unit_tests/browser_tests Change-Id: I7818d19a476576aac7b3251bc0a543e6928473a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525940 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#650414}
-
Sean Kau authored
zentaro@ is leading the team working on the printer setup experience. It will help if they can approve some of their own CLs Bug: None Change-Id: I500385fe2f8966ce6566b4d223f74ab27e46e55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564547Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#650413}
-
Theresa authored
Use a hairline border with inset so that the thumbnail is placed inside the card border (instead of on top of it) when the Feed UI is enabled. BUG=951074 Change-Id: Ie9ba70cce11c8ed72b91b9f1ccc483e82772d2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565181Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#650412}
-
Nancy Li authored
Gets and displays string descriptor in both tree view and byte view. Adds a button near to the string descriptor index fields to get the string descriptor of this field. And adds input element and button to end of page for querying string descriptor manually. Bug: 928923 Change-Id: Ib4f7be251fcb9532e75b1adf9a31d37b22cb5029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534629 Commit-Queue: Nancy Li <nancyly@google.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#650411}
-
Becca Hughes authored
Add about flags entry for the media session notifications on Chrome OS and another for the ARC blocking feature. BUG=897836 Change-Id: Ia2faeabae8f31438b984656871a9e4c3b72767d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555240 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#650410}
-
Jamie Madill authored
This removes mac_angle_rel_ng and linux_angle_rel_ng from various config files. These configs are replaced with mac-angle-rel and linux-angle-rel. Bug: 822310 Tbr: jbudorick@chromium.org Change-Id: Id533c874106947517cfd93fb5bcbc92e2b31c4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565246 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#650409}
-
Devlin Cronin authored
Add some basic unit tests for parsing all extension action types ("browser_action", "page_action", and "action") in the manifest. Bug: 893373 Change-Id: I8484377858ca5c837eb649a16c473ed0f0f91140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562615 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#650408}
-
Scott Violet authored
Calling SetProperty() with the same value notifies the server. Some properties we change quite often, even to the existing value. There is no reason to notify the server in this case as it results in unnecessary messages. I originally wanted to early out in SetPropertyInternal(), and not notify observers as well, but it turns out there is some code relying on current behavior. I filed a bug on that. BUG=951015 TEST=covered by test Change-Id: I36f33976ba044afe872347314dc44305b7a224a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565505Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#650407}
-
Matt Menke authored
Previously, the HttpStreamFactoryJob would tell the HttpStreamFactoryJobController to have the SpdySessionPool to inform the HttpStreamRequest when an appropriate SpdySession was created. When that happened, the HttpStreamRequest would then pass the resulting stream to the JobController, which would then destroy the original job. This CL simplifies that by having the Job watch the SpdySessionPool directly, though it still informs the JobController when it gets the SpdySession, and the JobController then immediately deletes the Job. Bug: 912727 Change-Id: I9585f037e2028159a24064111d670faddfe2bdba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551562 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#650406}
-
Yann Dago authored
Visual: http://screen/f95xLi88ybU Bug: 951066 Change-Id: I31ddebbd8b41a291b668b24c47cc4a1e9db33c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558686Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#650405}
-
Guohui Deng authored
ApplicationSessionIdManager must be extended to provide more media related information associated with application. Therefore replace it with ApplicationMediaInfoManager. No behavior change. Bug: internal b/110233576 Test: Manual cast and Internal CQ. Change-Id: I0b8a37f000d55933f740ca737ca1f88f21db5cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555355 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#650404}
-
Matt Menke authored
Instead of taking an HttpStreamRequest, SpdySessionPool::AddRequestToSpdySessionRequestMap() now takes a new delegate interface. It returns an object that can be deleted to cancel the request, instead of taking the HttpStreamRequest against to cancel. Instead of relying on the HttpStreamRequest to track what SpdySessionKey is being watched, the SpdySessionPool now handles that itself. Finally, the new delegate interface takes the SpdySession itself when a matching SpdySession is creating, and then makes the appropriate stream type on top of it, instead of requiring the SpdySessionPool to make a stream of the correct type. The new behavior more closely matches the common case where HttpStreamFactory::Job makes the streams. Bug: 912727 Change-Id: Icb1138e2f7438459019e9ed6f04e38aecf408c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549900 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#650403}
-
Paul Irish authored
Bug: 915945 Change-Id: I0301216c32a1792a7a23af49f530bd937137439b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566211 Auto-Submit: Paul Irish <paulirish@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#650402}
-
Mugdha Lakhani authored
This uses the discrete engagement level to potentially increase the interval between two periodic sync events. If the engagement with the site has fallen to zero/none, the registration is suspended. If it's more than that, the penalty is inversely proportional to the engagement score. The site engagement levels are set through Finch. The default values are: (code: https://cs.chromium.org/chromium/src/chrome/browser/engagement/ site_engagement_score.cc?rcl=9bb60bfa&l=85) MEDIUM_ENGAGEMENT_BOUNDARY = 15; HIGH_ENGAGEMENT_BOUNDARY = 50; According to this + logic in code, then, (Score is non-negative) Score == 0.0 --> NONE Score < 1.0 --> MINIMAL Score < 15.0 --> LOW 15.0 < Score < 50.0 --> MEDIUM 50.0 <= Score < 100 --> HIGH Else --> MAX. Bug: 925297 Change-Id: I64ca103722e7b6bdef4d9a7a0952d5edeb0cb0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546094 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#650401}
-
Donn Denman authored
Updates some of the Contextual Searchcolors for Dark Mode. Changes: 1) Divider line separator on the right side of the Bar gets it's own color setting. 2) Progress Bar background needs to be drawn with a Dark-compatible color. 3) Theres a few lines above the promo that were not covered by anything, now we're piping through the promo background color so we can fill that. BUG=942638 Change-Id: I1a224ed9a86bcea9b68b6dfd6d8e0135c1b39843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553903 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#650400}
-
Erik Chen authored
This reverts commit 8eec7f4c. Reason for revert: Rolling back change, as I don't intend to follow through with the remaining config changes, and I don't want to leave the iOS configs in a half-migrated state. Original change's description: > Remove custom iOS logic from mb. > > The public ios master/builders now have appropriate entries in mb_config.pyl > > Bug: 951182 > Change-Id: I500a3c00d47b7d5652654d14be2090c59214ed6f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561846 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649914} TBR=dpranke@chromium.org,erikchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 951182 Change-Id: I816efd0db4d13c8003af496d146483610c6c688a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566230Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#650399}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ef3496095d1d..249b32178539 git log ef3496095d1d..249b32178539 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5d453e25..f1e8910d (650211:650313) 2019-04-12 jeroendb@webrtc.org Revert "Make negotiationneeded processing in PeerConnection spec compliant." Created with: gclient setdep -r src/third_party/webrtc@249b32178539 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:740501 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6f3237a9f8cbfa2b8ad04d2f45d0ef8416958866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650398}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9a9b83751995..0c227e21d110 git log 9a9b83751995..0c227e21d110 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 yunchao.he@intel.com baseVertex in drawIndexed() should be int32, not uint32 2019-04-11 yunchao.he@intel.com Implement rasterization state for render pipeline - Part 1 2019-04-11 cwallez@chromium.org PushConstantsTest: Don't use additive blending Created with: gclient setdep -r src/third_party/dawn@0c227e21d110 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@chromium.org Change-Id: Id8238be449e53cf3114c61b93f49170c8c43dd76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566133Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650397}
-
Robert Ma authored
Follow-up to https://crrev.com/c/1555413 Change-Id: I34e094eca9a1795d069d93ba58e97349896b3c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565186Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#650396}
-
Jared Saul authored
Bug: 920385 Change-Id: I59c7a8230cbcc632b1c2725e24f6cd082f84deb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566092 Auto-Submit: Jared Saul <jsaul@google.com> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#650395}
-
Dan Beam authored
Global: * change all font-size: ##px to rem to scale to font size changes Headers: * remove useless h1 styles cuz there were no h1s * change h2 to h1 for a11y purposes, change h2 -> h1 styles * remove fluffy top margin from title (stale h1 code did this) Toolbar: * drop badly working --toolbar-height in favor of defined px value (based on height of #header in x-small and x-large font sizes) * change margin -> padding for taking up header space Search: * fix magnifying glass icon color with /dark/ path * fix (X) clear search icon with -webkit-mask Media queries/mobile: * remove stale media query for top padding for smallish screens * make warning 1 line (block + bottom margin) on smallish screens * make version number look better for smallish screens * remove stale media query for top padding for really short screens Promos: * remove bottom padding from #promos * make .promo -> #promos (cuz it's a 1 instance class...) * hide #promos when both dev/beta promos aren't showing (extra space) * start #promos as hidden to avoid flicker R=dpapad@chromium.org Bug: 951284 Change-Id: Idc12db3afbcfb5313d9988fadabfbf95556fcaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565531Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#650394}
-
Becca Hughes authored
The media notification should derive its foreground color from its artwork and background color. This ports an algorithm from Android. Also breaks out some of CalculateProminentColors so we can use it without recomputing swatches. BUG=944598 Change-Id: Ib4964a6668f8895da361eaf1243c29de570eed6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543929Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#650393}
-
chrome://offline-internalsIan Wells authored
OfflineInternalsUIMessageHandler::HandleScheduleNwake passes its first JS argument |callback_id| along to ScheduleNwakeWithGCMToken as a base::Value pointer whose target is destroyed before ScheduleNwakeWithGCMToken runs. This CL retrieves |callback_id| as a std::string which we can ensure still exists when passed to ResolveJavascriptCallback. Bug: 952047 Change-Id: If9267e894ab21947d29798094d3129108e2964c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565533 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#650392}
-
Guohui Deng authored
Rename application_session_id_manager.h/cc/mojom to application_media_info_manager.h/cc/mojom. We plan to extend ApplicationSessionIdManager service, to not only provide |application_session_id|,but also a flag indicating if a feature MIXER_AUDIO is enabled on an application. Therefore, this service is better renamed to ApplicationMediaInfoManager. Bug: internal b/110233576 Test: None. Change-Id: I5d48e455ad8425f91c63b6a463d77326e7ac4d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553829 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#650391}
-