- 09 Apr, 2020 40 commits
-
-
Lei Zhang authored
Make sure color models are color, and B&W models are not. Since PrintBackendCupsHelperTest has to deal with enum ColorModel anyway, it is a convenient spot to also exercise IsColorModelSelected(). Bug: 1069315 Change-Id: Ie3f665d5245e5aee04010f7c61d7b193936a0655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143372 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#757982}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d23973d2..0571c7d7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I867a1e7122c37624ccd005693274ad5e742be0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144711Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757981}
-
Reilly Grant authored
This test is flaky. Dashboard: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyYgsSBUZsYWtlIldjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BEdW1wQWNjZXNzaWJpbGl0eVRyZWVUZXN0LkFjY2Vzc2liaWxpdHlJZnJhbWVDcm9zc1Byb2Nlc3MM Bug: 622387 Change-Id: I7390a0250b4005c0361788a592f4fbecf1ff4ee1 Tbr: dmazzoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144402Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#757980}
-
Sadrul Habib Chowdhury authored
If a 'begin main frame' is aborted (e.g. because of no visual damage), then use the time of the abort as the termination time for the trace-event, rather than when the reporter gets replaced by a new reporter for the next frame, or when the scheduler drops the reporter after the frame's deadline. BUG=none Change-Id: I4fdb32f8793eb7228439937759bdf12f0f3c0798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138963 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#757979}
-
Peter Kasting authored
This was a stub implementation. No one should actually rely on its values, and returning null by default helps turn what could be subtle runtime behavior bugs into crashes. Provide the stub in ChromeViewsTestBase. In production code, Widgets should all be supplying a real theme provider. Bug: none Change-Id: I127048666ab3599f92f93a6d7627907344eae0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045314 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#757978}
-
Dan Harrington authored
Bug: 1044139 Change-Id: I5863d33d720fb180441e3823668b88d2be8f265b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138494 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#757977}
-
Roberto Carrillo authored
R=nodir,chanli,vadimsh Bug: 1027762 Change-Id: I2920ba111c4f5642922951893a4ebe47e8232163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142105Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#757976}
-
Garrett Beaty authored
The following changes were made to the console: * The category for chromeos-kevin-rel-hw-tests was updated from chromos to chromeos to match the other chromeos FYI builder. * The builders in the linux category were moved before builders with more deeply nested categories; less-nested builders always appear before more-nested builders. Bug: 1067057 Change-Id: I12c68275b9da6bcd308f2e3af543535016fb22fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140307 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#757975}
-
Ian Kilpatrick authored
Removes the optional inline_container parameter. There should be no behaviour change. Change-Id: I55893fd2e8b765cb0cd0e6786843f4d0dbb5ff2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142692Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#757974}
-
inglorion authored
This splits the unit tests and integration tests for goma_link. goma_link_unit_tests.py now contains unit tests that run quickly and don't depend on the host system being set up with the necessary external dependencies and environment. Integration tests that test actual linking of actual programs are now in goma_link_integration_tests.py. I have also expanded unit test coverage to check computing index parameters, codegen parameters, final link parameters, and the list of files to be codegenned, which is where most of the complexity of goma_link is. Bug: 877722 Change-Id: I18d5094e5044383cab2b4e43b9aff0086cfd2e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140813 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#757973}
-
bttk authored
Bug: 1063948 Change-Id: I3bdb268c3e3cb56819e95b7d4da307ee489bdce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134937Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#757972}
-
Jonathan Backer authored
This saves the SkSurface between consecutive write accesses of the WrappedSkImage. This caching of the SkSurface demonstrated positive CPU savings for both EGL and Vulkan on Pixel 3 on raster heavy telemetry tests (about 10% of thread_GPU_cpu_time_per_frame). Change-Id: I482cddb36853c03cab8902b48e8ba50b3ec7ca72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144353 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#757971}
-
Yaron Friedman authored
1) Add a test for changing the time period for deleting browsing data. 2) Add a test for tab ui and preference saving. BUG=10643665 Change-Id: I57f96eff5ff8b1d7023bb0c4a41a66fb023f25cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144397 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#757970}
-
Antonio Gomes authored
This test moves feimage-circular-reference-foreign-object-crash.html to wpt/. It also migrates the test into a regular crash test that waits long enough to check that the crash does not really happen using class="test-wait" (hence dropping the use of testharness.js and testharnessreport.js). R=fs@opera.com, smcgruer@chromium.org Bug: 1063749 Change-Id: I59eb6495c307d760e8969d37f72c17870b0d24bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144511 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#757969}
-
Mustaq Ahmed authored
Delay the click to let initial asserts complete synchronously. Bug: 1069087 Change-Id: I646b558d74cba977306f973c040c1420da9e2b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142139 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#757968}
-
Vasiliy Telezhnikov authored
This CL makes sure that DisplayResourceProvider return resources only when GPU Thread is available to make sure ReleaseImageContexts will complete in finite time. This doesn't change anything for Chrome where GPU Thread is always available, but on webview RenderThread that used for gpu access during composition is available only during specific times (init, dtor, DrawAndSwap) Bug: 1068716 Change-Id: I8fa482ab7399d6ce7639c1d76187be86ce152059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138551 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#757967}
-
sauski authored
This CL corrects the import of the assert function into site_data.js, as well as removes the import of the unused assert.html from controlled_ button.js Bug: 1069380 Change-Id: I5d50438763c355ca847567da1a9c6dfbfefcccb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143815 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#757966}
-
Reilly Grant authored
This test is flaky. Bug: 1069550 Change-Id: I45b2260a996ee7611b3d5fe250dc20d1e7170328 Tbr: lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143428Reviewed-by:
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into a WPT-specific directory for crashtests, adding links to the relevant specs and a test assertion describing its purpose. This CL also migrates usage of runAfterLayoutAndPaint(), which is based on Chromium's testRunner, to WPT's waitForAtLeastOneFrame() and uses it along with class="test-wait" to make sure we provide the test with enough time to check for potential crashes. Bug: 1063749 Change-Id: I2b0c1ee2f7b63c79b02ef320c969d474df37e395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144157 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/728b9178660e..dac5cc3b6a4e git log 728b9178660e..dac5cc3b6a4e --date=short --first-parent --format='%ad %ae %s' 2020-04-09 m.maiya@samsung.com EGL: Add support for EGL_EXT_image_gl_colorspace extension Created with: gclient setdep -r src/third_party/angle@dac5cc3b6a4e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I08a70011fff77875f22300a3fa3415fb2480c07b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757963}
-
David Bokan authored
This is a very complex system spread across both renderer and browser processes and compositor and main threads. Bugs here are often difficult to reproduce so having tracing to be able to diagnose issues would be very helpful. Bug: 1065841 Change-Id: I1a7d9e461f1b82a103ef0fb7234693d81164cb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140905 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Ionel Popescu authored
Prior to this CL dragging the color-well and the hue-slider was supported via mouse events. Because of this, dragging via touch wasn't working. This CL adds support for touch dragging. Unfortunately, since the popups don't have support for touch-action and we could not achieve a correct pointermove behavior for touch because we can't change the value of touch-action to none, the support is added by handling touch events. (see WebPagePopupImpl::SetTouchAction) [1] I have also added 2 new tests to validate dragging via touch. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=844547 Bug: 1068066 Change-Id: I9a70c7ab06de0506810bb7fd1a4baaab2ea7a622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142339Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#757961}
-
John L Chen authored
UserDataAuth migration is still ongoing. BUG: 1066099 Change-Id: If3a39d6dc9f3e46dfc144ebf627e0c3cf416677b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131106 Commit-Queue: John L Chen <zuan@chromium.org> Auto-Submit: John L Chen <zuan@chromium.org> Reviewed-by:
-
Tanya Gupta authored
string for permissions dialog. Bug: 1066228 Change-Id: I0580167cc2f39ac6ce1361596118c691c77ff4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130407Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#757959}
-
Leonard Grey authored
When creating a new window in fullscreen, we currently: - Create the window, focusing the location bar as expected - Make the window fullscreen As part of the fullscreen transition, we specifically clear focus from the location bar. This means that newly created windows in fullscreen don't automatically focus the location bar. While the main purpose of removing focus is for fullscreen modes that don't show the location bar, it prevents some jank even when the location bar is shown. For that reason, disabling it when the location bar is shown is not the best option. Instead, let's focus the location bar when showing a fullscreen browser window with nothing focused already. This is technically a superset of the "new window" case but it seems preferable to a key window with nothing focused. Bug: 884436 Change-Id: I1c1b60e293e976a2ef87bf416c36cabeabf0bca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144415Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#757958}
-
Elly Fong-Jones authored
This change: 1) Migrates ExtensionInstallDialogView to OnDialog* methods and removes the handled_result_ instance var, which is redundant with the presence of the callback 2) Migrates ExtensionUninstallDialogDelegateView to lambdas 3) Migrates ImportLockDialogView to lambdas with a close callback 4) Migrates PaymentRequestDialogView to OnDialog* methods 5) Migrates PlatformKeysCertificateSelector to a lambda 6) Migrates WebAppUninstallDialogDelegateView to OnDialog* methods 7) Migrates AppModalDialogViewViews to lambdas with a close callback For each dialog I attempted a manual inspection to figure out whether a close callback is needed or not. Bug: 1011446 Change-Id: I038371177d932546afe556f9f0665f841bb95e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135711Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#757957}
-
Roman Aleksandrov authored
Use new method for skipping screen. Add tests for UMA stats. Bug: 1064561 Change-Id: I953ec454a738fab1e9f58b08e27eec7356965d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141103Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#757956}
-
Mike Dougherty authored
Replace the boolean return value of WebStatePolicyDecider::ShouldAllowRequest with a struct PolicyDecision. PolicyDecision will be extended in a follow-up CL to specify an error which will denote the specific failure of loading a given |request|. Additionally, PolicyDecision::RequestAction is an enum as it will also be extended with an additional rejection type to reject the load and present UI displaying an error page with details about the given error. Bug: 1065161 Change-Id: I4e7eabf7ed4055bbd1365dab05bda53b5aaf2e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130971 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#757955}
-
Lei Zhang authored
The default case in the switch statement allows for a NOTREACHED() to be invoked at runtime if a new ColorModel is added that isn't handled in the switch statement. By removing the default case, the target will not compile unless the new case is handled by the switch. https://crrev.com/737599 already does this for IsColorModelSelected(). This CL refactors the common code used by IsColorModelSelected() and GetColorModelForMode() into ColorModeToColorModel(). Bug: 1069266 Change-Id: I38287e828d48640d6a3eef9891bb7040bf7450b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142953Reviewed-by:
-
Antonio Gomes authored
This test moves feimage-reference-foreign-object-crash.html to wpt/. It also migrates the test into a regular crash test that waits long enough to check that the crash does not really happen using class="test-wait" (hence dropping the use of testharness.js and testharnessreport.js). Differently from [1], circular reference isn't used. [1] https://crrev.com/c/2144511 R=fs@opera.com, smcgruer@chromium.org Bug: 1063749 Change-Id: I936649812fb546265f9e278a8b42ed60a1fe5363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144512 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Bug: 1065314 Change-Id: I2de531bf5889f4d19afbb7d015ecec371bbf70c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143651Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757952}
-
Etienne Pierre-doray authored
Since old DoWork/DoDelayedWork() was removed, last_work_check_result_ can be removed. Bug: 885371 Change-Id: If975d306e3b50b406b728d0e2b3961e30dc4b344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130824Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#757951}
-
Jazz Xu authored
Bug: 1060291 Change-Id: I6c70eb25b9b8e3c9f675b0030a42fe712a89715d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129018Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757950}
-
Jon Mann authored
This allows shared networks that were added by the logged in user to be saved to sync while filtering out networks that were configured by other users. Bug: 966270 Change-Id: I31063c09300290671f0236e71706fd00fe1ca77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142579Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#757949}
-
Charlie Hu authored
This CL follows up CL(https://chromium-review.googlesource.com/c/chromium/src/+/2101707). This CL moves handling of empty resource url in |Document::ReportFeaturePolicyViolation| and |Document::ReportDocumentPolicyViolation| to |LocationReportBody| constructor. Change-Id: I34d68421daf3899fdf9063a800e2fa34e34e641b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119256 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#757948}
-
chrome://appsDaniel Murphy authored
This change allows web apps that are populated in chrome://apps using WebAppProvider to be uninstalled. R=loyso@chromium.org Tested: Manually, with both BMO on and off. Bug: 1009302, 1068476 Change-Id: Ia80a546d4cff8c999ff2bc7a7541e672ce2b4e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117298Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#757947}
-
Varun Khaneja authored
Bug: 1044212 Change-Id: I68e11b7f06830b2d34c2bd5a48b0ef0c64bccae0 Fixed: 1069517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144671 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#757946}
-
Yi Xu authored
Fix size.attributes.parse.trailingjunk to match spec: offscreenCanvas.width = '100#!?' should shrow TypeError because 100#!? is NaN. Bug: 1067639 Change-Id: I5b9798cfb7d4f7ecfc77854fd1431c1df89f84a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142746Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#757945}
-
Evan Stade authored
When the app crashes, it can leave behind media streaming notifications. Track these in a pref and remove on next startup. We could use getActiveNotifications instead of storing a pref, but it's only available in API 23. Testing is still a todo and may be somewhat difficult as full integration testing requires crashing the app. For now this is manually tested by removing the cancel() calls that execute on stream/tab destruction and restarting the app. Bug: 1025622 Change-Id: Icdd475707ac1af0789968264c202e00fd8964d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142394 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#757944}
-
Ben Pastene authored
This reverts commit 320f9516. Reason for revert: deduping was reset, comment no longer needed Original change's description: > Add a whitespace change to test_env.py to reset swarming deduplication. > > Due to emergency server maintenance in crbug.com/1069091, we need all > tests to not be deduplicated into tests that ran prior to the > maintenance. Adding a trivial change to //testing/test_env.py will > prevent any task deduplication since most every test includes this file > in its inputs. > > TBR=johnchen > > No-Try: true > No-Tree-Checks: true > Bug: 1069091 > Change-Id: If99af96b6bce7b00cd982de0234b39dbb9a9ec89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142619 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757517} TBR=iannucci@chromium.org,bpastene@chromium.org,johnchen@chromium.org Change-Id: If0b620f3461efeef34ec7a0d24fcd813f585d00b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144360Reviewed-by:
-
