- 09 Nov, 2020 40 commits
-
-
Koji Ishii authored
This reverts commit 2493e000. Reason for revert: Hit test regression at crbug.com/1146797 Original change's description: > Avoid falling back to legacy if |CanTraversePhysicalFragments| > > When painting and hit-testing NG fragments, > |NGBoxFragmentPainter| falls back to |LayoutObject| at the BFC > boundary, because we already have a logic in |LayoutObject| > to switch painters for NG and legacy. > > This patch changes to do so only when |!CanTraverse|, because > |LayoutObject| cannot handle block fragmented NG objects. > > This patch eliminates |CurrentFragment| from > |LayoutNGBlockFlowMixin::Paint| by making sure it is not block > fragmented. > > Also changes |HitTestChildBoxFragment| so that it can handle > atomically-painted objects in NG code path. Due to the change > in |FragmentRequiresLegacyFallback|, such objects go to NG > code path without going through |LayoutObject|. > > Bug: 1061423, 829028 > Change-Id: Ife31d6dcd209668a489243b1158112dac44fc273 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515429 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824316} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,mstensho@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1146797, 1146935, 829028, 1061423 Change-Id: Id228899a56bbcdd118a860e8e73ecb18a9b0d96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525882 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#825301}
-
dpapad authored
This is done so that it is easier to view the contents of the dialog when the window is too short, or when the user has zoomed in. Fixed: 1066188 Change-Id: Ic3c1f4b8700b82e58fe4915e781cb65078cbdd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523051Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#825300}
-
Fredrik Söderqvist authored
SVGAnimateElement currently holds on to the computed animation value, and one of the animation elements in a sandwich is appointed the "result element". This value management is unnecessarily complex, since the lifecycle of the value is roughly create->compute->apply, and after having applied the value we no longer need it because a new one will be created on the next animation update. Clearing the value does not require actually having the value itself. Instead introduce a SMILAnimationValue structure which essentially wraps all possible animation value types. This structure is setup by CreateAnimationValue() (previously ResetAnimatedType()) and then subsequently passed to ApplyAnimation() (CalculateAnimatedValue()) and ApplyResultsToTarget(). ClearAnimatedType() is renamed to ClearAnimationValue() and CalculateAnimatedValue() is renamed to CalculateAnimationValue(). For SVGAnimateMotionElement this means we can compute the resulting transform and then apply it as the final step - i.e we don't need to compute it in-place. This should allow simplifying the application logic for motion paths in the future. Bug: 1017723 Change-Id: I205e83a8c471bbe8becb0bc4a686086d811eb482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523183 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#825299}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ed0b4d1e07fb..e42e853638c4 2020-11-09 sigurds@chromium.org [ts] Fix bug in data-grid/DataGrid.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I932c1ad498715d065d6b6d8e30aa664bea61adef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825298}
-
Alan Cutter authored
This was failing compile with: ../../chrome/browser/chromeos/policy/system_proxy_manager_browsertest.cc:438:23: error: comparison of integers of different signs: 'int' and 'std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>>::size_type' (aka 'unsigned long') [-Werror,-Wsign-compare] for (int i = 0; i < auth_schemes.size(); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~ and: ../../third_party/googletest/src/googletest/include/gtest/gtest.h:1544:11: error: comparison of integers of different signs: 'const unsigned long' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ ../../third_party/googletest/src/googletest/include/gtest/gtest.h:1571:12: note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ ../../chrome/browser/chromeos/policy/system_proxy_manager_browsertest.cc:436:5: note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long, int, nullptr>' requested here ASSERT_EQ(auth_schemes.size(), ^ Change-Id: Iae6fab7566a7a36efd5b41f4c76c696de4a29e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525386 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#825297}
-
Sergey Poromov authored
When confidential content appears in the capture area and screen capture is being paused, a black frame should be sent to override the last sent capture frame. Bug: 1134566 Change-Id: I20c2859cefcc0166ae86b08cde02e5b1b8835dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521737Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#825296}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id0b45ea7578a2babe5fce156ce72028a2b6cd66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525760Reviewed-by:
-
Tanmoy Mollik authored
Batch tests in BookmarkBridgeTest to reduce the overall running time of chrome_public_test_apk Bug: 1145843 Change-Id: Ib0f4490ea6c9bfee965ecc67eed02d29d16e149f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523327Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#825294}
-
Luciano Pacheco authored
Convert `var` to let/const as pointed by presumit. Convert an anonymous function to arrow function to avoid the `.bind(this)`. No change in behavior. Test: Manually tested the audio player (just in case). Change-Id: I73be16d039476b9fe9a087798f596a521b1bdabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525884 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#825293}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d4439824c554..46f5f4386f7c 2020-11-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 52d33a46 to 61aafe63 (506 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Ie892633aa908905b6e9b6ad09cbdb963e8ab7788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525824Reviewed-by:
-
Ewann authored
This CL fixes the Settings navigationBar background color. Bug: 922511 Change-Id: I9a59e152720c9208fbf6df709afaf66cc6f540d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523207 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#825291}
-
Christian Dullweber authored
The test fails when changing between winter/summer time due to days being longer/shorter than 24h. RevertTimeInDays assumes that every day has 24h. To fix the issue the test always runs on a fixed timestamp. Bug: 1144634 Change-Id: I55f94df979c61a3e965885eb577bc05d41612725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523032Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#825290}
-
Antonio Sartori authored
The policy container is a container for security policies that applies to a document and that we are prototyping in chrome. The implementation requires to track document policies both in Blink and in the browser. Previously, we were using a somewhat confusing naming convention, which was not coherent with the rest of chromium. This CL renames: - content::PolicyContainer => content::PolicyContainerHost - blink::mojom::PolicyContainerClient => blink::mojom::PolicyContainer - blink::mojom::PolicyContainerData => blink::mojom::PolicyContainerDocumentPolicies - blink::WebPolicyContainerClient => blink::WebPolicyContainer So that: - a RenderFrameHost owns a content::PolicyContainerHost - the corresponding LocalFrame owns a blink::PolicyContainer - content::PolicyContainerHost implements the blink::mojom::PolicyContainerHost interface - the blink::PolicyContainer holds a remote for the blink::mojom::PolicyContainerHost interface - a blink::PolicyContainer holds some blink::mojom::PolicyContainerDocumentPolicies Hopefully this makes the code easier to follow and better adheres to current chromium naming conventions. Bug: 1130587 Change-Id: Ic27955a854cb645cef19cd67dfd45e6a33571706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517467Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#825289}
-
Jesse McKenna authored
This change fixes an uninitialized pointer in the FloatingMenuButton class that triggers MemorySanitizer errors on bots. Currently, if FloatingMenuButton is initialized via its default constructor, its member `VectorIcon* icon_` is uninitialized. This causes errors when the value of icon_ is checked in SetVectorIcon(). Bug: 772945 Bug: 938501 Bug: 1130078 Bug: 1146255 Change-Id: I21f9596f496d6fd5090bd2e307dc648117be07ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523477 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#825288}
-
Alice Wang authored
This CL replaces the generic accessibility strings with more specific ones in the web sign-in bottom sheet. Bug: 1112696 Change-Id: I1dff9637b8df04a0f0f8c03940d21099196c3078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502431Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825287}
-
Viktor Semeniuk authored
This CL adds a condition to avoid prefetching a change password URL for requested facet, if Affiliation Service already stores data for this facet from previous prefetch. The change affects WellKnownChangePasswordNavigationThrottle and saves time that would be spent on unnecessary prefetch. Bug: 1108279 Change-Id: Idcab44f3a6a277298c97a0fdde6c6f6e88f40cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443655 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#825286}
-
Christian Dullweber authored
Create a transition to animate changes in height when switching between PageInfo subpages. Video: https://crbug.com/1077766#c92 Bug: 1077766 Change-Id: I5fb7392db017951e80cce162d11e17240b3eacd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517454 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#825285}
-
Ted Meyer authored
Bug: 1136730 R=andrescj Change-Id: I60f2704313adfae0f76ce0d1c55e30051a48267b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506770 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#825284}
-
Kenichi Ishibashi authored
ServiceWorkerScriptCacheMap uses ServiceWorkerResourceMetadataWriter which can be disconnected when the Storage Service disappears. To abort metadata writing gracefully, this CL sets a disconnection handler to invoke callbacks. Since callbacks need to be accessible from both the disconnection handler and OnMetadataWritten() we need to hold callbacks in ServiceWorkerScriptCacheMap instead of passing the ownership of them to OnMetadataWritten(). Bug: 1133143 Change-Id: I0ae2846821372b1f28fddc5d4ac9564ded6ee585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520477 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825283}
-
Mohammed Abdon authored
This CL introduces OnlineLoginHelper which will be used in authenticating Gaia and SAML users in loginscreen and SAML users in lockscreen. Bug: 1102942 Change-Id: Ie0e41b30e4e6cfb8f027d729be24bcd5b8169151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466422Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Mohammed Abdon <mohammedabdon@chromium.org> Cr-Commit-Position: refs/heads/master@{#825282}
-
Jan Wilken Dörrie authored
This change updates the guidance on top of values.h to prefer base::flat_map<std::string, base::Value> over base::DictionaryValue. Bug: 646113 Change-Id: Ib02ad787068b3f89ae56ea13c4044338eb703437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509576Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#825281}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I6f7099debb9e6459fb419b99dd28cf77fdacbc72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526180Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825280}
-
arthursonzogni authored
'file:' is special, because it produces a non opaque origin, uses port= = 0, and the conversion from/blink blink preserves port == 0. Previous patch: https://chromium.googlesource.com/chromium/src/+/a444094dd1d17b48a5a93629ac864a5c43671287 provided a different expectations for origins with (port == 0). When this happens, blink replace zero by DefaultPortForPrototocol(scheme): - http => 80 - https => 443 - ws => 80 - wss => 443 - ftp => 21 - ftps => 990 - _ => 0 So when the scheme is "file", zero is replaced by zero and the transformation can be reversed. Fixed: 1143052 Bug: 1144091 Change-Id: I8368cba6fa341a67b579ccfd9c972aace9e1e2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510052 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#825279}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4075f123..22679f90 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8f2ceee733c6b24bc8852ee969a582ae70f4dd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525606Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825278}
-
Shik Chen authored
Since we migrated CCA to SWA, there is no .crx bundle anymore. Bug: b:172341870 Test: CQ Change-Id: I4fe3cee4ed969e9047d2b432e0d65797d2761e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525960 Commit-Queue: Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#825277}
-
Clemens Arbesser authored
Also slightly refactors trigger script shutdown to ensure that metrics are correct. Bug: b/172548211 Bug: b/171792264 Change-Id: I9687dbf5497a1a15f1267444f478162b07d04373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517453 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Lukasz Suder <lsuder@chromium.org> Cr-Commit-Position: refs/heads/master@{#825276}
-
Victor Hugo Vianna Silva authored
No behavior is changed. Bug: None Change-Id: Ide3e55a5c72a2c25e9a9921b7bee3eb9032e4022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523209 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Clemens Arbesser authored
This is currently not yet wired up to the android UI, but is otherwise fully functional. There are some smaller follow-ups that I extracted from this CL: - Update to metrics enums - Wiring it up to android Bug: b/171776026 Change-Id: I7a05d97ccabb8c2bbaa3bb574d74772e9c4dbfb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517696 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Luciano Pacheco authored
The use of matchBottomLine() function was removed in: https://codereview.chromium.org/1491543002 Fix var/let violations pointed out by the presubmit. Change-Id: I94bc7853623ec73e54c066030bca60da37e5795d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525880 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
This CL replaces all uses of blink::Manifest::ShareTarget::Method with blink::mojom::ManifestShareTarget_Method in order to reduce type conversion between them. Bug: 919392 Change-Id: Id248941c750f0dd0b627c556e58a561a93ec8448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521883 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#825272}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/65040af1001b..ed0b4d1e07fb 2020-11-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I076f009fb15086b2317cec22e6e73daf4e839a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525045Reviewed-by:
-
Austin Tankiang authored
Bug: 1115025 Change-Id: If7943f16b862323a26f60e36f374b2fbcd41c3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525565 Commit-Queue: Austin Tankiang <austinct@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#825270}
-
Luciano Pacheco authored
Rename the test FilesAppEntryTypes because the flake was due to the dep `:files_app_entry_types_unittest.m` being commented out, which is fixed in this CL. Change js_test_gen_html() build rule to use `invoker.js_module` instead of `forward_variables_from()` because when there was multiple files in the same build target, it was failing with this error: ``` ERROR at //ui/file_manager/base/gn/js_test_gen_html.gni:117:39: Clobbering existing value. forward_variables_from(invoker, [ "js_module" ]) ^---------- The current scope already defines a value "js_module". forward_variables_from() won't clobber existing values. If you want to merge lists, you'll need to do this explicitly. ``` Bug: 1146484 Change-Id: Ifcf3105ef5f63d6d2e9e2ec9ce8cad7813b4cd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525473 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: -
Harvey Yang authored
Updating with CL:2386879, this commit adds SensorServiceNewDevicesObserver to support sensors that are setup after iioservice starts, and let iioservice notify sensor clients that new sensors are available. This commit also adds the implementation of the new method in the fake class. BUG=b:172414309 TEST=builds Change-Id: Ib2bfba1038dc737336424699bfabf02b6ae68941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523131Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825268}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ee0ce9858cbc..cffe7e631c4e 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a4f272b3 to 083976a7 (536 revisions) 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 612ded0654a0 to 4ed9d3498dcf (2 revisions) 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3dfaeeb00271 to d4439824c554 (28 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Test: Test: Test: Capture Clash of ClansTest: Test: angle_end2end_tests.exeTest: Test: angle_perftests --gtest_filter="*clash_of_clans*" Change-Id: I9fa84e51de5c3fd8f7464fef222631d3de74dc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524758Reviewed-by:
-
Yunke Zhou authored
Bug: 1141030 Change-Id: Ie530eeeb8c6f17a6df7fd2e5b81ebd81a85f039f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520839Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This reverts commit 70da33e0. Reason for revert: recipe was rolled to internal repo in https://crbug.com/1144638#c28 Original change's description: > Revert "Reland "[DEPS] update luci-go"" > > This reverts commit f19f9e01. > > Reason for revert: crbug/1144638 The changes have worked for webrtc, but is causing failures for iOS official bots. We'll wait for the autoroll and ensure that CL is in place before re-landing this if that's okay. > > Original change's description: > > Reland "[DEPS] update luci-go" > > > > This reverts commit 94863f6a. > > > > Reason for revert: > > https://crrev.com/c/2518615 fixed the previous issue. > > > > Original change's description: > > > Revert "[DEPS] update luci-go" > > > > > > This reverts commit 1585878b. > > > > > > Reason for revert: > > > https://crbug.com/1144638 > > > https://crbug.com/webrtc/12126 > > > > > > Original change's description: > > > > [DEPS] update luci-go > > > > > > > > Bug: 1142713 > > > > Change-Id: Id330d0c9a0e225e5fbf8ae12abeb6b8d55f46262 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507246 > > > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > > > > Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> > > > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#822547} > > > > > > TBR=yyanagisawa@google.com,tikuta@chromium.org > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: 1142713, 1144638, webrtc:12126 > > > Change-Id: Ie06d7c40065630f28ac44fe6f2dac82f91e64da1 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517405 > > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#823859} > > > > TBR=yyanagisawa@google.com,tikuta@chromium.org,mbonadei@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1142713 > > Bug: 1144638 > > Bug: webrtc:12126 > > Change-Id: I3cdb4d01a5d603b95d03b93b8dd43d81a84f7a2b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519179 > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#824332} > > TBR=tikuta@chromium.org,mbonadei@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1142713 > Bug: 1144638 > Bug: webrtc:12126 > Change-Id: I33f3cf4b84818a8abbf5d468fb9165543af5f434 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522982 > Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org> > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825019} TBR=tikuta@chromium.org,mbonadei@chromium.org,seblalancette@chromium.org,jeffyoon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142713 Bug: 1144638 Bug: webrtc:12126 Change-Id: I004fc735b04272bd604016af450ff387e6f63191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524810 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#825265}
-
Alan Cutter authored
This CL moves the filtering of apps by: - feature_name - user_type, - disable_if_arc_supported - disable_if_tablet_form_factor from ParseConfig() into PostProcessConfigs(). This is to be able to share that logic with apps added to GetPreinstalledWebApps(). There are no behavioural changes in this CL aside from minor fixups in ExternalInstallOptions::operator==() and its operator<<(). Bug: 1058265 Change-Id: I6a2f3d89f076269e612d0806fb9e3abd37536d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520559 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#825264}
-
Chris Hall authored
AXNodeObject::Language was returning the full meta tag value "en, fr" instead of only the first element "en" when computing the language value for kRootWebArea. A value containing comma is not a valid BCP47 language tag. [1] specifies the DOM lang attribute should be a valid BCP47 language tag, whereas a comma separated list is instead a language priority list. I'm not sure if this necessarily applies to our accessible interface, but it seems like the closest spec and this behaviour is consistent with our other return values. [1] https://html.spec.whatwg.org/multipage/dom.html#language AX-Relnotes: n/a. Change-Id: I0e7b2826e3cca0b9392a4add39c99244018e9dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505291 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#825263}
-
Bartek Nowierski authored
Bug: 1121427 Change-Id: I722ab107fd29489bf23f47f30a97d09622e5ae7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517220 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#825262}
-
