GitLab

This CL removes the ConnectionStatus::kWaitingForConnectionInitiation
enum value. In practice, we always get the OnConnectionInitiated()
callback before the RequestConnection() callback is invoked, so this
state should not exist.

Bug: 1148152, 1106937
Change-Id: Ie659a875ae3a32ec62aa991398331617b2c33d2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542573
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#828020}

Before the CL, the error handling logic lives in
CPRService#showAppSelector().

After the CL, CPRService#showAppSelector() returns the error to
PRService, and PRService handles the error.

Bug: 1148902

Change-Id: I992b449eb5d406db6c110ce9d300c6b68afd5528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536996Reviewed-by: Nick Burris <nburris@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828019}

This CL renames the "Live Captions" flag to "Live Caption".

Bug: 1148994
Change-Id: I133513bd6912e9a5f9adb4023533546ef0c382a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538268Reviewed-by: Abigail Klein <abigailbklein@google.com>
Reviewed-by: Evan Liu <evliu@google.com>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#828018}

Instead of using string constants, introduce an enum for the selected
nameservers type.
This is less error prone and easier to read.

Bug: 1108922
Change-Id: I05cc167f42467af8a6b78cb688b8239e8a896c67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537678
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828017}

https://swiftshader.googlesource.com/SwiftShader.git/+log/3e551b3ce67d..04515da400d5

2020-11-16 srisser@google.com Don't auto append value of stringified enums

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: If382c85f0b769fce5fae16b63bba80fa510b4430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542646Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828016}

NavigatorBase is a newly-added base class for Navigator and
WorkerNavigator. Making Permissions a Supplement of NavigatorBase
allows a single class to handle all of the work of exposing the
navigator.permissions getter for both windows and workers, and
greatly reduces boilerplate.

Bug: 1147612
Change-Id: I45b857df7864ba50f38ebebd2afe358ae759914a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538056
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828015}

Two main changes to address flakiness:
  1. Scroll to nickname before changing it.
  2. Use grey_replaceText as recommended by EG.

Evolved from previous CL
https://chromium-review.googlesource.com/c/chromium/src/+/2380145

Fixed: 1106766, 1108809
Change-Id: I0acfc0980b95bc657d545c43d1a7e15410485747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493423
Commit-Queue: Alfonso Garza <alfonsogarza@google.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#828014}

I tried compiling ChromeOS on a fresh installed gLinux and it failed:

  ACTION //chrome/browser/chromeos:device_policy_remover_generate(//build/toolchain/linux:clang_x64)
  FAILED: gen/chrome/browser/chromeos/device_policy_remover.cc
  python ../../chrome/browser/chromeos/policy/tools/generate_device_policy_remover.py gen/chrome/browser/chromeos/device_policy_remover.cc ../../third_party/protobuf/python pyproto pyproto/components/policy/proto
  Traceback (most recent call last):
    File "../../chrome/browser/chromeos/policy/tools/generate_device_policy_remover.py", line 63, in <module>
      sys.exit(main())
    File "../../chrome/browser/chromeos/policy/tools/generate_device_policy_remover.py", line 31, in main
      from chrome_device_policy_pb2 import ChromeDeviceSettingsProto
    File "pyproto/components/policy/proto/chrome_device_policy_pb2.py", line 7, in <module>
      from google.protobuf import descriptor as _descriptor
    File "../../third_party/protobuf/python/google/protobuf/descriptor.py", line 38, in <module>
      import six
  ImportError: No module named six

This is not easy to work around as it requires pip for Python2 which is
no longer available in apt, so I tried running the script in Python3 and
that seemed to work.

Bug: crbug.com/1112471
Test: compiled
Change-Id: I777c7a1c4562eec500ea487f48f0337b51735010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542063Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828013}

Based on crash reports it appears possible for open() to return null
without throwing an exception. getCameraParameters() handles this case
gracefully by returning null but isZoomSupported() will then try to call
release() on the null Camera. The release() call is unecessary because
getCameraParameters() already releases the Camera on error.

Bug: 1149283
Change-Id: I1a5522fa3179f3b6389e5dff83a0ca379f9f44ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542785
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828012}

Chrome OS hides many paths from the user. Users can only browse to
MyFiles, certain Android paths, and a selected set of mount points.
For security-in-depth, Chrome OS restricts download paths to those
directories and their subdirectories.

Many of the path utilities functions used to check for these
directories have ash dependencies that cannot be included in the
lacros build.

For now, restrict lacros downloads to the default Downloads
directory and its subdirectories. We can revisit this as part of
the Files work planned for early next year.

Bug: 1148848
Test: expanded unit_tests coverage for lacros

Change-Id: Ia7c41350dcfc29299579f9e7ecd4078e1eb00505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541124Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828011}

This reverts commit 4f35dbaf.

Reason for revert: Suspect causing chromedriver_py_tests failures on (none) GPU on Mac:
- main.MobileEmulationCapabilityTest.testNetworkConnectionDisabledByDefault
- main.ChromeDriverTestLegacy.testMobileEmulationDisabledByDefault
- main.ChromeDriverTest.testActionsMouseDrag
- main.ChromeDriverTestLegacy.testMouseDoubleClick
...215 more failure(s) (219 total)...

First build failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/61407

Sample log:
---
testWifiAndAirplaneModeEmulation (__main__.MobileEmulationCapabilityTest) ... ERROR
testConnectToRemoteBrowser (__main__.RemoteBrowserTest) ... application requires at least Mac OS X version 10.11.0 (10.11.0), but is being run on 10.10.5 ( 10.10.5/14F2511), and so is exiting.Received signal 6
---

Original change's description:
> mac: Update LSMinimumSystemVersion from 10.10 to 10.11
>
> Bug: 1148931
> Change-Id: Ic0cdded0c1c4821689486cacd5790fce82c40c87
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537057
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827937}

TBR=avi@chromium.org,rsesek@chromium.org

Change-Id: If527cdb6ffdde2807b2c9a2315316a8ae5699e24
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1148931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542934Reviewed-by: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828010}

- This CL contains no behavioral changes
- NFSManager stores flat_set of NFSWriterImpls rather than a
  UniqueReceiverSet of blink::mojom::NFSWriters
- FileWriter destroys itself via disconnect handler
- Opens the door for autoClose flag as described here:
  https://github.com/WICG/file-system-access/issues/236

Bug: 1135687
Change-Id: Icbc7375174ee2d48dca481d6490d5eddc282ccff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523653
Auto-Submit: Austin Sullivan <asully@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828009}

Googlers: a screenshot of the new sub-labels can be found here:
http://screen/345FdDordriQRcu

Fixed: 1146366
Test: Manual test
Change-Id: I49ca8a731b7ef1d63d794368ff27b355298e382d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525463Reviewed-by: My Nguyen <myy@chromium.org>
Commit-Queue: Michael Cui <mlcui@google.com>
Cr-Commit-Position: refs/heads/master@{#828008}

Bug: 971272
Change-Id: Ie8ab8512d9fc00ca0111b3f3bed1fc779593cad3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522195
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828007}

It should be ok to let animation timings go stale for such documents.
This has a significant performance impact in the presence of many
lazy-loaded iframes.

Bug: 1137931

Change-Id: I394ae63ea2c220b175fd7724ff915c2786046a76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536811Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828006}

This fixes an issue that FlushDone() in VideoEncoderClient will
never be called when the test runs with --disable_validator and
the VideoEncodeAccelerator doesn't support Flush().

Bug: None
Test: video_encode_acclerator_tests --disable_validator on trogdor
Change-Id: I8701a971deaa4cacfcd55a2c708de437a79ad863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537507Reviewed-by: David Staessens <dstaessens@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828005}

Add ESimManager bindings to OS Settings and create
FakeESimManagerRemote to use as a mock for unit testing.

Bug: 1093185
Change-Id: I03ab65d280f497ef9fac39bd1b48cef725083441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536113Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Gordon Seto <gordonseto@google.com>
Cr-Commit-Position: refs/heads/master@{#828004}

This is some ugly but temporary debugging to log extra information
when we find the the view has no main frame but the local root does.

Bug: 1139104
Change-Id: I791fc7572a4a5a5abf3c7c689c4029e1696bbd48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532535Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Auto-Submit: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828003}

Remove the unneeded feature declarations now that passive mixed
content is autoupgraded by default.

Bug: 1042877
Change-Id: I60ab635bc7f75527ca27f0657719b1ef42dbe7e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540654Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#828002}

On some platforms a node is represented as an "object replacement character" in the text of its parent node.
When calculating the parent AXPosition of a text position, we added special logic that
adjusts the resulting position to be either before or after the object replacement character depending on the navigation operation.
For example, if we are trying to find the start of line, we need to move to before the "object replacement character".
Similarly, we need to adjust to after the replacement character if we are trying to find
the end of the line.
This adjustment is not necessary unless there is some ambiguity in the original position.
Ambiguity only occurs when the original position is not at the start  and not
at the end of its anchor.

Unfortunately this special logic was not applied to tree positions, and it was
inconsistently applied to text positions at the end of their anchors, hence this patch.

Also fixes a few bugs in the CompareTo, SlowCompareTo and AtStartOfAnchor methods
that were found during testing:
1. AtStartOfAnchor was using text offsets for tree positions, even though they might not have been calculated
yet because AsTextPosition() hadn't been called.
2. CompareTo was adjusting both text and tree positions that are inside embedded objects to after
the embedded object character for comparison purposes, even though the comment in the code only talks about text positions.
Also the adjustment was done manually by adding or subtracting 1, which
is error prone. Now the comparason is done by SlowCompareTo.
3. CompareTo and SlowCompareTo were not properly comparing a tree and a text position that have the same anchor.
4. SlowCompareTo was not comparing a tree with a text position by converting the tree position to a text
position. It was doing the opposite, thereby losing information in the process.
5. SlowCompareTo was not taking embedded objects and affinity into consideration when comparing two text
positions that are not ancestors of one another.
6. SlowCompareTo was not normalizing tree positions to the start of their anchors before comparing them, thereby
running the risk of comparing an "After children" or an "After text" position with an adjacent "before children" or "before text"
position and erroniously finding them to be equal.

Split out from a larger patch that merges AXNodePosition and BrowserAccessibilityPosition
into one class:
https://crrev.com/c/2327552

AX-Relnotes: n/a.

R=dmazzoni@chromium.org, aleventhal@chromium.org

Bug: 1049261
Change-Id: Icedaebca48468c95bdbf1fc5c10393c4ace7dadf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343031
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Victor Fei <vicfei@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Auto-Submit: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828001}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e371caae2fd..bee2bff5b0e1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC tguilbert@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1136305,chromium:1146954
Tbr: tguilbert@google.com
Change-Id: I2266e8827053512a614f66c0bb57ed372d95ce73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542647Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828000}

- Update tests to verify tabstrip is not larger than parent when growing
- Add a test to ensure the grab handle space is always visible
- Update new tab button always visible test to match this
- Rename kTabStripWidth to kTabStripRegionViewWidth

Bug: 1141674
Change-Id: I7fa527ed836c78ea9a3c1958715dc83ba7893a2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536238Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827999}

When the browser window is large enough, the tabstrip should expand to
accommodate tabs dragging past the last tab. This is a test for
crrev.com/c/2472577

Bug: 1141674
Change-Id: Icfb4b0d6b9ebfa243a0e352b0cef68a2a6f2c263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537068Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827998}

The helper is no longer used. Mocking chrome.send() calls is happening
via the use of browser proxies in all newer WebUIs.

Fixed: 1148403
Change-Id: I543ad1d36a0a92110182b4998380b3061c478f78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537770
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827997}

This CL changes Audio Player background page to run as JS module.

Bug: 1133186
Change-Id: Ib9657c09bcea95deb97e63d19bfdfac88644daeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537287Reviewed-by: Jeremie Boulic <jboulic@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827996}

To prepare for adding new channel types (ie. fast posix channels) we
will need a way to extend existing Mojo NodeChannel messages.

Bug: b:173022729
Change-Id: I56b80ed58f28d058927d94ef9421319fe547c719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538166
Commit-Queue: Brian Geffon <bgeffon@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#827995}

Screenshot: http://shortn/_AyCiiMx92w

 - Center cards
 - Adjust margin within cards
 - Adjust card width
 - Remove minimum height requirement from cards

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: I4c4f31182c7c835f6015b15af0f5a3aab64f489d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530744
Commit-Queue: Michael Checo <michaelcheco@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827994}

Rename variables containing the parsing patterns.
Removes auto& statements in favor of explicit type declarations.
Removes spurious comments.

Change-Id: I9ca9523a5039952ab7de9dbeaa45f0baaa476d68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535770
Commit-Queue: Matthias Körber <koerber@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/master@{#827993}

Refactor print server components from CupsPrintersManager into its own
class.

Bug: b:168650771
Change-Id: If62b27ffde97257e9e0ac5b745ceecdd13721fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521226
Commit-Queue: Matt Menard <mattme@google.com>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827992}

CTAP 2.1 devices support the authenticatorSelection command to get a
touch. Use authenticatorSelection instead of creating a dummy credential
on those devices.

Fixed: 1039426
Change-Id: I89420f1a181470fbbcce59a6ca0cdf3a44bd2ec0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535874
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#827991}

Bug: 1148989
Change-Id: I2a9f46f26eb076cc73166db300d14a1feb63fa28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541579Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827990}

File preview icons have been enlarged to match the size of the
<nearby-progress> icon.

The confirmation page spec has been updated to require that the dashed
line between the file preview icon and the progress icon should be
aligned with their centers.

Bug: b/163036847
Change-Id: Ib86109fe36e275a90cf8db3d2ed70585e9a28b73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530736
Commit-Queue: Curt Clemens <cclem@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827989}

Bug: 1014639
Change-Id: I27a3ca26e027fc4059285de2462edc25c400d399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537144
Auto-Submit: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827988}

UX wants them to be a bit larger.

Bug: 1147637
Change-Id: I6980cc2cf0d35f757ca55e4a0cb1d91291eaa5b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542925
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827987}

The upload_trace_processor step on the perfetto bots has
been failing on Windows since a change that changed how
vpython dependencies were packaged landed.

This CL adds what I believe to be a missing data dependency
on //.vpython that will hopefully fix the problem.

Bug: 1122953
Change-Id: I7b42278bf1a1177b36e2547d0737cc9288c289e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536819Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#827986}

The test failed on the Win7 Debug CI bot because the
COM apartment of the code making COM calls in the
unit test was not initialized.

COM apartment initialization must be done per-process or
at least, per thread. It is unwise to do it per-function.

Bug: 1149213
Change-Id: I4ef5ae6396bbb101da3f6dfdccf070e54ae26983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543122Reviewed-by: S. Ganesh <ganesh@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827985}

With the genius app finally deleted, there are no possible entry points
left to get to the welcome tour.

Means all the Welcome tour code can be deleted.

Bug: 1001460, b/145710734
Change-Id: I95e6c3f23a1ccc47a017a434b8b17a3dcedc6a57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989721Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Rachel Carpenter <carpenterr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827984}

Updated the following policies:
NTPCustomBackgroundEnabled
PrintPreviewUseSystemDefaultPrinter
RequireOnlineRevocationChecksForLocalAnchors
SafeBrowsingForTrustedSourcesEnabled
SamlInSessionPasswordChangeEnabled

Bug: 1139306
Change-Id: I4657d533ad8dbf86f1a2ff4394d2122a4c2deb06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534712Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827983}

Display a generic error message on the discovery page when the share
target selection fails or if we can't get the discovery manager. Hide
the help section when the error section is showing to avoid crowding
the page, since the help is irrelevant if we're in an error state.

Bug: 1123934
Change-Id: If417cc633987da59fec495f329d2f54fe4d8eb83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538425
Commit-Queue: Curt Clemens <cclem@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827982}

This is a reland of 5d6ecbfb

The failing Tast test (ui.ShelfLaunchedApps) has been updated to
ensure it continues passing after this CL is landed.

This is the second of a chain of 3 CLs:

1. crrev.com/c/2538305: Allow Files app to be pinned by default in
   ui.ShelfLaunchedApps
2. crrev.com/c/2538857: Add Files app to default shelf pins in second
   position
3. crrev.com/c/2538307: Update ui.ShelfLaunchedApps to ensure Chrome and
   Files are always pinned

Original change's description:
> CrOS: Add Files app to default shelf pins in second position
>
> This adds the Files app to the spot after the Chrome icon, for new users
> only. There's also some variations of the default pin layout controlled
> by a Finch experiment, I've moved the Files app up in those layouts for
> consistency.
>
> This change was requested for M88 and will be merged back.
>
> Bug: 1148519
> Change-Id: Iae54561fec599b813ba97e82a5678fa834a02db2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537214
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Auto-Submit: Tim Sergeant <tsergeant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827272}

Bug: 1148519
Change-Id: I9186b43a651dea4c4de9e46f849d35da9cc6062c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538857Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827981}