- 21 Aug, 2019 40 commits
-
-
Becca Hughes authored
If there has never been any playback on the page and we enter Picture-in-Picture then there will be no buttons on the window since there is no media session. Therefore, this adds a play button on the window until media session takes over. BUG=996001 Change-Id: I5cbb6d4f4a4b23c2a998c8b1a0cae628ee6a27ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762933Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#689072}
-
Scott Violet authored
This is the start of getting rid of the usage of MostVisitedURL::redirects from TopSites. It turns out the redirects can be *huge*. Redirects are used for only one thing, to optimize deleting a url. That is, when a url is deleted storing the redirects helped to avoid unnecessarily querying history. Given redirects can be huge, and deletion is infrequent, this optimization isn't worth it and I'm going to remove the complexity. This patch removes the optimization and changes TopSites to always query history after removal. Assuming this lands, and sticks, I plan to change around the database side and hopefully completely remove MostVisitedURL::redirects. BUG=995906 TEST=covered by tests Change-Id: Id0ec659e112776b89b69ad916ac5c7f6ab723f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762441 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#689071}
-
Vlad Tsyrklevich authored
GWP-ASan [1] is a probabilistic heap memory-error detector meant to be deployed in-the-wild. Add calls to initialize GWP-ASan during WebView initialization (gated by feature flags) and white list the annotations GWP-ASan uses to communicate with the crash handler. [1] https://chromium.googlesource.com/chromium/src/+/master/docs/gwp_asan.md CQ-DEPEND=chromium:1757160 Bug: 973167 Change-Id: Ib950dadc957dc4e4c2356a070fa8c7ec244299f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757430Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#689070}
-
Mohamed Amir Yosef authored
After recent fixes, Sync USS Bookmarks is ready for prime time. Change-Id: I34546e66e12f4b129e592375d3f0bf56654eb539 Bug: 516866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760948 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#689069}
-
Caleb Rouleau authored
1. Fix broken links. 2. Rename Speed Services to Speed Tooling. 3. Delete out of date information. 4. Add various links. 5. Rename speed_services.png to speed_operations.png I think this is better than speed_tooling.png since benchmarking team owns the perf waterfall, and that image contains details on that. 6. Remove Ben Henry from TPM role since Ushesh is doing that now. Bug: 949246 Change-Id: Iab0312ab86619c814c8d95f26dba4a5f2eeb78cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763091Reviewed-by:
Ben Henry <benhenry@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#689068}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ed4906f89d3d..1d83e1e8a17e git log ed4906f89d3d..1d83e1e8a17e --date=short --no-merges --format='%ad %ae %s' 2019-08-21 tobine@google.com Vulkan: Handle new validation errors Created with: gclient setdep -r src/third_party/angle@1d83e1e8a17e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org,jonahr@google.com Bug: None Change-Id: Ia988804c49ca2f3893da3060ba52955b7bb22496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763254Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689067}
-
Manu Cornet authored
Change-Id: I31fa43e85afc0cfe7f5d7be1b4c75b2200aa6e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764116 Commit-Queue: Manu Cornet <manucornet@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689066}
-
Sergey Ulanov authored
Now FuchsiaVideoDecoder uses sysmem to allocate output buffers instead of creating raw VMOs. The sysmem collection is shared with the GPU where it's passed to Vulkan. This means that decoded frames are now passed from mediacodec to Vulkan directly, without being touched by the renderer or the GPU process. Bug: 981026 Change-Id: I7dc8b48ceb0621966034e554897efd542af63a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752918Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689065}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a62c380dea04..6a337fb9b12b git log a62c380dea04..6a337fb9b12b --date=short --no-merges --format='%ad %ae %s' 2019-08-21 eseckler@google.com Merge "Improve Perfetto recording page" Created with: gclient setdep -r src/third_party/perfetto@6a337fb9b12b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I34636e88b7a79808a2a33493c7dff1f15bc499b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764109Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689064}
-
John Chen authored
testChromeDriverSendLargeData used to use string concatenation to generate a long string, which was slow and can timeout on slow devices. Improving efficiency by using String.repeat() instead, to make it fast enough for Android. Bug: chromedriver:1175 Change-Id: I9b030a43c82cdbe69c374718a307a66f57cf04a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763171Reviewed-by:
Rohan Pavone <rohpavone@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689063}
-
Fernando Serboncini authored
Bug: 993762 Change-Id: I5dbc59e201b5d89e881da9413018e4982864ee21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762471Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#689062}
-
Daniel Cheng authored
Spotted from https://twitter.com/ericlaw/status/1163552434297483265l Change-Id: Ieeff46753eb86ca811b2217d7f943bcd360e5155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763225 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#689061}
-
Christopher Thompson authored
After internal discussions, we've decided to hold off on infobar-ing use of SSLKEYLOGFILE for now. We'll add metrics on usage and plan a new rollout strategy later. Bug: 991290 Change-Id: Ie4382dd6cd7cd752199dd55f8841bd4781305be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760866Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#689060}
-
Matt Mueller authored
Plumb through the CertPathBuilder::Result as the debug_data object, so that the debug data will eventually end up in the CertVerifyResult. Bug: 991247 Change-Id: If6ffc2b993d878297b7e9845ef9edcb60f05afaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738671 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#689059}
-
Charlene Yan authored
BUG: 985382 Change-Id: I23728b033603a17f3a27fafad1b8396a65051b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758660 Commit-Queue: Charlene Yan <xialinyan@google.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#689058}
-
Ella Ge authored
This CL adds the linear interpolation that resample events to 5ms before frame time. This is trying to match the resampling behavior in Android. This CL also removes the "Disable prediction when dt < 0" check. The check is not valid when we resample to frame_time - 5ms. And according to UMA Event.Latency.ScrollBegin.Touch.EventTimeToRAFTime, we only have around 0.05% data that frame_time - last_event_time < 1ms. Bug: 969697 Change-Id: I5e08b4e8f158e7bae60ef3869c2d56ebadfe4fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761310 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689057}
-
Matt Mueller authored
[net] Make CertPathBuilder::Result subclass SupportsUserData and clone the data into the CertVerifyResult. Bug: 991247 Change-Id: Ic2f8567163d0baa737bd5eaf1aaecc493c908b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739119 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#689056}
-
Leonard Grey authored
Currently, AXPlatformNodeCocoa only provides mappings for a small subset of accessibility notifications. While some of these should be implemented, there are many accessibility notifications that either don't make sense at all on Mac, or only make sense in some contexts. However, right now we send an accessibility notification to the OS even if the event is unmapped, with |nil| as the notification. You might think that this would be a no-op, but empirically it makes VoiceOver request several accessibility attributes synchronously during the call. Bug: None Change-Id: Iea70fd0309065a9993c39e123d40c1697c8dbfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761365Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#689055}
-
Leonard Grey authored
The other methods in this file send value changed instead of text changed, which makes sense since we treat text changed as title/name changed. The text changed notification was added in https://codereview.chromium.org/2852763002, which I confirmed was unintended in offline conversation with nektar@ a few days ago. Bug: None Change-Id: I4b77b037e162fef13141bf60e79b20f933f1d50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762472Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#689054}
-
Vincent Boisselle authored
Bug: 996025 Change-Id: Idabb5b920cbb59b5e6132ad18ae0ee8be87a13ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761353 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#689053}
-
Alex Ilin authored
TBR: fhorschig@chromium.org Bug: 984489 Change-Id: I2597f82efc20e7617d40555b2897ec851d456fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760790Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#689052}
-
Saman Sami authored
If RunPendingMessages() triggers a root re-layout, |tabbed_pane_| and |child1| both will be resized to have the same width as |widget_| (which is 650) and the EXPECT_EQ below fails. Resize the root to (100, 200) to avoid this problem. Change-Id: I033869ce0ec148a8e54ed9592fc63d6109744257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763257Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#689051}
-
dalyk authored
The current limit on outstanding DNS requests does not need to apply to DoH requests. DoH requests will be treated by intermediary routers as HTTPS traffic rather than as DNS requests, and HTTP/2 offers mechanisms for DoH servers to control the number of outstanding requests if desired. This change prevents the deadlock that can occur when many DoH requests are all blocked on resolving a DoH server hostname. Request completion due to queue overflow eviction is now always handled asynchronously. Bug: 993905, 985589 Change-Id: I24510fb93dbf0c5c510949329e3dbcae5138b0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754187Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#689050}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/538193cb0f15..3654f21952d9 git log 538193cb0f15..3654f21952d9 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 saklein@chromium.org api/contrib README.md: Better explanation of gen_call_scripts. Created with: gclient setdep -r src/third_party/chromite@3654f21952d9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I824fe391e9b64d1c701918a44461c127f84db919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763066Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689049}
-
Elly Fong-Jones authored
This test has not flaked in 100 local runs. Let's see if we are lucky! Bug: 674475 Change-Id: I9b54547ae00b6188c61eb3702b2ba758284c0e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761366 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#689048}
-
Peter Collingbourne authored
After https://crrev.com/c/1756721 we stopped passing -nostdlib on Android, so the -nostdlib++ flag is not redundant and is in fact required in some configurations to prevent linking against the NDK libc++. Bug: 996172 Change-Id: Iabede8e5cafad29debf6b5f098a247f399cb460c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762346 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#689047}
-
Clark DuVall authored
This renames AwContentsIoThreadClient to AwContentsNetworkClient, since it can now be used on any thread. All of the methods from AwContentsIoThreadClient are thread safe since they either call AwSettings (thread safe), call AwServiceWorkerSettings (thread safe), get a background thread client which is only used on a background thread, or access a static bool set at startup (for the SW getSafeBrowsingEnabled). The RfhToIoThreadClientMap already used locks when accessing the map as well. Bug: 994948 Change-Id: I74c3a5e47072d4608810c106c03faf6a4d12d92f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759009Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#689046}
-
Avery Musbach authored
OverviewWindowDragController::should_allow_drag_to_close_ shall be named is_touch_dragging_ based on how it will be used to address Issue 995413. Other names, and comments, shall be updated to maintain consistency. Bug: 995413 Change-Id: Ie382d8a729b3f5459e5922e4150707af73daec67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761307 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#689045}
-
Lowell Manners authored
Change-Id: I9d2d671c004931d9af0d982ca19fad136a53bb72 Bug: 992423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746178 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#689044}
-
Chris Lu authored
To create BadgeMediatorTest, a few properties and methods in InfobarBadgeTabHelper were move to "protected" to allow for the fake subclass to use. Bug: 984974, 994045 Change-Id: I8834338adbf87d17ec5fa007903ac3db17e59672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762342 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#689043}
-
Chris Whelan authored
Bug: b/138672579 Test: Build Change-Id: I1b0b30c80b2a32fb48131ee8f5cd4cc9e9cf5a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729730 Commit-Queue: Christopher Whelan <chwhelan@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#689042}
-
Evan Stade authored
Apply the same fix that was applied to ProfileResetterTest.ResetExtensionsByDisabling in f1207e30 Bug: 995851 Change-Id: I7355cb199dfcae0017ce11315025f71533c021b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762813 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#689041}
-
Ben Pastene authored
But do strip them for tast tests on coverage bots. Tast is likely broken on the coverage bot right now, but the bot's stuck failing on compile, so I don't think anyone noticed. Bug: 995776 Change-Id: I3fbfe16133c876c110eddf0747e49f5ee7fdffe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762446Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#689040}
-
Melissa Galonsky authored
The Unity "Sync and Google services" link in settings doesn't have any error subtext. This is ok on desktop, when there are other ways of indicating that sync is broken in the settings UI, but is bad on Chrome OS, where the additional UI doesn't exist. This adds subtext telling a user to type in their passphrase to enable sync when sync isn't working due to a passphrase error to both desktop Chrome and Chrome OS. Screenshots when the user needs to enter their passphrase to test sync. CrOS, current, pre-Unity: https://drive.google.com/open?id=1E_YNkHjap68yghIAtLbDRBZkRym1jkc4 Desktop, current: https://drive.google.com/open?id=15eemM7tNZtJzMgBpgxY1TBTcNtMrZ4hI This Change: https://drive.google.com/open?id=1Plq5W6oewGGi24TaDcWujpO2xVZagsUi Bug: 985056 Change-Id: Icc9abe9ce3002eebf3cfc5d52fcded12c9ee848e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742350 Commit-Queue: Melissa Galonsky <mgalonsky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#689039}
-
Nazerke authored
Support dark mode for omnibox keyboard accessory view. Bug: 989488 Change-Id: I76d3f2d5b3dd55199ad90078286eca5ecf53585d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735383 Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#689038}
-
Donn Denman authored
Refactors the logic that allows insetting the Visual Viewport. Now the control is moved from RWHV to ViewAndroid and its delegates. This allows the setting to be established for an object with the same lifetime as a WebContents, so when a new RWHV is swapped in it will still apply. BUG=986384, 968150 Change-Id: I5cb3601ff460637f99e98a4edf090ad28321bc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714286Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#689037}
-
Kevin Bailey authored
Adds -fsanitize=bool to the list of check flags. This adds code to verify that, when reading a bool, it is 0 or 1. Change-Id: I709eb462a53fc37014ed1fd261f783722e4ff2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699228Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#689036}
-
Nazerke authored
Supports dark mode for tab grid. Bug: 988415 Change-Id: I1ceb5ae19e9480308b4df2a10b9716aad8e139a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726054Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#689035}
-
Andrew Lee authored
Change-Id: Ie7156b3b1e49b7dac4fa69c4b4f5ac089e6942c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762997Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> Cr-Commit-Position: refs/heads/master@{#689034}
-
Elly Fong-Jones authored
TBR=marinaciocea@chromium.org Bug: 996235 Change-Id: I38b2c62887f708511baa3c0c2ae1a794246baaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762470Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#689033}
-