- 16 Jan, 2020 37 commits
-
-
Michael Thiessen authored
The InstalledAppProviderTest suite uses AsyncTask, which apparently requires a BrowserTaskEnvironment for the AsyncTask to actually run (sometimes it runs anyways - I don't know why). Bug: 1041909 Change-Id: Ida7a8ee8296ce489b560cec00e3b0ca2c4d7d982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003751 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732227}
-
Rakib M. Hasan authored
R=isamsonov@google.com TBR=robertma@chromium.org Bug: 986447 Change-Id: I2f0e1ea4cdfb7ec2fd207db283663ca9d71eaaf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002900Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#732226}
-
Lukasz Anforowicz authored
Fixed: 1042360 Change-Id: I5e0cc2859131d8524e72b46964b398242da6f81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002943 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#732225}
-
Meredith Lane authored
This reverts commit af5c4bc1. Reason for revert: Deterministically crashes MSAN and debug CrOS builds, first failure here: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17319 Original change's description: > Fix message_center::MessageView::OnSlideOut UAF > > Bug: 983009 > Change-Id: Ie285c4035bfc4c45e27e5f3fd6c34280d9f4c2d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001943 > Reviewed-by: Peter Beverloo <peter@chromium.org> > Commit-Queue: Matthew Denton <mpdenton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732131} TBR=peter@chromium.org,tengs@chromium.org,mpdenton@chromium.org Change-Id: Ib8a7cfeaa6c81fca58cee2cbff7102a20ca1a474 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 983009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003167Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#732224}
-
Margaret Mary Kearney authored
Updating banner across Chrome apps docs for deprecation Change-Id: Ib29fc705ad37cc21c46eb7eb23daccf089a6d300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003112 Commit-Queue: Meggin Kearney <mkearney@chromium.org> Reviewed-by:
Meggin Kearney <mkearney@chromium.org> Reviewed-by:
Anthony LaForge <laforge@chromium.org> Auto-Submit: Meggin Kearney <mkearney@chromium.org> Cr-Commit-Position: refs/heads/master@{#732223}
-
Felipe Salazar authored
Per @thomasanderson, the current minimum requirement is GLIBC 2.19. Bug: b/145962051, b/147656572 Change-Id: I1625753c6b0a2332015b78394740f0dba5a01519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003254Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Felipe Salazar <felipesalazar@chromium.org> Auto-Submit: Felipe Salazar <felipesalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#732222}
-
James Darpinian authored
In https://crrev.com/c/1991969 I added a new, faster way to disable ARB_texture_rectangle support in ANGLE's shader translator. This change starts using it in Chrome, replacing the earlier change introduced in https://crrev.com/c/1842223 Bug: angleproject:3770 Change-Id: Ica718828581b49efc34230f9f53f28fdec77eb67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992548 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732221}
-
Yutaka Hirano authored
Introduce the following messages: - QuicTransport.SendFin - QuicTransportClient.OnIncomingStreamClosed Bug: 1011392 Change-Id: If15ffb5bc7e619489cfc6e748300247a56ec888b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993075Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#732220}
-
Ryan Sturm authored
This experiment is in canary/dev and should be moved to Beta. Bug: 1038774 Change-Id: I4fc9c44e2b68aa58f9eee7210a625103f45edb01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992684 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#732219}
-
Alexander Dunaev authored
This CL continues the refactor of X11 drag'n'drop code. Here some more code that does not depend on Aura or Views is moved from views::DesktopDragDropClientAuraX11 into ui::XDragDropClient. Bug: 1014860 Change-Id: I34a81a4a10866850659cbe8c053fe396be303b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000113Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#732218}
-
Lei Zhang authored
Guard plugin code with BUILDFLAG(ENABLE_PLUGINS) in enterprise_reporting and extensions sub-directories. Also exclude c/b/extensions/plugin_manager.* when plugins are disabled. Also make modified files lint free. Bug: 1027360 Change-Id: I60328f7dd8747da65d4ad0ae6507697186bf9af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997654 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#732217}
-
Alex Newcomer authored
Just add a test. Bug: 1042405 Change-Id: If115f047374428247f5b0ca199c235f7030ad225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003443 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#732216}
-
Demetrios Papadopoulos authored
Previously these were defined at the global scope, which does not play well with the tools used for migrating to Polymer3. It also pollutes the global namespace. Bug: 1026426 Change-Id: I8e99c6f83e78a8ac8e1a4073102f60abe70c6448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002002 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#732215}
-
jonross authored
Viz is on by default. This change removes the feature check. There were two remaining usages of the check in tests, this updates them Both pass when ran locally. IncompatibleApplicationsBrowserTest itself should have been unaffected. At the time others couldn't repro locally, but never tried debugging on swarming. The bot which demonstrated the failure no longer exists. So let's bring it back on. TEST=IncompatibleApplicationsBrowserTest, CastContentGpuClient Bug: 936425, 850517 Change-Id: I193ec76f311b093f3f1aa6cf609238a3c313134d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001554Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#732214}
-
Zhuoyu Qian authored
This CL update the function CacheStorageContext::DeleteForOrigin and BrowsingDataCacheStorageHelper::DeleteCacheStorage to use dedicated Origin type instead of GURL. Bug: 598424 Change-Id: I744de003425372eddb015da97beae099adbdae57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997435Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#732213}
-
Jay Harris authored
Previously, Nautilus and Nemo would know that file handling web apps could handle files, but not what types of files. This meant that web apps would not show up in the "Open With" menus of these file handlers. The cause of this issue was two fold: 1. xdg-desktop-menu install my-file.desktop only runs update-desktop-database when installing a system wide desktop file (in Chrome, we only ever install in user mode). 2. update-desktop-database doesn't run on ~/.local/share/applications unless explicitly requested to. This meant that the mimeinfo.cache file in ~/.local/share/applications (which these file managers use to determine what apps can open different mime types) was not being updated. The fix is to run update-desktop-database $XDG_DATA_HOME/applications after installing a new entry in the desktop menu, to ensure mimeinfo.cache is updated. Bug: 1027994 Change-Id: Ia71fa4d49030ecec6622a5b0ab8e18facc303274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002043 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#732212}
-
Miguel Casas authored
This CL replaces the DRM specific XB30 with AB30 where appropriate, and adds the necessary entries to support AB30 with SCANOUT usage. Test: forcing RGBA_1010102 as DisplaySnapshot::PrimaryFormat, and allowing for only an opaque FB (ToT wants both opaque and normal) the primary plane of the device is indeed XB30 as per /sys/kernel/debug/dri/0/state). and gl_unittests --gtest_also_run_disabled_tests and ozone_gl_unittests --gtest_also_run_disabled_tests AB30 test cases passing. Bug: 949260 Change-Id: Ie1841763b059971460597eded768a9a9827914b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960073Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#732211}
-
Weiliang Chen authored
Create OverlayProcessorOnGpu class which is an empty class on gpu thread. This uses the helper class created on previous CL. Following CLs will fill out its functionalities and make use of it. This is CL 2/? for sending the overlay candidates directly. R=rjkroege Bug: 979788 Change-Id: I50fb4e11bead2d990477cc056e807705340b39f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985301 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#732210}
-
Kenneth Russell authored
This reverts commit cc0504e5. Reason for revert: speculative revert suspecting this CL as the cause of recently introduced test flakes Original change's description: > blink: Ensure correct shared image lifetime for static bitmap images. > > AcceleratedStaticBitmapImages created by WebGL rely on creating a > GL texture backing for a shared image to ensure the shared image > outlives the StaticBitmapImage. This in turn assumes that even if the > client explicitly destroys a shared image mailbox via > SharedImageInterface, they can continue to use this mailbox as long as > an associated representation is alive. This pattern is not something we > want to support. > > This pattern also means that when a mailbox is stored on > SharedImageInterface, we can not safely assume that the metadata > associated with it can be cached correctly. > > This change fixes this by transitioning WebGL to use the same factory > method for creating StaticBitmapImages as used by canvas2d. This in > turn also does the following: > > 1) Ensures that the correct texture target is plumbed through with the > StaticBitmapImage. > 2) Eliminates the needs to plumb an image and a release callback through > a bunch of code. Since the image now owns the release callback. > 3) Cleans up code in MailboxTextureHolder used to keep the mailbox's > texture backing alive. > 4) TransferToImageBitmap currently works by marking the resource as > lost, which means it can not be recycled. These redundant > reallocations are avoided with this change. > > R=kbr@chromium.org > > Bug: 1036142 > Change-Id: I8824aa8d03a48e35e39744cc30c9d0313dcbed08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996124 > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Khushal <khushalsagar@chromium.org> > Auto-Submit: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732100} TBR=kbr@chromium.org,khushalsagar@chromium.org,altimin@chromium.org,klausw@chromium.org Change-Id: Ic8c98f5f67d7c93c7e401846d1ff508e2b7159dc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1036142, 1017162, 1042446, 1042481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003615Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732209}
-
Kunihiko Sakamoto authored
This extends all active SignedExchange histograms until 2020-10-01, and updates histogram owners appropriately. Bug: 1039320,1039319,1039318 Change-Id: Ieec4e5b07425aa881a395e44c748b8dce76800a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000405Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#732208}
-
Vladimir Levin authored
This patch gathers the metrics for rendersubtree activation in UMA. R=chrishtr@chromium.org Change-Id: Id431799f9ff145ddb6413e37e43be6708ba626a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999319 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732207}
-
Nick Harper authored
Change-Id: Ia8eda5c1457b10d67c4f5b6a4caadefae4bde211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003351 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#732206}
-
Yue Zhang authored
This CL introduces a new tab tile that always shows in the end of tab list in GTS. Clicking the new tab tile will create a new tab. New tab tile does not support any gesture and exists for both normal and incognito mode. Everything introduced in this CL is gated by field trail under the enable-tab-grid-layout flag. Light mode: https://drive.google.com/a/google.com/file/d/1B-8y4P3Pg-gyv9Z1eJ8wRP2PqEOHy-bV/view?usp=sharing Dark mode: https://drive.google.com/a/google.com/file/d/1DLwfIoDcfDfG2zyzLoiRigivYotauT87/view?usp=sharing NOTRY=true # Expediting. Only failed test is to be disabled. Bug: 1042304 Change-Id: Ia7bbb33ec8a93e0cd72e8d6e1c3663818c4ece8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999749 Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#732205}
-
Noel Gordon authored
main.html <html dir="$i18n{textdirection}... suggests we should always read text direction from that element (document.documentElement). Test: browser_tests --gtest_filter="*ExpandHorizontalScroll*" Bug: 992819, 1025581 Change-Id: I890d9dc83568485f1b10096cc7ede61b8dc3085e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002548 Auto-Submit: Noel Gordon <noel@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#732204}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ffdd58f5c0bf..a7b91502cd7f git log ffdd58f5c0bf..a7b91502cd7f --date=short --first-parent --format='%ad %ae %s' 2020-01-15 ianelliott@google.com Vulkan: Updated expectations after recent fixes Created with: gclient setdep -r src/third_party/angle@a7b91502cd7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jonahr@google.com Change-Id: I379cd2aa1c9bd4ce44637fba15c49a7c1d510951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003610Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732203}
-
Anupam Snigdha authored
This patch removes the code where the input panel policy was set to notify TSF about the handling of the software input panel(SIP) as currently it is handled by calling TryShow/TryHide APIs. Bug: 1031786 Change-Id: I600f09b8e4d722d4586b51c67ac1078c5b35fe9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999547 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#732202}
-
Dan Beam authored
This reverts commit 87042ab6. Reason for revert: Clean up CLs have now landed and support for cr.exportPath() is being removed from Closure Compiler's --chrome_pass. It'll still have runtime effects, but the compiler wont understand that cr.exportPath('a.b.c') translates to window.a.b.c. Original change's description: > Revert "Add cr.exportPath() to ESLint banned properties" > > This reverts commit 6f69db7b. > > Reason for revert: > > The cleanup CLs haven't landed yet cuz the tree is borked > (ex: https://crrev.com/c/1995802) > > NOTREECHECKS=true > NOTRY=true > > Original change's description: > > Add cr.exportPath() to ESLint banned properties > > > > R=dpapad@chromium.org > > > > Bug: 1028829 > > Change-Id: I6ff5518a178bd86a5ab13b8ef7d8bce52b9588fd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995947 > > Commit-Queue: Dan Beam <dbeam@chromium.org> > > Auto-Submit: Dan Beam <dbeam@chromium.org> > > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#730348} > > TBR=dbeam@chromium.org,dpapad@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1028829 > Change-Id: I57cca1d4367794050cbd571382b30f11e650d429 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999549 > Reviewed-by: Dan Beam <dbeam@chromium.org> > Commit-Queue: Dan Beam <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#730990} TBR=dbeam@chromium.org,dpapad@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1028829 Change-Id: I50af2fb35ab9ea9a7a73533499c5876f4a44d05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003920Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#732201}
-
Sahel Sharify authored
coverage.py is hardcoded to generate coverage files in html format. This makes comparison of the two generated reports harder. While the text format allows users to use diff. This cl changes the script so that the user can specify either "html" or "text" output format via --format arg. The default value is html. Change-Id: I80da2701e332cb4bcda20bb187b928a307e907bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003790 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#732200}
-
Natalie Chouinard authored
Bug: 1035928 Change-Id: I2fba181a68566c535f83e1f4ad7d13491de1f1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003221Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#732199}
-
Andrew Xu authored
The current code fails to adapt gesture scroll on scrollable shelf under RTL. This CL fixes the issue by inverting the sign of the scroll offset under RTL. Bug: 1042119 Change-Id: I1db81df09b6f0b4d54097c7bd5e746e84e6e903f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931438Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732198}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8d5e7c35c508..737bab4e36f5 Created with: gclient setdep -r src-internal@737bab4e36f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042278 Tbr: jbudorick@google.com Change-Id: Ie8f4a80144483aaafa5c713c86b29e03f09f0ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003748Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732197}
-
Robert Ma authored
In addition to console errors/warnings, we now accept alert/confirm/prompt as well. Also remove the temporary workaround added in crrev.com/c/1995474. Bug: 1041588 Change-Id: Ife40be2466db2b0d807d55252ca3c08b24889cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003608Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#732196}
-
Nick Harper authored
Change-Id: I293601adfc78aa56b52faa0dbed32ea5319256db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002942Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#732195}
-
Philip Rogers authored
This patch updates the CompositeCrossOriginIframes feature to promote (composite) cross-origin iframes. The original patch for this feature (https://crrev.com/708336) had a subtle bug because it did not change the self-painting status of the iframe's layer. To be composited, PaintLayers must be marked as self-painting (see: PaintLayerCompositor::CanBeComposited). This patch builds on the existing iframe compositing reason by adding a check for cross-origin frames in LayoutEmbeddedContent::RequiresAcceleratedCompositing. Because cross-origin changes now affect compositing, a call to Element::SetNeedsCompositingUpdate has been added when the cross-origin status changes in DocumentLoader::InstallNewDocument and LocalFrameView::CrossOriginStatusChanged. Bug: 1014273 Change-Id: I096fbad4921345df836b2a61c338cb4f4b5f79d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997639Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732194}
-
Klaus Weidner authored
Update the "source" link in samples to point to the Chromium modified versions. (The "View source on GitHub" link at the bottom still goes to the upstream immersive-web version.) For proposals/index.html, add a "variants" array that supports creating links to variants of the page with added query options, i.e. input source debugging for the AR samples. Change-Id: Iadba3107b18ebcb262ce10f46d708853ca119e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003396 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#732193}
-
Reid Kleckner authored
Clang recently disabled lax vector conversions by default, but Chromium relies on them. Add this flag until we can clean up the conversions. Skipping try bots because none of them should set llvm_force_head_revision, so this has no effect. TBR=thakis@chromium.org No-Try: True Bug: 1042470 Change-Id: Ibbb1c054f8bf72098e43694de2b22153bbc63fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003921Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732192}
-
James Vecore authored
The test OSSettingsBluetoothPageTest.AllJsTests started being flaky after https://crrev.com/c/1954273 landed. This CL re-enables the test suite while skipping the single flaky js test for now. There is a simple fix for the failing test of repeating the await waitForListUpdateTimeout() however it is not well understood why this is necessary so it needs further investigation. See bug https://crbug.com/1042352 for the followup. Fixed: 1035378 Change-Id: I161165c01650c58fb74c2710e2957ad83add0a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999065Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#732191}
-
- 15 Jan, 2020 3 commits
-
-
Peter Boström authored
Bug: chromium:1038731 Change-Id: I9762a30586a86b5bfef9ae4a234e952923f95cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002894 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#732190}
-
Mike Dougherty authored
This reverts commit 534ab452. Reason for revert: Fails to compile on device. See https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/120373 Original change's description: > Disable testKeyboardHideState on iPhone > > Bug: 1041878 > Change-Id: Iae445f1161e1bd6d3de32de61921b70a9c1ffa7e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001197 > Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732187} TBR=rohitrao@chromium.org,lindsayw@chromium.org,javierrobles@chromium.org Change-Id: Id2e2cab9737ba9d9bb3ff5bfedeb4c0595bb35a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1041878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003918Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#732189}
-
sangwoo authored
It seems .cc file was included by accident. Bug: NONE Change-Id: I09db820dcd46b6898b5da07ddb7baba0a20d1376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002270 Auto-Submit: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#732188}
-