GitLab

Before, the labels were not properly aligned. This patch aligns them by simplifying the css.

TEST=Enter Files.app, check carefully the headers. Click on the 'select all' checkbox.
BUG=175962

Review URL: https://codereview.chromium.org/12262032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182391 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175802


Review URL: https://chromiumcodereview.appspot.com/12223124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182390 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174219

Review URL: https://codereview.chromium.org/12225163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182388 0039d316-1c4b-4281-b951-d872f2087c98

This suppresses 'E:0214: Missing description in @return tag' errors from closure linter.

All changes are in comment, hence I believe this patch doesn't change any behavior.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12212160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182387 0039d316-1c4b-4281-b951-d872f2087c98

This Cl adds missing '@return' annotations of JSdoc. The description leaves '//TODO(JSDOC)'.

All the changes are in comment. I believe this change doesn't affect any behavior.

BUG=175657
TEST=none
TBR=mtomazs@chromium.org

Review URL: https://codereview.chromium.org/12254003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182386 0039d316-1c4b-4281-b951-d872f2087c98

Active network is marked as PROXY_AUTH_REQUIRED only after 3
consecutive failing attempts. This gives enough time for the network
stack to connect to the proxied network after proxy authenication.

BUG=174061
TEST=unit_tests:NetworkPortalDetectorTest.*


Review URL: https://chromiumcodereview.appspot.com/12263006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182385 0039d316-1c4b-4281-b951-d872f2087c98

Also make it impossible to call AddObserver on an individual list from outside BrowserList.
This is to make sure the paradigm becomes that the consumer code is in charge of checking for HostDesktopType (should he care) upon receiving an event; allowing AddObserver to be called on an individual list would put burden on the reader to understand whether the events are coming from multiple browser lists or a single one (which seems unecessary for now).

BUG=129187


Review URL: https://chromiumcodereview.appspot.com/12258019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182384 0039d316-1c4b-4281-b951-d872f2087c98

Reverts changes made to template_url.* in http://crrev.com/178755.

BUG=170390
R=dhollowa@chromium.org,pkasting@chromium.org,sky@chromium.org
TEST=none; no visible changes.


Review URL: https://chromiumcodereview.appspot.com/12250033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182381 0039d316-1c4b-4281-b951-d872f2087c98

Update some #includes in content/browser/dom_storage for headers that have been moved to the new Platform directory upstream

Review URL: https://chromiumcodereview.appspot.com/12226037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182380 0039d316-1c4b-4281-b951-d872f2087c98

This will allow us to propagate it to the directory so that the client-side
web-app can identify out-of-date hosts, as discussed in the referenced bug
(option 3 in Renato's comment).

BUG=173502


Review URL: https://chromiumcodereview.appspot.com/12221123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182379 0039d316-1c4b-4281-b951-d872f2087c98

Replace last couple of instances by chrome::GetTotalBrowserCount() as in https://codereview.chromium.org/12212120/.

oom_priority_manager.cc is ChromeOS only and thus only needs to care about the ash browser list.

BUG=129187

Review URL: https://chromiumcodereview.appspot.com/12211139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182378 0039d316-1c4b-4281-b951-d872f2087c98

Useful in SPDY 4 development.

This lands server change 420065749.

Review URL: https://codereview.chromium.org/12256004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182377 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182375 0039d316-1c4b-4281-b951-d872f2087c98

http://trac.webkit.org/log/?rev=142795&stop_rev=142724&verbose=on

TBR=

BUG=


Review URL: https://chromiumcodereview.appspot.com/12262021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182374 0039d316-1c4b-4281-b951-d872f2087c98

The previous (x) button was very tiny - 16x16 pixels, which may be too small when using a touchpad.
This patch modifies css so the x button's clickable area is extended to the surrounding paddings. As a result, it is much easier to cancel an operation.
Along the way, simplified css for actions.

TEST=Copy a large file and try to cancel. Also delete to check if Undo link is not broken.
BUG=175950

Review URL: https://codereview.chromium.org/12218135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182373 0039d316-1c4b-4281-b951-d872f2087c98

> Base: Disable the scoped handle verifier.
> 
> This cl is intended for the beta branch.
> 
> BUG=176188
> TEST=none
> Review URL: https://codereview.chromium.org/12230034

TBR=rvargas@google.com
Review URL: https://codereview.chromium.org/12212181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182372 0039d316-1c4b-4281-b951-d872f2087c98

Fixed misnamed function call in popup.js in Chrome Extension tutorial from kittensOnFlickr_ to searchOnFlickr_.

http://developer.chrome.com/extensions/getstarted.html
http://developer.chrome.com/extensions/examples/tutorials/getstarted/popup.js


BUG=172849

Review URL: https://chromiumcodereview.appspot.com/12207102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182371 0039d316-1c4b-4281-b951-d872f2087c98

The sync integration test SyncErrorTest.XmppAuthErrorTest was flaky on Mac due to typed_url_data_type_controller.cc not being able to access the history service.

It appears that recent changes have fixed the flakiness, and the test passes with large --gtest_repeat numbers. Enabling this once the trybots are satisfied.

BUG=165328
TEST=SyncErrorTest.XmppAuthErrorTest

Review URL: https://codereview.chromium.org/12252029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182370 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
R=ben@chromium.org

Review URL: https://codereview.chromium.org/12212013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182369 0039d316-1c4b-4281-b951-d872f2087c98

lack this property.


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182368 0039d316-1c4b-4281-b951-d872f2087c98

This cl is intended for the beta branch.

BUG=176188
TEST=none
Review URL: https://codereview.chromium.org/12230034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/12251002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182366 0039d316-1c4b-4281-b951-d872f2087c98

BUG=3541


Review URL: https://chromiumcodereview.appspot.com/11573066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182364 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174047


Review URL: https://chromiumcodereview.appspot.com/12263007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182363 0039d316-1c4b-4281-b951-d872f2087c98

Previouly we removed it from Win8 but it is really just something
that is experimental and now that Aura is deployed we don't want
the casual user to play with it. Accelerator entry is gone as well.

The menu entry is kept in debug mode

BUG=175036
TEST=menu entry is gone in canary, see bug
Review URL: https://codereview.chromium.org/12251009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182362 0039d316-1c4b-4281-b951-d872f2087c98

Fix naming of DevToolsAgentHostImpl::DipatchOnInspectorBackend (Dipatch -> Dispatch). Make it virtual and override in RenderViewDevToolsAgentHost.

Right now the overridden version just calls the parent method. Next CL will change this to allow for request interception and optional handling.
BUG=167100

Review URL: https://chromiumcodereview.appspot.com/12209107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182361 0039d316-1c4b-4281-b951-d872f2087c98

BUG=176144
TBR=sky

Review URL: https://codereview.chromium.org/12263021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182360 0039d316-1c4b-4281-b951-d872f2087c98

The setup_third_party.py script was hand-rolling an implementation of
os.path.relpath in order to be 2.5 compatible, and that was getting
confused when we had to generate forwarding headers from ninja's
intermediate directory.

This patch reworks the python code to use relpath (since we require 2.6 now)
and work the same way regardless of platform or headers being generated, so
that we can have a single code path.

Full details in the bug.

R=tony@chromium.org
BUG=175273

Review URL: https://codereview.chromium.org/12224087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182359 0039d316-1c4b-4281-b951-d872f2087c98

Always use NativeComboBoxViews on non-Aura Win.
Enable NativeComboBoxViewsTest on non-Aura Win.
Both of these are already used on CrOS and Win Aura.
See non-Aura Win differences at http://crbug.com/175843#c1

TODO(followup): Tweak behavior/appearance of Views impl.
TODO(followup): Nix [Win|Wrapper], flatten Views->ComboBox.

BUG=175843
TEST=Windows combo-boxes look and behave different, but sane.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12217151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182358 0039d316-1c4b-4281-b951-d872f2087c98

When we're on a small page whose WebKit layout size is equal to the
viewport size, and the viewport size grows, we don't have enough content
to fill the screen until the pending tree finishes rasterizing.  This
patch disallows drawing on the active tree when the viewport size
has recently changed.

NOTRY=true
BUG=173449


Review URL: https://chromiumcodereview.appspot.com/12212156

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182357 0039d316-1c4b-4281-b951-d872f2087c98

This is the preparation to replace upload urls to resource ids.
After this CL, InitiateUploadXXX methods can be supported on Drive API v2.

BUG=148632
TEST=Ran unit_tests


Review URL: https://chromiumcodereview.appspot.com/12207075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182356 0039d316-1c4b-4281-b951-d872f2087c98

The previous patch ahd this reversed.

BUG=174572
TBR=epenner,piman

Review URL: https://codereview.chromium.org/12256026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182355 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157270
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12220130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182354 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166496
TBR=cpu
Review URL: https://codereview.chromium.org/12230011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182353 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174937
TBR=raymes@chromium.org

Review URL: https://codereview.chromium.org/12263023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182350 0039d316-1c4b-4281-b951-d872f2087c98

this CL adds a glue interface so that AutofillDialogController can be more agnostic about where its data is coming from.

BUG=174937
TBR=thestig@chromium.org
committed

Review URL: https://codereview.chromium.org/12208070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182348 0039d316-1c4b-4281-b951-d872f2087c98

Relanding this as the original attempt caused a bunch of browser test and other failures because of an infinite
recursion crash. This occurred because the newly added helper function chrome::ShouldUseNativeFrame invoked the
ShouldUseNativeFrame function on the native widget passed in which as per this change calls back into the helper function
leading to an infinite recursion crash.

Fix is to only invoke the helper if the underlying native widget implementation of ShouldUseNativeFrame returns true.
This typically returns true if the aero theme is to be used on Windows.

To achieve this we need to mimic the implementation in BrowserFrameWin::ShouldUseNativeFrame in the
DesktopBrowserFrameAura::ShouldUseNativeFrame override.

The code in BrowserFrameWin::ShouldUseNativeFrame has been moved to a helper function ShouldUseNativeFrame
in the chrome namespace in the newly added files browser_frame_common_win.h/.cc.
This is invoked from BrowserFrameWin and from the DesktopBrowserFrameAura overrides.

BUG=175372
R=sky
Review URL: https://codereview.chromium.org/12261017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182347 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12230015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182346 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/12041062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182345 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/12262016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182344 0039d316-1c4b-4281-b951-d872f2087c98