- 12 Feb, 2020 3 commits
-
-
Darwin Huang authored
Bug: 1046261, 1049131 Change-Id: I5e221665da64079ddf33603fdb5d012402c5d465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045076 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#740478}
-
Kristi Park authored
Correction for https://crrev.com/c/2050494, MEMORY_SANITIZER should be ADDRESS_SANITIZER TBR=hbos@chromium.org,phoglund@chromium.org Change-Id: Ibeea898c6490d38e7ae5eb7b065cbf083f89b788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051264Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740477}
-
Sasha McIntosh authored
Extend Display::RemoveOverdrawQuads to track up to 10 occluding rects as a region in target space. cc::Region::GetRegionComplexity() exposes the number of rects contributing to a region. In the past, using regions as occluders without limiting the number of rects contributing to a region resulted in cases with significant CPU times. RemoveOverdrawQuadPerfTest benchmark results show little difference among kMaximumOccluderComplexity values when compared to pre-change results. See Occlusion Culling Improvements doc [1] for results details. [1] https://docs.google.com/document/d/1LeBa-f80FG4eioHpX706Th65FEoXcEzWmNgooZQyNSw/edit?usp=sharing#heading=h.dgeynqo2z2ly Test: viz_perftests Bug: 1022544 Change-Id: I1c844490fe57146d9448bcf408ee23dd627657ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040201 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#740476}
-
- 11 Feb, 2020 37 commits
-
-
Sergey Ulanov authored
Previously fidl_library GN template required namespace parameter. It was separate from library_name mainly to workaround the lack of string_replace() function in GN. But that's not a problem anymore. This change updates fidl_library template to make namespace parameter optional. Now library_name can contain complete name of a FIDL library, e.g. "fuchsia.ui.gfx". namespace is still supported and works as before. Also updated all FIDL targets to specify namespace as part of library_name. Bug: 1050252 Change-Id: I3de83e244b3ef32449e170f06933beb58198aa0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045000 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740475}
-
Nektarios Paisios authored
This patch starts the long journey of combining AXNodePosition and BrowserAccessibilityPosition into one class. It also takes a small step in combining AXTreeManager and AXTreeManagerMap into a single interface that will be used to manage a forest of AXTrees across Web, Views and chrome.automation. For now, this patch introduces TestAXTreeManager, which implements AXTreeManager and encapsulates AXTreeManagerMap. Currently, this class is used only in tests. The static method in AXNodePosition that is used to set a single AXTree as the tree to which the position belongs has been removed. This enables AXNodePosition to rely on the same tree ID as BrowserAccessibilityPosition at all its calls sites, especially in tests. An additional overload "GetNodeFromTree" has been added in AXTreeManager, that makes it easier to retrieve a node from the current tree without the need to always specify the tree ID. Some cleanup fixes have been introduced in test fixtures that now inherit from TestAXTreeManager. The constructors, destructors and move + assign operations have been fixed where they were missing or erroniously implemented, and some class comments have been cleaned up. R=dmazzoni@chromium.org, kschmi@microsoft.com, kbabbitt@microsoft.com Change-Id: I3d5e86e6e5ae77c2b47469d2c9eb44ae5093350e Bug: 1049261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039310 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#740474}
-
Brandon Wylie authored
TBR=jinsukkim@chromium.org Bug: 1051221 Change-Id: I57fdf8c492208c2cdd70ac0008c37f921dac450c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050578Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#740473}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b40d48a67c93..72e9f4d73f65 git log b40d48a67c93..72e9f4d73f65 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 cnorthrop@google.com Vulkan: Update bug number in KHR ES 3.1 expectations 2020-02-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 428455ca6121..45b9d01815d9 (2 commits) 2020-02-11 timvp@google.com Fix assignment of CacheOpResult::EnumCount Created with: gclient setdep -r src/third_party/angle@72e9f4d73f65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ifd6dbd40e1a118deaee976c9eaced7235bd62d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050813Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740472}
-
Kristi Park authored
This reverts commit ae806eaa. Reason for revert: Suspect for ExtendedCrashReportingTest.RecordsAnnotation and ActivityTrackerAnnotationTest.RegistersAtCreation components_unittests failures: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/99752 https://ci.chromium.org/p/chromium/builders/ci/win-asan/10270 Original change's description: > Refactor extended crash reporting initialization. > > Bug: 1044707 > Change-Id: I51ae9d5fd4d0972f9145927d265f36cef3a4e98c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037711 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740420} TBR=fdoray@chromium.org,bcwhite@chromium.org,chromium-reviews@chromium.org,joenotcharles@chromium.org,siggi@chromium.org,olivierlidupuis@gmail.com Change-Id: I019bfb0c1ce194dbe4c4f3237c9031851ec40b2e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050042Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7e12fc7c. With Chromium commits locally applied on WPT: 5579aad0 "SharedWorker: Name shared workers identically in credentials mode WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9b97e813d58e375c473b3546b359485fe27e338a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050991Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740470}
-
Nasko Oskov authored
We are currently lacking explicit coverage for web documents starting a navigation to WebUI document. This is currently handled by FilterURL, which disallows the navigation and rewrites the URL to about:blank#blocked. The CL adds explicit tests for this behavior and those should be changed as we move towards blocking the navigation instead of rewriting the URL. Bug: 1002276 Change-Id: Ie61558b55e4bb3c887844b53b91f731b1e7029e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044335 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#740469}
-
Brandon Wylie authored
TBR=chouinard@chromium.org Bug: 1051213 Change-Id: Id2b6c0d8929e5eb09d9a7a063d216ea324e1b540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051288Reviewed-by:
-
Vadim Bendebury authored
A lot of new boards and Cr50 versions have been released since these enums were introduced. The integers reported by UMA were converted to 4 byte ASCII and looked up in the RLZ database found at go/chromeos-rlz. BUG=none TEST=none Change-Id: I4623b495bd2461a1eaadb5c4543c4a1622064d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984627 Auto-Submit: Vadim Bendebury <vbendeb@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#740467}
-
Bo Liu authored
Implementation just list and returns all valid directories in the root profile directory. Bug: 1044581 Change-Id: I0cae48abf7ad6f2543478df582ef4e5d5b32f5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048945Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740466}
-
Scott Violet authored
This code is only compiled on android, so no need for chromeos ifdef. BUG=none TEST=none Change-Id: I4be1faeaf122d998a1b8aee4b5ccda31d85f0de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050924Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#740465}
-
Jinsuk Kim authored
This CL factors accessibility-related methods/interfaces out of ChromeActivity into its own class ChromeAccessibility. |updateAccessibiilityVisibility| in TabImpl was also moved to the new class, reducing the ChromeActivity's dependency on TabImpl. Bug: 995903 Change-Id: I2296aa25cbcee3e09f1fa48a5ba43ccb9eec92ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015919 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#740464}
-
Zhaoxin authored
Move RenderProcessHostObserver methods into CastWebContentsImpl. Remove CastBluetoothChooser with corresponding CastWebView::Delegate method. Merge-with: eureka-internal/361134 Bug: b/148898885 Test: CQ Change-Id: I2adce89c9b3baba5780211e58d5a3be48ff63171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051024Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Zhaoxin Liang <zxliang@google.com> Cr-Commit-Position: refs/heads/master@{#740463}
-
Daniel Cheng authored
Blink allows use of the //base histogram helpers, so switch away from the Blink-specific histogram helpers and standardize on //base. The long-term goal is to remove the Blink helpers, which differ from the //base ones in some interesting and surprising ways. Miscellaneous cleanup: - use the histogram functions where appropriate (i.e. for metrics that aren't recorded on performance-critical paths) - simplify enum histogram recording by changing the enum metric to be an enum class and defining kMaxValue where needed. Bug: 742517, 1047547 Change-Id: Iafa021a78e4640604e638e40dae0fc988606881a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046530Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#740462}
-
Jinsuk Kim authored
This reverts commit fb7edd8c. Reason for revert: Not the culprit! Original change's description: > Revert "Android: Remove OverlayPanel-based Preview Tab code" > > This reverts commit 928037da. > > Reason for revert: Speculative fix for a mysterious crash in > Contextual Search when animating the Overlay. Issue 1050431. > > BUG=1050431 > > Original change's description: > > Android: Remove OverlayPanel-based Preview Tab code > > > > Now that Preview Tab is working on top of ThinWebView and BottomSheet, > > this CL deletes the old implementation that based it on OverlayPanel. > > > > Bug: 1043677 > > Change-Id: Icccc93cca3f09e9ae122b1e0dcb7537331136ac0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032466 > > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Reviewed-by: Donn Denman <donnd@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#739094} > > TBR=dtrainor@chromium.org,donnd@chromium.org,yusufo@chromium.org,jinsukkim@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1043677 > Change-Id: I7c9fa71c3aba77e3e1c8938db8f1b9f7f28a2b22 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049206 > Reviewed-by: Donn Denman <donnd@chromium.org> > Commit-Queue: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740156} TBR=dtrainor@chromium.org,donnd@chromium.org,yusufo@chromium.org,jinsukkim@chromium.org Change-Id: Ifbf3c03cc955bd942bfbcbf791cbddac8cf96e70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050431, 1043677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050404Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#740461}
-
Thanh Nguyen authored
This CL adds a UMA metricthat records number of result list launch with non-empty query. It also makes GetLastQueryLength() returns trimmed query length instead of raw query length. Bug: 1006133 Change-Id: I42eb211d4b45682ca1b55d66f9a205ab4c0e0f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999967 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#740460}
-
Stephen Chenney authored
TBR: fs@opera.com Bug: 1050993 Change-Id: I19a00d98ca20e2b1430cde0dc7640313f4177d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050166Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#740459}
-
Manu Cornet authored
Reuse the existing ShelfAnimationWaiter and generalize it a little bit. TBR: mmourgos Bug: 1050788 Change-Id: Ica852940cb765143c242c2fa3f101c28cca6922a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051025Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#740458}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6a8f7c51bda2..9badae8a5df5 git log 6a8f7c51bda2..9badae8a5df5 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 treehugger-gerrit@google.com Merge "Change min PowerDataSource poll interval to 100ms." 2020-02-11 primiano@google.com Merge "Add install-build-deps check at build time" Created with: gclient setdep -r src/third_party/perfetto@9badae8a5df5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1a2e5b19ce6c75c5e7e2d326aececcdd47f7b5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051126Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a0453d55f721..6cbb02e0dc93 git log a0453d55f721..6cbb02e0dc93 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 bclayton@google.com CMakeLists: Drop the explicit include path to marl Created with: gclient setdep -r src/third_party/swiftshader@6cbb02e0dc93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ibf1a344e6fb8b2ed2646efbfd68d6b6517cbcc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050845Reviewed-by:
-
Sajjad Mirza authored
Modify scripts that indirectly use it to include the new location into sys.path so that they are not implicitly using a copy of six that is installed in the environment. Bug: 1004616,1047519 Change-Id: I7d5054802a57744933f038ea0b58af8f7f4314a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043078Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#740455}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae99dcadb384..471fa4f0aff2 git log ae99dcadb384..471fa4f0aff2 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 borenet@google.com [infra] Update infra dep to fix Housekeeper-PerCommit-PushAppsFromWASMDockerImage 2020-02-11 herb@google.com Move scaler context fallback to GDI Created with: gclient setdep -r src/third_party/skia@471fa4f0aff2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: If297dabeeb018bd2b85d3b1742599bae15a3f5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050575Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/713d9cbf939e..2fd618192985 git log 713d9cbf939e..2fd618192985 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 natlee@microsoft.com Handle Device Lost for SwapChain Created with: gclient setdep -r src/third_party/dawn@2fd618192985 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib1871485dfbeb1e0a5ce4160898eb89b02c6c37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050725Reviewed-by:
-
Scott Violet authored
This better conveys what the object does. BUG=none TEST=none Change-Id: I21df5bcf0eca88184ace9a479e35b0e76a4be595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051018 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#740452}
-
George Steel authored
Merge CSSAdditiveAnimations and StackedCSSPropertyAnimations into WebAnimationsAPI flag. These were unlabeled dependencies of features being added under WebAnimationsAPI but not explicitly listed and are planned to launch as part of the WebAnimations v1 launch. Bug: 978551 Change-Id: If49801b1f4e3e76d3de552b53d3a2afe36e8b736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044540 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#740451}
-
Scott Violet authored
from weblayer/browser to weblayer/browser/persistence BUG=none TEST=none Change-Id: I57a953381066548f3cd02e6858b5ee40f63437ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050936Reviewed-by:
-
Xing Liu authored
ForegroundServiceUtils.startForeground is put to downstream when Android Q sdk is not published. Now the default SDK is Q, so we can upstream it now. There will be 2 following CLs to delete the function in AppHooks.java. TBR=dtrainor@chromium.org Bug: 1051183 Change-Id: I1d2f43c4c102c4f60073e3c6dc882f9cce885ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051171Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740449}
-
Ben Pastene authored
This reverts commit 2c8f8ff6. Reason for revert: New LKGM updates have landed. Could be safe to re-enable. Original change's description: > Disable all failing capture_unittests after latest Chrome OS LKGM update. > > These tests have started failing after fec354dc. > > Tbr: guidou@chromium.org > Bug: 1048934 > Change-Id: Id54e609d286cea6c4b2506edc11c3bc1433d46c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038253 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738428} TBR=guidou@chromium.org,bpastene@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048934 Change-Id: I3b06ed57ad1544cf1e7969143140d1c50ebc0559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050574Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#740448}
-
Leonard Grey authored
This reverts commit 34d7e5df. Reason for revert: Speculative fix in patchset 2 Original change's description: > Revert "Mac: windows always display as key if a child is key" > > This reverts commit e8438fe0. > > Reason for revert: https://crbug.com/1050430 > > Original change's description: > > Mac: windows always display as key if a child is key > > > > On other platforms, user expectation is that a parent window will display > > as inactive when a modal is showing. This isn't the case on Mac. > > > > Additionally, the code that passes key commands up to the parent window > > uses this status to determine whether to pass keys from child windows up. > > > > This change (hopefully) shows a window as active iff a child is active. > > It plays well with the current code that handles this for bubbles because > > PaintAsActive is now reference counted. > > > > Still outstanding: making a non-key child window key *does* cause the > > browser frame to be drawn as key and *does* handle hotkeys correctly, > > but does *not* fix the traffic lights until the browser window has been > > interacted with. > > > > Bug: 1046540 > > Change-Id: I1629e66457c42b268c2283a8dbeb6823c66b1111 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033432 > > Commit-Queue: Leonard Grey <lgrey@chromium.org> > > Reviewed-by: ccameron <ccameron@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#739444} > > TBR=ccameron@chromium.org,lgrey@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1046540 > Change-Id: Ic25e1562df10809be9cdc9cd886fbf794b96b3c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047085 > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739878} TBR=ccameron@chromium.org,lgrey@chromium.org Change-Id: I6ac87880427b118ab06b822f7372e3b345dab86e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048144Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#740447}
-
Hiroshige Hayashizaki authored
Bug: 906850 Change-Id: Iceeb534baa175b6615bc69cfad921759ad460e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895926 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#740446}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87e60d9c3b30..3bc454cda8bc Created with: gclient setdep -r src-internal@3bc454cda8bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041701,chromium:1044741,chromium:827542 Tbr: jbudorick@google.com Change-Id: Ie68538e37a6b0d5428eafb4a8543aa1ce8faa712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051086Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740445}
-
Darwin Huang authored
Remove extraneous namespacing in //ui/base/clipboard. Refactoring change. No intended functional changes. Change-Id: I079079bf7eb4d99cb2dacc51cf977b22e58a89e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047988 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
shrekshao authored
From OpenGL spec 4.2 GL_COMPRESSED_RED_GREEN_RGTC2_EXT Each 4 × 4 block of texels consists of 64 bits of compressed unsigned red image data followed by 64 bits of compressed unsigned green image data. GL_COMPRESSED_SIGNED_RED_GREEN_RGTC2_EXT Each 4 × 4 block of texels consists of 64 bits of compressed signed red image data followed by 64 bits of compressed signed green image data. TBR=kbr@chromium.org Bug: 1013369 Change-Id: Ie17e2224d725059e88b22851d1b60a6e9d88430f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050615Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#740443}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d0da7b4d..56ab990e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifdc4de6683b74e27faaf4ec230a8f8e4c7512b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050989Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740442}
-
Vasiliy Telezhnikov authored
This CL caches SkSurface in SharedImageRepresentationSkiaGL. Creating surface around texture requires creation FBO and is costly. This change saves 100us in DrawToSwapUs in local telemetry run. Bug: 1051195 Change-Id: I5b5911c731b0a57710f0f9db0df8b25308704c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049911 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#740441}
-
Mohamed Heikal authored
These histograms are still required for tracking the number of chrome startups in reduced mode vs full browser, at least while experiments on the former are still ongoing. Bug: 1039317 Change-Id: I8423c4c9550159ec67766ee1f91f9180edfceb31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048305 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
Brandon Wylie authored
Bug: 1051173 Change-Id: I48c24823d29619b1f30e640f620c048aa40f705b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044485 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#740439}
-
