- 25 Feb, 2015 40 commits
-
-
earthdok authored
Those are now compiled into the executable. Also remove tools/lsan/ which used to house the suppressions file. BUG=302040 R=kjellander@chromium.org Review URL: https://codereview.chromium.org/940033002 Cr-Commit-Position: refs/heads/master@{#318035}
-
nednguyen authored
Revert of Enabled gpu_times metrics. (patchset #1 id:1 of https://codereview.chromium.org/937073003/) Reason for revert: Causing not redness. Original issue's description: > Enabled gpu_times metrics. > > The issue where gpu_times would use too much memory has been fixed: > https://codereview.chromium.org/920523002 > > In order to prepare for future changes where additional metrics > will be added to the TBM module, I have also preemptively added a > filter function which filters out values relating to gpu_times. > > R=nednguyen@chromium.org > BUG=455292, 453131 > TEST=local runs measuring memory usage shows ~700mb > > Committed: https://crrev.com/ed5b27a7459e35248992fd5549b72b5731a8baa4 > Cr-Commit-Position: refs/heads/master@{#317974} TBR=dyen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=455292, 453131 Review URL: https://codereview.chromium.org/952133003 Cr-Commit-Position: refs/heads/master@{#318034}
-
timvolodine authored
This test is flaky on Linux Tests (dbg) bot. BUG=298193 TBR=arv@chromium.org,creis@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/948023003 Cr-Commit-Position: refs/heads/master@{#318033}
-
rsorokin authored
BUG=459475 Review URL: https://codereview.chromium.org/957673003 Cr-Commit-Position: refs/heads/master@{#318032}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/b36e957..9bbb321 TBR=arv@chromium.org Review URL: https://codereview.chromium.org/956833003 Cr-Commit-Position: refs/heads/master@{#318031}
-
earthdok authored
BUG=459588 TBR=glider@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/952173002 Cr-Commit-Position: refs/heads/master@{#318030}
-
afakhry authored
This to make sure that after login, the system tray is always visible and within the bounds of the screen. R=nkostylev@chromium.org BUG=372838 TEST=interactive_ui_tests --gtest_filter=Login*Test.* Review URL: https://codereview.chromium.org/922463005 Cr-Commit-Position: refs/heads/master@{#318029}
-
perkj authored
Adding MockVideoSource::Stop and ::Restart so that the interface can be made pure virtual. Review URL: https://codereview.chromium.org/956883002 Cr-Commit-Position: refs/heads/master@{#318028}
-
vasilii authored
Also fix the alignment in the "Blacklisted" bubble. BUG=400674 Review URL: https://codereview.chromium.org/942743003 Cr-Commit-Position: refs/heads/master@{#318027}
-
tfarina authored
This directory is almost empty except for this OWNERS file. BUG=None R=jcivelli@chromium.org Review URL: https://codereview.chromium.org/954633002 Cr-Commit-Position: refs/heads/master@{#318026}
-
alph authored
BUG=406277 Review URL: https://codereview.chromium.org/792903003 Cr-Commit-Position: refs/heads/master@{#318025}
-
phoglund authored
Revert of Revert of [DevTools] Check request_id in DevToolsUIBindings::IndexPath (patchset #2 id:40001 of https://codereview.chromium.org/956873002/) Reason for revert: Turns out the revert was incorrect (the error even started happening a couple builds before this patch). Original issue's description: > Revert of [DevTools] Check request_id in DevToolsUIBindings::IndexPath (patchset #1 id:1 of https://codereview.chromium.org/951953002/) > > Reason for revert: > Speculative revert: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/4683/steps/browser_tests%20on%20Mac-10.6/logs/DevToolsSanityTest.TestReattachAfterCrash became very flaky on Mac OS X 10.6 about when this patch was introduced. This is the only devtools change near to the start of the flakiness. > > The errors are: > DevToolsSanityTest.TestReattachAfterCrash (run #1): > [ RUN ] DevToolsSanityTest.TestReattachAfterCrash > [32422:28675:0224/105826:WARNING:data_reduction_proxy_config.cc(211)] SPDY proxy OFF at startup > HTTP server started on http://127.0.0.1:64960... > sending server_data: {"host": "127.0.0.1", "port": 64960} (36 bytes) > [32427:9479:0224/105828:WARNING:channel.cc(547)] Failed to send message to ack remove remote endpoint (local ID 1, remote ID 1) > [32427:9479:0224/105828:WARNING:channel.cc(547)] Failed to send message to ack remove remote endpoint (local ID 2147483648, remote ID 2 > > Original issue's description: > > [DevTools] Check request_id in DevToolsUIBindings::IndexPath > > > > If request_id is reused before the previous job with the same id is finished the old job won't be stopped in ~DevToolsUIBindings. > > > > BUG= > > > > Committed: https://crrev.com/88ac3ce8fa6463e5f04d4b3e7e2327e2ec1b3a19 > > Cr-Commit-Position: refs/heads/master@{#317799} > > TBR=dgozman@chromium.org,vkuzkokov@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/012bebf20cabd5a81179a185b87bd75f632edb66 > Cr-Commit-Position: refs/heads/master@{#318019} TBR=dgozman@chromium.org,vkuzkokov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/957623003 Cr-Commit-Position: refs/heads/master@{#318024}
-
primiano authored
This is a follow-up to crrev.com/928723004. It introduces the code which is able to read and parse the /proc/.../smaps file into an actual TraceValue and the corresponding unittest. BUG=460884 Review URL: https://codereview.chromium.org/951463002 Cr-Commit-Position: refs/heads/master@{#318023}
-
ksakamoto authored
This fixes a task ordering bug between WebMessagePortChannelImpl and ServiceWorkerScriptContext. The former posts tasks via the Blink scheduler's default task queue, and the latter was using the MessageLoop directly. This patch makes tasks from service worker to the main thread go through the scheduler. BUG=460833 TEST=http/tests/serviceworker/postmessage-msgport-to-client.html Review URL: https://codereview.chromium.org/958523002 Cr-Commit-Position: refs/heads/master@{#318022}
-
perkj authored
If the security origin of frame is not the same as its ancestors, we don't use preset allow. We should then not sticky store deny either. BUG=456628 Review URL: https://codereview.chromium.org/929253004 Cr-Commit-Position: refs/heads/master@{#318021}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/648ff04..b36e957 TBR=arv@chromium.org Review URL: https://codereview.chromium.org/956863002 Cr-Commit-Position: refs/heads/master@{#318020}
-
phoglund authored
Revert of [DevTools] Check request_id in DevToolsUIBindings::IndexPath (patchset #1 id:1 of https://codereview.chromium.org/951953002/) Reason for revert: Speculative revert: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/4683/steps/browser_tests%20on%20Mac-10.6/logs/DevToolsSanityTest.TestReattachAfterCrash became very flaky on Mac OS X 10.6 about when this patch was introduced. This is the only devtools change near to the start of the flakiness. The errors are: DevToolsSanityTest.TestReattachAfterCrash (run #1): [ RUN ] DevToolsSanityTest.TestReattachAfterCrash [32422:28675:0224/105826:WARNING:data_reduction_proxy_config.cc(211)] SPDY proxy OFF at startup HTTP server started on http://127.0.0.1:64960... sending server_data: {"host": "127.0.0.1", "port": 64960} (36 bytes) [32427:9479:0224/105828:WARNING:channel.cc(547)] Failed to send message to ack remove remote endpoint (local ID 1, remote ID 1) [32427:9479:0224/105828:WARNING:channel.cc(547)] Failed to send message to ack remove remote endpoint (local ID 2147483648, remote ID 2 Original issue's description: > [DevTools] Check request_id in DevToolsUIBindings::IndexPath > > If request_id is reused before the previous job with the same id is finished the old job won't be stopped in ~DevToolsUIBindings. > > BUG= > > Committed: https://crrev.com/88ac3ce8fa6463e5f04d4b3e7e2327e2ec1b3a19 > Cr-Commit-Position: refs/heads/master@{#317799} TBR=dgozman@chromium.org,vkuzkokov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/956873002 Cr-Commit-Position: refs/heads/master@{#318019}
-
phoglund authored
It's pretty clear from the sizes graph (http://goo.gl/zdhb0b) that the cl https://codereview.chromium.org/905023005 causes an increase of 40k of nacl_helper on Linux x64. As per Chrome policy on which states that increases < 100k are alright. http://dev.chromium.org/developers/tree-sheriffs/perf-sheriffs says: "If sizes fails and the jump is <100k, update expections." TBR=bbudge CC=piman,llandwerlin,jam,wfh BUG=455409 Review URL: https://codereview.chromium.org/929483006 Cr-Commit-Position: refs/heads/master@{#318018}
-
bratell authored
Followup to https://codereview.chromium.org/890873007 which moves webkit/common/gpu/context_provider_web_context.h to cc/blink/context_provider_web_context.h. R=tfarina@chromium.org,jamesr@chromium.org,piman@chromium.org BUG=459058,338338 Review URL: https://codereview.chromium.org/954733002 Cr-Commit-Position: refs/heads/master@{#318017}
-
bratell authored
Followup to https://codereview.chromium.org/920963003 which removed media/base/scoped_histogram_timer.h. R=rkaplov@chromium.org,dalecurtis@chromium.org BUG=459058 Review URL: https://codereview.chromium.org/948423002 Cr-Commit-Position: refs/heads/master@{#318016}
-
blundell authored
//build/module_args/mojo.gni is the canonical place for setting information that might differ between repos, such as the location of the Mojo SDK. Review URL: https://codereview.chromium.org/956573002 Cr-Commit-Position: refs/heads/master@{#318015}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/675f7d2d..fbb26b21 Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/957703002 Cr-Commit-Position: refs/heads/master@{#318014}
-
vitalybuka authored
PrivetHTTPAsynchronousFactoryImpl can use ServiceDiscoverySharedClient::GetInstance. Also we don't use this for testing, so we can simplify interface. BUG=461504 Review URL: https://codereview.chromium.org/959503003 Cr-Commit-Position: refs/heads/master@{#318013}
-
merkulova authored
Following the bug discussion the photo was slightly changed. BUG=151287 Review URL: https://codereview.chromium.org/951303002 Cr-Commit-Position: refs/heads/master@{#318012}
-
tkent authored
It was removed by #317969. The test result is updated due to Blink r190795. Difference of the test result: - state, expire_month, expire_year have values of the second OPTION element, not the first OPTION element. BUG=461586 TBR=estade@chromium.org Review URL: https://codereview.chromium.org/959623002 Cr-Commit-Position: refs/heads/master@{#318011}
-
sammc authored
BUG=11746 Review URL: https://codereview.chromium.org/918933002 Cr-Commit-Position: refs/heads/master@{#318010}
-
vabr authored
This CL removes CheckPasswordChangesWithResult, because unlike in the other native backend tests, this method was not used inside base::Bind, and so is less useful than confusing. It also removes a global std::vector in favour of replacing it with a pointer to a test-owned instance, and turns that instance into a ScopedVector. BUG=461385 Review URL: https://codereview.chromium.org/951883005 Cr-Commit-Position: refs/heads/master@{#318009}
-
vkuzkokov authored
BUG=458979 Review URL: https://codereview.chromium.org/925483002 Cr-Commit-Position: refs/heads/master@{#318008}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/341bffc..648ff04 TBR=hiroshige@chromium.org,arv@chromium.org Review URL: https://codereview.chromium.org/959603002 Cr-Commit-Position: refs/heads/master@{#318007}
-
mtomasz authored
Before, the entire vertical bar was accepting clicks, so it was hard to select items in grid view when starting from far right. TEST=Tested manually by trying to click around the scrollbar thumb (button). BUG=461728 Review URL: https://codereview.chromium.org/956843002 Cr-Commit-Position: refs/heads/master@{#318006}
-
hirono authored
The CL just adds new metadata model as a member varaiables of gallery models. The following CL replaces existing metadata model with the new model. BUG=410766 TEST=None Review URL: https://codereview.chromium.org/944163004 Cr-Commit-Position: refs/heads/master@{#318005}
-
christiank authored
This CL adds support for compressed GPU buffer formats. BUG=434699 Committed: https://crrev.com/3113db1250a2687c030585f6045f2ef242b98db6 Cr-Commit-Position: refs/heads/master@{#317765} Review URL: https://codereview.chromium.org/916083002 Cr-Commit-Position: refs/heads/master@{#318004}
-
hirono authored
Previously the image DOM in the list is removed for reusing for another item unintentionally. Thanks to ListThumbnailLoader we no longer need to reuse DOM. BUG=461338 TEST=None Review URL: https://codereview.chromium.org/955933002 Cr-Commit-Position: refs/heads/master@{#318003}
-
pneubeck authored
This removes all includes from $X.cc files where the $X.h has the same include to conform to the style guide: "[...] However, any includes present in the related header do not need to be included again in the related cc (i.e., foo.cc can rely on foo.h's includes)." BUG=460988 Review URL: https://codereview.chromium.org/947173002 Cr-Commit-Position: refs/heads/master@{#318002}
-
tengs authored
This id should not change if the same user is removed and added to the same device. BUG=455515 TEST=removed account, added account back and id is still the same Review URL: https://codereview.chromium.org/877033005 Cr-Commit-Position: refs/heads/master@{#318001}
-
jackhou authored
Other platforms renamed their class names in r251542: https://codereview.chromium.org/166573005 BUG=344082 Review URL: https://codereview.chromium.org/918063002 Cr-Commit-Position: refs/heads/master@{#318000}
-
hirono authored
BUG=410766 TEST=None Review URL: https://codereview.chromium.org/957663003 Cr-Commit-Position: refs/heads/master@{#317999}
-
nyquist authored
Currently the adb_remote_setup.sh uses the SVN repository to update itself. Given that chromium has moved hosting to use git, it should use that repository as its canonical source. Gitiles currently does not have support for directly downloading the raw contents of a file, but it is possible to download it as base64 encoded data. This is a security precaution to ensure that browsers do not accidentally act upon the downloaded data. More info can be found in this issue: https://code.google.com/p/gitiles/issues/detail?id=7 This CL updates the canonical script URL, and changes the update-self function to base64 decode the downloaded data before storing it in the new script file. BUG=None Review URL: https://codereview.chromium.org/926973002 Cr-Commit-Position: refs/heads/master@{#317998}
-
kenobi authored
Break a circular reference which was causing FileManagerPrivateComputeChecksumFunction to never be cleaned up. This, in turn, was holding open one file stream for every file for which a content checksum was requested. BUG=458624 Review URL: https://codereview.chromium.org/950423003 Cr-Commit-Position: refs/heads/master@{#317997}
-
nektar authored
Fixed IAccessibleText::TextAtOffset with IA2_TEXT_BOUNDARY_WORD to return text that spans from the start of one word to the start of the next. BUG=347852 R=dmazzoni@chromium.org Review URL: https://codereview.chromium.org/660633002 Cr-Commit-Position: refs/heads/master@{#317996}
-