GitLab

This reverts commit 9311d412.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 577500 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzkzMTFkNDEyNTNmYzc0ZDQ5NTI3ZmIyZWU2OWUwMzYzMzM0Yjk2OWQM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/41118

Sample Failed Step: viz_content_unittests

Original change's description:
> Reland "[Background Fetch] Move all updatable UI options to their own proto."
> 
> This is a reland of d3981964
> 
> TBR=avi@chromium.org
> 
> Original change's description:
> > [Background Fetch] Move all updatable UI options to their own proto.
> >
> > Bundle up the icon and the title since they will be accessed/modified
> > together in the updateUI call.
> >
> > It also makes sense to move the icon from the metadata proto since that
> > will speed up getting the registration info.
> >
> > TBR=avi@chromium.org
> >
> > Bug: 865063
> > Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593
> > Reviewed-on: https://chromium-review.googlesource.com/1146650
> > Commit-Queue: Rayan Kanso <rayankans@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Reviewed-by: Peter Beverloo <peter@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#577272}
> 
> Bug: 865063
> Change-Id: I77567e8e2e0ea59ede514c77b40326e7ece48a25
> Reviewed-on: https://chromium-review.googlesource.com/1148261
> Commit-Queue: Rayan Kanso <rayankans@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577500}

Change-Id: I60aa46070806c053cc60d77b32456d192de378c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 865063
Reviewed-on: https://chromium-review.googlesource.com/1148500
Cr-Commit-Position: refs/heads/master@{#577559}

Things still look wrong even with this patch, because the Y coordinate is also
wrong; that's a deeper issue tracked in bug 866671.

Bug: 866665
Change-Id: I6a5f8fb159b3a70d71d1d17c904d2bd2d6d4fc6f
Reviewed-on: https://chromium-review.googlesource.com/1147085Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577558}

Elf reloc code will go in reloc_elf.

Change-Id: Ibc93aef1cbf03a1df7b29ddf088498a70c4d3722
Reviewed-on: https://chromium-review.googlesource.com/1145688Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577557}

TBR=stevenjb@chromium.org

Bug: 866904
Change-Id: Iec0f3ffc77048afa1947605e9488860c7bcc08df
Reviewed-on: https://chromium-review.googlesource.com/1148548Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577556}

https://chromium.googlesource.com/catapult.git/+log/2a64e6b6d554..ca2b32c84463


git log 2a64e6b6d554..ca2b32c84463 --date=short --no-merges --format='%ad %ae %s'
2018-07-24 mythria@chromium.org Adds v8_tools directory in experimental branch


Created with:
  gclient setdep -r src/third_party/catapult@ca2b32c84463

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:866423
TBR=sullivan@chromium.org

Change-Id: Ia266121b72045f2def4532bc76b1cb1c85b968b5
Reviewed-on: https://chromium-review.googlesource.com/1147908Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577555}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8c06b38fa0133336f1a85f73a29b54a44a148505
Reviewed-on: https://chromium-review.googlesource.com/1141953Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577554}

Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1142589
Reverted for test flakiness on Fuchsia.
Implementation is fine (this is a diagnostic metric -- this change
definitely doesn't make it worse). The test was only added to ensure
proper logging on UI thread only. Made the test more robust in this
reland (see diff vs PS1). If it flakes again, please disable it on flaky
platforms instead of reverting.


Original change's description:

Addresses crbug.com/860801 in time for the M69 branch while keeping the
diagnosis signals which will be used to assess future improvements
(MessageLoop.DelayedTaskQueueForUI.PendingTasksCountOnIdle that is).

Removed MessageLoop.DelayedTaskQueue.PostedDelay as we've
learnt everything we needed from this one, that is :
We now know that while 99% of tasks are posted with a delay under 30s,
95% of users post at least one task in every portion of the 0ms-3hours
range at least once per day:
https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.DelayedTaskQueue.PostedDelay&fixupData=true&uniqueUsers=true&showMax=true&filters=platform%2Ceq%2CW%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial

Removed MessageLoop.ScheduledSleep.* metrics as we've also
learnt what we wanted from it, that is :
The maximum sleep a MessageLoop ever completes is 1 hour (and
even then 99% of completed sleeps are under 1 second), all
longer delays are reliably always interrupted.
Win : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
Mac : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
Android : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CA%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial

Added a test for MessageLoop.DelayedTaskQueueForUI.PendingTasksCountOnIdle
but it appears to be broken on MacOSX (prior to this CL). Added a note
to investigate on the metric but it shouldn't block this CL which
doesn't make it worse.

TBR=wez@chromium.org

Bug: 860801, 850450, 786597, 866299
Change-Id: Ic0fb2b58780cd595e47b36f97a9ae440bb988225
Reviewed-on: https://chromium-review.googlesource.com/1147400
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577553}

Bug: 865818
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4523754e637f1fa9f0cb1c729717e0eeecf334d6
Reviewed-on: https://chromium-review.googlesource.com/1148016Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577552}

https://webrtc.googlesource.com/src.git/+log/903bd4145f5a..e09e6ef947d7


git log 903bd4145f5a..e09e6ef947d7 --date=short --no-merges --format='%ad %ae %s'
2018-07-24 sakal@webrtc.org Reorder sdk/android/BUILD.gn.
2018-07-24 terelius@webrtc.org Plot RTCP SR and RR contents in event_log_visualizer.
2018-07-24 buildbot@webrtc.org Roll chromium_revision bc855194..83a1a9ed (577382:577482)
2018-07-24 titovartem@webrtc.org Move portaudio to proper third_party directory


Created with:
  gclient setdep -r src/third_party/webrtc@e09e6ef947d7

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I121869ebb1f9623f0c848b70631753bbe933acaa
Reviewed-on: https://chromium-review.googlesource.com/1147907Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577551}

This is step 1 in an API shrinking effort for AsyncTask. There is no reason for Params to exist instead of just using constructor arguments, so we are changing the few usages over. Step 2 will be the removal of the Params argument.

Bug: 843745
Change-Id: I36a03dd91b7af10763587fb5048e9f8d775f203e
Reviewed-on: https://chromium-review.googlesource.com/1136730Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577550}

Modify the filter to use gl_vendor and gl_renderer.

Bug: 811661
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2e1b31abf95c3bd82018fd740c75191c31052682
Reviewed-on: https://chromium-review.googlesource.com/1146760Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577549}

Bug: 865063
Change-Id: I8d9cc10e56189099c278d63012dee1d32f0728de
Reviewed-on: https://chromium-review.googlesource.com/1143306
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577548}

Since all the logic outside of the data.ndjson file is self-contained
in the client, we can make the client run offline and support add to
shelf.

Bug: 847599
Change-Id: Ic29237e994fd07f75006d1f2ef4402b835511341
Reviewed-on: https://chromium-review.googlesource.com/1145595Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#577547}

This deprecated method was already implemented in terms of the new
GetDisableReasons. This CL moves the remaining callers over to use
GetDisableReasons directly, and removes IsSyncAllowed.

Bug: 839834
Change-Id: I41d1a59aff323f0752431a281a432118d437df44
Reviewed-on: https://chromium-review.googlesource.com/1138250
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577546}

https://chromium.googlesource.com/angle/angle.git/+log/522095f7d7fe..06235df9ff91


git log 522095f7d7fe..06235df9ff91 --date=short --no-merges --format='%ad %ae %s'
2018-07-24 oetuaho@nvidia.com Make HLSL shaders use only one main function


Created with:
  gclient setdep -r src/third_party/angle@06235df9ff91

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I8d1f93ae32280b1a4aa5d9f8a009aa826f6719f3
Reviewed-on: https://chromium-review.googlesource.com/1147944Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577545}

Prior to this CL, SurfaceDependencyTracker read activation_dependencies
from the pending CompositorFrame's CompositorFrameMetadata. This meant
that it had to look up already resolved dependencies. It's more efficient
to use the remaining dependencies set tracked in Surface directly. The code
is also more compact and easier to read.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I97acf5637fd92eaa6485f15601582dc75dd69c35
Reviewed-on: https://chromium-review.googlesource.com/1148226Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577544}

Add a new feature flag, ScheduledScriptStreaming, which makes the script
streamer use the task scheduler for streaming tasks, rather than using a
dedicated ScriptStreamerThread.

Bug: chromium:865098
Bug: chromium:866868
Change-Id: I05ca411d8d5187c4b5180011ebce2a603e3944fe
Reviewed-on: https://chromium-review.googlesource.com/1145386
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577543}

Bug: none
Test: compile ozone_demo with is_component_build=true

Change-Id: Icf24cfcb5c3737d9f51136da73a9bc593937f813
Reviewed-on: https://chromium-review.googlesource.com/1146981
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577542}

Use IMMEDIATE_CRASH on official builds instead of BreakDebugger in
LOG(CRASH), to try to increase the likelihood that stack unwinding will
work correctly. BreakDebugger isn't guaranteed to have a stack frame and
thus can thwart CFI unwinding.

This matches the behaviour of CHECK() so should be pretty safe.

Bug: 851851
Change-Id: I7bcf8669ee90aa3fe42769e4e4cc841bf1df1b57
Reviewed-on: https://chromium-review.googlesource.com/1147474Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577541}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/18dc0c00..4ac42e42

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I78797ba6840fe9c144ea3d3fb2ac21cac12f1fcd
Reviewed-on: https://chromium-review.googlesource.com/1148230Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577540}

Previously, |-continueTrackingWithTouch:withEvent:|  returned NO when
UIControl.touchInside became NO to short-circuit the tracking event.
However, if the touches continued after this, |-endTrackingWithTouch:
withEvent:| was not called, and the page control can be stuck in an
intermediary state.  This CL updates to continue tracking the pan
after the touch leaves the page control's bounds so that the cleanup
tracking callbacks can be properly received.

Bug: 853634
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0bfdedabceab824dd6ec4c687e3773fb0f4bcf63
Reviewed-on: https://chromium-review.googlesource.com/1147862
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577539}

Bug: 805496
Change-Id: Idb1cc63960409eeb8117d74267f5df33f401eb08
Reviewed-on: https://chromium-review.googlesource.com/932101
Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577538}

This performs the per-process phased offset processing used for the orderfile.

Bug: 758566
Change-Id: I5cbdb69c4834d95a52f2e43ad3f72e4845413883
Reviewed-on: https://chromium-review.googlesource.com/1144935
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577537}

NOTRY=TRUE
TBR=fserb@chromium.org

Bug: 866850
Change-Id: I78fd73f7dafadac914938b14338d482cc4ab97ca
Reviewed-on: https://chromium-review.googlesource.com/1148542Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577536}

Gn check can enforce dependencies only if the header is included with
an absolute path (from the root of the project) or if "include_dirs"
is used. It ignores -isystem and -imsvc since they are part of
cflags (and similar variants).

Since //third_party/abseil-cpp/absl:absl_include_config was using
-isystem and -imsvc only to sidestep compiler warnings in absl code,
it is good to try to switch back to include_dirs instead of adding
-isystem/-imsvc support to "gn check".

Bug: 862521
Change-Id: I9c2d01abad75023918a88f852e3080486dcafead
Reviewed-on: https://chromium-review.googlesource.com/1124478
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577535}

Native content is typically presented after its placeholder navigation
to ensure correct ordering of WebStateObserver callbacks. However, for
UI smoothness when opening a new tab, native content is presented before
its placeholder navigation as well (http://crbug.com/819606). This CL
removes the duplicate presentation of native content after its
placeholder navigation, by storing a flag in NavigationContextImpl that
the native content is already presented.

Bug: 865422
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I71dc25f6a3284c34cf946800dee9bb4581506370
Reviewed-on: https://chromium-review.googlesource.com/1146777
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577534}

Based on a try job in the linked bug, it looks like these stories are
no longer failing.

TBR=sullivan@chromium.org

Bug: 798536
Change-Id: I44a6d819fa0fea6dc71b76d0189933b9009d3c78
Reviewed-on: https://chromium-review.googlesource.com/1143450Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577533}

That prevents the linker from dead-stripping the function, as it is not called
directly, it is resolved in the runtime via dlsym().

I copied the change from https://crrev.com/c/833995

R=mmoroz@chromium.org

Bug: 837098
Change-Id: I998517ebab623e67d275fe656643a8ee5fd1e951
Reviewed-on: https://chromium-review.googlesource.com/1148391Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577532}

gcm::SocketOutputStream is not keeping track of partial writes correctly.
It will always try to write |next_pos_| bytes.
This CL adds a regression test.

Bug: 866635
Change-Id: Iccfc4c88a9247ff151073d3691e20ba052f082b0
Reviewed-on: https://chromium-review.googlesource.com/1147475
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577531}

[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in /third_party/WebKit/LayoutTests

Bug 850000 added standard logical properties and aliased prefixed ones
to them. The prefixed properties are still used in various places, but
the standard ones should be used instead. This patch replaces all the
uses in /third_party/WebKit/LayoutTests, except that the original
fast/css/logical-property-resolution.html is preserved in a new test
logical-property-resolution-webkit-prefix.html to ensure that prefixed
properties continue working.

Spec: https://drafts.csswg.org/css-logical/#box

BUG=862141

Change-Id: I3090713fc6fbe507a19724cca4f6ca69bcaf5eb9
Reviewed-on: https://chromium-review.googlesource.com/1147523
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#577530}

These flags are potentially preventing Chrome from being optimized on
O+ devices. Having spoke with agrieve@ there is no easy way to ensure
that these flags are the culprit with monochrome. However, if we move
away from monochrome this will at least ensure that WebAPKs aren't the
blocker of optimization.

I've tested this on L, N and O devices and confirmed there don't
appear to be any negative effects or crashes resulting from their
removal.

Notifications were tested using:
https://tests.peter.sh/notification-generator/
as well as the bound and unbound WebAPK targets.

Change-Id: I4e93db09aec3271493b29bfd310d1df8f27cb4d7
Reviewed-on: https://chromium-review.googlesource.com/1127150Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577529}

|network_connection_tracker_| might never be set (if no profile
is loaded). In that case, it should not be dereferenced.

Bug: 866865
Change-Id: I490be08795f41908d7ac49fdcd5d8588fbea83b7
Reviewed-on: https://chromium-review.googlesource.com/1148335
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577528}

We now use exit prompts. The only remaining case was the unhandled code
point when rendering URLs, but we should ever reach it.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1e7e715b146d0052b893dcac0abb762e9cfb00d2
Reviewed-on: https://chromium-review.googlesource.com/1147433Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577527}

With gmock, if any of the expectations fail, we will see a diff of
the contents - in particular, we'll see the extra histogram name
if there is one.

Bug: 863262
Change-Id: Iff375adf1ebbc0a14d64005f48dd574efb45b8dc
Reviewed-on: https://chromium-review.googlesource.com/1146907Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577526}

This reverts commit daa348fa.

Reason for revert: https://crbug.com/866782

Original change's description:
> Attach UsbContext to libusb_device(_handle) pointers
> 
> This change modifies ScopedLibusbDeviceRef and adds a new class
> ScopedLibusbDeviceHandle. This now explicitly own a reference to the
> UsbContext object (which reference counts a libusb_context) in addition
> to the libusb_device or libusb_device_handle they are wrapping.
> 
> This resolves potential use-after-frees possible when posting tasks
> with a ScopedLibusbDeviceRef since the UsbService the task is being
> posted to could be destroyed before the task is executed. The
> libusb_device would then be released after its libusb_context has been
> destroyed.
> 
> This is based on https://crrev.com/c/1131949 after I realized there
> where additional issues that needed to be addressed.
> 
> Bug: 838947
> Change-Id: Idee02828bf615bd477033e585fffe03cf4d20595
> Reviewed-on: https://chromium-review.googlesource.com/1145910
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Commit-Queue: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577329}

TBR=rockot@chromium.org,reillyg@chromium.org

Change-Id: I4146987c84b34e1d3625e7e91cfc672afe98054c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 838947
Reviewed-on: https://chromium-review.googlesource.com/1147950Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577525}

updateUI accepts a dictionary now, where the developer can change the
title and/or the icon.

TBR=haraken@chromium.org

Bug: 865063
Change-Id: I779c05ee6bdeee83ce94793eddb4409af95395c6
Reviewed-on: https://chromium-review.googlesource.com/1142152
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577524}

As part as implementation of saving in NewPasswordFormManager some parts
of PasswordFormManager will be copied to NewPasswordFormManager. Let's
make clean-up of the old code first.

Bug: 831123
Change-Id: Idb6acf4e0308d6193e3dbf4da07f73ee63859e99
Reviewed-on: https://chromium-review.googlesource.com/1073231Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577523}

Bug: 866748
Change-Id: If48fa3bf307e8dc7876360840acced8e83f7572a
Reviewed-on: https://chromium-review.googlesource.com/1148015Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577522}

Also change identity::ClearPrimaryAccount to work on a SigninManager,
so I can use it in tests that have a production SigninManager.

BUG=801971
R=blundell@chromium.org

Change-Id: I49176bd7e50a0e7c208403e276371bf93822fde6
Reviewed-on: https://chromium-review.googlesource.com/1143268
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577521}

Bug: 865571
Change-Id: I722a58f53bbeee0236e6fb64b8f7eb9956526c3c
Reviewed-on: https://chromium-review.googlesource.com/1147485Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577520}