- 15 Sep, 2020 40 commits
-
-
Alexander Cooper authored
Bug: 1126786 Change-Id: I8e3bd1c9bb938a54dd7bc058ae92620b15cf9f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412629 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#807142}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. It lays the groundwork for hooking up more KeystoreServices APIs. Change-Id: Ic5925cdf4ce110601c2cab01d1bfdd5504d4ed12 Bug: 1127505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393004Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807141}
-
Michael Thiessen authored
Native Java Unittests have all been removed, and so it's time to revert the infra changes they required. Reverted: https://crrev.com/ea65b1a1577f1fbba45e035f43e1c898a9874f9b https://crrev.com/26dc9eefadac5e70cf3789abbfb1eead7c9f7b68 https://crrev.com/1265cac9f769d0460a84e3f906b93f62290fd117 https://crrev.com/d46596b1702517799459d4b6a9a26669b187c94b https://crrev.com/04c511fd08177c915d5c267835110d0194bdd671 Bug: 1103344 Change-Id: I12ea68454c118de7860be6ba23c6e8263baceb99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406692 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#807140}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e049f9d1de14..b189aac83132 2020-09-15 fmayer@google.com Merge "Fix invalid CHECK in flamegraph generation." 2020-09-15 hjd@google.com Merge "ui: Fix logcat dropdown" 2020-09-15 taylori@google.com Merge "Revert "ui: Upgrade immer from 1.12.0 -> 7.0.8"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2e6c0527755ee79035f18d86828a980c119f5c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412365Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807139}
-
Eugene Zemtsov authored
N.B. libvpx will later check that frame diminsions don't exceed codec specific limits. Bug: 1127590 Change-Id: I20d635169a63e81eed40a7cc3ee4a77284a753ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411672Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#807138}
-
Nick Harper authored
The list of ssl_early_data_reason_t values why 0-RTT would be not attempted was incomplete. Change-Id: Ie067f160a8cdf751ee0e80726f831df9ab4dadaf Bug: b/168020146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410309 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#807137}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600171148-66b09300985d04c4504d7b1ddf5998f31579a7e2.profdata to chrome-linux-master-1600192792-36de61e8f764b4ecaec9d88047348ce6694afdaf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ib6196544dd26209e506e2a25a3fa54a7fa4ea87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412596Reviewed-by:
-
Sonny Sasaka authored
BUG=b:166673181 Change-Id: Id5f5ef0782c6d43ea99617b66f89294b2d7d19a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380741 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#807135}
-
manukh authored
On creation (and ominbox changes), the omnibox attempts to wakeup the current profile's BitmapFetcherService by invoking BitmapFetcherService::WakeupDecoder. But incognito and guest profiles do not have a BitmapFetcherService, resulting in calling WakeupDecoder on a nullptr and crashing. The recent CL crrev.com/c/2348328 introduced this wakeup call. This CL adds a prior null check. Other usages of BitmapFetcherService don't require a null check as they're conditioned on the existence of omnibox images which requires a non-incognito/guest profile. Bug: 1115108, 1128282 Change-Id: If0c21b6743182dfb7e5ab1d3f75fc7da6ee0bad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411655 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#807134}
-
Kyle Milka authored
Extend the expiry dates by 2 milestones. Bug: 1125774 Change-Id: Id132f16f3d76a1e7308b52b78c39511d5a0f1206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410343Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#807133}
-
Daniel Rubery authored
Enabling this feature flag would cause the DownloadProtectionServiceTest to look for an AdvancedProtectionStatusManager, which did not exist. This CL fixes that. Patch set 3 demonstrates that all tests now pass with the feature flag enabled. Change-Id: I90d771b0ca7a297e7f81509019c6f6de09ded3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410847 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#807132}
-
Sonny Sasaka authored
This changes FakePowerManagerClient to allow setting specific fake battery values per device so that tests can be more controlled. Without this, all devices will trigger PeripheralBatteryStatusReceived events that are often unwanted in tests. BUG=b:166530001 Change-Id: I74ee52685a955a0996b0aef72da403ae9ea79d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410961 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#807131}
-
Luke Zielinski authored
By formatting test output to match the metadata format we can easily diff the output against the expectation metadata to identify changes. Bug: 1127360 Change-Id: I8c9c760478b2ff73699f847510d80706d3054955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405700Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#807130}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkProxyExclusionsTest* Change-Id: Ic0f9fbc01f2f31baa893104d93111ed486f4f20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411285 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
Xing Liu authored
In devices with small screen, "page 1" can fall outside of the view port. We have to scroll to make the recycler view create the view holder in memory. About view port: 1. RecyclerView won't create view holder outside view port to save memory. 2. IsDisplay() won't check things outside view port. 3. In order to verify stuff outside view port, we have to scroll to a particular view holder or position. To scroll, there are a couple of ways: 1. Use any of 3 RecyclerViewActions.* API. 2. Implement our own ViewAction for RecyclerView, and scroll with the recycler view handle. Bug: 1039491 Change-Id: I1669370abf595140313fc8cfcf2728e12e3b3389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411557Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807128}
-
Tina Wang authored
Previously the TableViewInfoButtonCell/Item is only used by managed settings UI, so the accessibility hint is set to "This settings is managed". Since the item and cell is refactored for generic usage, the accessibility hint should be exposed and be set accordingly. Bug: 1124407 Change-Id: I292e6215c59fafb55618316ccdd176a3ae777c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391504 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#807127}
-
Jose Dapena Paz authored
Two using declarations have been added in x11.h for an unnamed struct. This is not allowed by C++ (and GCC). An example: using XErrorEvent = struct { ... }; The solution is giving a name to the struct. Bug: 819294 Change-Id: I9e77017851efe8e0a92fb37c01fdba693bb7a36d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412450Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#807126}
-
Becca Hughes authored
BUG=1128462 Change-Id: I78a060c655e7ffd90a636a428e3565bd510f5c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410291 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#807125}
-
Dominic Mazzoni authored
Page info bubbles just display a single string. To match recent UX mocks, the text of these bubbles should be multi-line and the bubbles should be the minimum width for a page info bubble (currently 320px). Bug: 1124489 Change-Id: I5fbe9e3395b450d8f45b7cc55f5bb09aeb95a1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409136Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807124}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/534924ed9ee5..93d0ecf3d428 2020-09-14 dpranke@google.com Add test executable API arg equivalents to typ 2020-09-14 fancl@chromium.org auto-triage: Fix None comments in issue If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1127899,chromium:816629 Tbr: zhanliang@google.com Change-Id: I9f8f03ee70ff76fade8fbd1c98d468fba2ba8c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411183Reviewed-by:
-
Bo Liu authored
Set the background color on ContentViewRenderView according to the dark mode, ie set it to black if dark mode is enabled. Then also set the same background on the compositor which is the the part that actually appears to make a difference visually. This is meant to be merged back to 86. Bug: 1127873 Change-Id: Ifcb9fa47af1e578b963f3f47ba5dc2b8252b80b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412189 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#807122}
-
Christian Biesinger authored
Border and padding gets added at the end of the function. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1083010 Change-Id: Iae51e87f93f8be2906690f888dde898763457bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412128 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#807121}
-
Min Qin authored
There are several issues with this download test: 1. The new download progress info bar will mess up with the duplicate infobar when trying to find the latter. 2. Download update may never go through DownloadManagerService in download's new code paths 3. Only 1 duplicate infobar will show at a time, so the AllowMultipleInfoBars test is no longer valid This CL fixes the above 3 issues. BUG=597230 Change-Id: I9cfbfcd51c040dc77bd4f6e0cb0f6bfaf967a912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411732Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
-
edchin authored
* Moves feature flag file to //ios/chrome/browser/screen_time This was placed in the wrong place to begin with. This ensures that //ios/c/b does not depend on //ios/c/b/ui. Bug: 1123704 Change-Id: I103ad33fc14b56109249ee794c1e52a92f1a8a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393300 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#807119}
-
Evan Stade authored
This change uses the pre-existing GoogleAccountsCallback API to ask the embedder for the active user's email, and extends it to also be able to ask for full name and avatar. This allows WL to identify the active user and promote the associated contact info to the top of the list. If the active user's info is not in their own contacts, the email, name and avatar are used to synthesize contact info. Bug: 1016938 Change-Id: Ib2e6ce38761fc036b2657727775627186f0e7dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392578 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#807118}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/34f5ab82feae..c6dbc5ee8027 2020-09-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2c970cbe..5aa7e239 (806885:807011) 2020-09-15 philipp.hancke@googlemail.com objc: fix rollback 2020-09-15 hmaniar@nvidia.com Adding field trials to control additional quality scaler settings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I523e20f616668d0409d920a49c73e9bea8ad188a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412357Reviewed-by:
-
Elly Fong-Jones authored
The main change here is to remove most of the logic from Accept(). There was code in here to handle when Accept() was called with the accept button disabled, which is actually impossible*. This change also cleans up some other overrides of WidgetDelegate methods in BookmarkEditorView. *: This change also adds a DCHECK to guarantee that AcceptDialog() is never called with the accept button disabled. While this can't happen in production, a misguided test might reasonably call AcceptDialog() without first ensuring that the button is enabled, so enforce the invariant redundantly here. Bug: 1075649 Change-Id: Ib421da682ef3e8d8dc47be8b22d3339229d8068e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380255Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#807116}
-
Victor Fei authored
AXEventGenerator::Iterator iterates over the generated events in std::map<AXNode*, std::set<EventParams>> tree_events_. Often there could be entry with empty event sets (std::set<EventParams) in |tree_events_|, and if these empty event sets happen to be the first entry when we iterate over |tree_events_|, AXEventGenerator::Iterator ::operator++ would increment AXEventGenerator::Iterator::set_iter_ past its end, causing an exception. This CL fixes this issue by looping over |tree_events_| in AXEventGenerator::PostprocessEvents a second time to delete empty empty std::set<EventParams> entry; so AXEventGenerator::Iterator should only iterate over non-empty std::set<EventParams> entry. DCHECKs are also added in AXEventGenerator::Iterator to check the condition that only non-empty event sets remain. AX-Relnotes: n/a Bug: 1120281 Change-Id: I6c049be2cfb786c9777b4b840d598c77a8362e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410925Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#807115}
-
Koji Ishii authored
crbug.com/1111154 discovered that |getBoundingClientRect()| for culled inline has regressed a lot in LayoutNG. r793989 crrev.com/c/2332083 fixed this by traversing |LayoutObject| tree instead of fragments. This change, however, regressed a hit-testing performance case previously raised at crbug.com/1008523, because hit- testing uses |MoveToIncludingCulledInline| for every leaf, by limiting the search range to the containing line. This can easily lead to thousands of |MoveToIncludingCulledInline| for one hit-test request. This patch changes the function to revert the change if the search range is limited. In this case, most of |LayoutObject| descendants may not be in the search range, and that the searching fragments can be faster than searching |LayoutObject| descendants. Case A Case B Before r793989: 19 420 ToT: 2,556 9,064 This CL: 16 403 Numbers in milliseconds Case A: test attached to crbug/1008523 Case B: culled-inline-hittest.html in this CL Note, the design to call |MoveToIncludingCulledInline| so many times is questionable, but this CL does not try to change it to reduce the risk of regressions. Bug: 1127976, 1008523 Change-Id: Id21dd07cba0d0746b779b913ae9f180a77e23c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409734Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#807114}
-
Christopher Cameron authored
There are four places where we do basically the same thing, namely, find a profile (or profiles) to launch, and either launch or, if they are already open, focus them. They are - OnShimProcessConnected: When an app shim launches - OnShimOpenedFiles: When files are opened - OnShimSelectedProfile: When the profile menu selects a profile - OnShimReopen: Coming soon for the new x behavior Update OnShimOpenedFiles and OnShimSelectedProfile to use the new path. To enable this, break out a new sub-function LoadAndLaunchApp_TryExistingProfileStates from LoadAndLaunchApp. This function is used to short-circuit loading all profiles for an app, if the app is already open. Bug: 1080729 Change-Id: I314e4d0d80ae8e8b84f605fb16ff23c2680f8b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407976 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#807113}
-
Karandeep Bhatia authored
BUG=1113513 Change-Id: I70e687978361920419b834eb9b4c4cb2112cfc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368290 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807112}
-
Yuke Liao authored
This reverts commit 48522640. Reason for revert: During the refactoring, 'os.listdir' was somehow accidentally changed to 'list', which resulted in the test failures, and this CL fixes the problem. Original change's description: > Revert "[lacros] Make test runner supports lacros_chrome_browsertests" > > This reverts commit e4eacd09. > > Reason for revert: Suspect for lacros test failures: > https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/2227 > The only lacros-related change in diff with the previous success run. > > Original change's description: > > [lacros] Make test runner supports lacros_chrome_browsertests > > > > This CL makes test runner supports lacros_chrome_browsertests by: > > 1. Appending necessary args to establish mojo connections. > > 2. Always use '--test-launcher-jobs=1' to run tests serially because > > multiple clients crosapis are still not supported yet. > > > > Bug: 1120582 > > Change-Id: I865ace26aa4a86c83912c6660bc433d79e43ef76 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410350 > > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Reviewed-by: Sven Zheng <svenzheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#806903} > > TBR=erikchen@chromium.org,liaoyuke@chromium.org,svenzheng@chromium.org > > Change-Id: Ie630ade531428e78718127792c4f6ab6b0d55025 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1120582 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410246 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806980} TBR=erikchen@chromium.org,poromov@chromium.org,liaoyuke@chromium.org,svenzheng@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1120582 Change-Id: Ifaa2235a0a4f9ce8deb9aea5011eda0924e1f051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412253 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807111}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/28ecfe40d6ae..8b1a5e7995a5 2020-09-15 sigurds@chromium.org Turn layout test into e2e test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110817 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9de1a652c2102a64fed1b6dca0a2d4a2213ec487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412352Reviewed-by:
-
Alex Newcomer authored
Bug: 1112441 Change-Id: If5ea1d536313885fde79f407346db8715789c6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406681Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#807109}
-
Sebastien Lalancette authored
In a previous CL, I've added logic to disable the Edit and Move actions in the new Context Menus based on the enterprise policy's setting, but forgot about the new Delete action. Bookmarks' deletion is also controlled by this policy, so in this CL we'll be disabling that action as well, based on the policy. Bug: 1128028 Change-Id: I9f7cf4e8fa9e0889657d73a80ce1036d45d46511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410308 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807108}
-
Sven Zheng authored
This is a reland of ee48012a Previously cl got reverted because of crbug.com/1127103. Original change's description: > [lacros] LUCI config for chromeos-amd64-generic-lacros-dbg > > Adds CI bot for chromeos-amd64-generic-lacros-dbg. > Also changes chromeos_amd64-generic_lacros, > chromeos_amd64-generic_lacros_rel to use other pre-defined configs > and it should have no differences. > > Bug: 1121667 > Change-Id: I6405da5c9ec0464fed59effeadcb3758f18ce927 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398976 > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805467} Bug: 1121667 Change-Id: I12a5a12adb16e9fa9181231f5a3d731c6bf32f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410612Reviewed-by:
-
Harkiran Bolaria authored
[bfcache] Update IPC hash setting functionality in mojo and add unit tests + browser test for IPC tracking to frames in cache Currently, IPC hash isn't set for tasks posted on the IO thread; adding IPC to SimpleWatcher when tasks are posted allows for the task posted on the IO thread to be annotated with an IPC hash, so that it can then be tracked in the histograms. ScopedSetIpcHash changes are to allow for tracking of IPCs posted from remote mojo objects. However, calculating the MD5 hash of a char* on every posted task is expensive, so we have also introduced storage of the IPC interface name. The IPC interface name can be used to calculate IPC hash on an as-needed basis (i.e. only in cases where IPC is posted to cached frames/documents). Also includes histogram testing to ensure metrics are recorded. and how ScopedSetIpcHash is set. Bug: 1110344 Change-Id: I26da160b65145f06639c33679ff03872f686e4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345673 Commit-Queue: Harkiran Bolaria <hbolaria@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807106}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009150800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/7-Fyv71mIOgLZ5UT2rzvAWdbDHOekNFf1CVgl0mHSkkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/155018433,b/166043485 Tbr: help-app@grotations.appspotmail.com Change-Id: I1181a02aa6df2a05136d3605a5c6bfd929835e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412284Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807105}
-
Jonathan Freed authored
This still works for dark mode, because the color used in the ic_settings_gear_24dp.xml file is adapative (@color/default_icon_color_secondary). Bug: b/166795933 Change-Id: Ia229e019701511ae39642eac4c28525d986212f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406720Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#807104}
-
behdad authored
Tests skipped on android-pixel-2 and android-nexus-5x: blink_perf.bindings/worker-structured-clone-different-payloads.html blink_perf.owp_storage/idb-load-docs.html blink_perf.owp_storage/idb-put-all.html blink_perf.owp_storage/idb-put.html jetstream2/JetStream2 system_health.common_mobile/load:tools:dropbox:2019 system_health.memory_mobile/load:tools:dropbox:2019 Bug: 1128019 Change-Id: I1f86c29ea8cba6593f03a2498fc496f4ece404cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411649 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807103}
-
