- 21 Sep, 2020 40 commits
-
-
Morten Stenshorne authored
Bug: 829028 Change-Id: I30d3d7349c97b497026141a242209051199c4c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421371Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#808959}
-
Sadrul Habib Chowdhury authored
Allow the LayerTreeHostImpl::SetVisible trace-event to be collected in traces, so that we can measure how long a page is visible for. BUG=1125152 Change-Id: I1be619aca28c88f834bbde989872be68e9f94e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422144 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808958}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4559368cc4a1..8614e4925896 2020-09-21 johnstiles@google.com Replace VariableReference::copy_constant with clone(). 2020-09-21 bsalomon@google.com Stop building GL backend on Android Vulkan builders 2020-09-21 jvanverth@google.com Fix D3D non-dev release build. 2020-09-21 johnstiles@google.com Allow a BasicBlock to be dumped, outside the CFG. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I672ee4ade5c45465a096856f34217d7d9aa38c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422209Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808957}
-
Luke Sorenson authored
Before this fix, we were unable to successfully restart the Media Perception Service and re-connect over Mojo IPC. Bug: 1129628 Test: Verified on-device this fixes the bug. Change-Id: I3eb60d99320c41ff2aef357ed9ae83a18d9d715a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422183Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Luke Sorenson <lasoren@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#808956}
-
David Dorwin authored
Also breaks out the multiple cases in the *UserAgent tests into individual WebEngineIntegrationUserAgentTests. Change-Id: I4aab782d55ff327456d6a2b638739b0c4ec86204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421655 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808955}
-
Tim Volodine authored
The BundleLanguageTest#testWebLayerString and BundleLanguageTest#testSharedString tests are failing on android-pie-x86-rel. BUG=1130660 TBR=cduvall@chromium.org Change-Id: I6720dddfef3ba936e91685cbb799bda5d297b669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421656Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#808954}
-
Andrew Grieve authored
This reverts commit cac6380f. Reason for reland: Fixed typo in .patch file. Original change's description: > Revert "SuperSize: Update to newer emscripten version" > > This reverts commit be818705. > > Reason for revert: Patch was corrupt. > > Original change's description: > > SuperSize: Update to newer emscripten version > > > > * Fixes an issue with an unrecognized compiler flag. > > * Could not get -flto to work and no good error message from the > > failure. Left a TODO to re-enable it. > > > > Bug: None > > Change-Id: I683119e43e767ff5b228706bc6b6f68c2282f7a7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418993 > > Reviewed-by: Samuel Huang <huangs@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#808898} > > TBR=huangs@chromium.org,agrieve@chromium.org > > Change-Id: I8cf548eb57ed34b4fd9722ba2843f645c36c3b46 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: None > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421871 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808944} TBR=huangs@chromium.org,agrieve@chromium.org # Not skipping CQ checks because this is a reland. Bug: None Change-Id: Iff705f1de426b219e274d90236b8f8d1c7984550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422166Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808953}
-
Kyle Horimoto authored
This fixes two issues with tablet navigation button settings: (1) This setting is now shown on all devices with tablet capabilities, even if tablet mode is not currently active. Previously, it was only shown when tablet mode was active. (2) The settings search result for this toggle is now only shown on tablet-capable devices. Previously, it was always shown, even in situations where the setting was not available. This CL also moves the location of the IsBoardTypeMarkedAsTabletCapable() function to //ash/public where it can be accessed by settings. Additionally, it removes accessibility_handler_unittest.cc, since the only thing tested in this file was the previous functionality which would only show tablet navigation button settings when tablet mode was active. Bug: 1111564 Change-Id: Iefa982ab3a28fae6ad40fba827cfd658c09fe98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420771Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808952}
-
Raymond Toy authored
The threshold for the vector math Zvmul test is a little too tight for mac-arm64. Hence update the threshold from 1.5e-5 to 1.9e-5 but only on mac-arm64. We keep the threshold the same for other mac platforms so we can catch any regressions there. Bug: 1128434 Change-Id: Ib51fa772e27378fb8022e19790ecdfcf1e1a6e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419539Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#808951}
-
Ehimare Okoyomon authored
Bug: 1077766 Change-Id: Ia4ff90e3aedaa1254cedb3b788d506650157907a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421893Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#808950}
-
Morten Stenshorne authored
Block-end border and padding are added as part of layout, but if the box is too tall to fit, we'll remove it again. FinishFragmentation() already handles that, but we need to do something similar when column layout is interrupted by a spanner, since block-end padding and border of the spanner's ancestors will be placed after the spanner. Without this fix, we'd also make room for the border/padding before the spanner. Bug: 829028 Change-Id: I85e9dd812bbe96df16ae6ab729f809797a30f905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421495Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#808949}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a53556930038..71b08cd277f4 2020-09-21 jacktfranklin@chromium.org Fix non-primitive nullable handling in bridges 2020-09-21 tvanderlippe@chromium.org Typecheck network/BlockedURLsPane.js with TypeScript 2020-09-21 changhaohan@chromium.org Enable CSS Grid experiment by default 2020-09-21 jacktfranklin@chromium.org Revert "Fix ElementsBreadcrumbs mutation bugs." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1047356,chromium:1129881 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I416077de0b2ea8debea309505dbf7075606fba47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422208Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808948}
-
Dan H authored
This reverts commit 0048fa4a. Reason for revert: Previous CL was for merging to stable branch only Original change's description: > Disable Feed v2 build flag on stable channel > > Bug: 1129504 > Change-Id: Icb74a2b914c65ba2cfda14409f0d7a7642d132f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417049 > Auto-Submit: Carlos Knippschild <carlosk@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Commit-Queue: Justin DeWitt <dewittj@chromium.org> > Commit-Queue: Carlos Knippschild <carlosk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808013} TBR=dewittj@chromium.org,carlosk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1129504 Change-Id: I119b1221f95d79901af4ae8d6a0fc1259aaf0b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422298Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#808947}
-
Tim Volodine authored
In particular the test is failing on some Android P bots (timeout). BUG=1130617 TBR=aluo@chromium.org Change-Id: I315c7876e34d180b29b7b69ff94297debda600cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421815Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#808946}
-
Alice Wang authored
This CL adds render tests for the screen when user tapped the continue button on the sign-in auth error screen. Bug: 1122942 Change-Id: Ie6e534054a71bb89b98998ecba52623a38e183a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421490Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808945}
-
Andrew Grieve authored
This reverts commit be818705. Reason for revert: Patch was corrupt. Original change's description: > SuperSize: Update to newer emscripten version > > * Fixes an issue with an unrecognized compiler flag. > * Could not get -flto to work and no good error message from the > failure. Left a TODO to re-enable it. > > Bug: None > Change-Id: I683119e43e767ff5b228706bc6b6f68c2282f7a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418993 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808898} TBR=huangs@chromium.org,agrieve@chromium.org Change-Id: I8cf548eb57ed34b4fd9722ba2843f645c36c3b46 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421871Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808944}
-
Gil Dekel authored
Split Partially Occluded Quads has been enabled by default since 83.0.4103.0 without regressions. Cleaning up flag since there is no plan of removing this feature anytime soon. Bug: 1129155 Change-Id: I45813471ef4cce77fa0bb4f4fd0c18009a775eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422240Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#808943}
-
Benoit Lize authored
This was enabled only when DCHECK_IS_ON() to assess stability. Enable it for regular builds as well to assess performance. Bug: 1125999, 1061437 Change-Id: Ia38c81c95ed0e6ba3fab1754cb4809a08f1fea01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421651Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808942}
-
Ravjit Singh Uppal authored
Bug: 1127074 Change-Id: I99834a4c5efb2dd38ffea9e28f83c8d0592ca9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405572Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#808941}
-
George Burgess IV authored
It seems that this constructor call was intended to be used as a scope guard. In order for that to happen, there has to be a variable name here. Bug: 1130379 Change-Id: I3c5f1ec85cefcfebc6d40ca82488423edb8e7ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420916Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#808940}
-
Collin Baker authored
Bug: 1055150 Change-Id: Iee3d318ff90362a2cc29754b9a118a2a60d5a4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418809 Commit-Queue: Collin Baker <collinbaker@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#808939}
-
Nela Kaczmarek authored
This change adds LookupAffiliationByHashPrefixRequest and LookupAffiliationByHashPrefixResponse to support requesting affiliations by sending only hash prefixes of facets. It will be used in AffiliationServiceImpl to support users requiring more privacy. Bug: 1108279 Change-Id: I69c6d55520d478f276b76b61a47d89d6d14f5958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421493Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Cr-Commit-Position: refs/heads/master@{#808938}
-
Andrew Grieve authored
Bug: 1130584 Change-Id: I0ad7e220c67f7af029f3e1a4656a832d124b4b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422119 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808937}
-
David Tseng authored
This change is somewhat of a workaround to shield Chrome from any issues contained within the underlying tts engine. Issues: - the extension system evicts extensions that don't explicitly fire an Activity as defined by extensions/browser/activity.h - audio playback isn't plumbed through as an activity - engines like Espeak work even for long utterances that hit the eviction time, because they trigger the extension api activity via word callbacks - the Google tts engine currently is buggy for some sentences in emitting callbacks All interleavings of increment/decrements were considered: - engine loads, enable ChromeVox/STS, disable ChromeVox/STS - enable ChromeVox, engine loads, enable STS, disable STS/ChromeVox - enable both STS and ChromeVox, engine loads, disable STS/ChromeVox In all cases, the keep alive count will be 0 at the end. R=dmazzoni@chromium.org Fixed: 1128093 Change-Id: I92b3fc32cd777961e4fbba40c5891c49943b9645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416571 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808936}
-
Benoit Lize authored
Bug: 998048 Change-Id: Ida68e21565a44fee0dc22051892eb10c4c806a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421890Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808935}
-
James Vecore authored
Previously discovery manager assumed transfer updates would only come after a share target was selected. This is not true and can happen when registering the foreground surface if an existing transfer is in progress or recently completed. Fixed: 1128188 Change-Id: I5de66fd895117e37d8f45c76a346e6edabdc564d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419662 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#808934}
-
Haiyang Pan authored
The graph http://shortn/_OkQ1Rvzvk9 shows the capacity is over OK, only a little bit tight on 09/19. Let's see how it goes after increasing to 60. Bug: 1111436 Change-Id: I65eebf773e9e0ae047ebff7fd0920b7214041483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422261 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#808933}
-
David Bienvenu authored
Change-Id: I6875db3512929aa5671f199acebdd9bbb1d3fefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422241 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#808932}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3fb34c1e. With Chromium commits locally applied on WPT: b943d006 "[COOP] Access reporting with 2 reporters." f5abb9c0 "[mathml] Update CSS math-style to match specification update" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/cookies NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I81956fd545db263a0b76c022483f4b1f0819d01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421869Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808931}
-
Filip Gorski authored
The issue observed with Find in Page is that when there is nothing yet to search for (no input) the Talk Back order of visited controls is incorrect: Text entry field is followed by web contents and its elements that can be jumped to, and not by the remaining Find in Page toolbar controls (previous, next and close buttons). The problem happens because the search results counter field, while visible with no input, carries no focusable content. That makes the accessibility API fail and jump to web contents. This patch ensures that the field is gone, when there is no content for it to hold, and makes it visible as soon as there is content. Bug: 1093480 Change-Id: I158114b8b07f7defa12671ab900736ea728401e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421293Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#808930}
-
Alice Wang authored
This CL adjusts the scope of the methods called only in native in WebSigninBridge. Bug: 1124737 Change-Id: I353dea64e7382da0dac4569cd4a4b418d7c869c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421112Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808929}
-
Tanmoy Mollik authored
Sync error card for sync error incomplete is shown when the ManageSyncSettings page is launched from signin screen. This cl fixes the issue. Bug: 1129935 Change-Id: I9410b902681b2908479f5b64376b34cc57b23a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418955 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#808928}
-
Wan-Teh Chang authored
It is generate_source.py, not generate_sources.py. Change-Id: I2b44dd0ac343d1eaa91b48a4402406009c82b052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419588Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#808927}
-
Jeffrey Young authored
Append a link to the assistant in launcher results when no tiles are shown. Gated by feature "EnabledEmbeddedAssistantUI". https://screenshot.googleplex.com/9H5Ds7TjUPmgoxi.png BUG=1103703 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I28dc5c06a85863d0f78eb1da26b214c774008041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388001Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#808926}
-
Sebastien Lalancette authored
Bug: 1103778 Change-Id: Id4fa1e2ff13e376bfd8d8c99e7405793375225d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422179Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#808925}
-
Martin Šrámek authored
Since we plan to reuse these triggers for another round of surveys soon. Bug: None Change-Id: I7ad17f483288afbac90955ca1a24e21fd9973397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421489Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#808924}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic87fc75ebf9015fb05d9b71b3d1f06a02573e06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422205Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808923}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009210800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/cIWqR5ZGkLWwRsrEQfxfW_msq-yAvUIUa0Xxwz6bCXkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/152286436,b/159892033,b/162706572,b/165872577,b/165883916,b/168080782 Tbr: media-app@grotations.appspotmail.com Change-Id: I83bad7ba8ef0f532a66b4bb56d9a51a6fe44510a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422206Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808922}
-
Dave Tapuska authored
This change moves the rest of the UpdateVisualState handling into blink. No functional changes are intended. BUG=1097816 Change-Id: Ib162f3add233971c76ceff4206e113bf66c6ad8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402116 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#808921}
-
Victor Hugo Vianna Silva authored
Some code that has minimal dependencies on AndroidSyncSettings depends unnecessarily on SyncContentResolverDelegate in its tests. This CL removes these dependencies (either by mocking AndroidSyncSettings or by using AndroidSyncSettingsTestUtils) and SyncContentResolverDelegate is made a package-private class. Bug: 1129426 Change-Id: I5374ea7378456bc7060e186254d3e6f80523ceb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421811 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#808920}
-