- 24 Jul, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f564f1515bde..fdf4bfe6d389 git log f564f1515bde..fdf4bfe6d389 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 halcanary@google.com SkQP: Refactor Java method SkQP.runTests() Created with: gclient setdep -r src/third_party/skia@fdf4bfe6d389 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: Ie87664bbee3a2689e9aded26a1b9450b7f185168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716608Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680467}
-
Yue Zhang authored
https://crrev.com/c/1666270 this CL uses recyclerView.removeViewAt to manually remove dropped view and avoid calling notifyDataSetChanged(). However, removing using index can be problematic if there are scrolling and recycling in recyclerView. This CL fixes this issue. Bug: 985904 Change-Id: I207206bbd4830b1762bfd1a22f998b2617f43fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714215Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#680466}
-
Aga Wronska authored
Bug: 939593 Change-Id: Ifb09f92e3188c161038557f6c2384a1f1a6c4d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713866Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#680465}
-
Stephane Zermatten authored
AA Dropout metrics don't make much sense when direct actions are used to trigger scripts. This change turns them off in a way that keeps the guarantee that dropouts are tracked if and only if AA_START was recorded, which is done in the Facade, just before calling Start. In other cases, dropouts are not measured yet. There should be some separate metrics for tracking scripts started by direct actions. Bug: b/138288747 Change-Id: If6792b6173983a289ce08978d52d68bd3c161dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715693 Auto-Submit: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#680464}
-
Yue Zhang authored
Bug: 986849 Change-Id: I718c19178ac078414cd773f657c64000ad61cdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715225Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#680463}
-
Peng Huang authored
Bug: 985024 Change-Id: Idca21625c38971fc53c58cfa9d644aedf1bbe7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716303 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#680462}
-
Salvador Guerrero authored
LevelDB.ApproximateMemTableMemoryUse helps us track memory usage for leveldb_proto databases, as we'll migrate clients from multiple instances to a single shared instance this histogram will be useful to track possible performance regressions. This CL extends the histogram's expiration by 1 year, and replaces ssid@ with salg@ as an owner. Bug: 986506 Change-Id: I30c472c8ccc3df844de85e6890e17e2ce0dc0234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715543Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#680461}
-
Becca Hughes authored
This is follow up from https://crrev.com/c/1706777 Replaces last updated time with base::TimeTicks. BUG=986542 Change-Id: Icfda207848085a7b7d15c87b3fcf94c87eee3609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715504 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#680460}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I6fdac09b795461c2f1de6be177b2ce141fcab529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715006 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#680459}
-
Becca Hughes authored
Adds position state to WMPI. This is a combination of playback rate, duration and current time and is used to display the playback position in the UI. The next step is sending this to the browser process. BUG=985394 Change-Id: I76a3671d6357d5fb620e05857e3519de6707fbc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706777Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#680458}
-
BUG=762641 TBR=malaykeshav@google.com Change-Id: If8925fc68ccf05d43ce1ade9ef631bfc2745622a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716177Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#680457}
-
Yi Su authored
ContentSuggestionsService now can possibly return ContentSuggestion objects with empty |salient_image_url| if the image is not allowed to be displayed due to EUCD compliance. If the image URL is not valid, ContentSuggestionsItem.hasImage should be set to NO so that ContentSuggestionCell will use the new layout without image placeholder. The layout of ContentSuggestionCell when feature flag kOptionalArticleThumbnail is enabled is also changed a bit. The subtitle will now attach to the bottom of the main title instead of the bottom of the cell. Notice that under normal font size and when image is missing, the minimum height of the cell is still default-image-height+2*margin, which means there might be some extra space at the bottom of the cell. screenshots: normal-font-top https://drive.google.com/open?id=1uYBuv935wem-Q6UC6dMWSHNa-BHS754j normal-font-bottom https://drive.google.com/open?id=1Yb9vALnGV1w7wmqysL-6_df1cuYeTd7Z a11y-font-top https://drive.google.com/open?id=1totdzFd9DAEAsQL4mKeO-kpVa1yNjChs a11y-font-bottom https://drive.google.com/open?id=1U6lgtNVKMTrowvkgYIuTGlQxY-8UQgKb Bug: 978061 Change-Id: I5ca3f2de7d8304ae48d309180c36b4d466c4a75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715371Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#680456}
-
Junbo Ke authored
ResourceDispatcherHostDelegate is deprecated in network service path. Bug: 985873 Test: build cast_shell Change-Id: Ibb34749c6b01c969fb61d91b286593ad7af6edb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716284Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#680455}
-
Aga Wronska authored
The tests used to be flaky. Re-enabling them to check if they are still flaky after code mauve. (Code mauve did changes to login tests building blocks) Bug: 936407 Change-Id: I7dc8102ac6fe7e75c47deb028fb4cf2de0dc631f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714024Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#680454}
-
Ren-Pei Zeng authored
When creating VASurface from VideoFrame in VaapiDmaBufVideoFrameMapper, remove the usage of VaapiPicture to avoid pulling Ozone/EGL specific codes. Bug: b:120057531 Test: video_decode_accelerator_tests Change-Id: Iaad5abb53a84901734d330a341ed265bb9cf8e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701661 Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#680453}
-
Samuel Huang authored
To prepare for handling native resource loading after DFM installation, this CL adds a new hook in ModuleInstallerBackend.onFinished() to call (via JNI) a new native handler for each newly installed module: JNI_ModuleInstallerBackend_OnInstallModule() AsyncTask is used to make the JNI call asynchronous, taking place outside the UI thread. This allows file access (e.g., to open native resources) to take place in the native code, thereby preventing assert failure in Debug builds. After the JNI call, |mListener.onFinished()| is called on UI thread, just like before. Bug: 927131 Change-Id: I36880cc7739a48534052b51d3d655d1ae0beb29a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702905 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#680452}
-
Andrew Grieve authored
Change-Id: Ia041cfab55543c476f85ed92e0f82812ce1e011d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716917 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#680451}
-
Avi Drissman authored
This reverts commit 584c663e. Reason for revert: New entitlement incompatible with signing Original change's description: > Implement support for macOS 10.15 Universal Links. > > Reuse the PWA intent picker for the UI. > > BUG=981337 > > Change-Id: Ib4956fb0218d9d6055c315a4fcb579094ea0daec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703487 > Commit-Queue: Avi Drissman <avi@chromium.org> > Reviewed-by: Maggie Cai <mxcai@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680138} TBR=avi@chromium.org,rsesek@chromium.org,dominickn@chromium.org,mxcai@chromium.org Change-Id: I49114ca972f4bb3c9dca4f86a18c71bbf01f80fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 981337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716255Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#680450}
-
Rahul Arakeri authored
This CL improves readability by splitting GetScrollDeltaFromPointerDown into 2 separate functions with specific tasks: - GetScrollbarPartFromPointerDown: Determines the ScrollbarPart that was hit based on the supplied pointer position. - GetScrollOffsetForScrollbarPart: Determines ScrollOffset based on the hit tested ScrollbarPart and the orientation. Bug: 987163 Change-Id: I89acddc1dd8d65042c468383a9e99abd50e4b7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716606Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#680449}
-
Jordan Demeulenaere authored
Change-Id: I81c4e271fb5500bc40c0f8cd459c96bacbaeebd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713638Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#680448}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3439373f..212a3bf6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I262f93a431fb26988ced0177e67232543ace2d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715419Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680447}
-
Steve Kobes authored
These steps will need to be deferred for pointerdown buffering. Also expand logging to indicate when layout shifts were ignored due to recent input. Bug: 978027 Change-Id: I9beca66d9d626de8f1327d730e41ed9bdebbcfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715228Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#680446}
-
Majid Valipour authored
These counters are added to better understand potential breakage once we change the viewport style propagation logic for scroll snap props [1] They should be removed once we successfully make the change. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1704859 R=bokan@chromium.org Bug: 952711 Change-Id: I7651968b9699e4ecec9d44a148f9968b73d357bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715906 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#680445}
-
Kevin Babbitt authored
In http://crrev.com/c/1693772, Tricium flagged out-of-order includes in the last patchset after I sent it to CQ. This CL fixes the issue. R=nektar@chromium.org Change-Id: Ie0555ab86ca001ae908391a61ead9049e0bd9c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715627 Auto-Submit: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#680444}
-
ssid authored
Change-Id: I488a82d11c1f142182355471eb00fcccb8938e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713846Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#680443}
-
Javier Ernesto Flores Robles authored
Changes the fallback icon to the tiny world one. Bug: 987174 Change-Id: Ic959867784076e7fba3c6693226bb63383af36ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715274 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#680442}
-
Rune Lillesveen authored
Bug: 305376 Change-Id: I5cbd87d04852a4605507859dd39187c24e282d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715814Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#680441}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b42ca287673..f9c500b31ad8 Created with: gclient setdep -r src-internal@f9c500b31ad8 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: I2a526f655775ded79520ffa3d2bb7e6241d3f171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716607Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680440}
-
Peter Kotwicz authored
This CL moves the grantUriPermissionToHostBrowser() call to TransparentLauncherActivity/H2OTransparentLauncherActivity which receive the share intent from the sharer app (vs SplashActivity which receives a copy of the share intent from H2OTransparentLauncherActivity) BUG=982394 Change-Id: I37ca0f168e312e03e58158b9b858879cc5771fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715534Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#680439}
-
Becky Zhou authored
We removed logic listening to BottomSheetObserver from https://chromium-review.googlesource.com/c/chromium/src/+/1553710, but there are some obsolete logic causing the view hierarchy not updated correctly. Bug: 984793 Change-Id: Ibef11b60324bbf10abafafd6c73041f3fd20175d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709005 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#680438}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cb636760. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6a6b173b "Add type option to showToast helper" a148378d "KV Storage: rename storage export to default" 43ad80dd "[css-typed-om] Don't crash when setting CSSVariableReferenceValue." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6f1d6269ea573b050c4ba69eb55690fb87444133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716926Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680437}
-
Leonard Grey authored
This reverts commit 9bc33932. Reason for revert: https://crbug.com/987044 Original change's description: > Mac: Record process “energy impact” to UMA > > This is a synthetic estimate displayed to users in Activity Monitor, the battery menu, and top. > More info at https://blog.mozilla.org/nnethercote/2015/08/26/what-does-the-os-x-activity-monitors-energy-impact-actually-measure/ > > Bug: 969105 > Change-Id: Ie3438307226c3f9a46459948ea88efb6479de0c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707472 > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#679557} TBR=isherman@chromium.org,oysteine@chromium.org,lgrey@chromium.org,mark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 969105 Change-Id: Iec95be777c3816183dc92fd87797bbb0cc890ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715509Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#680436}
-
Mario Sanchez Prada authored
This reverts commit 93120719. Reason for revert: It's possible that this patch has caused the renderer process to crash on Android, perhaps due to the last minute change to make SurroundingTextImpl a Supplement<LocalFrame> (see [1]), so let's revert it for now. [1]https://chromium-review.googlesource.com/c/chromium/src/+/1698413/8..12 Original change's description: > Migrate blink::SurroundingTextImpl from WebLocalFrame to LocalFrame > > Now that we have blink::SurroundingText inside Blink and implemented > using internal Blink types like WTF::String and LocalFrame, we can > finally migrate blink::SurroundingTextImpl away from WebLocalFrame > and remove the DEPS exception rule we previously introduced during > this process of Onion Soup'ing the SurroundingText API. > > Additionally, we move the instantiation of blink::SurroundingTextImpl > from WebLocalFrame to LocalFrame as well and, with that, we remove any > reference to public Blink classes from SurroundingText-related code. > > Bug: 980151 > Change-Id: I1a1014dbf6671b9327a068ceca4f62d873cb5fb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698413 > Commit-Queue: Mario Sanchez Prada <mario@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680346} TBR=haraken@chromium.org,mario@igalia.com Change-Id: Ic351b09b2c57a316f14473c8a1dfefd96b909386 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 980151, 987214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715197Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#680435}
-
Steve Kobes authored
The trace event now incorporates move distance into the score field, reflecting CLS calculation, and score_with_move_distance is removed. PerFrameTraceData now computes the granularity scale instead of having it passed in. This paves the way to defer reporting on pointerdown. Also removed references to "jank" in variable names and comments. Bug: 963474, 978027 Change-Id: I87d69aa628446c46ce25647914b5d9c0dbcc1fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714992Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#680434}
-
Tanmoy Mollik authored
This histogram was removed in this cl https://crrev.com/c/1688844 Bug: 975910 Change-Id: I05654fbf8f3516c16ef389322bca15de94351aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715364Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#680433}
-
Alex Chau authored
- Make time_to_live shorter than send timeout to avoid false send error Bug: 987175 Change-Id: I9a67820f90ee43681eb1ea6e6b07d6fb7443b890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715494 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#680432}
-
Weiliang Chen authored
When using a BufferQueue, the OutputSurface is treated as an Overlay, and is made into an OverlayCandidate. That overlay candidate is then pushed in as the front of the candidate list. This CL changes it into its own type instead of checking for a bool on OverlayCandidate. R=rjkroege Bug: 963597 Change-Id: I05588ba4d3b1ac03ed01ac0fff25d9ae03fc28c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696168 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#680431}
-
Maxim Kolosovskiy authored
This reverts commit f4a585a3. Reason for revert: This CL causes failures of SettingsUIBrowserTest.All The first failed build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/14356 Original change's description: > WebUI: Remove --cr-list-item-focus and --cr-selectable-focus mixins > > This CL removes the unused --cr-list-item-focus mixin and moves all > the CSS properties/values from --cr-selectable-focus to the only > place where they were being used. > > https://imgur.com/a/yFz9k61 > > Bug: 973674 > Change-Id: I95f93fcfee6dc7b77ce5180a7875a1b526f066e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710852 > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Commit-Queue: John Lee <johntlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#679323} TBR=hcarmona@chromium.org,johntlee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973674 Change-Id: I777671fc0d62f5a307a410c4d9b8b108aa5ef83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715691Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#680430}
-
Stephane Zermatten authored
This change makes cancel/close available on the UI, available as a direct action with the same behavior when the UI is up. When the UI is not up, "cancel" is only available if it exists in UserAction as a direct action. When the UI is up, "cancel" is executed through the UIController instead of being run directly as a UserAction. This allows closing the UI or showing the undoable snackbar as a result of the "cancel" direct action being executed. Bug: b/134742442 Change-Id: Ia43275a090a0ad2a440447b175fdcf15dd893430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699675 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#680429}
-
Alexander Yashkin authored
Change-Id: Ib777e1293012c37b2622be97aca7a8e61ce66d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715272Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#680428}
-