GitLab

Revert of mojo: Add a runloop utility in python (patchset #3 id:40001 of https://codereview.chromium.org/552783004/)

Reason for revert:
This fails on the build bots.

======================================================================
ERROR: testRunLoop (runloop_unittest.RunLoopTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/data/b/build/slave/Linux_Tests/build/src/mojo/python/tests/runloop_unittest.py", line 24, in testRunLoop
    loop = system.RunLoop()
AttributeError: 'module' object has no attribute 'RunLoop'

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/13669/steps/mojo_python_bindings_tests/logs/stdio

Original issue's description:
> mojo: Add a runloop utility in python
>
> This is necessary to be able to use async operation on handles.
>
> R=sdefresne@chromium.org,cmasone@chromium.org
>
> Committed: https://crrev.com/830c88cca3c89dfabcbfc360ac7c035a020b8307
> Cr-Commit-Position: refs/heads/master@{#295267}

TBR=cmasone@chromium.org,sdefresne@chromium.org,qsr@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/575893004

Cr-Commit-Position: refs/heads/master@{#295280}

Cleaning up weak_ptr_factory destruction order.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/581563002

Cr-Commit-Position: refs/heads/master@{#295279}

The trailing '\' on a comment line produces following error on gcc 4.8

chrome/browser/extensions/chrome_url_request_util.h:29:1:
    error: multi-line comment [-Werror=comment]

TBR=fsamuel@chromium.org, lfg@chromium.org, rockot@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/552103003

Cr-Commit-Position: refs/heads/master@{#295278}

When the files in //content are in their final positions I'll add those
to the watchlist too.

BUG=

Review URL: https://codereview.chromium.org/575043002

Cr-Commit-Position: refs/heads/master@{#295277}

This CL moves TranslateHelper to the translate component.

A couple dependencies had to be injected, through the constructor:
- extensions (group and scheme)
- isolated world id

BUG=335087
TBR=jochen

Review URL: https://codereview.chromium.org/564793003

Cr-Commit-Position: refs/heads/master@{#295276}

If process_name is greater than 50 characters, display truncated process_name

BUG=340294
NOTRY=true

Review URL: https://codereview.chromium.org/559113002

Cr-Commit-Position: refs/heads/master@{#295275}

This fixes a regression introduced by CL
https://chromiumcodereview.appspot.com/379143002/.

BUG=405812, 408684

Review URL: https://codereview.chromium.org/494083002

Cr-Commit-Position: refs/heads/master@{#295274}

https://skia.googlesource.com/skia/+log/170f90b4576f291879371ecd6ae4bc2b1d85c64a..b0a35f7c5d2c4bfeb601e3ac43f412d202a25292

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/575023002

Cr-Commit-Position: refs/heads/master@{#295273}

Not required anymore after crrev.com/555503006
This reverts commit df01991e.

BUG=407545
TBR=anton@chromium.org

Review URL: https://codereview.chromium.org/576123002

Cr-Commit-Position: refs/heads/master@{#295272}

HttpNetworkTransactionSpdy*Test has been removed in https://crrev.com/17028007,
making these FRIEND statements obsolete.

BUG=118883

Review URL: https://codereview.chromium.org/580473002

Cr-Commit-Position: refs/heads/master@{#295271}

https://chromium.googlesource.com/chromium/blink/+log/b4e442fe37dd474df89b221e0f6fbf083730bc0c..67581588750bb81e5e495ec615dd5ef74eb0ba59
TBR=dpranke@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/576103002

Cr-Commit-Position: refs/heads/master@{#295270}

As FontSizePrefs class is singleton and will be alive till the entire application lifespan
and there are no references for destroy(), hence destroy() implemention can be removed.

BUG=None.

Review URL: https://codereview.chromium.org/563743002

Cr-Commit-Position: refs/heads/master@{#295269}

Adjust the z-order of the virtual keyboard to ensure that it does not overlap context menus.  Previously, the virtual keyboard was placed just below the cursor container.  Adding a test case to ensure that the virtual keyboard overlaps normal windows but not menus.

BUG=377180

Review URL: https://codereview.chromium.org/565373002

Cr-Commit-Position: refs/heads/master@{#295268}

This is necessary to be able to use async operation on handles.

R=sdefresne@chromium.org,cmasone@chromium.org

Review URL: https://codereview.chromium.org/552783004

Cr-Commit-Position: refs/heads/master@{#295267}

Cr-Commit-Position: refs/heads/master@{#295266}

BUG=none
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/570423002

Cr-Commit-Position: refs/heads/master@{#295265}

BUG=414644

Review URL: https://codereview.chromium.org/572233002

Cr-Commit-Position: refs/heads/master@{#295264}

https://chromium.googlesource.com/chromium/blink/+log/48c74875dbbd1bfdcab18a17a3b3710487aaefb5..b4e442fe37dd474df89b221e0f6fbf083730bc0c
TBR=dpranke@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/566063005

Cr-Commit-Position: refs/heads/master@{#295263}

Revert of Use chromeos accelerometer reader and support only lid accelerometer. (patchset #3 id:60001 of https://codereview.chromium.org/574113002/)

Reason for revert:
Breaks ChromeOS compilation http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/11155/steps/compile/logs/stdio

Original issue's description:
> Use chromeos accelerometer reader in athena and support only lid accelerometer.
>
> BUG=380831
> TEST=Glimmer/clapper still work, manually tested not having a base accelerometer.
>
> Committed: https://crrev.com/2aa8d2e93a06cc7673c872704c04e933bd6cc252
> Cr-Commit-Position: refs/heads/master@{#295258}

TBR=derat@chromium.org,oshima@chromium.org,flackr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=380831

Review URL: https://codereview.chromium.org/571283006

Cr-Commit-Position: refs/heads/master@{#295262}

R=jkarlin@chromium.org

Review URL: https://codereview.chromium.org/580793002

Cr-Commit-Position: refs/heads/master@{#295261}

Move two variable declarations to the top of their function, so
Chromium's version of SQLite compiles on Windows. SQLite is used
by NSS on Dart's standalone Windows executable.

NOTRY=true
This is not based on src/, and is not tested until DEPS are updated.

This patch is not added to recover.patch, because the last 3 patches,
including the one this fixes, are not there, and recover.patch says:
    Since recover.c is in somewhat active development, it is possible that
    the patch below will not reliably re-create the file.

Review URL: https://codereview.chromium.org/552673003

Cr-Commit-Position: refs/heads/master@{#295260}

BUG=410824

Review URL: https://codereview.chromium.org/577933002

Cr-Commit-Position: refs/heads/master@{#295259}

BUG=380831
TEST=Glimmer/clapper still work, manually tested not having a base accelerometer.

Review URL: https://codereview.chromium.org/574113002

Cr-Commit-Position: refs/heads/master@{#295258}

BUG=415092
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/551563003

Cr-Commit-Position: refs/heads/master@{#295257}

This is using the short_name and the name set in the Manifest.

BUG=366145

Review URL: https://codereview.chromium.org/573073002

Cr-Commit-Position: refs/heads/master@{#295256}

https://chromium.googlesource.com/chromium/blink/+log/950989fb2c87550e55d5a09f04071998b96b1c1f..48c74875dbbd1bfdcab18a17a3b3710487aaefb5
TBR=dpranke@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/556243007

Cr-Commit-Position: refs/heads/master@{#295255}

This way we'll get saner and less noisy histogram-based results.

Rationale for moving histogram_utils.py: HistogramValue is part of
telemetry.value, so it makes sense that all utils it needs are there too;
doesn't make sense to import the utils from metrics.

BUG=

Review URL: https://codereview.chromium.org/578593004

Cr-Commit-Position: refs/heads/master@{#295254}

This implements a Cast button in the default media controls, and a second,
overlayed Cast button on videos that don't use the default controls.

This replaces the previous implementation of the cast button in the
Android UI.

Pressing the Cast button asks the browser UI to bring up cast device
selection menu. If a device is selected the video or audio will be played
on that device, rather than locally.

The Cast buttons are only displayed when there are cast devices available.

Currently this is only implemented for Android; on other targets Chrome
will always tell Blink that there are no devices available.

Depends on Blink issue https://codereview.chromium.org/291163004/

BUG=390125

Review URL: https://codereview.chromium.org/349923007

Cr-Commit-Position: refs/heads/master@{#295253}

This CL changes the padding values in the experimental app list to
precisely match the padding spec.

BUG=411775

Review URL: https://codereview.chromium.org/570233002

Cr-Commit-Position: refs/heads/master@{#295252}

Also makes the scheduler state machine output use the scheduler Now() value so
the output is identical on every run during tests.

BUG=380889

Review URL: https://codereview.chromium.org/576013002

Cr-Commit-Position: refs/heads/master@{#295251}

This CL updates the layout of the experimental app list's start page to
suit its new size.

BUG=411775

Review URL: https://codereview.chromium.org/578543002

Cr-Commit-Position: refs/heads/master@{#295250}

BUG=

Review URL: https://codereview.chromium.org/574843003

Cr-Commit-Position: refs/heads/master@{#295249}

Empirically it can take chrome up to 40 seconds to come up for a cold start on the 10.6 bots. Increase the timeout in Telemetry to reduce test flakiness.

BUG=405386

Review URL: https://codereview.chromium.org/568673004

Cr-Commit-Position: refs/heads/master@{#295248}

R=darin@chromium.org

Review URL: https://codereview.chromium.org/563743005

Cr-Commit-Position: refs/heads/master@{#295247}

Errors reported by closure linter are fixed to keep accordance with style guide and prepare for closure compiler
Some errors are ignored.
- E:0007: We don't adopt the blank-line policy as it's not specified by style guide.
- E:0011,0002,0225: There are some false positives around bind().
- E:0121: Comma at end of object literal is valid in ES5, and not prohibited by style guide.

BUG=412662
TEST=find ui/file_manager -name *.js ! -path */*_scripts.js | xargs gjslint --strict --disable 0007,0011,0002,0121,0225

Review URL: https://codereview.chromium.org/571453002

Cr-Commit-Position: refs/heads/master@{#295246}

Revert of Second attempt to land change to remove NativeViewportService and (patchset #9 id:160001 of https://codereview.chromium.org/568883003/)

Reason for revert:
ViewManagerTest failure.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=chromium.win&testType=mojo_view_manager_unittests&tests=ViewManagerTest.AddAncestorFails,ViewManagerTest.AddViewWithNoChange,ViewManagerTest.CantAccessChildrenOfEmbeddedView,ViewManagerTest.CantGetViewTreeOfOtherRoots,ViewManagerTest.CantModifyChildrenOfEmbeddedView,ViewManagerTest.CantRemoveViewsInOtherRoots,ViewManagerTest.CreateView,ViewManagerTest.DeleteView,ViewManagerTest.DeleteViewFromAnotherConnectionDisallowed,ViewManagerTest.EmbedWithSameViewId,ViewManagerTest.EmbedWithSameViewId2,ViewManagerTest.MultipleEmbedRootsBeforeWTHReady,ViewManagerTest.OnViewInput,ViewManagerTest.ReorderView,ViewManagerTest.ReuseDeletedViewId,ViewManagerTest.SetViewVisibility,ViewManagerTest.SetViewVisibilityNotifications,ViewManagerTest.ViewHierarchyChangedAddingKnownToUnknown,ViewManagerTest.ViewHierarchyChangedViews,ViewManagerTest.ViewsRemovedWhenEmbedding

Original issue's description:
> Second attempt to land change to remove NativeViewportService and
> ViewManager from mojo_shell. First attempt here:
> https://codereview.chromium.org/477923004/
>
> Failed the linux gn dbg build after cq landed:
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/12251
>
> BUG=
> TBR=ben@chromium.org
>
> Committed: https://crrev.com/d3e622b0bb31f20c274bc9ad634b8ee7bae99ac1
> Cr-Commit-Position: refs/heads/master@{#295230}

TBR=jamesr@chromium.org,davemoore@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/578793002

Cr-Commit-Position: refs/heads/master@{#295245}

Move non-trival constructor and destructor out of line.

R=phajdan.jr@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/569193002

Cr-Commit-Position: refs/heads/master@{#295244}

https://chromium.googlesource.com/chromium/blink/+log/829f4154fb8a3afc1bee0c3487e2f5a4060e66ea..950989fb2c87550e55d5a09f04071998b96b1c1f
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/580723002

Cr-Commit-Position: refs/heads/master@{#295243}

BUG=414488

Review URL: https://codereview.chromium.org/572083004

Cr-Commit-Position: refs/heads/master@{#295242}

BUG=401492

Review URL: https://codereview.chromium.org/475633008

Cr-Commit-Position: refs/heads/master@{#295241}