GitLab

BUG=none

Review URL: https://codereview.chromium.org/137723008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247593 0039d316-1c4b-4281-b951-d872f2087c98

SenderId can be either integer obtained from developer dashboard or
email. Android chrome invalidations uses email.
Fix double escaping so that registration server accepts senderId.

Review URL: https://codereview.chromium.org/148153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247592 0039d316-1c4b-4281-b951-d872f2087c98

This patch has only images. The code of new audio player will be committed separately.

The images are copied from
https://code.google.com/p/chromium/issues/detail?id=273308#c13

BUG=273308
TEST=none
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/145423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247591 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an incorrect assumption in
PasswordAutofillAgentTest.InlineAutocomplete. Previously, this code assumed
that one trip through the event loop was sufficient to ensure that style was
recalcuated. After we move recalc style to be triggered by
requestAnimationFrame, this assumption will no longer be valid. This CL changes
the test to explicitly recalc style by calling WebView::layout.

Unfortunately, we cannot simply call WebView::layout in straight-line code
because this test does some of its work off the event loop. Instead, we need to
schedule the call to layout after we schedule the other async work.

BUG=337617
R=gcasto@chromium.org

Review URL: https://codereview.chromium.org/136003013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247590 0039d316-1c4b-4281-b951-d872f2087c98

We still need to pass RWHVGuest::SelectionChanged() call to platform_view_.
This broke while adding IME support, this function doesn't seem to be required for IME (made sure by running BrowserPluginHostTest.InputMethod).

Wrote a browser_test to catch the regression.

BUG=331722
Test=Open a <webview> in a chrome app. Select some text. Observe that "Look up in dictionary" and "Speech=>Start Speaking" features work.

Review URL: https://codereview.chromium.org/148433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247589 0039d316-1c4b-4281-b951-d872f2087c98

> Add the viewer toolbar to the PDF extension.
> 
> BUG=303491
> R=arv@chromium.org, ganetsky@chromium.org
> 
> Review URL: https://codereview.chromium.org/110723007

TBR=raymes@google.com

Review URL: https://codereview.chromium.org/135183012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247588 0039d316-1c4b-4281-b951-d872f2087c98

So we can see if we're hitting the timeout, how long requests take, etc.

BUG=302816

Review URL: https://codereview.chromium.org/148573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247587 0039d316-1c4b-4281-b951-d872f2087c98

(See https://code.google.com/p/gyp/source/detail?r=1846 for
how GYP deals with this.)

BUG=82385

Review URL: https://codereview.chromium.org/147083011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247586 0039d316-1c4b-4281-b951-d872f2087c98

This is a sideeffect of the fake WS_VSCROLL and WS_HSCROLL styles added to the window and us hiding the scrollbars
during sizing operations.

Bug does not exist on Windows 8. On Windows 7 hovering near the bottom right portion of the window where the vertical
scrollbar would be returns HTBOTTOMRIGHT instead of HTVSCROLL or HTHSCROLL which we already handle. This eventually results
in non client mouse messages like WM_NCMOUSEMOVE/WM_NCMOUSEDOWN being sent to the RWHA window which are ignored.

Attempted fix is to check in WM_NCHITTEST if the mouse coordinates are in the bottom portion of the window using metrics
like SM_CXVSCROLL/SM_CYVSCROLL/SM_CXSIZEFRAME/SM_CYSIZEFRAME and if yes convert the hittest code to HTCLIENT.

BUG=335487
R=sky@chromium.org, sky

Review URL: https://codereview.chromium.org/145513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=324859

Review URL: https://codereview.chromium.org/142863006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247583 0039d316-1c4b-4281-b951-d872f2087c98

The new trace event will include time to setup gpu canvas.

BUG=334492

Review URL: https://codereview.chromium.org/132743007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247582 0039d316-1c4b-4281-b951-d872f2087c98

The previous patch had a bug. Instead of modelItem.entry, entry was used, which was always undefined.

TEST=Tested manually.
BUG=337575

Review URL: https://codereview.chromium.org/143653014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247581 0039d316-1c4b-4281-b951-d872f2087c98

Bookmark apps can currently get square icons. This CL rounds the icons
when displaying them in the app launcher.

BUG=315632

Review URL: https://codereview.chromium.org/135533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247580 0039d316-1c4b-4281-b951-d872f2087c98

BUG=303491
R=arv@chromium.org, ganetsky@chromium.org

Review URL: https://codereview.chromium.org/110723007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247578 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247574 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ganetsky@chromium.org

Review URL: https://codereview.chromium.org/146693013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247573 0039d316-1c4b-4281-b951-d872f2087c98

In BrowserMainLoop::ShutdownThreadsAndCleanUp(), we explicitly call
a new ZygoteHostImpl::TearDownAfterLastChild API to notify the Zygote
to exit after its last child died.

The notification is to simply close the IPC channel to the Zygote.
Before this patch, this would happen implicitly when the browser process
died.

To implement this, we add a lightweight child tracking mechanism to ZygoteHostImpl.

BUG=334345
R=piman@chromium.org

Review URL: https://codereview.chromium.org/148443006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247572 0039d316-1c4b-4281-b951-d872f2087c98

If targets shouldn't be part of the android build, they should be conditional
in gyp instead.

Removing this line leads to 17 more files being compiled and one more binary
(printing_unittests) being linked on the open source bots, and there are no
build errors.

(An internal build of the 'all' target is also successful, and it builds only
183 additional edges too, which add about 1 minute / 5% to build time.)

BUG=330631
NOTRY=true

Review URL: https://codereview.chromium.org/149103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338787
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/149063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247570 0039d316-1c4b-4281-b951-d872f2087c98

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708

Review URL: https://codereview.chromium.org/149033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247569 0039d316-1c4b-4281-b951-d872f2087c98

Currently the FocusController is destroyed after the root
window. FocusController may use
DesktopNativeWidgetAura::content_window_. Since the FocusController is
destroyed after content_window_ it is entirely possible for
FocusController to attempt to use content_window_ after it's been
destroyed.

This patch destroys FocusController before the root.

BUG=314118
TEST=covered by test
R=ben@chromium.org

Review URL: https://codereview.chromium.org/148883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247568 0039d316-1c4b-4281-b951-d872f2087c98

Dependencies added in the range 247500-247514.  I suspect 247509, a
blink roll.

BUG=None
NOTRY=true
NOTREECHECKS=true
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/148583013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334202
R=pfeldman

Review URL: https://codereview.chromium.org/148463009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247566 0039d316-1c4b-4281-b951-d872f2087c98

This should fixe the issues seen in the bug, and includes some cleanup
in prep for syncing folders.

BUG=338520
TBR=jamescook@chromium.org for ash_shell.cc

Review URL: https://codereview.chromium.org/148403007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247565 0039d316-1c4b-4281-b951-d872f2087c98

This test assumes that spinning the event loop is sufficient to trigger
asynchronous style recalculation. After we move style recalculation to be
triggered off requestAnimationFrame, this assumption will no longer be valid.
This CL removes this assumption by triggering layout explicitly

R=fsamuel@chromium.org
BUG=337617

Review URL: https://codereview.chromium.org/148153013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=305652,223859

Review URL: https://codereview.chromium.org/148153011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247562 0039d316-1c4b-4281-b951-d872f2087c98

- RelativeFileSystemPath (also called VirtualPath) is the path appended
in the filesystem URL, after .../external/. So it looks like
"drive-xxx/root/foo/bar" or "Downloads-xxx/foo/bar".
Note that in the Drive case, it begins with the mount point name,
that differs from profile to profile.

- DrivePath is the path in the hierarchy we manage in drive::ResourceMetadata.
It is like "drive/root/foo/bar" and always begins with "drive".

Every path comes from drive::FileSystem is in DrivePath.
Every path that will be the part of FileSystem API must be in RelativeFileSystemPath.
We need proper conversion for the bridging codes.

BUG=337095

Review URL: https://codereview.chromium.org/147993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247561 0039d316-1c4b-4281-b951-d872f2087c98

Store() and MarkAsDirty() should be performed together, atomically.
Otherwise, it may cause troubles when something goes wrong. (e.g. sudden shutdown of the device)

Provide a way to perform Store() and MarkAsDirty() at the same time by specially handling empty MD5.

BUG=260539
TEST=unit_tests

Review URL: https://codereview.chromium.org/146833015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247559 0039d316-1c4b-4281-b951-d872f2087c98

BUG=272596
TEST=chromeos_unittests under valgrind

Review URL: https://codereview.chromium.org/145273015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247558 0039d316-1c4b-4281-b951-d872f2087c98

This patch cleans up the initialization code, by separating the current directory from selection. Before, there was only one variable holding either current directory or the selection, and heuristics were used to determine how to interpred the path there.
The new code is also a preparation for migrating to URLs, since there are no more operations on the passed paths on the JS side. Note, that before we were fetching parent of a non existing path, which would be very tricky after migrating to URLs.

And finally, this patch fixes wrong behaviour of the select directory dialog. Since now, the selected directory is really selected, and not opened.

TEST=Tested manually several scenarios. All dialogs + recovering from crash. Drive and Downloads.
BUG=328767, 321962

Review URL: https://codereview.chromium.org/144783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247556 0039d316-1c4b-4281-b951-d872f2087c98

Kills some dead code because it is no longer possible to drag maximized windows. (https://codereview.chromium.org/80323002)

Also removes DragDetails::window_resizer which is no longer needed.

Review URL: https://codereview.chromium.org/144713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=no change

Review URL: https://codereview.chromium.org/144343005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247553 0039d316-1c4b-4281-b951-d872f2087c98

This is the first checkin for creating a new sync datatype for the synced notifications app info.  The new datatype will be used for synced notification metadata such as the name and icon of the service sending the synced notification.

BUG=280266

Review URL: https://codereview.chromium.org/143973006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247551 0039d316-1c4b-4281-b951-d872f2087c98

chrome://network is only available on ChromeOS so other builds
should not include the strings for it.

BUG=326023
NOTRY=true

Review URL: https://codereview.chromium.org/136683007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247550 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/79673003
and reverted here:
https://codereview.chromium.org/120323002/

I think the build failure was because "browser" target should depend
on "cast_channel_proto" so that cast_channel.pb.h is built before
browser target is built.

Review URL: https://codereview.chromium.org/132763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247549 0039d316-1c4b-4281-b951-d872f2087c98

Need to revert this because it's causing crashes on Canary.

BUG=338848


> Implement browser-side logging to WebRtc log
> 
> This adds a logging callback to RenderProcessHost and also adds logging
> for device enumeration in the browser process.
> 
> BUG=332261
> 
> Review URL: https://codereview.chromium.org/140843007

TBR=vrk@chromium.org

Review URL: https://codereview.chromium.org/132233058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247548 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Android] Re-enable content_browsertests on main waterfall.  (https://codereview.chromium.org/132403005/)

Reason for revert:
content_browsertests have been crashy and flaky since being re-enabled.

Looks like they crashing on shutdown, but I'm not sure.

Failed:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/11552
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/11554

On this one, content_browsertests crashed but still passed. This caused INJECT_EVENTS exceptions in later tests.
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/18163

We see the same thing downstream.


Original issue's description:
> [Android] Re-enable content_browsertests on main waterfall.
> 
> There's enough infra capacity now.
> 
> BUG=
> R=navabi@chromium.org, navabi@google.com
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247341

TBR=navabi@chromium.org,navabi@google.com,frankf@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/135363005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247547 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83774
R=bbudge@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247473

Review URL: https://codereview.chromium.org/69663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247546 0039d316-1c4b-4281-b951-d872f2087c98

Also validation and parsing of the permessage-deflate extension parameters, and unit tests.

BUG=280910
TEST=net_unittests --gtest_filter=WebSocket*

Review URL: https://codereview.chromium.org/143913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247545 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330672
TEST=*DetachToBrowserTabDragControllerTest.*

Review URL: https://codereview.chromium.org/143153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247544 0039d316-1c4b-4281-b951-d872f2087c98