GitLab

BUG=749785

Change-Id: Id9e7bf25b421199bdb0f6b0dc41d617792a64bbb
Reviewed-on: https://chromium-review.googlesource.com/1093019Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565660}

Some states were not reset after successful fling.

Test: manual
Bug: 850806
Change-Id: I826501e6921163b9f5eaa36dd7a1c6d5de940e94
Reviewed-on: https://chromium-review.googlesource.com/1092152Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565659}

The Android horizontal tab switcher is currently using the same
clipping/visibility logic as the existing overlapping tab switcher. This logic
is largely unnecessary and is in fact causing a bug in RTL mode when we try to
clip a tab from the left side as it goes off-screen (ContentLayer doesn't
properly support clipping the live layer in this case).

This CL splits up the visibility/clipping logic for the overlapping and
non-overlapping tab switchers. For the non-overlapping tab switcher, the only
logic we need is a performance optimization to only draw at most four tabs,
based on which tab is currently centered.

Bug: 849930,831359
Change-Id: Ia000e91b91615acf9f6b071b2d501ee55da231cc
Reviewed-on: https://chromium-review.googlesource.com/1091164Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565658}

When iframe upgrades were moved out of crrev.com/c/1067846 and into
crrev.com/c/1086005, some non iframe specific code was also moved by
mistake, this is that code, along with the tests.

Change-Id: I41aece313c1dd6504e9a27bb85fb810c975e8167
Reviewed-on: https://chromium-review.googlesource.com/1091184Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565657}

This adds frame pausing when new frames are created.

This also changes the browsertests to use the infobar.

Bug: 835895
Change-Id: I79d92bd91ad0482f41a26b0f1ceaddd88d798abb
Reviewed-on: https://chromium-review.googlesource.com/1091496
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565656}

Update the 'value' member variable of the DrmProperty class to be a uint64_t
since this is the type expected by the DRM APIs.

Bug: None
Test: Chrome on Ozone-DRM
Change-Id: I51fe25d1d70e0ffbeda72312b8910c1dd8d41527
Reviewed-on: https://chromium-review.googlesource.com/1091317Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565655}

This reverts commit 25016613.

Reason for revert: Speculative revert for
virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-click-hyperlink.html
failure under WebKit Linux Trusty (dbg) .

Original change's description:
> Fix browser menu button flood fill effect always originating from center
> 
> The MenuButton::PressedLock used to be always created with a null
> event from MenuController::Run() causing it to eventually call
> AnimateInkDrop() with a null event, which then used to clear
> the inkdrop host's `last_ripple_triggering_event_` which is
> used as the point from which the flood fill is generated.
> 
> This CL passes the current located event (if any) to
> MenuButton::PressedLock.
> 
> BUG=819878
> 
> Change-Id: I4fb18ab73f60c75af3bce948f44ac41a8c6683b8
> Reviewed-on: https://chromium-review.googlesource.com/1089495
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565538}

TBR=tapted@chromium.org,afakhry@chromium.org

Change-Id: Ib3c0639e217e4e62d6c8a1aa004eda721e318c4f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 819878
Reviewed-on: https://chromium-review.googlesource.com/1092249Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565654}

This reverts commit 53e1a9c3.

Reason for revert: This appears to cause compile to fail on several Android builder bots, e.g. https://ci.chromium.org/buildbot/chromium.webrtc.fyi/Android%20Builder/16413

Original change's description:
> Created @TraceEvent annotation and corresponding processor
> 
> When a method has the @TraceEvent annotation, it will be transformed to include
> TraceEvent.begin() and TraceEvent.end() at the start and end of the method.
> The function body is moved to a new helper method, while the old function's new
> body looks like the following:
> ```
> TraceEvent.begin("Foo.bar");
> try {
>     wrappedByTraceEvent$bar();
>     TraceEvent.end("Foo.bar");
> } catch (Throwable e) {
>     TraceEvent.end("Foo.bar");
>     throw e;
> }
> ```
> 
> Used the following code to test building various methods:
> ```
> @TraceEvent
> public static void basic() {}
> 
> @TraceEvent
> public void takesArguments(boolean arg1, long arg2, float arg3) {}
> 
> @TraceEvent
> public int returnsPrimitive(int arg1, byte arg2, Object arg3, TraceEvent arg4) {
>     return 10;
> }
> 
> @TraceEvent
> public Object returnsObject(char arg1, short arg2, double arg3) {
>     return null;
> }
> 
> @TraceEvent
> public int throwsError() throws Exception {
>     throw new Exception();
> }
> ```
> 
> Bug: 818267
> Change-Id: I11127203662bf84de4a890da29a09676e760e621
> Reviewed-on: https://chromium-review.googlesource.com/1066173
> Commit-Queue: Tiger Oakes <tigero@google.com>
> Reviewed-by: Biao She <bshe@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Eric Stevenson <estevenson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565624}

TBR=bshe@chromium.org,agrieve@chromium.org,estevenson@chromium.org,tigero@google.com

Change-Id: I211510f4d7e1d301ad8982f5190972730ddbec1f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 818267
Reviewed-on: https://chromium-review.googlesource.com/1092248Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565653}

This simplifies history backend tests where some page transitions types
were created with FromInt(GetQualifier(TYPED)), which is equivalent to
simply using PAGE_TRANSITION_LINK directly (as the qualifier bits are
all zero). However, semantically these tests make more sense using
TYPED transitions in these cases (although the outcome of the tests
work either way).

This is followup work from comments on crrev.com/c/1048826.

Change-Id: Ief02ad7fde7a92f05ebaf9b30ad58886cc5d1672
Reviewed-on: https://chromium-review.googlesource.com/1091273Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565652}

This will visualize the world default favicon for collections that use FaviconLoader.

Bug: 847795

Change-Id: I0d0b3cfacd79bcf0510bed3b98397cc00ee57c6d
Reviewed-on: https://chromium-review.googlesource.com/1089882Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565651}

- only disables the "spellcheck" section when spellchecking is disabled
  by policy, but not if disabled by the user;
- disables the context menu entry if spellcheck is enforced by policy.

This is a second attempt at landing this. The first attempt was reverted
due to the CrSettingsLanguagesPageTest.Spellcheck test failing.

Bug: 814318
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8f3da717f63ca00eedd82deff8fdbe6d60b10e34
Reviewed-on: https://chromium-review.googlesource.com/1091175Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565650}

Now the CDM is not running in a plugin, there's no need for
MediaBrowserTest to watch for plugin crash.

For the record, see the original CL that added this:
https://codereview.chromium.org/206693004

Bug: 772160
Test: Remove obsolete code. No functionality change.
Change-Id: I8c0a9e74cc4c1d05b153f1e80a0882ee28287ac7
Reviewed-on: https://chromium-review.googlesource.com/1091888Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565649}

Change-Id: I15ff2424bbc5773eae3bbfe847a83d574eceb066
Reviewed-on: https://chromium-review.googlesource.com/1093014Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565648}

Bug: skia:8060
Change-Id: I7440c4560c788a2c179ddf43fbde8bd9a121272b
Reviewed-on: https://chromium-review.googlesource.com/1092751Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Eric Boren <borenet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565647}

There were two small (identical) helper functions in
content/browser named CreateMemoryCoordinatorHandle(..). One in
gpu and one in render_host, and with no obvious place
to put a shared copy.

These two cause problems in some extreme jumbo configurations so
this patch renames them according to how they are user.

Change-Id: I508530b6290606a01046ec0378d8da7d9f8c164b
Reviewed-on: https://chromium-review.googlesource.com/1092696
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565646}

When the browser is resized to be very narrow the picker should
resize to two columns.

Bug: 850338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If73628d85df3bba6860a03949cdfa8b995651264
Reviewed-on: https://chromium-review.googlesource.com/1090997Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565645}

Bug: 797860
Change-Id: I8b9fd75051fa22040ff81defe252eb6de62c0b91
Reviewed-on: https://chromium-review.googlesource.com/1091690Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565644}

This CL fixes a number of inconsistencies with input style and
overall dialog appearance.

Bug: 832177,829272
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icb5bdd4245073d3c8db5100ebc3bca1a8b4f1b17
Reviewed-on: https://chromium-review.googlesource.com/1091166
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565643}

The platform-specific side is now in services/device/generic_sensor. While
here, fix a small typo ("intrefaces" -> "interfaces").

TBR=alexander.shalamov@intel.com

Change-Id: I810dce6ba28ad9fc6a5b7417431543df8f4b5a5d
Reviewed-on: https://chromium-review.googlesource.com/1093072Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#565642}

The test is slow because it does a lot of registrations and updates.

Bug: 850842
Change-Id: I5782e4e426e571a604929da7369c8474ffda88e5
TBR: robertma
Reviewed-on: https://chromium-review.googlesource.com/1092958Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565641}

Relands parts of https://chromium-review.googlesource.com/c/chromium/src/+/1088754

headless tests can't run on the memory waterfall yet because of bug 844865.
This adds them to the linux clang tot bots. (They already run on the mac and win
clang tot bots, and on the main waterfall.)

TBR=kbr

Bug: 843511,843732
Change-Id: Iec20d59c425b9d847fa2d3f076f907b69ba0e795
Reviewed-on: https://chromium-review.googlesource.com/1093051Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565640}

The static member variable to keep track of whether the black overlay
is added can fail when we switch Activities while entering VR when the
black overlay is added.

In practice without other bugs this should be borderline impossible to
make happen, but it crops up now and again, like in the linked bug.

We should instead just track the overlay per-activity.

Bug: 850741
Change-Id: I8849786972f216d7b628e2c8938579261ecd66b6
Reviewed-on: https://chromium-review.googlesource.com/1091699Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565639}

This reverts commit 5a797379.

Reason for revert: Relanding without making lld failures critical for now (see https://crbug.com/849904).

Original change's description:
> Revert "Make generate_breakpad_symbols.py not silently ignore subprocess errors."
>
> This reverts commit 924c8465.
>
> Reason for revert: This appears to break the Android WebView bots.
>
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20WebView%20N%20%28dbg%29
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20WebView%20O%20(dbg)
>
> Traceback (most recent call last):
>   File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 327, in <module>
>     sys.exit(main())
>   File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 316, in main
>     deps = GetSharedLibraryDependencies(options, queue.pop(0), loader_path)
>   File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 151, in GetSharedLibraryDependencies
>     deps = GetSharedLibraryDependenciesLinux(binary)
>   File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 67, in GetSharedLibraryDependenciesLinux
>     ldd = subprocess.check_output(['ldd', binary])
>   File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/subprocess.py", line 219, in check_output
>     raise CalledProcessError(retcode, cmd, output=output)
>
> Original change's description:
> > Make generate_breakpad_symbols.py not silently ignore subprocess errors.
> >
> > GetCommandOuput() used to pipe stderr to /dev/null, and it ignored
> > the command's return code. Use check_output() to check the return
> > code, and keep stderr attached to parent's stderr.
> >
> > Also make breakpad_integration_test.py a bit simpler (this part is
> > supposed to be behavior-preserving.)
> >
> > Bug: 813163
> > Change-Id: I8c55d3da9fff3b944111c3e868121ac34bf65c17
> > Reviewed-on: https://chromium-review.googlesource.com/1086981
> > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#564531}
>
> TBR=thakis@chromium.org,jochen@chromium.org
>
> Change-Id: Iee5a81e9b7e9db21f1dda9bdc272d3392438f481
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 813163
> Reviewed-on: https://chromium-review.googlesource.com/1087871
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564707}

TBR=thakis@chromium.org,tedchoc@chromium.org,jochen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 813163,850055
Change-Id: I3b241dffac522af75c46dc1a7554bd954b2a8f57
Reviewed-on: https://chromium-review.googlesource.com/1092671
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565638}

Bug: 821815
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifc9c196dc725cda6e4b369473aefdfea284fd36f
Reviewed-on: https://chromium-review.googlesource.com/1089050Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565637}

This is a follow-up to crrev.com/c/964448, which was committed before
a comment around this was addressed.

Bug: 849323
Change-Id: I5c6de00476424a566081a55b5bb2f2ef787c4cb6
TBR: tapted@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1092857
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565636}

- Removed cc::OrderedSimpleTaskRunner.
- Removed redundant test fixture.
- WTF::Bind --> base::BindOnce.

Bug: 841735
Change-Id: Iada37d1c7ad60149eb9a933b5968b6101a76bebc
Reviewed-on: https://chromium-review.googlesource.com/1092864
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565635}

Mark three tests as flaky:
http/tests/devtools/tracing/timeline-time/timeline-usertiming.js
http/tests/devtools/tracing/console-timeline.js
http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js

The underlying reason ist still unknown. More details and timeline in
the linked bug.

TBR=kozyatinskiy@chromium.org

Bug: 850892
Change-Id: I7fba9de0c12fc124ca3dd84875e796de677f976b
Reviewed-on: https://chromium-review.googlesource.com/1092854
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565634}

Bug: 841735
Change-Id: I3b3e808fc2537da93cdf460cbc1da2c0cdbe35d7
Reviewed-on: https://chromium-review.googlesource.com/1092743Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565633}

The stack indicates PrerenderManager::PeriodicCleanup() is being
called. PeriodicCleanup() is deleting a PrerenderContents. Deleting the
PrerenderContents is triggering a call PrerenderManager::GetPrerenderContents().

My suspicion is PeriodicCleanup() is calling clear() on a vector. The vector
contains std::unique_ptr<PrerenderContents>. It would appear the implementation
of vector::clear() destroys the entries, and *then* resets the size.
This means during destruction PrerenderManager::GetPrerenderContents() is
iterating over the vector that now contains deleted objects and we get a crash.

BUG=850489
TEST=none

Change-Id: I8472c577bfd583105abaebe32cec2d39b6fbcca1
Reviewed-on: https://chromium-review.googlesource.com/1091189Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565632}

Move key_silk_cases into the rendering folder and refactor classes to
inherit from RenderingStory.

Bug: 849392
Change-Id: Ibc4c5289c3c14b1dc8a990cc7e2156a45e93fce0
Reviewed-on: https://chromium-review.googlesource.com/1087569
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#565631}

It is not cancelable in the spec:
https://html.spec.whatwg.org/#history-traversal

Investigating behavior in Chrome, Edge, Firefox and Safari, it was
only cancelable in Chrome and Safari:
https://github.com/web-platform-tests/wpt/pull/11355#issuecomment-394696654

It doesn't actually make any sense to cancel it, so this is most
likely an historical accident.

Change-Id: I3982d4414d1214784a6d8af3b03ea7264ff93b48
Reviewed-on: https://chromium-review.googlesource.com/1087047
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565630}

This reverts commit eb3da872.

Reason for revert: Breaks downstream builder. See https://crbug.com/850916.

Original change's description:
> Android: Remove BuildHooksAndroidImpl from the main dex.
> 
> Removing the reference to BuildHooksAndroidImpl from BuildHooksAndroid
> shrinks the main dex by ~2000 methods for downstream targets.
> 
> Bug: 820570
> Change-Id: If4051f7a85e387129c65a7a5b927183b5b36bf65
> Reviewed-on: https://chromium-review.googlesource.com/1089625
> Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565305}

TBR=agrieve@chromium.org,estevenson@chromium.org

Change-Id: I2d5c807f6b4dfa0639a75ec665af4e494b765a48
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 820570, 850916
Reviewed-on: https://chromium-review.googlesource.com/1092971Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565629}

This CL is the first step: create new imagesets + 1 function to return the
correct image name.

Bug: 821815
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia2ce8dc327226857b3105605b23b5b220edb9ff6
Reviewed-on: https://chromium-review.googlesource.com/1088912
Commit-Queue: Elodie Banel <lod@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565628}

This CL hooks up the pieces to be able to read changes in team
drives as well as the users default change list.

Changes in this CL:
- Add team_drive_change_list_loaders when OnTeamDriveListLoaded is
  received.
- Poll all team drives when CheckForUpdates() is called.
- Fix fake_drive_service to read team drive lists correctly.
- Re-order default_corpus_change_list_loader to load resource metadata
  before loading team drives. This is to support the offline scenario
  where users can still browse the file system if it was already loaded.
- Enable team drives in file_system_unittest.
- Add the first test for reading from team drives in
  file_system_unittest. More to come in a followup to keep this CL
  a reasonable size.

Bug: 723955
Change-Id: I7dfab6549241d8a50b54461b41dcd8312875eb56
Reviewed-on: https://chromium-review.googlesource.com/1085667
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565627}

TBR=hinoka@chromium.org,efoo@chromium.org

Change-Id: I221e4bf2a14f2aa4b2d7cdefa4f210b7fdaa468e
Reviewed-on: https://chromium-review.googlesource.com/1092875Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565626}

KSV app registers ash specific window properties and sets up to
use MusPropertyMirrorAsh. ShelfWindowWatcher is then able to take
care of the rest.

Also make InternalAppWindowShelfController to ignore visibility
change for windows it does not observe. Otherwise, it crashes
when it attempts to manage the content window from KSV app.

Bug: 848884
Change-Id: Ib9c1e46eb3f39bdda4e66529d0497a4ef775b80f
Reviewed-on: https://chromium-review.googlesource.com/1091799Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565625}

When a method has the @TraceEvent annotation, it will be transformed to include
TraceEvent.begin() and TraceEvent.end() at the start and end of the method.
The function body is moved to a new helper method, while the old function's new
body looks like the following:
```
TraceEvent.begin("Foo.bar");
try {
    wrappedByTraceEvent$bar();
    TraceEvent.end("Foo.bar");
} catch (Throwable e) {
    TraceEvent.end("Foo.bar");
    throw e;
}
```

Used the following code to test building various methods:
```
@TraceEvent
public static void basic() {}

@TraceEvent
public void takesArguments(boolean arg1, long arg2, float arg3) {}

@TraceEvent
public int returnsPrimitive(int arg1, byte arg2, Object arg3, TraceEvent arg4) {
    return 10;
}

@TraceEvent
public Object returnsObject(char arg1, short arg2, double arg3) {
    return null;
}

@TraceEvent
public int throwsError() throws Exception {
    throw new Exception();
}
```

Bug: 818267
Change-Id: I11127203662bf84de4a890da29a09676e760e621
Reviewed-on: https://chromium-review.googlesource.com/1066173
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565624}

Password Manager keeps the map from WebFormControlElement to last
non-JavaScript value in FieldValueAndPropertiesMaskMap. That's bad from
memory consumption perspective since it keeps input elements in memory
even if they were removed from DOM (and WebFormControlElement keep
s whole WebForm). Now we have reliable mechanism - unique renderer ids,
which might be used instead of WebFormControlElement. This CL replaces
usages of WebFormControlElement with unique renderer ids.

Also this CL contains small clean-up in password_autofill_agent.h:
removing not used typedef and typedef to using conversion.

Bug: 831123, 734427
Change-Id: I12a7b53859fccb9c5398997c61250ccf1a4f5c89
Reviewed-on: https://chromium-review.googlesource.com/1085460
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565623}

Opening omnibox context menu when clipboard contains over 32K characters caused chrome to freeze up for ~1 minute.
Other performance issues remain outside of the 'is paste & go allowed' checking and large clipboard sizes (.5 - 1 million characters) still cause freezing for ~10 seconds.

Bug: 277732
Change-Id: I7d130ef4e1668f6e73b2c670143ed69f7309cc6d
Reviewed-on: https://chromium-review.googlesource.com/1089193
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565622}

With https://crrev.com/c/1070158, base::Bind() supports
block via base::RetainBlock(). Converts uses of the now
deprecated base::BindBlock().

Bug: 701275
Change-Id: I759e9bc6d62b933463602ccc3b574be3b47c918b
Reviewed-on: https://chromium-review.googlesource.com/1092572Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565621}