- 03 Dec, 2019 40 commits
-
-
Mathias Bynens authored
Several DevTools CLs (see below) change the expected output for this test. This patch temporarily allows the relevant Blink Web Test to fail, so that we can land the devtools-frontend patch. We can re-enable and update the test once that happens. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1947533 [2]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1944335 Bug: chromium:1029031 Change-Id: I72939298ae1f306e5b1d27c3a91c2b13f0d620a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948883 Commit-Queue: Mathias Bynens <mathias@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#720992}
-
Nazerke authored
This CL removed extra headers and deps from BUILD file in make the further eg2 conversion easier. Bug: none Change-Id: I44e34504627afa5f8ce5a8b288e68bde81ddd81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932553Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#720991}
-
David Bienvenu authored
WindowOcclusionTracker tracks WebContentsViewAura’s window_, not it's own window_. See WebContentsViewAura::CreateAuraWindow(). The WebContentsViewAura’s window_ appears to be a great grandchild of DesktopWindowTreeHostWin()'s window. It's unclear why this stat was ever non-zero, but it fired 15 times in a week on stable. It would be nice to have a test for this, but I'm not sure where a meaningful test would live. Bug: 813093 Change-Id: I65c175a2ee2343742c4e9196d950015a84154234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941113Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720990}
-
Stephen Nusko authored
Currently we emit category and name fields for both BEGIN and END events however trace processor doesn't need it and in fact will fail to match the events together into a single complete event if we do so. Change-Id: Id086777f7498850cfcb96f9c3abaf519d3f34a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948824 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#720989}
-
Sergey Poromov authored
The infra change is tested on M78 master and works as expected. Launching it by default for M80+. Stats: http://uma/p/chrome/histograms/?sid=9bbdede2f378da682008a3440f86c9e1 Bug: 940648 Bug: b/135194570 Change-Id: I9871101048697d88e0b92d1ffb1a88340f57eb1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948887 Commit-Queue: Sergey Poromov <poromov@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#720988}
-
Maggie Chen authored
This reverts commit 007cb99b. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable GpuInitializationAndRunningTasks on TSan > > It was flaky on TSan bot. > > TBR=zmo@chromium.org > > No-Try: true > Bug: 1030130 > Change-Id: I3dbbe2f8e3559609bc1bac8e6504417c2a2c1b11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947866 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Makoto Shimazu <shimazu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720815} TBR=zmo@chromium.org,shimazu@chromium.org Change-Id: Ie4472f6d98e0fe98ce95af1c7be7e95ef568b436 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948516Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#720987}
-
Elly Fong-Jones authored
Since Mac PWAs are now implemented, their windows should be restored across restarts as well. This change: 1) Enables the code to save PWA state in session restore on Mac, and 2) Adds an assert to one of the relevant PWA tests to ensure this doesn't regress - if it does, the assert will fail, rather than the test hanging Bug: 1028239 Change-Id: Iecf5da0a1df4d0f434216960dca2056bba926187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945753 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#720986}
-
Friedrich [CET] authored
This reverts commit cef89bf2. Reason for reland: Wasn't the culprit, sorry. Original change's description: > Revert "split view: Replace CanSnapInSplitview with SplitViewController function" > > This reverts commit b5bf966d. > > Reason for revert: Most likely culprit to break All/ShelfLayoutManagerTest.NoShelfUpdateDuringOverviewAnimation/1 > (more details in the linked bug) > > Original change's description: > > split view: Replace CanSnapInSplitview with SplitViewController function > > > > Instead of a CanSnapInSplitview function referring to the root window of > > the argument window, there shall be a SplitViewController::CanSnapWindow > > function referring to the root window of the SplitViewController. > > Leveraging that, the split view drag indicators on each root window > > shall account for whether the dragged window can be snapped in split > > view on that root window. The present CL is also a step toward properly > > implementing functionality where you drag from one display to another > > and snap (see the TODO in OverviewWindowDragController::SnapWindow). > > > > Bug: 970013, 995413 > > Change-Id: I0e0b6d34ec8b3b3856d26fc5750bb062405f8dc6 > > Fixed: 961171 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906931 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Commit-Queue: Avery Musbach <amusbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#720754} > > TBR=oshima@chromium.org,amusbach@chromium.org > > Change-Id: I1398c2eefc9d275d90708229521ff906ba667493 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 970013, 995413, 1030222 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947726 > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720899} TBR=oshima@chromium.org,fhorschig@chromium.org,amusbach@chromium.org Change-Id: I4069ec089d37285f09a69ddefeea93b437ade974 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 970013, 995413, 1030222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947657Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#720985}
-
Geoff Lang authored
This reverts commit 5c675fd9. Reason for revert: Test failures on GPU FYI bots Test: SharedImageBackingFactoryD3DTest.GL_SkiaGL/0 Error: "Unable to create shared handle for DXGIResource" Bots: https://ci.chromium.org/p/chromium/builders/ci/Win7%20FYI%20Debug%20%28AMD%29 https://ci.chromium.org/p/chromium/builders/ci/Win7%20FYI%20Release%20%28AMD%29 https://ci.chromium.org/p/chromium/builders/ci/Win7%20FYI%20x64%20Release%20%28NVIDIA%29 https://ci.chromium.org/p/chromium/builders/ci/Win7%20FYI%20x64%20Release%20%28NVIDIA%29 Original change's description: > Enable WebGPU on Skia Renderer > > Implement SharedImageBackingD3D::ProduceSkia and supporting methods. > > Bug: 1021118,1002316 > Change-Id: Ia699bddfa08469b9e151018eca6c5206620cb731 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938707 > Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720722} TBR=zmo@chromium.org,sunnyps@chromium.org,rafael.cintron@microsoft.com Change-Id: Ie43049a059a0c7545676ba3fbff90025fa75ffc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1021118, 1002316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947930Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#720984}
-
Andreas Haas authored
We are currently removing uses of blink::ArrayBuffer to eventually remove the whole class altogether. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I7d3399114127c91827a77900025baa946a9c08f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948437Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#720983}
-
Juan Antonio Navarro Perez authored
This was lost during some refactor. The file is used to back the spreadsheet at bit.ly/csh-stories with the list of all system health stories. Bug: 1029042 Change-Id: I53a9c87838f023e15cff6f589eed31333daae394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945174 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#720982}
-
Miguel Casas authored
crrev.com/c/1828078 added and wired the video encode acceleration minimum resolution; this CL uses this information from peerconnection's rtc_video_encoder.cc and video_codec_factory.cc to avoid using a hw accelerator for resolutions below the given one. TEST=https://codepen.io/miguelao/full/jONQBYb on nocturne (pixel slate), then inspecting chrome:webrtc-internals, verifying that resolutions below 321x241 are encoded using libvpx while larger ones are encoded using "ExternalEncoder", i.e. the video encode accelerator in Chrome, in this case VA-API. Bug: 1008491 Change-Id: Iccfe6be8811ca265d6dbc742beb3ec0901406a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848398 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#720981}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9fe91522ae86..9dac0d8216b2 git log 9fe91522ae86..9dac0d8216b2 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 brianosman@google.com Particles: Better integration for ResourceProvider Created with: gclient setdep -r src/third_party/skia@9dac0d8216b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I097adb21a6f7668496991d4fd9a0b84d61c6ea1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720980}
-
Jan Wilken Dörrie authored
This change renames password_manager::CredentialPair to UiCredential, which is a better name for what the class represents. Furthermore, the object is turned into a class, making its members private and only providing read-only access through public getters. Lastly, a constructor from autofill::PasswordForm is added for convenience. Bug: 1030230 Change-Id: I55af2ee6046dcec6a82464d188c380dccaefd3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947661Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#720979}
-
Fredrik Söderquist authored
There doesn't appear to be any strong motivation for why the code should be in a header file, so create a .cc file and move the implementation there. It will grow a bit more in the future. Bug: 674797, 633012 Change-Id: I4fc61c32fa52fb369fc1112db1c4eeef36d63630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947730 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#720978}
-
Kamila authored
This cl enables showing an entry in Page Info, when a permission is automatically blocked (set under embargo) after the prompt has been ignored several times. If the user sets the permission from Blocked->Not-Blocked-State, the embargo is removed from that site. Bug: 1030238 Change-Id: I0cdfa45d4aae68711689ea00b59277539abb8d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947736 Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#720977}
-
Mohamed Amir Yosef authored
Bug: 1012203 Change-Id: I1ac3faf1c07c6bfe76985ea148d28934e3bec9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944345Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#720976}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/25d54ed1700d..392bb2bdc686 git log 25d54ed1700d..392bb2bdc686 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 perezju@chromium.org [devil] Replace perezju's TODOs with bugs 2019-12-03 perezju@chromium.org [devil] Remove perezju form OWNERS 2019-12-03 perezju@chromium.org [experimenta/v8_tools] Remove perezju from OWNERS Created with: gclient setdep -r src/third_party/catapult@392bb2bdc686 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029008 Tbr: sadrul@google.com Change-Id: I4597a1f2d75cfb9524f4abbc5597be9451350cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720975}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8a582e859273..2c526f508df1 git log 8a582e859273..2c526f508df1 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 treehugger-gerrit@google.com Merge "Reland "Upgrade to protobuf v3.9.0""" Created with: gclient setdep -r src/third_party/perfetto@2c526f508df1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I14c5fbfe4ef7aa90570083363cf73b3a5f5b0ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948602Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720974}
-
Fredrik Söderquist authored
Since SVGMarkerData is essentially a builder class for creating the list of marker positions, add a Builder suffix to the class name. Also move the "driver" parts into new method Build(...) on the class and make the old "entrypoints" private. Move MarkerForType(...) to MarkerPosition and rename it to SelectMarker(...). Bug: 674797, 633012 Change-Id: I7191434047c9227ee6555a318afa5b1829a4bfdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947653Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#720973}
-
Yi Gu authored
V2 has been enabled by default. This patch cleans up v1 related logic: -- Remove HitTestDataBuilder -- Remove HitTestDataProvider -- Remove HitTestDataProviderDrawQuad -- Update unit tests such that v1 is no longer tested -- Remove feature from flags, switches etc Bug: 1029012 Change-Id: I6b358cf64918dc951f8bebd428315d0429b4e3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935371Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720972}
-
Clemens Arbesser authored
This CL will allow the backend to send generic UI layouts to the client. For now, this will be limited to static views without event handling or interactions. It is a first step away from hard-coded UI and towards backend-driven UI for autofill_assistant. As a first step, the new UI will only be available in a special container of the UserData action. Bug: b/145043394 Binary-Size: The size increase is almost entirely due to adding new proto messages. In the mid-term, the backend-driven UI framework will allow us to remove many of the existing hard-coded UI interactions, which may well result in a net binary size decrease. In the short term, the size increase is unavoidable. Change-Id: I53839aa9c9d17f35414b0c89e137af5be4111e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920042 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#720971}
-
Vasiliy Telezhnikov authored
This CL deprecates collection of GPU.GpuBlockedBetweenSwapsUs and hides measuring time GPU Main thread was blocked under the --enable-gpu-blocked-time flag as it still can be useful for telemetry runs, but measuring cpu time has overhead and causes performance regressions on large amount of GPU tasks. Bug: 1025876 Fixed: 1022950 Change-Id: I1f2375e8d79e3ccfb1024669905aeb77b6097506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940487Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#720970}
-
Mohamed Amir Yosef authored
The method create either a PasswordSaveManagerImpl or a MultiStorePasswordSaveManager according to the enabled features. Bug: 1012203 Change-Id: I49a381419bd184381478c0107aa2f8a6ebf25b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948826 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#720969}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/becc67f976ee..3bf22fd49e87 git log becc67f976ee..3bf22fd49e87 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 tvanderlippe@chromium.org Do not load ARIAProperties as an ES module Created with: gclient setdep -r src/third_party/devtools-frontend/src@3bf22fd49e87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1030029 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibbc6a0f629c6524e09fdc9cb6546a111c1beac39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948601Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720968}
-
Ali Juma authored
This adds the file as an EG2 target, updates #includes, and replaces calls to helpers that can't be used in EG2. This also fixes an unused result warning when calling [GREYCondition waitWithTimeout], in testPreventDefaultOverridesWindowOpen. Bug: 987646 Change-Id: Ib747675b35798582bea89d60aaa443a4ecbcf1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946674Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#720967}
-
Antonio Gomes authored
BUG=787254, 919392, 704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I67fbde3e7cfdde32335312b38c2e7c758893f8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946635Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#720966}
-
Friedrich Horschig authored
This CL intends to make the testActionsMultiTouchPoint ChromeDriverTest less flaky by waiting for the correct number of events to arrive. Bug: 1030260 Change-Id: I165e42d93aeacf4d1f4ce1564a4761ecb95d0074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948829 Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#720965}
-
Sergey Poromov authored
Bug: chromium:1012048 Test: Compile and run Change-Id: I8d601a559d1eef1d1d0c900f9a3bf1872108e97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854398Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#720964}
-
Yifan Luo authored
Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/g_SYa13ZDPQ/m/cElYxaGoAwAJ Bug: 843478 Change-Id: I9a9a050a54197e029557a92232c902b91bba4175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936250Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@google.com> Cr-Commit-Position: refs/heads/master@{#720963}
-
Alex Chau authored
Bug: 1029747, 1029483 Change-Id: I9278de6531b610124aa982675b61eb847fff4591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944502 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#720962}
-
Hans Wennborg authored
This reverts commit 443c985b. Reason for revert: It broke base_unittests on Windows, see second bug. Original change's description: > Reland "Enable init_stack_vars for non-official Windows builds" > > This is a reland of 4c424ef5 > > Windows bot is fixed with crrev.com/c/1946985 > > Original change's description: > > Enable init_stack_vars for non-official Windows builds > > > > With crrev.com/c/1914359 merged so we can enable the flag on Windows. > > Patch is similar to crrev.com/c/1795632 and crrev.com/c/1838383. > > > > Bug: 977230 > > Change-Id: I166392ee0f65ed7fd7f68cbdd5b7a3b7d589539b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854805 > > Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> > > Auto-Submit: Vitaly Buka <vitalybuka@chromium.org> > > Reviewed-by: Hans Wennborg <hans@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#719737} > > Bug: 977230 > Change-Id: I7fa02038503e83eb5ccdbba8c07dc08010c2722f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941278 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720912} TBR=hans@chromium.org,brucedawson@chromium.org,vitalybuka@chromium.org Change-Id: I5fa5adf19f4454d76b090938349875715ed38b9d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977230, 1030261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948925Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#720961}
-
Changhao Han authored
DevTools CL that changes the expectations: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1934208 Bug: chromium:1025667 Change-Id: I4e4ff93e144e885c3f27cda022c4d687f5496247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948427 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#720960}
-
Andreas Haas authored
The problem was that we created an empty ArrayBufferContents without internal v8::BackingStore object. This missing v8::BackingStore object caused the crash. I will upload the original CL as patchset 1, and upload the fixes in the follow-up patchsets. Original message: With a recent change, ArrayBuffers are allowed to have nullptr as their `Data` pointer. However, a condition in ArrayBuffer::Transfer bailed out if Data() was nullptr. I changed the condition now, and added a test. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: Id85f7617d9c440564153783949d4e18a3ad02013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944349Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#720959}
-
Jonah Ryan-Davis authored
Needed to add the ability to disable all of ANGLE's workaround with this flag. Bug: 1016377 Change-Id: Icff8bde12cf6194e057ac09db099bd045da902a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937668Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#720958}
-
Omer Katz authored
During insertion the HashTable might need to expand. If that happens, a new backing store is allocated and all existing entries are moved over to the new store. Updating the backing store pointer can race with reading it during tracing. To resolve the race, the read in Trace and the write in RehashTo need to be atomic. Bug: 986235 Change-Id: I0d6d4350026144a1e1675313ec7b193fd58beaca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943141Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#720957}
-
Brian Salomon authored
Bug: 1028116 Change-Id: I06e931ff71384883181db349dc269cd324da6975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940447 Auto-Submit: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#720956}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d405652ad675..13c558ef1494 Created with: gclient setdep -r src-internal@13c558ef1494 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0ae1e063c03faa212547eb8a8e8bb8d33c1d5f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948600Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720955}
-
Balazs Engedy authored
Bug: 1028642 Change-Id: I0a16154ead9b668f2100afc4e46caa0a5c879269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945818 Auto-Submit: Balazs Engedy <engedy@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720954}
-
Eric Seckler authored
This reverts commit fcbcc346. Reason for revert: The benchmarks were timing out during trace conversion. We increased the timeout in [1], which hopefully resolves the flakiness / failures. [1] https://chromium-review.googlesource.com/c/catapult/+/1944488 Original change's description: > Disable tests which are failing on Android. > > browse:news:nytimes:2019 > browse:social:facebook_infinite_scroll > browse:news:washingtonpost:2019 > > TBR: crouleau@chromium.org > Bug: 1029460,1029465,1029467 > Change-Id: I0de4f43db3cc3f499724d71577fe6a0294ff229b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943137 > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720173} TBR=nuskos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1029460, 1029465, 1029467 Change-Id: Ibe7dee84ecf3befba6917340b7a5eab2964fe58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948441Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#720953}
-