- 23 Oct, 2019 21 commits
-
-
siyua authored
So that icon will not be highlighted if icon is hovered when animation is showing Bug: 932818 Change-Id: I2b894b48bcad73fb89739e3a551b1390e980f7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872729Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#708447}
-
Scott Violet authored
Two special cases that carry over from the old code: . LayoutDeprecatedFlexibleBox always started layout at an origin of 0, even when rtl. This gives the same behavior. . End is treated as start when rtl. BUG=1014884 TEST=fast/deprecated-flexbox/017.html Change-Id: I2d232efd0b84ab997e6262253869828d5a758eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872566 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#708446}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/be1fa7d8cddf..0b779a7c4e88 git log be1fa7d8cddf..0b779a7c4e88 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 geofflang@chromium.org GL: Emulate primitive restart when PRIMITIVE_RESTART_FIXED_INDEX is unavailable. Created with: gclient setdep -r src/third_party/angle@0b779a7c4e88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I8f522bbeeb0fbcf9dbf1e35ee7267cd6101f798f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874640Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708445}
-
Martin Barbella authored
This was inspired by crbug.com/970343, and the fuzzer catches that issue if its fix is reverted. Change-Id: I2a4037900e5c21c00b8625bdf0de4e0d349c6104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874687 Commit-Queue: Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#708444}
-
chrome://device-emulatordpapad authored
Replacing calls to the global device_emulator namespace with FireWebUIListener() and ResolveJavascriptCallback(). This is in preparation of migrating this page to Polymer3. Bug: 1015241 Change-Id: Ic77512ee3972bbe8957a293b7c1cb8082f40b9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874586 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708443}
-
James Cook authored
We rely on sync to provide the user's OS settings when setting up a new Chromebook. However, new devices are not guaranteed to be running the latest version of Chrome before the user's first login (it's a poor experience to have to wait to download a large OS update before being allowed to sign in). As part of go/split-settings-sync we are migrating OS prefs to new sync ModelTypes OS_PREFERENCES and OS_PRIORITY_PREFERENCES. We need to ensure that old clients still get synced updates for these preferences. When split sync is disabled, register OS pref names with the browser pref ModelTypes. This makes sync work just like it did before the split, and allows OS prefs to always be registered as SYNCABLE_OS_PREF, without conditionals on the flag. When split sync is enabled, register OS pref names with the PrefModelAssociators for both the new ModelType and the old ModelType. When a pref is changed locally, this sends updates to the sync server under both ModelTypes. However, when a sync change is received from the server we only apply the update if the change is for the new ModelType. We made a product decision not to sync updates from old clients to new clients. This helps avoid ping-pong updates between old and new clients. Bug: 1013466 Test: added to components_unittests Test: manually verified that new client with flag enabled sends updates to old client (M78), but old client changes are ignored on new client. updates Test: manually verified that client with flag disabled syncs updates in both directions with old client (M78). Change-Id: I04c494938d3526c57b8eb2f9c689acb0d4b0a3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865662 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#708442}
-
Alan Cutter authored
This CL updates label icons to no longer perform the text "slide" animation when the OS accessibility setting "prefers reduced motion" is enabled. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=417373&signed_aid=t0VJYHPUtkw0z1lDKkbiVA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=417374&signed_aid=5yX5WthdugQRYA75A6Ua8A==&inline=1 Change-Id: I79ede8bfec7c0c13b9678e2374ba16ec1aefee7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871504 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708441}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7b3cc35cb6e5..c833c0c59253 git log 7b3cc35cb6e5..c833c0c59253 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 bryan.bernhart@intel.com D3D12: Enable sub-allocation for MSAA and non-MSAA textures. Created with: gclient setdep -r src/third_party/dawn@c833c0c59253 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I7afa2d590734a22f407f27afbf17d8ac1098ec7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874639Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6e9cdb62e782..1834bbb39c1c git log 6e9cdb62e782..1834bbb39c1c --date=short --no-merges --format='%ad %ae %s' 2019-10-22 wbbradley@chromium.org contrib: add a tool called updog.sh for finding package/board mappings 2019-10-22 vapier@chromium.org run_tests: support --py3/--py2 with --list 2019-10-22 tcwang@google.com afdo: Adapt to AFDO bits moving outside of Chrome ebuild. Created with: gclient setdep -r src/third_party/chromite@1834bbb39c1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia00354b395ee22f316de78e34c09433c45026480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874730Reviewed-by:
-
Matt Mueller authored
This was already the case on macOS/iOS, but not on the other verifiers. Bug: 952091 Change-Id: I9819f17bc5d9695daf41aeb51b0494e7b6fafc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872786 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708438}
-
My Nguyen authored
Change-Id: Ia7502b1b90e49b6e8e954db35bb86921c7210376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873811Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#708437}
-
Frank Tang authored
It will not need to parse the year string now. And it will not break while we switch on the harmony_intl_other_calendars flag Fixed: 1016909 Change-Id: I711d2553c29688576a252b610c101ba948f3a308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874491Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708436}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bef344f7017f..9f6271e66386 git log bef344f7017f..9f6271e66386 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 crouleau@chromium.org [Telemetry] Implement --story=<exact story names> flag. Created with: gclient setdep -r src/third_party/catapult@9f6271e66386 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:982027 Change-Id: I06d2207d70cd20c59fccd038e4b63c5047b7150d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874729Reviewed-by:
-
Yusuke Sato authored
ARC container does not use the field and it will soon be removed from proto definition. BUG=b:142144019 BUG=b:143175953 TEST=try Change-Id: Ieabdbace116d9c70c35a031f0aee3fe648bdcd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874580 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#708434}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8e8e4f75129b..308277131853 Created with: gclient setdep -r src-internal@308277131853 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1baf448be5e3dd4c0d3b5917103b83bc86967456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873293Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708433}
-
Alex Danilo authored
No change in behaviour, just tidy up removal of a test for the hidden attribute on a panel item which is never set. Bug: 980452 Change-Id: I61d32291448132434c77a0df5f5d84ee9cae4cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873813 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#708432}
-
Toni Barzic authored
The HomeLauncherGestureHandler does not use last_event_location_ and last_scroll_y_ in kDragWindowToHomeOrOverview and kSwipeHomeToOverview mode except for derermining: * whether drag is in progress * the final state for slide up/down in OnTabletModeEnded For the first usage, checking the mode_ value should provide the same information. In the second case, finalizing slide up/down state is not the intended behavior - requesting drag mode controllers to cancel current drag operation would be more suitable course of action. BUG=1005366 Change-Id: I4ec543ae24c854edd681716aa784fe2925554679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872302 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#708431}
-
Caroline Rising authored
Stop OnAnchorBoundsChanged from being called for bubbles with no anchor in PageActionIconView. Bug: 1005031 Change-Id: I8df7601f95ebbf38cd3a78bc4973e0cef89ef028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872735Reviewed-by:
-
Will Harris authored
OSCrypt is a singleton that's process-bound, so verify that it behaves for network service running both in and out of process. BUG=1016384 Change-Id: Icdcb97b976a9d282f7593d0f9eb0b152991843a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872457Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708429}
-
Patrick Noland authored
Bug: 1016872 Change-Id: Id31cb8d81901e0e9d0d54b6edc12439616192eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874629Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#708428}
-
Evan Stade authored
This re-lands commit 00722f1e. The change was reverted for causing unit test failures under asan. The fix for those failures was committed as e9179a4f. Thus, this change is identical to the original. Original change's description: > Remove NOTIFICATION_PROFILE_ADDED from UserCloudPolicyManagerChromeOS > > Use ProfileManagerObserver::OnProfileAdded instead. > > Also worth noting that this removes an obsolete superclass from > UserCloudPolicyManagerChromeOS, i.e. KeyedService. Both KeyedService > and ConfigurationPolicyProvider have a "virtual void Shutdown()" > so this removes that collision (not that it was doing any harm). > > Bug: 268984,171406 > Change-Id: Ia0b3dd4dd34a0f62e84dd057928d61c5677231d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854525 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707909} TBR=antrim@chromium.org Change-Id: I9c7342b0cdf9b8d1555c27ab41ff1015633dbbf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874717Reviewed-by:
-
- 22 Oct, 2019 19 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/53f9e0979a58..67fccdf0c90e git log 53f9e0979a58..67fccdf0c90e --date=short --no-merges --format='%ad %ae %s' 2019-10-22 ehmaldonado@chromium.org gerrit_util: Add tests for CookiesAuthenticator Created with: gclient setdep -r src/third_party/depot_tools@67fccdf0c90e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1016601 Change-Id: I928bfaf37f20c4587f5ec055034feb3dffa58564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874501Reviewed-by:
-
Evan Stade authored
Bug: 268984 Change-Id: Iabb05901e16d6002304ddf1ad427e0ea2836468b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873215 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708425}
-
Christopher Thompson authored
Bug: 1016105 Change-Id: I91d0405ead02d38f146c060403adace067d07788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872022 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708424}
-
Bryan Clark authored
is enabled if the gn arg enable_video_with_mixed_audio is 'true'. Bug: b/141625857 Test: Ran cast_shell locally Change-Id: Ic61fa599cd6aa573b555df7ac25fab9358d61681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874521Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Bryan Clark <bryanclark@google.com> Cr-Commit-Position: refs/heads/master@{#708423}
-
Avery Musbach authored
Change-Id: I32d5c3e30be0ea43aeb75acd8cba35a5566a2119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872426Reviewed-by:
-
Peter Boström authored
Replaces OnAnchorBoundsChanged calls, these were not called due to anchor changes. Bug: None Change-Id: I26988ca55b019e0504e54fd0f37af45309b9b25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874712 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#708421}
-
Anupam Snigdha authored
This change adds mechanism to control the software input panel on Windows using TSF input panel policy. It triggers the input panel through a policy that is set in TSF status flag based on whether user has interacted with the page or not. It uses the existing TextInput state object to get that information. This is also a step towards removing the TryShow/TryHide API calls which uses a legacy IPC message and also don't work properly on some Windows touch devices such as Surface Book. TryShow/TryHide input pane API calls cannot co-exist with TSF input panel policy as it leads to a race condition in input service that decides when to raise the virtual keyboard which sometimes results in flickering of input panels. Test: ui\base\ime\win\tsf_input_policy_unittest.cc Bug: 1014365 Change-Id: I598a15bd16a90f578fbfc62fd06ef0c5724b243d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862860Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#708420}
-
Istiaque Ahmed authored
These are used to monitor extension resource request read stats, hence extend these by one more year. Following three UMAs were change in this CL: ExtensionUrlRequest.Latency .SeekPosition .TotalKbRead Bug: 1016408 Change-Id: I61246cb38003e5cffab20fb9366477c10cd9a01c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873086Reviewed-by:Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#708419}
-
Steven Bennetts authored
This also fixes a bug in AutoConnectNotifierTest, which has been "flaky" but failing consistently for quite a while now. For trivial removal of extra include in ash_test_helper.cc: TBR=jamescook@chromium.org Bug: 1015493 Change-Id: I50ed1f11c39c7385888ae4b310d686fbe4f38a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864626 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#708418}
-
Emircan Uysaler authored
Bug: 1016958 Change-Id: I7d918b17cd8b6d6b0b0d8a471087d44e5af11d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872487Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708417}
-
Will Harris authored
This reverts commit 76f496a7. Reason for revert: decided to take a different approach https://chromium-review.googlesource.com/c/chromium/src/+/1872475 fixes this in a better way, that doesn't rely on oscrypt behavior. Original change's description: > Tolerate setting same os_crypt key twice in the same process. > > Setting the same key twice is allowed but a different key is still > something that should never happen. > > This permits service such as network process to run in-process > and also fixes --single-process mode. > > BUG=1000799,1016384 > > Change-Id: I9da8221adc763d1188b64589dafedeee866d585f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872155 > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707865} TBR=wfh@chromium.org,cfroussios@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1000799, 1016384 Change-Id: I572d066180a2d2438732072c6806e21cddfacdbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874612 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708416}
-
Istiaque Ahmed authored
These are histograms that reflect generic health stats of extension content verification. Extend these by one more year. The following seven umas were changed: Extensions.ContentVerification.ComputedHashesInitTime .ComputedHashesReadResult .FetchResult .ReadContentHashTime .VerifiedContentsInitResult .VerifiedContentsInitTime ExtensionContentVerifyJob.TimeSpentUS Bug: 1016402, 1016416, 1016406 Change-Id: Ie610257d34121ff9d660e5f6896ef2752ef6bb7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872771 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: -
Hans Wennborg authored
This reverts commit 95f797d6. Reason for revert: It broke some tests in official builds, see bug. Original change's description: > CHECK that CommitNavigation/CommitFailedNavigation IPCs always commit. > > Currently, state synchronization between the browser and the renderer > process is complicated and buggy for cross-process navigations. The > renderer process is responsible for processing the commit IPC and then > reporting success back up to the browser process, which then updates its > state. However, it's unclear if this can lead to races. > > Instead, if it is possible to assume that one CommitNavigation() IPC > from the browser always maps to one committed navigation in the > renderer, the code can be simplified to remove multiphase navigation > commits. This means the browser would be able to mark a provisional > local frame as committed as soon as it sends a commit IPC to the > renderer for that frame. > > Bug: 999255 > Change-Id: I7d58293e6c2ec6ca0d09b614ae5a41340f4afd8e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775663 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705414} TBR=danakj@chromium.org,dcheng@chromium.org,nasko@chromium.org,clamy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 999255,1014903 Change-Id: I9b5429c66a47e1a180ba2ff82059fe596d7f0b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874575Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#708414}
-
Owen Min authored
Rename ChromeBrowserCloudManagementController ::IsMachineLevelUserCloudPolicyEnabled to ChromeBrowserCloudManagementController ::IsEnabled Use a shorter name to avoid repetition. Bug: 1010704 Change-Id: If6808b2687099c09edd20a3161c7144875ba5a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865407Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708413}
-
Rahul Arakeri authored
This fixes an issue when scroll deltas for arrow clicks, shift+click and autoscrolling was improperly scaled. The fix here is to use the painted_device_scale_factor (when use-zoom-for-dsf is true). As a part of this change, 2 VirtualTestSuites have also been introduced. One of them runs the new tests with DSF=2 on the main thread and the other one on the cc thread. New test had to be added because the scroll offsets when DSF=2 (and use-zoom-for-dsf=true) are different compared to offsets when DSF=1 (and use-zoom-for-dsf=true) both in case of main and cc scrollbars in some cases (eg: shift+click). Bug: 1007875 Change-Id: Ib4fbad3004f0ef503420ada6b701432798ec7265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848792 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708412}
-
Will Harris authored
BUG=1016384 Change-Id: I1abcc4ccf7e388f81f3ba191700b81bac47c3473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872475Reviewed-by:
-
Matt Menke authored
Also move all tests of the method as well, and merge the fuzzers of URLRequestDataJob and DataURL::Parser. This is in preparation to remove URLRequestDataJob, which is only used in tests (And those tests are only still around to test URLRequestDataJob::BuildResponse()). This test also adds a couple test cases to DataURL unit tests, since that doesn't really seem worth a seprate CL, but noticed some cases could be covered a bit better as I was moving stuff. Bug: 934009 Change-Id: I4025e77e0bde27a271ed32c0d274b0e24604e842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869539 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/33678af88db3..05691ddbd2bc git log 33678af88db3..05691ddbd2bc --date=short --no-merges --format='%ad %ae %s' 2019-10-22 mbonadei@webrtc.org Add possibility to skip check_includes presubmit check. Created with: gclient setdep -r src/third_party/webrtc@05691ddbd2bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I017539003e08a9d51d62465ca5b7566b77a69a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874498Reviewed-by:
-
arthursonzogni authored
The test was given web_ui capabilities to the URL: "http://privileged". This doesn't correctly reflect the reality. WebUI URL have the "chrome" scheme, not "http". As a side effect, this test is now passing when the back-forward cache is enabled. Only HTTP/HTTPS URL are allowed to enter the back-forward cache. It was previously failing, because the page was loaded with the WebUI capabilities, and the test was expecting the capabilities not to be set when navigating back to it. Since it was the same RenderFrameHost in both case, it was failing. Bug: 511340 Change-Id: Ie371e2e6a894e0074b451ec53168e8500fea4145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860032 Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#708408}
-
