- 07 Oct, 2019 35 commits
-
-
Koji Ishii authored
Ran rebaseline-cl twice but this test doesn't stabilize only on Mac10.10. TBR=yukishiino@chromium.org NOTRY=true Bug: 1011453, 1010662 Change-Id: I147d1c81d3a5c4be0a36c173109cd25ddb67a22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843799Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#703228}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7eb4caf5..523df09a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic7c72a0e1d2043de6dbdb2683e824e3e14ca0279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844392Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703227}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/1f4e5bcb19ea..1167bff3e9a6 git log 1f4e5bcb19ea..1167bff3e9a6 --date=short --no-merges --format='%ad %ae %s' 2019-10-06 wl@gnu.org * src/sfnt/sfwoff2 (reconstruct_glyf): Fix reallocation. 2019-10-06 wl@gnu.org Improve memory debugging. 2019-10-06 wl@gnu.org docs/DEBUG: Document environment variable `FT2_KEEP_ALIVE'. Created with: gclient setdep -r src/third_party/freetype/src@1167bff3e9a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Idbeb0c24828d6bf779664f0778c0805ed8373415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844196Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#703226}
-
Chromium WPT Sync authored
Using wpt-import in Chromium da0efe3e. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" df884b61 "[WPT/referrer-policy] Add worker subresource tests" 86ea3d5b "Renaming fetch/metadata web platform tests" 69c11064 "[WPT/upgrade-insecure-requests] Regenerate files" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie8f3ff9b2682db625b275e78ed02dac29e6cb3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844032Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703225}
-
Maksim Sisov authored
It is no longer needed to have a post task when frame type is changed. That workaround was added in https://codereview.chromium.org/2597733002 to fix these tests (see also see https://codereview.chromium.org/2594533003): TwoClientThemesSyncTest.CustomThenSyncNative_E2ETest TwoClientThemesSyncTest.CycleOptions_E2ETest SingleClientThemesSyncTest.NativeTheme As these tests pass now, remove the workaround and just use DWTHPlatform::FrameTypeChanged impl. Bug: 990756 Change-Id: Ibb10a5b925116ede7e6f73cefea3891f0dc7c35e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834087 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#703224}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Ia22f86a9f020c4f9421b1f2e3c963cf24ed08391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844002 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#703223}
-
Yang Guo authored
DevTools frontend is moving to a separate repository and pulled into a separate path. It would be nice to have this test not point to a non-existent path (even though the file does not exist either). Change-Id: Id5ce7cd3057617fd5880968cb7aab3ec064fe5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840235 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#703222}
-
Canon Mukai authored
The previous version of DecompressionStream accepted only Uint8Array as its input, so I added change to accept ArrayBuffer and other ArrayBufferView like Int16Array. I also added a test. Bug: 999091 Change-Id: I8c153c3f639cb4e9b8563128e4cce1e6c6597cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831920Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Canon Mukai <canonmukai@google.com> Cr-Commit-Position: refs/heads/master@{#703221}
-
Alexandre Courbot authored
SetInputFormat() and SetOutputFormat() use the V4L2 queues. Make sure they are acquired before calling these methods. This bug slept in because I forgot to specify --use_vd to the unit test. Bug: 1003223 Test: video_decode_accelerator_tests --use_vd passes on Kevin. Change-Id: I3847c9ba947739e673a106a7d2d3139b1ec432b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844519 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#703220}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a703cbaf0526..0c59193cb7ce Created with: gclient setdep -r src-internal@0c59193cb7ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If27c5766744ba6192e48c5f9ce0ee4c97db2ffaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844357Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703219}
-
Adam Rice authored
It's a nuisance for modules/ OWNERS to have to review CompressionStream CLs, so add a specific OWNERS file. TEAM and COMPONENT are the same as StreamsAPI for now, until we need something more specific. BUG=999091 Change-Id: I7a09a310f0ce52027f070f818948981278b678c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844521Reviewed-by:
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including foo.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes and following CLs will continue replacing them more. Bug: 1001360 Change-Id: I282e3e334670f66fc2d5e4b9060fa619a9d57d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843999Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#703217}
-
Mikel Astiz authored
During trusted vault passphrase, the existence of pending keys should be signaled using OnTrustedVaultKeyRequired() instead of OnPassphraseRequired(). This patch fixes the calling site in NigoriSyncBridgeImpl::Init() and refactors the code to centralize all calling sites to prevent similar issues in the future. Bug: 1010189 Change-Id: I408279ff56c8e21aae05c498cf1238e1827b2ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840632 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#703216}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a7d9c0d86c82..e92ee0ae0d32 git log a7d9c0d86c82..e92ee0ae0d32 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e92ee0ae0d32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: Ie8d9527446110f203bc1d0b1804d9620f68b554e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844336Reviewed-by:
-
Yutaka Hirano authored
This is a follow up change for https://crrev.com/8ee3f7e6d3a79b15824b6e286eb71c0a96c4d879. See its CL description for details. I forgot to migrate a callsite in https://crrev.com/c/1830252, so I'm doing that here. Bug: 961614, 1006292 Change-Id: I74f2817d9958fb2cb7e265c0069590fea2f2844c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844516 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#703214}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c9256e16303a..4102985e1427 git log c9256e16303a..4102985e1427 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@4102985e1427 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I7bf03dec074e978f6b06e762c90b6a44d40da13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844433Reviewed-by:
-
Alexandre Courbot authored
V4L2Queue::SetFormat(), which has just been introduced, has a serious bug: it always tries to set the format on the CAPTURE queue. This error slept in because I forgot to test with --use_vd. Bug: 1003223 Test: video_decode_accelerator_tests --use_vd passes on Kevin. Change-Id: Ibfb9684e66ea0d1f64801935ad6bc2c5460c03d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844518 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Yuki Shiino authored
This reverts commit 1edbfe77. Reason for revert: The revert causes a build breakage. https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-rel/14339 Original change's description: > Revert "media/gpu/v4l2: add rudimentary V4L2Queue::SetFormat() method" > > This reverts commit 173e2342. > > Reason for revert: Suspicious about causing failures at: > https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/16980 > > Original change's description: > > media/gpu/v4l2: add rudimentary V4L2Queue::SetFormat() method > > > > Having information about the format currently set on a queue is > > valuable, e.g. to validate queued buffers. Rewrite the output queue > > format setting method of V4L2SliceVideoDecoder into an equivalent method > > of V4L2Queue, and use it from there. > > > > Bug: 1003223 > > Test: video_decode_accelerator_tests passing on Kevin. > > > > Change-Id: Iaaf56809a46a0c193bf890c73b4bcfac4988374f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839319 > > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > > Auto-Submit: Alexandre Courbot <acourbot@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#703198} > > TBR=akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org > > Change-Id: I57a064a5b334aa2eba7175ae958dddc188c2120f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1003223 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844007 > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703210} TBR=yukishiino@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org Change-Id: I6e8bb1f11f1fe536d063bd82881abd3b8d35685f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1003223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844008Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#703211}
-
Yuki Shiino authored
This reverts commit 173e2342. Reason for revert: Suspicious about causing failures at: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/16980 Original change's description: > media/gpu/v4l2: add rudimentary V4L2Queue::SetFormat() method > > Having information about the format currently set on a queue is > valuable, e.g. to validate queued buffers. Rewrite the output queue > format setting method of V4L2SliceVideoDecoder into an equivalent method > of V4L2Queue, and use it from there. > > Bug: 1003223 > Test: video_decode_accelerator_tests passing on Kevin. > > Change-Id: Iaaf56809a46a0c193bf890c73b4bcfac4988374f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839319 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Auto-Submit: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703198} TBR=akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org Change-Id: I57a064a5b334aa2eba7175ae958dddc188c2120f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1003223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844007Reviewed-by:
-
Chih-Yu Huang authored
Originally, we enqueue V4L2 CAPTURE buffers when receiving bitstream buffers from the client. Also, V4L2 driver might need an extra empty buffer to notify flush is done. That means, if we don't get an extra bitstream buffer, we cannot know when the flush is done. This CL separates the logic of enqueueing/dequeueing V4L2 CAPTURE buffers and receiving/returning the bitstream buffer. With this CL, we could get the extra V4L2 CAPTURE buffer even there is no bitstream buffer. BUG=chromium:990687, b:141285506 TEST=run VEA unittest on kevin with h264 and vp8 codec Change-Id: I1d116f0df0d9c4406c84099774c0e7ae5d0dffc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824303 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#703209}
-
Mikel Astiz authored
This relands the full logic in https://chromium-review.googlesource.com/c/chromium/src/+/1721379 which got reverted due to issues on Android (source device listed as target device). Note that the non-problematic bits of the original patch (that got reverted) have been committed in https://chromium-review.googlesource.com/c/chromium/src/+/1828817, which did NOT remove the name-based dedupping as fallback mechanism. In this patch, such name-based fallback is removed and the code now fully relies on GUID-based dedupping. It has been manually tested on Android and the issue that caused the revert does not reproduce. Bug: 991943,966413 Change-Id: Ia964d5fae36f5d9ad267a882dbda27ac578d4351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835575Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#703208}
-
Alexandre Courbot authored
In the V4L2SVD, the allocation of bitstream ids was performed in the client thread by a method and member counter. Move this into a dedicated internal class that keeps things localized and ensures thread-safety. This also makes it easier to split the stateless part of the V4L2SVD into a separate backend. Bug: 1003223 Test: video_decode_accelerator_tests passing on Kevin. Change-Id: I507dc48ac3d2b016e569b6c8d288fe6e7bced78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840033 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#703207}
-
Justin Cohen authored
Fix is in flight, but disabling tests to get downstream bots green in the meantime. Tbr: rkgibson Bug: 1011336 Change-Id: I0b4a0eb598a72fcd8ac0ba3927515e7156dd5c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844232Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703206}
-
Alexandre Courbot authored
Queuing DMAbuf buffers require some safety checks to be performed, especially regarding the number of FDs submitted and their use of offset. We used to have an ad-hoc verification function in V4L2SliceVideoDecoder, but now that V4L2Queue is aware of the current format we can move that check there, where it ought to be. Bug: 1003223 Test: video_decode_accelerator_tests passing on Kevin. Change-Id: Ic5d960c626c4146059311fb1633c25a3e207793f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839320 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a100188762d2..a703cbaf0526 Created with: gclient setdep -r src-internal@a703cbaf0526 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0cfd72848426c06dc2f4187b5142ecdcca3920d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844093Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iba4edb08a95a9a40bb567dd8e54c862e8a329d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843776Reviewed-by:
-
Kuo Jen Wei authored
This reverts commit a4453534. Reason for revert: http://crbug.com/1011605 Original change's description: > Mark some blink testing targets testonly > > This forbids production code depending on these targets, and enables > these targets to depend on other testonly targets in the future. > > The only dependency prevented core:testing from being testonly was > from BlinkLeakDetector. Add Page::PrepareForLeakDetection() and > InternalSettingsPageSupplementStub (in page.h) to avoid the > dependency. > > Change-Id: Ie22676a233d9b5c02cf3cde79629f4b84782b572 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829586 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701334} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Icb266b74d3f75ffff2176ec2b0ca4871d99e7587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842973Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#703202}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I72e15ffeefc05f4694466f4a8c502ae8c764f331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844095Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703201}
-
BUG=762641 TBR=oshima@chromium.org Change-Id: I8c255a127810c39c0e533931413228e158db496e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844551Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703200}
-
Takuto Ikuta authored
Bug: 693079 Change-Id: Ib103e0e4d53d3f7d072971780ef9dd07d64cdc1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844513 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#703199}
-
Alexandre Courbot authored
Having information about the format currently set on a queue is valuable, e.g. to validate queued buffers. Rewrite the output queue format setting method of V4L2SliceVideoDecoder into an equivalent method of V4L2Queue, and use it from there. Bug: 1003223 Test: video_decode_accelerator_tests passing on Kevin. Change-Id: Iaaf56809a46a0c193bf890c73b4bcfac4988374f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839319 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
Workers and worklets interact with various features, and tests are scattered among Chromium codebase. This sometimes caused us to forget to add test cases, and notice some features are broken after they are shipped. To avoid the situation as much as possible, this CL lists locations where we should add tests in README.md. Bug: n/a Change-Id: Ie0dfc875f4a8149e7c820d9491c75aea418a87ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839277 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#703197}
-
Kazuki Takise authored
Bug: b/142095503 Bug: b/141899229 Test: tast -verbose run my_crbook arc.PIP Change-Id: I259dfc8f8b1c1ffaaa24ff2fd274dba65a9784c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838840 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#703196}
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including foo.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes and following CLs will continue replacing them more. Bug: 1001360 Change-Id: I8a3de3f462f1c74a270762f60ba83d69c008f92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839226Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/34747e9180a6..a100188762d2 Created with: gclient setdep -r src-internal@a100188762d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8e5c0a02d72c27e62884fdd1ec1d780c38a43ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844201Reviewed-by:
-
- 06 Oct, 2019 5 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd1a11cb2f1c..34747e9180a6 Created with: gclient setdep -r src-internal@34747e9180a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I982d15f8b0d6fa8c209f25f1b0291d37bbd14776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844193Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib431917e8265e1024e9016366ab941db4b025274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844191Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b37d05ea5346..dd1a11cb2f1c Created with: gclient setdep -r src-internal@dd1a11cb2f1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I12aa0d34f365ab48cc45c91a711b2d904185d0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843824Reviewed-by:
-
BUG=762641 TBR=rkc@chromium.org Change-Id: Id3dda69ec09aef324c2c9e47558c148f2f4a7ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844031Reviewed-by:
-
Xianzhu Wang authored
We create webview plugins at least for unsupported plugins to show placeholder information. These plugins create frames in the frame tree, and compositing update creates GraphicsLayers for the root paint layers in these frames. Previously PrePaintTreeWalk didn't walk into webview plugins, causing missing paint properties in them. Bug: 1004146 Change-Id: I2dca2eb19b55eabec015333ace5783af4bbed03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838992Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703189}
-
