- 02 Oct, 2018 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7f61afaa6ec3..121ad83c50b6 git log 7f61afaa6ec3..121ad83c50b6 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 hjd@google.com Add libfuzzer to buildtools gitignore Created with: gclient setdep -r src/third_party/perfetto@121ad83c50b6 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If22e3137e25ca856e41afdc3e1666ba504fe412d Reviewed-on: https://chromium-review.googlesource.com/1256231Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595786}
-
Camillo Bruni authored
Several login pages do no longer work by simply settings the value of the email and password inputs. Using EnterText single KeyboardEvents are dispatched to the currently selected input thus simulating more closely real input. Bug: 878390 Change-Id: I86ba8edbac681d6739acaaebe74ed4e6b1034096 Reviewed-on: https://chromium-review.googlesource.com/1254962 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#595785}
-
Camillo Bruni authored
Bug: 878390 Change-Id: I496645dbfe68a1e5603035647ad70167b1107164 Reviewed-on: https://chromium-review.googlesource.com/1236793 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Mikel Astiz authored
OnSyncStarting() should be completed (replied to) when a model is ready to sync and the initial sync metadata has been loaded. This is important to honor the processor's invariant that no remote changes are expected (from the worker) unless the model is ready to sync. For the (unlikely) case where OnSyncStarting() detects a cache GUID mismatch (e.g. database in a corrupt state), *AND* the bridge becomes unready to sync (currently the case for SESSIONS) as a reaction to that, we should make sure no reply is issued for OnSyncStarting() until the model becomes ready to sync. Specifically, for SESSIONS (SessionSyncBridge), this scenario could lead to MergeSyncData() being called too early, before the model was ready to handle it, running into DCHECKs (for DCHECK-enabled builds) or crashes. This becomes more likely if the UssMigrator is exercised (i.e. clients that transition from the directory-based sessions implementation to the USS implementation for the first time), because the migrator mimics a response from the server that is very fast (no actual network involved). Bug: 876490 Change-Id: I83e851fbbff235bb49ee03fd7f98d9764830ed83 Reviewed-on: https://chromium-review.googlesource.com/1256565 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#595783}
-
Manuel Rego Casasnovas authored
Spec text (https://drafts.csswg.org/css-contain/#containment-size): "2. Elements with size containment are monolithic." This patch updates LayoutBox::GetPaginationBreakability() to check if the element has size containment. BUG=855263 TEST=external/wpt/css/css-contain/contain-size-breaks-001.html TEST=external/wpt/css/css-contain/contain-size-monolithic-001.html Change-Id: I372888eec2e3ab7ca51ad9c9b397ea6b8c89b629 Reviewed-on: https://chromium-review.googlesource.com/1256566Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#595782}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/95ed233ed1a3..59297c6f73a6 git log 95ed233ed1a3..59297c6f73a6 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 mattcary@chromium.org Tracing: add java_base* executable memory metrics. Created with: gclient setdep -r src/third_party/catapult@59297c6f73a6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:875276 TBR=sullivan@chromium.org Change-Id: I0f47af7fffdfbc9c497d5cdce9c61dc82782c527 Reviewed-on: https://chromium-review.googlesource.com/1256077Reviewed-by:
-
Yutaka Hirano authored
- Fix beacon-common.sub.js and so that it can handle exceptions thrown from sendBeacon. - Simplify beacon-common.sub.js. - Remove navigate.iFrame.sub.html. Replace it with scripts in the main page. Bug: 876670, 626703, 848275, 876669 Change-Id: I847dec3a71b27c76df156326637be243876daaab Reviewed-on: https://chromium-review.googlesource.com/1237796Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#595780}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/674c0aa15399..daa3b5e9795b Created with: gclient setdep -r src-internal@daa3b5e9795b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8ec528525fa6add94519451bc47cd6aa0976b858 Reviewed-on: https://chromium-review.googlesource.com/1256228Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595779}
-
Ian Kilpatrick authored
During computing the size of an SVG we may end up calling: ContainingBlock()->AvailableLogicalWidth() This is invalid inside LayoutNG as we should always use the override set by the LayoutNG algorithm. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia9f32ac921726cf3f3f0d76dcccd2a0497cb25cf Bug: 635619 Reviewed-on: https://chromium-review.googlesource.com/1255598 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
A Olsen authored
SystemSettingProvider had a dep on both LoginState and ProfileManager, in order to check if the user had permission to change the timezone. ProfileManager is in chrome/browser and I am trying to remove chrome/browser deps, so I changed the code to use only UserManager. See https://chromium-review.googlesource.com/1238450 I realized afterwards that UserManager deps are also currently not allowed in src/chromeos, where this code will soon live. Rather than expand the list of deps (which should be kept small), I have updated LoginState so that only it is needed here (instead of ProfileManager or UserManager). So, the last change is no longer needed, and is reverted. I also tidied up conversion code in ChromeUserManager slightly - Moving if-else-else chain into a helper function with switch + return means that the compiler checks that all cases are handled. Bug: 446937 Change-Id: I3aa44cacdef752f997d12b647d6e073f806371d3 Reviewed-on: https://chromium-review.googlesource.com/1249209Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595777}
-
Olga Sharonova authored
The theory is that the count difference is due to different timing of events when navigation happens during the output stream creation. That situation would correspond to the cases when AudioOutputStreamBroker is destroyed while its internal |disconnect_reason_| state is DisconnectReason::kDocumentDestroyed. We'll measure both probability of this situation as well as duration of stream creation as seen by AudioOutputStreamBroker. Bug: 867827 Change-Id: I226fd275b485cccbc3899ec4c6fa39232a719979 Reviewed-on: https://chromium-review.googlesource.com/1249841 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#595776}
-
Maksim Sisov authored
The wl_surface_damage method was used in a wrong manner - if a damage region is not supplied, the wl_surface_damage still must be provided with the width and the height of the buffer to update the surface with a new content. This happens when partial swap is disabled and there is no damage region provided. What is more, instead of using wl_surface_damage, start using wl_surface_damage_buffer, as long as the damage region corresponds more to the buffer region contents rather than the surface itself (and which is claimed to be a better approach by the Wayland documentation) Bug: 891188 Change-Id: Iff3a4eb50eae1a113818ef7881b6529b906f4820 Reviewed-on: https://chromium-review.googlesource.com/1255635Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#595775}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2f9fe770. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." 534cd7bb "isXXX methods added to TrustedTypePolicyFactory" a9d61b8e "Implement RTCIceTransport.onselectedcandidatepairchange" 3e89d0d3 "Revert "Implement RTCIceTransport.onselectedcandidatepairchange"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25748 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1af14b5a781a6dc1982de8c68f04a42962972f88 Reviewed-on: https://chromium-review.googlesource.com/1256623 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595774}
-
Vaclav Brozek authored
On non-iOS platforms, the PasswordStore reports metrics about the usage of password manager on every start. For iOS, all the pieces are there, but have not been used. This CL adds the reporting on iOS. Bug: 887409 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Icef32ced5cbc7e61776e0f1ca41466d4ef65f032 Reviewed-on: https://chromium-review.googlesource.com/1255523Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595773}
-
Alex Clarke authored
This reverts commit c8c4a655. Reason for revert: I fixed a bug in LazilyDeallocatedDeque here https://chromium-review.googlesource.com/c/chromium/src/+/1253982 which might be responsible for the crashes. Lets re-enable LazilyDeallocatedDeque and see. Original change's description: > Revert "Second try at using LazilyDeallocatedDeque instead of circular_deque in TaskQueue" > > This reverts commit 6410ee3d. > > Reason for revert: This is causing some crashes. > > Original change's description: > > Second try at using LazilyDeallocatedDeque instead of circular_deque in TaskQueue > > > > Previous patch: https://chromium-review.googlesource.com/c/chromium/src/+/1080792 > > > > Our usage pattern is unfortunate for existing queues such as > > base::circular_deque. We tend to fill up an empty queue and then drain all > > those tasks until it's empty. This means the queue yo-yos in size which > > confuses the memory reclamation schemes of most queues. > > > > As an optimisation we introduce a deque specialised for TaskQueueManager's > > usage patterns. For performance (memory allocation isn't free) we don't > > automatically reclaim memory when the queue becomes empty. Instead we rely > > on the surrounding code periodically calling MaybeShrinkQueue, ideally when > > the queue is empty. > > > > We keep track of the maximum recent queue size and rate limit > > how often MaybeShrinkQueue actually shrinks the buffer to avoid unnecessary > > churn. > > > > This yields a nice win on our microbenchmark: > > > > Patch: us/run for 10000 delayed tasks with N queues > > 1 queue 4 queues 8 queues 32 queues > > 33448.166666666664 33215.75496688742 33484.34 34018.37414965987 > > 33972.18243243243 33846.91891891892 34489.737931034484 34727.90277777778 > > 33367.90666666667 33167.54304635762 33392.96 33906.89864864865 > > 33392.13333333333 33107.17763157895 33340.18 33718.73825503356 > > 37921.01515151515 39379.06299212598 38851.27906976744 39366.03125 > > 38171.564885496184 37401.72388059701 37640.32330827068 37800.51127819549 > > 34691.2275862069 34359.61643835616 34993.468531468534 35366.795774647886 > > 35981.20863309353 35089.18881118881 38530.230769230766 39280.3515625 > > 39262.8671875 36411.384057971016 33576.10067114094 33939.69594594595 > > 37913.59848484849 38324.076335877864 38061.59848484849 39921.00793650794 > > Average 35812.1871 35430.24471 35636.02188 36204.63076 > > > > ToT: us/run for 10000 delayed tasks with N queues > > 1 queue 4 queues 8 queues 32 queues > > 40459.540322580644 40536.04838709677 38994.573643410855 38696.2 > > 39422.149606299216 39299.5 37888.18939393939 37874.74436090225 > > 38419.70229007633 38025.742424242424 37844.41353383459 38020.469696969696 > > 35052.72027972028 38147.80303030303 35504.89361702128 34138.02721088436 > > 37096.77777777778 34942.541666666664 37003.529411764706 37579.60447761194 > > 38818.67441860465 38233.068702290075 37978.628787878784 37867.57142857143 > > 38455.49618320611 37903.05303030303 38106.143939393936 38129.5 > > 40609.33064516129 37721.75187969925 34656.441379310345 34294.33561643836 > > 35273.704225352114 34646.324137931035 34335.643835616436 34311.82876712329 > > 35821.41428571429 35362.035211267605 37522.27611940299 35429.281690140844 > > Average 37942.951 37481.78685 36983.47337 36634.15632 > > > > Percentage improvement > > 5.61570422 5.473437399 3.643388159 1.172472933 > > > > NB the reason the improvement goes down with the number of queues is because > > we're saving malloc overhead in the queue, but a constant number of tasks are > > posted across N queues. This means the more queues we have in this test, the > > less loaded the queues are individually. > > > > Change-Id: I975d7f864dc55715fb9f949ef65321da93e4cef4 > > Reviewed-on: https://chromium-review.googlesource.com/1169043 > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#582586} > > TBR=skyostil@chromium.org,alexclarke@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Id8290646dba1dcea9fcf92d490b9ce4ac63ae702 > Reviewed-on: https://chromium-review.googlesource.com/1177561 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584314} TBR=skyostil@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia3931cc50bc18fda4df3f385927498728c7a2e8f Reviewed-on: https://chromium-review.googlesource.com/1254301Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595772}
-
Mikel Astiz authored
This is part of a patch series where we leverage the recently introduced layer that allows integrating legacy SyncableService implementations within the newest architecture, USS. This requires forking custom controllers because a different class hierarchy is used. Bug: 870624 Change-Id: I0931243109eef8f757692c5a932f03004f8ce039 Reviewed-on: https://chromium-review.googlesource.com/1254211 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#595771}
-
Gauthier Ambard authored
The toolbar model is only used by the location bar. It is called toolbar model to because of the components code. It has nothing to do with the ios/chrome/browser/ui/toolbar. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3161f3bb47ec16e21331266a4e1a2bcfa091b325 Reviewed-on: https://chromium-review.googlesource.com/1246164Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595770}
-
Mark Cogan authored
Bug: 884724 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I53368d4beeb536695e2190f0fdebf64f4198c6a4 Reviewed-on: https://chromium-review.googlesource.com/1251545 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#595769}
-
Gauthier Ambard authored
This CL removes the method allowing the web controller to decide if the location bar needs to display the hint text or not. It keeps the SetShouldShowHintText in the LocationBar for now as I don't know the code well enough to remove all of it. Bug: 374984, 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3612e999ac7648620db958e0f6913727f3f64c80 Reviewed-on: https://chromium-review.googlesource.com/1245364 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
stkhapugin@chromium.org authored
Moves the shortcuts experiment flag from iOS-only list to omnibox flags, and disables ZeroSuggest provider when it's on. Bug: 884687 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iaa709a78b0ae0a5862edec457ec0f2555e45dced Reviewed-on: https://chromium-review.googlesource.com/1233454Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Kouhei Ueno authored
Bug: 890180 Change-Id: I3cedfd4b03b534eabeb9573c226123bd3d70068e Reviewed-on: https://chromium-review.googlesource.com/1250686Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#595766}
-
Daniel Bratell authored
In jumbo builds a whole build target can compile together and share the same anonymous namespace. Then two methods with the same name and arguments will clash which happens in chrome/common. This resolves that clash twice over by giving one GetInfo a longer name and inlining the other one since it was only used once in a one line function. Bug: 890323 Change-Id: Icbb1d768bdf9c1385f35bebd54d0d008e4be49d9 Reviewed-on: https://chromium-review.googlesource.com/1251603Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#595765}
-
Marc Treib authored
PersonalDataManager.addServerCreditCardForTest adds a server credit card directly to PDM's cache, without going through Sync. That creates an inconsistent state, which makes the tests fragile to unrelated changes (e.g. https://crrev.com/c/1251041). Instead, this CL uses FakeServer::SetWalletData, which needed to be plumbed through to Java. Bug: 889941 Change-Id: Ie70a2f8ca311d36267c9aa16dca9363b60b4ee2c Reviewed-on: https://chromium-review.googlesource.com/1255062Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#595764}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9fe56ff9c6f8..674c0aa15399 Created with: gclient setdep -r src-internal@674c0aa15399 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I519019be1efa6e3a1934e55f494ac1879aa2b238 Reviewed-on: https://chromium-review.googlesource.com/1256076Reviewed-by:
-
Henrik Boström authored
Adds destructor traits to ensure WebRtcMediaStreamTrackAdapter, which is reference counted, is destroyed on the main thread. Due to references in base::Bind-ings, possibly from third_party/webrtc or elsewhere, destruction did not always occur on the main thread. The mix of reference counting and usage on multiple threads is just inherently risky. This change allows us to add a DCHECK in the destructor and fixes one of the most common crashes currently in Canary. Bug: 888460 Change-Id: I30948f1ade16769bfc3c94a6a2893df7c56c8d5a Reviewed-on: https://chromium-review.googlesource.com/1254206Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#595762}
-
Sergio Villar Senin authored
Users of ProfileOAuth2TokenService should use instead the IdentityManager API so that they could eventually use the identity service. Bug: 887245 Change-Id: I2ac628d92759488530ee699d438dea920b8b6a9b Reviewed-on: https://chromium-review.googlesource.com/1245784 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#595761}
-
Tetsui Ohkubo authored
This CL fixes two issues related to UserChooserView in UnifiedSystemTray. * Ensure the UnifiedSystemTray bubble is expanded before showing UserChooserView. * Show error messages when number of added users reaches the limit. BUG=890720,890722 TEST=manual Change-Id: I2ea7c807da18e165f66345e50b9c6cf39e954840 Reviewed-on: https://chromium-review.googlesource.com/1255745Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#595760}
-
Miyoung Shin authored
This CL reimplements to use one CF_HDROP clipboard format having series of file path's strings instead of series of CF_HDROP having a file path string to get multiple file paths correctly for dragging. BUG=878690 Change-Id: I167e93f6411f866cb143b910b1fc7d4896481ffc Reviewed-on: https://chromium-review.googlesource.com/1195176Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595759}
-
Morten Stenshorne authored
AbsoluteContentBox() used to cast directly from float to int, and if the float value was sufficiently large, we'd end up with a negative integer value. Changed the two former callsites to using PhysicalContentBoxRect() + LocalToAbsolute() instead. AbsoluteContentBoxOffset() was unused. Bug: 888510 Change-Id: Id1447973f23cabf40a45180aa95a69ba402688c6 Reviewed-on: https://chromium-review.googlesource.com/1245782Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#595758}
-
Kent Tamura authored
security_context.h is used in 2,700+ compilation units. crrev.com/594074 increased its pre-processed size by 1.32MB, and this CL fixes it. Bug: 242216, 888668 Change-Id: I623ad22e5351328f934a0b1cd7caece6b4b07944 Reviewed-on: https://chromium-review.googlesource.com/1256470Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#595757}
-
Mitsuru Oshima authored
ui/views dependency will be addressed as a part of crbug.com/890403 Bug: b/116028711 Test: Tested using following apps with and without chrome caption, in windowed, maximized, fullscreen using Japanese IME. hangout, hangout inline reply (in notification), Google play, FB chatheads I couldn't test with Docs due to b/116855183 Change-Id: Ie371f44286ca0e42e6f0a7f4bb40c9e19e2717da Reviewed-on: https://chromium-review.googlesource.com/1252012Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#595756}
-
Manuel Rego Casasnovas authored
r595201 fixed how overflow is clipped in paint containment, there were two tests failing because of that so we can now unskip them. TBR=eae@chromium.org,vmpstr@chromium.org BUG=882322 Change-Id: I029cad3f873f90894bd66a531aee2e2e94b62eb0 Reviewed-on: https://chromium-review.googlesource.com/1256682 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#595755}
-
Stephane Zermatten authored
With this change, Autofill Assistant only runs when the feature is enabled and the Intent contains: org.chromium.chrome.browser.autofill_assistant.ENABLED. Bug: 806868 Change-Id: I6bc81181b9f16a2d13e56ff657c6bd9076621808 Reviewed-on: https://chromium-review.googlesource.com/1254281 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595754}
-
Ramin Halavati authored
kMediaDeviceIdSalt is removed from incognito persistent preferences list. After this CL, the changes to this preference in incognito mode are not written to user profile. Bug: 861722 Change-Id: If9328b582523573fb0f9cbcc7dbe89ff8b36c8b4 TBR: perkj@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1255525 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#595753}
-
Christopher Cameron authored
In theory, views::Widget::ReparentNativeView and views::Widget::InitParams allow specifying any NSView* as the parent of a views::Widget. The only parent ever actually specified in production is the NSView* corresponding to the root views::View of another views::Widget. Add a CHECK to verify that this is the case. If the CHECK is not hit, then we remove this functionality. Continue to allow testing of this path (for now) by disabling this CHECK via a static method. Bug: 859152 Change-Id: I70a9a22352e22b1949d37c86c36388ed5380316b Reviewed-on: https://chromium-review.googlesource.com/1255863 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#595752}
-
Christopher Cameron authored
The NSView hierarchy for most windows is - BridgedNativeWidget - WebContentsView (*) - RenderWidgetHostView This patch adds a cross-process interface for WebContentsView. This interface created via the NSViewBridgeFactory interface, using the new mojo method CreateWebContentsNSViewBridge. Add the mojo interface content::mojom::WebContentsNSViewBridge and content::mojom::WebContentsNSViewClient. - The interface that is exposed is motivated by the native Cocoa calls made by views::NativeViewHostMac (which are targeting the WebContentsViewCocoa). - Note that this interface is public (unlike RenderWidgetHostNSView) because it doesn't have any content-private dependencies. Add methods to the C++ interface ui::ViewsHostableView (which is implemented by WebContentsViewMac), to perform all of the functions currently done by Cocoa calls on WebContentsViewCocoa. Add the class content::WebContentsNSViewBridge, which implements the new mojo interface. - This performs the same Cocoa calls that are done in the browswer process. - Note that this class does not instantiate WebContentsViewCocoa (the NSView sub-class used by WebContents), rather, it uses a vanilla NSView. This may change in the future, if need be. - Note that this NSView is in addition to the WebContentsViewCocoa created in the browser process (not in place of it). Update RenderWidgetHostMac::MigrateNSViewBridge to take the arguments that content::WebContentsViewMac will send it. Bug: 821651 Change-Id: Ic1dd5c469a8dab32837cdf23cdda34d24d6240cb Reviewed-on: https://chromium-review.googlesource.com/1253095 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595751}
-
David Jean authored
- Resize on rotation. - Disable scrolling of table when active. Bug: 889012,889506, 889461 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I54d4f41d31a0fb3ec7e248a3cb25bb985e58cf72 Reviewed-on: https://chromium-review.googlesource.com/1249483 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595750}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/421d954080fe..9fe56ff9c6f8 Created with: gclient setdep -r src-internal@9fe56ff9c6f8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I211ebf858b183eefe6dd0830ee82ebdffa50ccef Reviewed-on: https://chromium-review.googlesource.com/1256074Reviewed-by:
-
Alice Boxhall authored
Previously, ChildrenChanged() was being called while layout was in-progress, potentially causing crashes as certain AXObject attributes require walking the flattened DOM tree. This change instead queues up changes which would trigger ChildrenChanged() calls, and processes all updates to the accessibility tree after layout is complete. Change-Id: Ifd99b31a229cbabd48bfa6515951d0aba32c1cc6 Reviewed-on: https://chromium-review.googlesource.com/1239296 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#595748}
-
Noel Gordon authored
The QuickView text <webview> provides no signal that it is loaded, but it does have a src attribute. That can used as a proxy for loaded, and help make a test that is robust (to load / script timing) on the bots. - make the text <webview> selector precise (.text-content class) - change the text scroll test to check the webview src attribute is non-empty before proceeding. - change to use scrollBy, and send incremental scrolls until the the scroll limit is reached [1]. [1] if the bot misses or drops a JS scrollBy request, no problem: just ask for it again. Bug: 891150 Change-Id: I0bb49c2b08b3535172819a3c1088fca5ba6fda94 Reviewed-on: https://chromium-review.googlesource.com/1256469Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595747}
-
