- 29 Jun, 2018 40 commits
-
-
Allen Bauer authored
Bug: 842798 Change-Id: I2ccf920a119bece954ff037fed8e0e18cedadf25 Reviewed-on: https://chromium-review.googlesource.com/1113505 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#571483}
-
David Quiroz Marin authored
Restoring a transformation using ctx.restore() transforms all points in the path by that transformation which gives unwanted results when it's a non-invertible matrix, like collapsing all points to 0,0. This fix prevents that from happening applying the non-invertible transforms only to the affected points. Bug: 261727 Change-Id: Ibf6793626a7db1fa7ff4c8aa23d506db7f858787 Reviewed-on: https://chromium-review.googlesource.com/1115767 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#571482}
-
Aldo Culquicondor authored
This avoids any corruption of the state between chromium and Skia. Bug: 856404 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib77c4d23d0aa2ba8704499f2f2e12a93c5ec9609 Reviewed-on: https://chromium-review.googlesource.com/1117741 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#571481}
-
Friedrich Horschig authored
This CL makes the ManualFillingMediator consider various cases of a tab being hidden. Most importantly, it's now aware to when the tab overview is opened which resolves a crash that happened in combination with the HorizontalTabSwitcherAndroid feature. Bug: 856523, 853742, 856033 Change-Id: If09a3ac3551e2ebed1cfac6bb4870ff98d6c1ec1 Reviewed-on: https://chromium-review.googlesource.com/1118384Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#571480}
-
manuk authored
Previously, if navigating a link did not cause a url change (e.g. clicking on the `stackoverflow` logo on the `stackoverflow.com` homepage reloads the same page), then the display url remained unchanged. If the user had deleted or edited the url, his changes would remain. Now, the url is reset. Bug: 830491 Change-Id: I9819fa29ca1d86467a660e0e40ddb149cf210f1d Reviewed-on: https://chromium-review.googlesource.com/1114337Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#571479}
-
kylechar authored
The callback was added so we could use CompositorFrameSinkSupport* in HostFrameSinkManager. This functionality never ended up getting used for anything beyond a DCHECK. Remove it as it's not neccessary. Bug: 856705 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ib4c100744cdf7964283eef941567513a1034c10c Reviewed-on: https://chromium-review.googlesource.com/1119097Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#571478}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c54f706993be..43d0b98fe5ad git log c54f706993be..43d0b98fe5ad --date=short --no-merges --format='%ad %ae %s' 2018-06-29 terelius@webrtc.org Clean up RateControlInput struct, used by bandwidth estimation. 2018-06-29 mhoro@webrtc.org Unit test for case where the number of active and configured spatial 2018-06-29 mbonadei@webrtc.org Set gtest_enable_absl_printers to true. 2018-06-29 minyue@webrtc.org Implement PacketDuration() for FakeDecoderFromFile. Created with: gclient setdep -r src/third_party/webrtc@43d0b98fe5ad The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia0383dd049921bffd215fdaafd4d02a5ab2a3574 Reviewed-on: https://chromium-review.googlesource.com/1120186Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571477}
-
Denis Kuznetsov authored
Add "enterprise card", made license selection screen use the card. Bug: 811556 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ibb8dc59b3232c4a5d9a65b4c79faf57294bec913 Reviewed-on: https://chromium-review.googlesource.com/945994 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#571476}
-
David Michael Barr authored
Android ABI compat code for x86 assembly was removed August 2016. See vpx_ports/x86_abi_support.asm in: "more cleanup of vp8 and vp9" https://aomedia.googlesource.com/aom/+/a3cff082 Bug: 783519 Change-Id: Ifb32c16d8d6bc139860d9a0f8a29e8e5c558c947 Reviewed-on: https://chromium-review.googlesource.com/1119615Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#571475}
-
Justin Novosad authored
This CL moves checks on GetOrCreateResourceProvider() to make sure they are done after call to FlushRecoriding, just in case FlushRecording cause the gpu context to be dropped (which invalidates the ResourceProvider). As a drive-by improvement, some call sites to GetOrCreateResourceProvider() were replaced with calls to ResourceProvider() in cases that follow checks on GetOrCreateResourceProvider(). BUG=856745 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3a362b518df3f6fe4312c04a9aabb4b9aa698277 Reviewed-on: https://chromium-review.googlesource.com/1118530 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
-
Greg Kraynov authored
The way how ThreadController work isn't compatible with the semantic of unscheduling wake-ups at a *specific* time, simply because there's only one delayed wake-up can be set at any time. ThreadControllerImpl::DoWork post a delayed continuation if necessary, making TimeDomain's CancelWakeUpAt pointless, so TimeDomain now simplified as well. Bug: 857101 Change-Id: Ib542ee3eb13a481175aeed4d9072e0296a1d06e4 Reviewed-on: https://chromium-review.googlesource.com/1120245Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#571473}
-
Devlin Cronin authored
According to https://html.spec.whatwg.org/multipage/scripting.html#scriptingLanguages, JS files should have a MIME type of text/javascript. Update our mappings. Bug: 857588 Change-Id: I6c9ce8c52a3e6afcb8768392b59e766a0db3b5c5 Reviewed-on: https://chromium-review.googlesource.com/1117564 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#571472}
-
Scott Graham authored
https://chromium.googlesource.com/chromium/buildtools.git/+log/9c9fd97928dd..aec56e26079f $ git log 9c9fd9792..aec56e260 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 scottmg Roll to gn from gn.googlesource.com 2018-06-27 scottmg Add gn-has-moved binary in old gn location 2018-06-26 scottmg Remove GN from buildtools Bug: 858852, 855791 Change-Id: Iff22850633eac5a56540d261da6fd52c021e2ba4 Reviewed-on: https://chromium-review.googlesource.com/1119579Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#571471}
-
Henrik Grunell authored
TBR=dtseng@chromium.org Bug: 857382 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib3ed2aeb9704d36ac70d2333da1c93be0fc78d78 Reviewed-on: https://chromium-review.googlesource.com/1120181Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#571470}
-
Bence Béky authored
The most recent recommendation for field trials is that the experiment group name should not control behavior, parameters should be used instead. See cr/202316744. Indeed, naming an experiment group that was meant to disable HTTP/2 push "DisablePush" has instead disabled HTTP/2 altogether, causing https://crbug.com/853153. This CL removes this behavior from this particular field trial to avoid this mistake in the future. Change-Id: I9396e1a0e97172d5347bc78188041f32d58f07d4 Reviewed-on: https://chromium-review.googlesource.com/1118858Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#571469}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fa5d84be4145..cdf50444934c git log fa5d84be4145..cdf50444934c --date=short --no-merges --format='%ad %ae %s' 2018-06-29 jmadill@chromium.org Add test for sampler struct rewriting indexing. Created with: gclient setdep -r src/third_party/angle@cdf50444934c The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I1f381603cf213e0648dbdfa8084e487a8de02fb9 Reviewed-on: https://chromium-review.googlesource.com/1120185Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571468}
-
Yi Gu authored
TBR=grunell@chromium.org NOTRY=true Bug: 859063 Change-Id: Idc773b6de9d9a729ce298f6f950dfc6e818fa269 Reviewed-on: https://chromium-review.googlesource.com/1120161Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571467}
-
Yi Gu authored
TBR=grunell@chromium.org NOTRY=true Bug: 859063 Change-Id: Ie4248ed7493c81f946734678ddea9c228a8c0c24 Reviewed-on: https://chromium-review.googlesource.com/1120160Reviewed-by:
-
Justin Donnelly authored
The new search icon looks cool but is not obviously a magnifying glass to many people's eyes. Bug: 846407 Change-Id: Ibe32f016d34827d8f03b7bbda5fdf721dddf9f5e Reviewed-on: https://chromium-review.googlesource.com/1118716Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#571465}
-
Eric Noyau authored
Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2cc95182aa69a74e05c5b31eb6f05af5e6eb9b9a Reviewed-on: https://chromium-review.googlesource.com/1118265 Commit-Queue: Eric Noyau <noyau@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#571464}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/20c3677acc37..c4642d4ffe8e git log 20c3677acc37..c4642d4ffe8e --date=short --no-merges --format='%ad %ae %s' 2018-06-29 art-snake@yandex-team.ru Implement CPDF_HintsTable::PageInfo. Created with: gclient setdep -r src/third_party/pdfium@c4642d4ffe8e The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5d59b67c61ad2a6c997352a7af9072cb33545b9a Reviewed-on: https://chromium-review.googlesource.com/1120188Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571463}
-
Henrik Grunell authored
This reverts commit 89b548a0. Reason for revert: Likely to cause flakiness of test WebViewTest.SelectShowHide. Original change's description: > cc: Post task on mojo begin frame to mitigate begin frame flood > > Unlike PostTask from IO thread to compositor thread in Chrome IPC, mojo > polls for messages on the compositor thread which means it can dequeue a > large number of begin frame messages after the compositor thread has > been busy for some time. All but the last begin frame cancels the > previous begin frame, and is essentially a nop, but it still ticks > animations. When a page has a large number of animations each begin > frame can take a long time and push out other tasks such as tile manager > callbacks stalling the pipeline. > > Throttling the begin frames in viz doesn't fully solve the problem > because we have to allow at least two begin frames in flight for > pipelining, and so the client can still process two begin frames back to > back. > > Post a task to issue the begin frame to the source and its observers. > The task is reset on every begin frame mojo message so only the last > message is propagated to the source. > > TEST=AsyncLayerTreeFrameSinkTest.MultipleBeginFrames > R=danakj > BUG=782002 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ie98930a3078dde5ff99b42148596cf564c079220 > Reviewed-on: https://chromium-review.googlesource.com/1111474 > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571282} TBR=sadrul@chromium.org,danakj@chromium.org,fsamuel@chromium.org,sunnyps@chromium.org,piman@chromium.org Change-Id: I5f184c5bde6384aa8b40feb2941e259ace7d7ac3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 782002 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1120305Reviewed-by:
-
Yi Gu authored
TBR=grunell@chromium.org NOTRY=true Bug: 859063 Change-Id: Iafc22ff3f54532562e53c7c0a11f1fe2e3c4c157 Reviewed-on: https://chromium-review.googlesource.com/1120157Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e2d6bbca629c..f76f0b44062c git log e2d6bbca629c..f76f0b44062c --date=short --no-merges --format='%ad %ae %s' 2018-06-29 cphlipot0@gmail.com [Systrace] remove duplicate --target option. Created with: gclient setdep -r src/third_party/catapult@f76f0b44062c The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia094742e6ff5c33aa84bd31c03ed2ce05dfa88d5 Reviewed-on: https://chromium-review.googlesource.com/1119928Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571460}
-
Adithya Srinivasan authored
Follow up to https://crrev.com/c/1081092 Bug: 781655 Change-Id: I6329b9a9f256aa3658c3fb3616355165bec0e780 Reviewed-on: https://chromium-review.googlesource.com/1118614Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#571459}
-
Colin Blundell authored
IdentityProvider currently has baked-in knowledge of OAuth2TokenService for functionality that is shared between ProfileIdentityProvider and DeviceIdentityProvider. However, as we will be converting ProfileIdentityProvider to talk to IdentityManager rather than OAuth2TokenService, this baked-in knowledge needs to be moved out of IdentityProvider; ultimately, it will end up only in DeviceIdentityProvider. As the last step of removing this knowledge from IdentityProvider, this CL moves IdentityProvider's observing of OAuth2TokenService into its two derived classes. ProfileIdentityProvider is now ready to be converted to use IdentityManager; that work will shortly follow. Bug: 809452 Change-Id: I9beaae509b2aae22308c0bd47f962a42cba93f8d Reviewed-on: https://chromium-review.googlesource.com/1114855 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#571458}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb21219e. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20355 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox TBR=kereliuk No-Export: true Change-Id: I3a79c0ad52836e825f2ba59fc2943810fb4d1d94 Reviewed-on: https://chromium-review.googlesource.com/1120145 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#571457}
-
cathiechen authored
In order to compute the intruded float width, we find opportunity for marker, and compare it to ListItem content_rect. If direction:ltr, compare the left side, if rtl, compare the right side. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3901ac5e758497b2503a5b9fefa71ec0a4ca57e5 Reviewed-on: https://chromium-review.googlesource.com/1116895Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: cathie chen <cathiechen@tencent.com> Cr-Commit-Position: refs/heads/master@{#571456}
-
Adam Rice authored
Replace the remaining 7 uses of #include <v8.h> in Blink with the modern- style #include "v8/include/v8.h". Bug: 688155 Change-Id: I6b28c0f94275f9e461fedf68d48edc1ebd7c7b74 Reviewed-on: https://chromium-review.googlesource.com/1119951 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d3714bb8..b5ad7b8d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I26e21d7aa8255fcfb55a412a1a89a3a8327b6a76 Reviewed-on: https://chromium-review.googlesource.com/1119854Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571454}
-
Oscar Johansson authored
The macro CACHE_UMA_BACKEND_IMP_OBJ is defined in: net/disk_cache/blockfile/backend_impl.cc net/disk_cache/blockfile/entry_impl.cc When building using jumbo these end up in the same scope and conflict. This commit solves the issue by undefining the macro at the end of the file. Bug: 772146 Change-Id: Ib888216156c3054616f6e906e6c23a648154d2d9 Reviewed-on: https://chromium-review.googlesource.com/1118273Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571453}
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variables kBeta in: net/third_party/quic/core/congestion_control/cubic_bytes.cc net/third_party/quic/core/congestion_control/rtt_stats.cc This commit solves the issue by renaming kBeta in net/third_party/quic/core/congestion_control/cubic_bytes.cc to kDefaultCubicBackoffFactor to avoid the conflict and to give the variable a more descriptive name. Bug: 772146 Change-Id: Ibc2e6732d2c5fa70672a73e7b6669d8b71f581d1 Reviewed-on: https://chromium-review.googlesource.com/1119691Reviewed-by:
-
Colin Blundell authored
This CL adds APIs to IdentityManager for obtaining the set of all accounts with refresh tokens and querying whether the primary account is available with a refresh token. The design follows that of IdentityManager's caching of the primary account information: - IdentityManager initializes its state with the current state of ProfileOAuth2TokenService. - IdentityManager updates this state in response to notifications from PO2TS that an account's refresh token was updated/removed. TBR=bsazonov@chromium.org Bug: 806774 Change-Id: Idc4a37a15ced2e7d32f012a50e4e0d1fdb1aecdf Reviewed-on: https://chromium-review.googlesource.com/1098668 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#571451}
-
Oscar Johansson authored
The macro RETURN_STRING_LITERAL is defined in namespaces in: net/third_party/quic/core/crypto/crypto_utils.cc net/third_party/quic/core/quic_error_codes.cc net/third_party/quic/core/quic_utils.cc net/third_party/quic/core/quic_versions.cc When building using jumbo these end up in the same namspace and conflict. This commit solves the issue by undefining the macro inside the namespace. Bug: 772146 Change-Id: Ibb07acd829f8ad2867748d1db8aba5aa59a39e47 Reviewed-on: https://chromium-review.googlesource.com/1118222Reviewed-by:
-
chrome://policyA Olsen authored
cloud_policy_generated.cc parses JSON for certain policies in a function called DecodeJSON - however, if the JSON is invalid, it simply drops the invalid policy with no visible warning. This CL wires errors through by adding an error field to PolicyMap. The different possible designs are compared internally at go/decodejsonfix Bug: 853719 Change-Id: I98979183ac54278710f1ac57e5a48f2a9eee0b59 Reviewed-on: https://chromium-review.googlesource.com/1104354Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#571449}
-
Tanja Gornak authored
FCMSyncInvalidationListener aims to substitude SyncInvalidationListener for the Tango->FCM migration. Bug: 801985 Change-Id: Ib2907b8d5431e4730e42947744c84036050cd253 Reviewed-on: https://chromium-review.googlesource.com/1111714 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#571448}
-
Yuichiro Hanada authored
zcr_input_method_surface_v1 is an interface implemented by wl_surface that hosts IME windows. Bug: 845079 Change-Id: I3c2ef1927781afd4c6d6532135430b1bbda39311 Reviewed-on: https://chromium-review.googlesource.com/1118403 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571447}
-
Henrik Grunell authored
TBR=reveman@chromium.org Bug: 859020 Change-Id: I0fa9cfa276acf2f39e3e635cf5d0023a6b4986a2 Reviewed-on: https://chromium-review.googlesource.com/1120172Reviewed-by:
-
stkhapugin@chromium.org authored
iPad multitasking UI should match iPhone or normal iPad depending on size class: * in RxR size class, it should show the suggestion icons and align to the icon in the omnibox * in other size classes, it should be left-aligned and have no suggestion icons However, pre-UI Refresh UI should remain the same. Bug: 821817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibeed9ecf4f4b1058e80e7e4d45523b1d1f0d4ee8 Reviewed-on: https://chromium-review.googlesource.com/1118225 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#571445}
-
Nico Weber authored
Ran `tools/clang/scripts/upload_revision.py 335864`. Contains two notable changes: - lld now increases section layout to 16 bytes for sections that are CFG targets, which makes CFG more precise on x86 and works around a crash bug in Microsoft's x86 emulator on arm. - Wconstant-logical-operand now fires more often and finds more bugs. We fixed all new instances of this warning on all bots we know about. Bug: 857012,857393 Change-Id: I9396f5bae9750a1abcb9f0b256e9caed7b6ccc71 Reviewed-on: https://chromium-review.googlesource.com/1118531Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#571444}
-
