- 23 Jun, 2018 40 commits
-
-
Evan Stade authored
Update the last few tests that used it to pass the browser context around in other ways. TBR=sky@chromium.org Bug: 826374 Change-Id: Ic6de0e33b8ccc20ab84a0dcf8309cc103595f5f5 Reviewed-on: https://chromium-review.googlesource.com/1112666 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#569902}
-
Xianzhu Wang authored
Previously, to let the painting layer of a repeating table header/footer in paged media initiate multi-fragment painting, we created fragments in the painting layer. This caused several problems: - The fragments didn't have proper fragment clips, causing non-fragmented contents to be painted multiple times. It's also not feasible to create fragment clips for the forced fragments on the painting layer because we couldn't insert them into the clip tree. - The previous "if (paint_info.FragmentToPaint(layout_table_section_)) return;" in TableSectionPainter caused nested repeating header/footer not repeated. Now don't fragment painting layer of repeating table header/footer in paged media. Instead, let the repeating table header/footer repeat by itself when needed. Bug: 852773 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1172a334b5021eb7e987404bb72d9b841a4d39d4 Reviewed-on: https://chromium-review.googlesource.com/1112578 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569901}
-
Reilly Grant authored
The requestDevice() IPCs can race with navigation. This change ensures that choosers are closed on navigation and adds browser tests to exercise this for Web Bluetooth and WebUSB. Bug: 723503 Change-Id: I66760161220e17bd2be9309cca228d161fe76e9c Reviewed-on: https://chromium-review.googlesource.com/1099961 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569900}
-
Jacob Dufault authored
It is possible for the PIN to timeout while on the lock screen. Bug: 855629 Change-Id: Ib23cebdec84bb4713b7fcb78c2f72d6877d6d859 Reviewed-on: https://chromium-review.googlesource.com/1112207 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#569899}
-
Mounir Lamouri authored
Bug: 855883 Change-Id: I383e660319c86bf64872d2183cb36998cabbffe8 TBR: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1112945Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#569898}
-
Xianzhu Wang authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3524d99338e48de260f1ff7acf7fa2cda537ed10 Reviewed-on: https://chromium-review.googlesource.com/1112313 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569897}
-
Steve Kobes authored
The first is redundant with PLSA::ScrollsOverflow; the other is unused. Also remove LFV::GetScrollingReasons, which was used in a confusing way by MainThreadScrollingReasonsPerFrame. Bug: 823365 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iff0e8dae4bf80979868f5718427856d2efff7575 Reviewed-on: https://chromium-review.googlesource.com/1112066Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/73be50da2a1f..c2cc67b5c3a7 git log 73be50da2a1f..c2cc67b5c3a7 --date=short --no-merges --format='%ad %ae %s' 2018-06-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@c2cc67b5c3a7 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I5d565acb96cbd8973ab678db7252f417908520b9 Reviewed-on: https://chromium-review.googlesource.com/1112821Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569895}
-
sczs authored
- Checks the IndexPath instead of the Cell on canEditRow, the previous method was causing new cells not to be on edit Mode when the table did was on edit Mode. - Moves back the editingCell setup to cellForRowAtIndexPath (like legacy) since it was crashing on willDisplayCell. - Creates a test to check the previous case. Bug: 854185 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic4f7b27a6a48d48d26a68b9297a4b17e535a542f Reviewed-on: https://chromium-review.googlesource.com/1112675Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#569894}
-
Mitsuru Oshima authored
BUG=788782 TEST=manully tested with gtk3-demo Change-Id: I4a381b9350675d4e5407b378fbe07ae9de64fe8a Reviewed-on: https://chromium-review.googlesource.com/1108558 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569893}
-
Morten Stenshorne authored
-webkit-margin-collapse is a shorthand for -webkit-margin-before-collapse and -webkit-margin-after-collapse (and there's also -webkit-margin-top-collapse and -webkit-margin-bottom-collapse that will only work in horizontal writing modes). These are all about controlling whether we should collapse block-direction margins (default), separate them, or discard them completely. If we separate margins, we'll separate (otherwise) adjoining margins before the margin from the margin in question, AND separate the margin in question from (otherwise) adjoining margins after it. If we discard a margin, we'll discard all (otherwise) adjoining margins, both before and after the margin in question. There's no spec. This is based on the behavior in legacy Blink / WebKit. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I91c869013d11a0ce9327908ce724d518a19209e8 Reviewed-on: https://chromium-review.googlesource.com/1111117 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#569892}
-
Ned Nguyen authored
NOTRY=true NOTREECHECKS=true TBR=thakis@chromium.org Bug: 855689 Change-Id: Ie4c77e59bd642d581a73954723470d5920ae8865 Reviewed-on: https://chromium-review.googlesource.com/1112946 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#569891}
-
Ned Nguyen authored
This reverts commit 3161a1df. Reason for revert: the roll wasn't causing the test failure. THe test is also disabled in https://chromium-review.googlesource.com/c/chromium/src/+/1112946 Original change's description: > Revert "Roll src/third_party/catapult 34451063bc29..2e625dcb82db (1 commits)" > > This reverts commit bca5514b. > > Reason for revert: TestShardingMapGenerator.testGeneratePerfSharding > fails on many mac bots, e.g. here: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/33316 > > Error: > [18/22] core.sharding_map_generator_unittest.TestShardingMapGenerator.testGeneratePerfSharding queued/b/s/w/ir/.swarming_module_cache/vpython/fe1f6b/bin/python: can't open file 'tools/perf/generate_perf_sharding': [Errno 2] No such file or directory > > File is probably missing from isolate and needs to be in some gn data list. > > Original change's description: > > Roll src/third_party/catapult 34451063bc29..2e625dcb82db (1 commits) > > > > https://chromium.googlesource.com/catapult.git/+log/34451063bc29..2e625dcb82db > > > > > > git log 34451063bc29..2e625dcb82db --date=short --no-merges --format='%ad %ae %s' > > 2018-06-23 nednguyen@google.com Disable MEMORY_AMOUNTS diagnostic > > > > > > Created with: > > gclient setdep -r src/third_party/catapult@2e625dcb82db > > > > The AutoRoll server is located here: https://catapult-roll.skia.org > > > > Documentation for the AutoRoller is here: > > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > > > If the roll is causing failures, please contact the current sheriff, who should > > be CC'd on the roll, and stop the roller if necessary. > > > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > > > BUG=chromium:854676 > > TBR=sullivan@chromium.org > > NOTREECHECKS=true > > > > Change-Id: If0ebad6d392890f8aaf4b2336dad28367d83973d > > Reviewed-on: https://chromium-review.googlesource.com/1112138 > > Commit-Queue: Ned Nguyen <nednguyen@google.com> > > Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/master@{#569878} > > TBR=sullivan@chromium.org,nednguyen@google.com,catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com > > Change-Id: I6e51636a5151616cc5ade6f3ddd4a556d05303fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:854676 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/1112978 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569880} TBR=thakis@chromium.org,sullivan@chromium.org,nednguyen@google.com,catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Change-Id: I64954dacf7cc9ef68610f479f34ca9bf5eec7189 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:854676 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1112919Reviewed-by:
-
Xiaohan Wang authored
Also parse supported CdmProxy::Protocol from CDM manifest. For CDMs supporting hardware secure decryption, the supported CdmProxy protocol should be specified in CDM manifest, e.g. for kIntel protocol: "x-cdm-supported-cdm-proxy-protocols": ["intel"], In the next CL, we'll check whether the supported CdmProxy protocol is also supported by the system. Bug: 848532 Test: Updated unit tests. Change-Id: I59567943620e672d72f72fdadd80cb3ce6c5bcfd Reviewed-on: https://chromium-review.googlesource.com/1111109 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#569889}
-
Farah Charab authored
Use PageSchedulerImpl::IsBackgrounded. Move IsLoading from main thread scheduler to page scheduler. Change-Id: I2a7154aad19ed97ee87e44dddf655922af23fccd Reviewed-on: https://chromium-review.googlesource.com/1111842 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#569888}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bca5514b. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20063 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rob.buis@samsung.com: external/wpt/quirks TBR=robertma No-Export: true Change-Id: I1283cf13a2bc2b2ce90b49848a1cbc7c947a9eb9 Reviewed-on: https://chromium-review.googlesource.com/1112941 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#569887}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6ec076ceabc3..1deead13f98b git log 6ec076ceabc3..1deead13f98b --date=short --no-merges --format='%ad %ae %s' 2018-06-23 jclinton@chromium.org lib/git.py: Support bare repos in DeleteStaleLocks Created with: gclient setdep -r src/third_party/chromite@1deead13f98b The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:842018 TBR=chrome-os-gardeners@chromium.org Change-Id: Ic551e41c07f15ad9a8973763dc131a400a2f8642 Reviewed-on: https://chromium-review.googlesource.com/1112232Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569886}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/08d753e88484..d91a468aa50d git log 08d753e88484..d91a468aa50d --date=short --no-merges --format='%ad %ae %s' 2018-06-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d91a468aa50d The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id4898a5e21727a24d19bdea84821f32d5db38fa6 Reviewed-on: https://chromium-review.googlesource.com/1112233Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569885}
-
Sergey Ulanov authored
When creating a window using Scenic Ozone platform it's necessary to supply ViewOwner request, which the caller can use to attach the view to a parent. This CL updates content_shell to pass view_owner_request to the main window and then presents that view full-screen using Presenter API. Bug: 796979 Change-Id: I4732201359902ce99bda2f517dda790155d06270 Reviewed-on: https://chromium-review.googlesource.com/1107212 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569884}
-
Zhongyi Shi authored
Bug: 843299 Change-Id: I53dc2d1dec079f099cc7a68376f494d9a12b4df1 Reviewed-on: https://chromium-review.googlesource.com/1112654 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569883}
-
Nico Weber authored
This reverts commit 86a87223. Reason for revert: ash_unittests LoginAuthUserViewUnittest.PasswordClearedAfterAnimationIfPasswordDisabled has been failing on linux-chromeos-dbg since this landed in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6443 Original change's description: > cros: Views login/lock clear password when switching active auth user. > > Bug: 855725 > Change-Id: I91f6bab46701c9d66bc8b497661c460a7968619f > Reviewed-on: https://chromium-review.googlesource.com/1112075 > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569802} TBR=jdufault@chromium.org,xiaoyinh@chromium.org Change-Id: I7a54ed3ba91ea6a9adb46f83852488ed1c76178c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855725 Reviewed-on: https://chromium-review.googlesource.com/1112980Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569882}
-
Nico Weber authored
This reverts commit 7df8da93. Reason for revert: Doesn't build on iOS bots: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8942978656263239232%2F%2B%2Fsteps%2Fcompile%2F0%2Fstdout ../../components/autofill/core/browser/form_structure.cc:1320:60: error: comparison of unsigned expression >= 0 is always true [-Werror,-Wtautological-compare] for (auto current_index = field_index - 1; current_index >= 0; ~~~~~~~~~~~~~ ^ ~ I filed https://bugs.chromium.org/p/chromium/issues/detail?id=855881 for figuring out why the regular bots didn't catch this. Original change's description: > [Autofill] Country/State rationalization. > > Sometimes, server misidentifies countries and states, > and we can handle it with rationalization. > This usually happens when the form/field signature of > the two are identical. See go/rationalize-repeated-fields. > > Tests + Refactoring. > > Fixes: www.coolstuffinc.com > Bug: 850220 > Change-Id: I85f601cd37f6c24b51423c8d3ccee0fc117f4f12 > Reviewed-on: https://chromium-review.googlesource.com/1099559 > Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569814} TBR=sebsg@chromium.org,parastoog@google.com Change-Id: If9433043e5fc735988bfa34c556267d36398b080 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850220 Reviewed-on: https://chromium-review.googlesource.com/1112979Reviewed-by:
-
Nico Weber authored
This reverts commit bca5514b. Reason for revert: TestShardingMapGenerator.testGeneratePerfSharding fails on many mac bots, e.g. here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/33316 Error: [18/22] core.sharding_map_generator_unittest.TestShardingMapGenerator.testGeneratePerfSharding queued/b/s/w/ir/.swarming_module_cache/vpython/fe1f6b/bin/python: can't open file 'tools/perf/generate_perf_sharding': [Errno 2] No such file or directory File is probably missing from isolate and needs to be in some gn data list. Original change's description: > Roll src/third_party/catapult 34451063bc29..2e625dcb82db (1 commits) > > https://chromium.googlesource.com/catapult.git/+log/34451063bc29..2e625dcb82db > > > git log 34451063bc29..2e625dcb82db --date=short --no-merges --format='%ad %ae %s' > 2018-06-23 nednguyen@google.com Disable MEMORY_AMOUNTS diagnostic > > > Created with: > gclient setdep -r src/third_party/catapult@2e625dcb82db > > The AutoRoll server is located here: https://catapult-roll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > BUG=chromium:854676 > TBR=sullivan@chromium.org > NOTREECHECKS=true > > Change-Id: If0ebad6d392890f8aaf4b2336dad28367d83973d > Reviewed-on: https://chromium-review.googlesource.com/1112138 > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#569878} TBR=sullivan@chromium.org,nednguyen@google.com,catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Change-Id: I6e51636a5151616cc5ade6f3ddd4a556d05303fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:854676 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1112978Reviewed-by:
-
Nico Weber authored
This reverts commit 39c14237. Reason for revert: Broke many tests on many bots, eg. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/1473 Original change's description: > All callbacks to notify when InProgressDownloadManager is initialized > > Currently DownloadManagerImpl intializes InProgressDownloadManager. > However, when only ServiceManager is running, DownloadManagerImpl will > not be created. > As a result, some other class will initialize InProgressDownloadManager. > And when chrome fully starts, DownloadManagerImpl needs to know whether > InProgressManager has been initialized. > This CL allows InProgressDownloadManager to take more callbacks to > notify when initialized. > So multiple classes can observe the initialization event. > > BUG=842245 > > Change-Id: I5881b10db0f93f98262ab1baebc67621c2743fbe > Reviewed-on: https://chromium-review.googlesource.com/1111027 > Commit-Queue: Min Qin <qinmin@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569849} TBR=dtrainor@chromium.org,qinmin@chromium.org Change-Id: Ic2e8b09dc8aca3680c7a5939fdfb545e0dfec82a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842245 Reviewed-on: https://chromium-review.googlesource.com/1112977Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/34451063bc29..2e625dcb82db git log 34451063bc29..2e625dcb82db --date=short --no-merges --format='%ad %ae %s' 2018-06-23 nednguyen@google.com Disable MEMORY_AMOUNTS diagnostic Created with: gclient setdep -r src/third_party/catapult@2e625dcb82db The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:854676 TBR=sullivan@chromium.org NOTREECHECKS=true Change-Id: If0ebad6d392890f8aaf4b2336dad28367d83973d Reviewed-on: https://chromium-review.googlesource.com/1112138 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569878}
-
Nico Weber authored
Bug: 855573 Change-Id: If84f612e1500d9189f2206a4ff106fccfdc308d5 Reviewed-on: https://chromium-review.googlesource.com/1112468Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569877}
-
jonross authored
Bug: 855585 Change-Id: Id4bc8041f88a788aeafa6946d4bb1b0633e1e90b Reviewed-on: https://chromium-review.googlesource.com/1112560 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#569876}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ifd517d8e010d9dc7acc4c3d82423ef74a36e8b48 Reviewed-on: https://chromium-review.googlesource.com/1112809Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569875}
-
David Reveman authored
Add oshima@ and dcastagna@ as owners in components/exo. Test: Change-Id: I9295e888a216d52237663330abae3acf0ec60373 Reviewed-on: https://chromium-review.googlesource.com/1112297Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569874}
-
Geoff Lang authored
This will change the optional GPU testers to always test what we're shipping. Change webgl2_conformance_d3d11_passthrough_tests to webgl2_conformance_d3d11_validating_tests now that the passthrough command decoder is used in webgl2_conformance_tests on Windows. BUG=828135 BUG=602688 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I600b53722d797693fd205166afcc4cefc2a4f242 Reviewed-on: https://chromium-review.googlesource.com/1107846 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Nikunj Bhagat authored
Add IsForCreditCard to Suggestion filled to correctly distinguish Profile Records and Creditcard Records Bug: 853993 Change-Id: I17d0ab8057f8a36a130d3ed2f4bb7d70883db9ce Reviewed-on: https://chromium-review.googlesource.com/1105494Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569872}
-
Jun Choi authored
In order to implement virtual CTAP2 security key, we need to be able to parse and validate serialized MakeCredential request bytes that the client sends to the device. Add the corresponding parsing/validation logic. Bug: 829413 Change-Id: Ibbb2800a444d844b01ce7a35eba50a4541b0da02 Reviewed-on: https://chromium-review.googlesource.com/1104956 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#569871}
-
Bret Sepulveda authored
This reverts commit c5604690. Reason for revert: Causes BrowserViewTest suite to fail under Refresh on Linux. See crbug.com/855797 Original change's description: > Show promo account icon in toolbar when user is signed out > > When the user is signed out of Chrome and the profile icon > has not been explicitly changed, AvatarToolbarButton now > uses the account icon of the first sync promo account. > > Screenshots: > https://drive.google.com/file/d/1a7kr12KtA11Wt7MQ9MLnSf-M3D9nlLdg/view?usp=sharing > https://drive.google.com/file/d/1nKLnoD1sbcZOvwGQY3YtHVTUv32DQNFn/view?usp=sharing > > Bug: 853363 > Change-Id: I11ed80e2250bc4eb9202e4a1c4cabf242954f726 > Reviewed-on: https://chromium-review.googlesource.com/1105772 > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569213} TBR=droger@chromium.org,tapted@chromium.org,tangltom@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 853363 Change-Id: Ib8d9a5350277146050677a2676577d29b315efda Reviewed-on: https://chromium-review.googlesource.com/1112599Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#569870}
-
Johann authored
Update to the finalized version of the AV1 bitstream. https://aomedia.googlesource.com/aom.git/+log/c5a56b99df86..63256264a978 $ git log c5a56b99d..63256264a --date=short --no-merges --format='%ad %ae %s' 2018-06-22 yaowu Replace "<< 1" with "* 2" 2018-06-22 tdaede Don't write timing or display model for still pictures. 2018-06-22 ravi.chaudhary Fix highbd warp intrinsic module 2018-06-19 tdaede [NORMATIVE] Update decoder_peek_si_internal to match RAP spec. 2018-06-21 debargha [NORMATIVE] Fix dr preds when upsampling is enabled 2018-06-20 huisu Reset seen_frame_header before decoding a frame 2018-06-21 debargha [NORMATIVE] Rem rest. for show_exisitng_frames 2018-06-21 zoeliu Remove duplicate assert statement 2018-06-20 anorkin [NORMATIVE] Update of decoder model syntax 2018-06-20 rathaval common: convolve: Use memcpy in av1_convolve_2d_copy_sr_c 2018-06-20 ravi.chaudhary Fixed issue in AV1MultiThreaded/TestVectorTest 2018-05-24 yuec Add wavelet energy based q modulation 2018-06-20 angiebird Turn off inter_mode_data_push on multi-tile mode 2018-06-20 david.barker [NORMATIVE] Fix random-access decoding 2018-06-21 johannkoenig Revert "Fix bug in round shift array unit test" 2018-06-20 angiebird Implement handle_intra_mode 2018-06-19 angiebird Move skip_repeated_mv into order indep skip func 2018-06-19 angiebird Move ref_frame_skip_mask out of search_state 2018-06-19 angiebird Move mode_skip_mask out of search_state 2018-06-21 sachin.kumargarg Add ARM Neon optimization of compound_diffwtd_mask_d16 (...) Created with: roll-dep src/third_party/libaom/source/libaom BUG=chromium:783519 Change-Id: I2532d7bf4684c19dea2b9606f6ed6d60bf0165f2 Reviewed-on: https://chromium-review.googlesource.com/1112501Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#569869}
-
Xi Cheng authored
Bug: 851163 Change-Id: Ia6fa3551e22b37784b63d5450c1755dd918d6a35 Reviewed-on: https://chromium-review.googlesource.com/1112739Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#569868}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0f6e609b..dff3cfd6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib0cecc94c20f651aed84a33abbb1dac315f583e1 Reviewed-on: https://chromium-review.googlesource.com/1112642Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569867}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fa74d9840634..34451063bc29 git log fa74d9840634..34451063bc29 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 sbalana@google.com Add idb to third_party. Created with: gclient setdep -r src/third_party/catapult@34451063bc29 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:855252 TBR=sullivan@chromium.org Change-Id: I2f265280fdc9d9b62b7621d3b5be5276f9266ec2 Reviewed-on: https://chromium-review.googlesource.com/1112224Reviewed-by:
-
Kyle Milka authored
Remove the overlay element, and instead make the menu itself a dialog. This results in the picker being centered properly. Bug: 855198 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic77afee81667d9267a87362a80debfa2724bc05e Reviewed-on: https://chromium-review.googlesource.com/1112063Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569865}
-
Adrienne Walker authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I70ee24b28189726254ea22798054d48d5b8a2706 Reviewed-on: https://chromium-review.googlesource.com/1112722 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#569864}
-
Xing Liu authored
This reverts commit 8d5afbb1. Reason for revert: We found other issues related to this CL, also this may introduce some flaky test, see crbug/855167, crbug/855168. Original change's description: > Download location: fix ANR issue. > > Currently we access disks on Android main thread to pull download > directories, which can cause Android to skip over 100 frames during > rendering, or even totally bust the rendering and show a black screen. > When try to build download location UI, it may stuck a few seconds(ANR). > > This CL moves all disk access operation to background thread, so UI > will be fast and smooth. > > Bug: 844107 > Change-Id: Icba6db01a4a638cdc62b2e1d207e73981af15dca > Reviewed-on: https://chromium-review.googlesource.com/1107041 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569129} TBR=dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 844107 Change-Id: I131166661ca57ee2b07d7c27c5f0df17813dc0dc Reviewed-on: https://chromium-review.googlesource.com/1112777Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569863}
-
