Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 17 Jul, 2017 8 commits
    • Timothy Loh's avatar
      Scope PermissionPrompt lifetime to UI visibility · 0a992857
      Timothy Loh authored 
      This patch make the lifetime of PermissionPrompt objects more sensible
and match what we occasionally think it actually is. Currently these
objects exist when a tab is active, or on Android all the time. This
patch changes it so that, as the name might suggest, it corresponds to
when a prompt is actually visible. We retain the distinction between
desktop/Android where desktop hides the UI (now deletes the object) on
tab switching, while Android retains the UI (keeps the object alive)
as the InfoBar system manages hiding the prompt.

Since we don't explicitly manage lifetimes of the actual UI surface on
Android (infobars in particular, as it's clearer for modals when the UI
is actually destroyed) from the PermissionPrompt, we change the pointer
to a WeakPtr for safety. When the PermissionPrompt is destroyed due to
navigation, if an infobar happens to still persist due to a bug it
won't be able to be resolve different permission requests.

Bug: 606138, 737102
Change-Id: I26a8843b9b446e91282a9b0ce67c4b442bf440e9
Reviewed-on: https://chromium-review.googlesource.com/567940
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: default avatarRaymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487029}
      0a992857
    • Tim Sergeant's avatar
      MD Bookmarks: Replace folder iron-icons with divs with an SVG background · c53fb608
      Tim Sergeant authored 
      MD Bookmarks stamps a large amount of the same folder icon: 1 for every
node in the sidebar, and 1 for every item in the list. While iron-icon
is fast as far as Polymer elements go, stamping 50+ of them is still
expensive.

This CL switches all folder icons across the page to a plain divs that
have an SVG background. This appears to save at least 5% of page load
time on profiles with a large number of folders.

Bug: 727177
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I439f83ad3c3f645108d1a3d744cce2e402acbcee
Reviewed-on: https://chromium-review.googlesource.com/566264Reviewed-by: default avatarcalamity <calamity@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487028}
      c53fb608
    • v8-autoroll's avatar
      Update V8 to version 6.1.497. · 2d24b9cf
      v8-autoroll authored 
      Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/248b789e..4b582195

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I2209f6d52c351284ddb1480e160c18b74f9ae9e9
Reviewed-on: https://chromium-review.googlesource.com/573600Reviewed-by: default avatarv8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487027}
      2d24b9cf
    • Noel Gordon's avatar
      Skia color space fuzzer: mix input and output color transform formats · f9e2b22c
      Noel Gordon authored 
      The fuzzer color transform had the same input and output pixel color
format in each run. In this change, create a mix of input and output
color formats to add extra fuzz.

Tbr: mmoroz@chromium.org
Bug: 708016
Change-Id: I520eafad1959ae2d8688b156e24006718aaf4b0c
Reviewed-on: https://chromium-review.googlesource.com/572890Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487026}
      f9e2b22c
    • Antonio Gomes's avatar
      Add entries for content editable and date/time field in Mojo's text input state · 1bd7abc4
      Antonio Gomes authored 
      Both chrome --mash and chrome --mus --use-ime-service use
InputMethodMus for IME. In such cases, pages with 'content editable'
elements simply hang with the following error and stack trace:

  [ERROR:validation_errors.cc(90)] Invalid message: VALIDATION_ERROR_UNKNOWN_ENUM_VALUE

  #1 0x56228f4e5a9e mojo::internal::ReportValidationError()
  #2 0x56228c7ee648 mojo::internal::TextInputState_Data::Validate()
  #3 0x56228c7e2da9 ui::mojom::internal::WindowTree_SetImeVisibility_Params_Data::Validate()
  #4 0x56228c9dfbe2 ui::mojom::WindowTreeRequestValidator::Accept()
  #5 0x56228f4d423c mojo::FilterChain::Accept()
  #6 0x56228f4d5755 mojo::InterfaceEndpointClient::HandleIncomingMessage()
  #7 0x56228f4dc84c mojo::internal::MultiplexRouter::ProcessIncomingMessage()
  #8 0x56228f4dc03f mojo::internal::MultiplexRouter::Accept()
  #9 0x56228f4d4256 mojo::FilterChain::Accept()
  (...)

This happens because in InputMethodMus::UpdateTextInputType,
ui::TextInputType::TEXT_INPUT_TYPE_CONTENT_EDITABLE is the value
(correctly) used to construct the mojo::TextInputState instance
to be sent to Mus.
Down the road, WindowTreeClient::SetImeVisibility calls out to Mus
passing the mojo::TextInputState instance created previously.

At the mojo validation step, it fails (see stack above) because
text_input_state.mojom does not declare CONTENT_EDITABLE
(see IsKnownValue impl in <out>/gen/ui/platform_window/mojo/text_input_state.mojom-shared-internal.h).

Patch fixes this by syncing up ui::TextInputType, blink::WebTextInputType
and mojo::TextInputType.

PS: For the sake of completeness, DATE_TIME_FIELD enum item was added,
    and mojo::TextInputType::LAST is renamed to ::MAX in order to be able to
    compile assert it against ui::TEXT_INPUT_TYPE_MAX.

TEST=load any page with 'contenteditable' attr, in chrome --mash.

BUG=718105,742491

Change-Id: Icbea847e7fc655ca3c04243fefb8d67abaaa9239
Reviewed-on: https://chromium-review.googlesource.com/570056
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: default avatarTom Sepez <tsepez@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487025}
      1bd7abc4
    • Sam McNally's avatar
      Mojo: restrict user-provided task runners to SingleThreadTaskRunners. · d482b4bc
      Sam McNally authored 
      Allowing user-provided SequencedTaskRunners does not provide a clear
benefit if they run on the same sequence and binding to a task runner
that is not sequenced with the current task runner is not threadsafe so
restrict user-provided task runners to SingleThreadTaskRunners that run
on the current thread.

Bug: 678155
Change-Id: I5472e39f688f47a8abdda516a6e2902fe18eee36
Reviewed-on: https://chromium-review.googlesource.com/544717
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Reviewed-by: default avatarWu-Cheng Li <wuchengli@chromium.org>
Reviewed-by: default avatarFlorin Malita <fmalita@chromium.org>
Reviewed-by: default avatarYuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487024}
      d482b4bc
    • Nico Weber's avatar
      mac: Use @available instead of -Wunguarded-availability suppression where possible. · 6ae692d7
      Nico Weber authored 
      This works despite https://llvm.org/PR33796 here because these
functions are in an unnamed namespace.

Bug: 735328
Change-Id: Ia22c05303a0360573aa1a0385c6a3966767f84cd
Reviewed-on: https://chromium-review.googlesource.com/573113Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487023}
      6ae692d7
    • Miguel Casas-Sanchez's avatar
      VEA mojification: service-side implementation w/ unittest · 414c18ea
      Miguel Casas-Sanchez authored 
      This CL lands the service-side implementation of the mojom::VEA
and unit tests for it. It doesn't connect it yet, but the 
final result can be found in https://crrev.com/c/558846.

Bug: 736517
Change-Id: I6d77da653cfa8e4db9b2691707302fa2ad2d4479
Reviewed-on: https://chromium-review.googlesource.com/566262
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: default avatarDan Sanders <sandersd@chromium.org>
Reviewed-by: default avatarEmircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487022}
      414c18ea
  3. 16 Jul, 2017 20 commits
  5. 15 Jul, 2017 12 commits