- 08 May, 2013 1 commit
-
-
scottmg@chromium.org authored
Currently contains chrome_browser_dll target. Removes some paths from browser->webcore via content that are there due to single process mode, and removes dependency of content on content_renderer. Current remaining paths from chrome_browser_dll to webcore: http://i.imgur.com/7WWRvpA.jpg R=cpu@chromium.org BUG=237249 Review URL: https://chromiumcodereview.appspot.com/14682014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198834 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 May, 2013 39 commits
-
-
mukai@chromium.org authored
This is a bit tricky scenario, but the current code may lead to a mismatch of increment/decrement by calling Close(). See the bug for how the mismatch happens. BUG=238477 Review URL: https://chromiumcodereview.appspot.com/14820016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198829 0039d316-1c4b-4281-b951-d872f2087c98
-
binji@chromium.org authored
* Remove duplicated comments. * Rename main .cc/.c file to the name of the example. * Remove _module.cc files BUG=none R=noelallen@chromium.org Review URL: https://codereview.chromium.org/14607005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198828 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
BUG=237354 Review URL: https://chromiumcodereview.appspot.com/14670013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198827 0039d316-1c4b-4281-b951-d872f2087c98
-
vmpstr@chromium.org authored
This moves a clear per picture into a clear-to-background color per picture pile. We need this to ensure that a solid color page in low res is considered solid, since all the draws are of the same color. BUG=233622 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198272 " TBR=reveman Review URL: https://chromiumcodereview.appspot.com/14322017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198826 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
Updates an existing suppression (filed for bug 222876) to reflect new function signature. (Part of PKS using BrowserContext now) NOTRY=true TBR=thestig@chromium.org,phajdan@chromium.org BUG=222876 Review URL: https://chromiumcodereview.appspot.com/14823006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198825 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198824 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
The current code seems to generate '/\foo' for a given path '\foo' BUG=238212 TEST=FileSystemUtilTest.GetNormalizedFilePath TBR=grv@chromium.org Review URL: https://codereview.chromium.org/14588006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198822 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
R=samarth@chromium.org TBR=samarth@chromium.org BUG=238863 Review URL: https://codereview.chromium.org/14819011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198821 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked. BUG=175002 R=rvargas@chromium.org Review URL: https://codereview.chromium.org/13165005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198820 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198819 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@chromium.org authored
BUG= TEST=tree Review URL: https://codereview.chromium.org/14722016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198818 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/15004009/danakj@chromium.org authored
TBR=jamesr, piman BUG=179896 Review URL: https://codereview.chromium.org/15043004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198817 0039d316-1c4b-4281-b951-d872f2087c98
-
benwells@chromium.org authored
The documentation was out of date, as there is now no way to have default versus specific bounds. Instead all supplied bounds are default. BUG=230606 Review URL: https://chromiumcodereview.appspot.com/14037005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198815 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
R=rdsmith@chromium.org TBR=rdsmith@chromium.org BUG=238831 Review URL: https://codereview.chromium.org/14660016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198814 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
Allow "--top-symbols <n>" as an argument for "waterfall match". Will list the top <n> symbol occurrences in all unsuppressed reports. NOTRY=true R=thestig@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/15039007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198813 0039d316-1c4b-4281-b951-d872f2087c98
-
lambroslambrou@chromium.org authored
Previously, this test was based on whether the Me2Me host plugin was loaded. But if Native Messaging is supported, this NPAPI instance will not get loaded, so the Share button test should not depend on it. BUG=173509 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/15017006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198812 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
The synthesized mouse move events when a menu is closing could cause the selection to change, which would notify the RenderWidgetHostViewBase twice, triggering a DCHECK. BUG=118872,237819 Review URL: https://chromiumcodereview.appspot.com/14818007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198811 0039d316-1c4b-4281-b951-d872f2087c98
-
aruslan@chromium.org authored
BUG=238487 NOTRY=True Review URL: https://chromiumcodereview.appspot.com/14786021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198810 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
> Reland 198495 for Windows. > > > Build libpeerconnection as a loadable module for win, mac and linux by default. Also remove the allocator shim variable since it's no longer needed. > > > > This requires updating .isolate files for some try bots. > > In practice, I've only seen failures in interactive_ui_tests because of this change, but I'm being a bit proactive here and making sure that libpeerconnection.so exists with test hosts that have tests that depend on it. > > > > BUG=238207 > > R=csharp@chromium.org, ronghuawu@chromium.org > > > > Review URL: https://codereview.chromium.org/14907003 > > TBR=tommi@chromium.org > > Review URL: https://codereview.chromium.org/14767016 TBR=tommi@chromium.org Review URL: https://codereview.chromium.org/14615011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198809 0039d316-1c4b-4281-b951-d872f2087c98
-
binji@chromium.org authored
BUG=176596 R=noelallen@chromium.org Review URL: https://codereview.chromium.org/14779007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198808 0039d316-1c4b-4281-b951-d872f2087c98
-
karen@chromium.org authored
29 is the atomic number of copper. "$29.00" is a song on the album Blue Valentine by Tom Waits. 29 is a prime number. 29 is a Lucas Number. The Human skull is made-up of 29 bones. The alphabet of the Phoenicians had 29 cuneiform signs. The Turkish and Norwegian alphabets contain 29 letters. Saturn takes 29 years to orbit our Sun. In the United States of America, Interstate 29 is a freeway which runs from Missouri to North Dakota. Also in the USA there is a place in California called 29 Palms. The probability of being born on 29th February is 1 in 1,461. A polygon made up of 29 sides is called an icosikaienneagon, enneacosagon or a nonacosagon. R=laforge@chromium.org Review URL: https://codereview.chromium.org/15017011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198807 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
To allow generating a graph of linkage information that gyp-explain outputs. Output example: http://i.imgur.com/7WWRvpA.jpg R=thakis@chromium.org BUG=237249 Review URL: https://codereview.chromium.org/15026004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198806 0039d316-1c4b-4281-b951-d872f2087c98
-
dewittj@chromium.org authored
> Speed improvements to SubstringSetMatcher > > The main one is coputing the Aho-Corasick tree size in advance. > > Also contained are code clean-ups and minor optimisations, like removing HasEdge/GetEdge sequences, or adding const to aid compiler optimisations. > > This was tested on a benchmark adding 20k+ patterns. It showed a reduction of the running time by 30%. > > BUG=236368 > > Review URL: https://chromiumcodereview.appspot.com/14780003 TBR=vabr@chromium.org Review URL: https://codereview.chromium.org/15045002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198805 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
NOTRY=true TBR=thestig@chromium.org,phajdan@chromium.org BUG=238339 Review URL: https://chromiumcodereview.appspot.com/14800010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198804 0039d316-1c4b-4281-b951-d872f2087c98
-
vabr@chromium.org authored
The main one is coputing the Aho-Corasick tree size in advance. Also contained are code clean-ups and minor optimisations, like removing HasEdge/GetEdge sequences, or adding const to aid compiler optimisations. This was tested on a benchmark adding 20k+ patterns. It showed a reduction of the running time by 30%. BUG=236368 Review URL: https://chromiumcodereview.appspot.com/14780003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198803 0039d316-1c4b-4281-b951-d872f2087c98
-
petewil@chromium.org authored
Synced notifications tried to access a null pointer, make sure we don't crash when we do. Also add logging so we can determine how the code got into a bad state. BUG=235979 Review URL: https://chromiumcodereview.appspot.com/14862004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198801 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Linux: Change dump_app_syms script to pass -r to dump_syms. This option was added in Breakpad r1163. BUG=230995 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14188058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198800 0039d316-1c4b-4281-b951-d872f2087c98
-
mef@chromium.org authored
BUG=224248 TEST=net_unittests --gtest_filter=HostResolverImplTest.EmptyListMeansNameNotResolved NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14760008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198799 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
This handler tracks Shill's profiles. Currently only the ManagedNetworkConfigurationHandler is making use of this handler but it is also required for upcoming changes to proxy handling in ChromeOS. In the ONC validator only an LOG(ERROR) was fixed to LOG(WARNING) if the flag error_on_missing_field=false. BUG=157696 TEST=managed_network_configuration_handler_unittest.cc, networking_private_apitest.cc Review URL: https://chromiumcodereview.appspot.com/13957012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198798 0039d316-1c4b-4281-b951-d872f2087c98
-
justincohen@google.com authored
Support setting GYP_CROSSCOMPILE from gyp_env files. BUG=None Review URL: https://chromiumcodereview.appspot.com/14652028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198797 0039d316-1c4b-4281-b951-d872f2087c98
-
csharp@chromium.org authored
TBR=jstritar@chromium.org BUG=238805 Review URL: https://codereview.chromium.org/14687015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198796 0039d316-1c4b-4281-b951-d872f2087c98
-
aurimas@chromium.org authored
The text watcher was not being removed correctly when switching from one EditText to another in AutofillDialog editing layout. Incorrect editedOrActivatedField() calls were being sent out. BUG=237750 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14779006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198795 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/14691006phajdan.jr@chromium.org authored
TBR=rch BUG=96594 Review URL: https://codereview.chromium.org/15039011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198794 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
Implement header compression/decompression in ReliableQuicStream. Merge internal change: 44867738 QUIC: deflake proof_test. The current proof_test removes a byte from the start of the signature in order to make it invalid. However, the signature is a big-endian number and, ~1% of the time, the first byte will be zero - thus removing it doesn't change the number. This change adds a non-zero byte to the start of the signature instead. Merge internal change: 44803399 Replace calls to scoped_ptr(NULL) with calls to scoped_ptr(). Merge internal change: 44799980 Add a blank line in order to get the dependencies correct for rebuild. Merge internal change: 44796024 Fix "large integer implicitly truncated to unsigned type" Merge internal change: 44793986 QUIC: compress certificates. This change causes server certificates to be compressed using three tricks: 1) The client can advertise sets of common certificates that the server can then simply reference. This change contains "common certificate set 0", which is the set of the intermediates used twice or more in the Alexa top 5000. It's temporary because it's missing GIAG2 which we'll want to include soon. 2) The client can send 64-bit, FNV-1a hashes of certificates that it already has and the server can reference them by hash. 3) Otherwise, certifciates are gzip compressed with a dictionary that includes any certificates compressed using the previous two methods and a 1500 byte lump of common substrings. (Again, taken from the Alexa top 5000) POKE=1 Merge internal change: 44792710 R=mnaganov@chromium.org, rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198736 Review URL: https://codereview.chromium.org/14651009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198793 0039d316-1c4b-4281-b951-d872f2087c98 -
sky@chromium.org authored
> Disables ExtensionApiTest.CaptureVisibleNoFile on windows as it keeps > timing out. > > R=yoz@chromium.org > TBR=yoz@chromium.org > BUG=238775 > > Review URL: https://codereview.chromium.org/14917021 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/15039010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198792 0039d316-1c4b-4281-b951-d872f2087c98
-
binji@chromium.org authored
The dlopen example demonstrates opening a .so file that is not located in the manifest; for example, from a HTTP mount. The nacl_io code was broken as a result of a recent change to "fast path" nexe loading/validation in certain cases. This change attempts to mmap the nexe using PROT_EXEC, which we would ignore and happily write to a bad address. Now, we always fail PROT_EXEC requests, which should fallback gracefully to the old way. BUG=none R=sbc@chromium.org R=ncbray@chromium.org Review URL: https://codereview.chromium.org/14642024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198791 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
R=justinlin@chromium.org TBR=justinlin@chromium.org BUG=224249 Review URL: https://codereview.chromium.org/14863010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198790 0039d316-1c4b-4281-b951-d872f2087c98
-
zea@chromium.org authored
The typed URL sync datatype is being transitioned to the syncable service API, and this patch introduces the new interface the typed url sync code will use to communicate with sync as well as the HistoryBackend which implements the datatype. This patch implements logic for syncing typed url changes originating from the history backend to the sync server, through the syncable service API. Original patch by mgist1@chromium.org. Review at https://codereview.chromium.org/12703036/ BUG=77819 TBR=brettw@chromium.org, atwilson@chromium.org Review URL: https://codereview.chromium.org/14615010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198789 0039d316-1c4b-4281-b951-d872f2087c98
-
dsinclair@chromium.org authored
This CL allows the prefixing of category names with disabled- to have them not traced by default. Only if an explicit disabled-foo is provided in the category filter do we enable the category. Providing a disabled-foo in the category filter does not act like an include category in that all other includes have to be specified. The disables are treated as their own group. BUG=232109 Review URL: https://chromiumcodereview.appspot.com/14748003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198787 0039d316-1c4b-4281-b951-d872f2087c98
-