Commits · 0a9d81fd45782c4e818772cbf6915904f34f7622 · eriksson monteiro / tangled

25 Feb, 2020 40 commits

cocoa: mark active tab in Tab menu · 0a9d81fd

Elly Fong-Jones authored Feb 25, 2020

The active tab now gets a check mark, by analogy with the active window
in the Window menu.

Bug: 990838
Change-Id: I2589913a271eaffe0b03ff200d06cc14d7a958b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071045
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744293}

0a9d81fd

Roll src/third_party/skia c8d092a060ad..9f00494951f9 (1 commits) · 88a6bf51

chromium-autoroll authored Feb 25, 2020

https://skia.googlesource.com/skia.git/+log/c8d092a060ad..9f00494951f9

git log c8d092a060ad..9f00494951f9 --date=short --first-parent --format='%ad %ae %s'
2020-02-25 bsalomon@google.com Add test that SWPathRenderer GenIDChange listeners get removed.

Created with:
gclient setdep -r src/third_party/skia@9f00494951f9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jlavrova@google.com
Change-Id: I4ce96dcd2d3a35fb0db16867d607260d7e2fe126
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072315Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744292}

88a6bf51

win: Remove is_win_fastlink arg. · 108dc921

Nico Weber authored Feb 25, 2020

It only has an effect when not using clang and lld, and the default
build setup is to use clang and lld. Also, goma has dropped support
for non-clang compiles, and a main use case for is_win_fastlink
was being able to use goma. Finally, is_win_fastlink never worked
well.

Bug: 1053958
Change-Id: Ida8079da90157e3f02acf6b056fea3bef667f5bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071243
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744291}

108dc921

Roll src/third_party/angle aa09ca69e417..b185002d559b (4 commits) · 380f5b56

chromium-autoroll authored Feb 25, 2020

https://chromium.googlesource.com/angle/angle.git/+log/aa09ca69e417..b185002d559b

git log aa09ca69e417..b185002d559b --date=short --first-parent --format='%ad %ae %s'
2020-02-25 xinyi.he@arm.com Fix the condition of glOrtho{fx} validation
2020-02-25 pmberube@google.com Fix a GCC 10 build failure.
2020-02-25 b.schade@samsung.com Vulkan: prevent volk reloading on null instance and devices
2020-02-25 jmadill@chromium.org Trace/Replay: Add uniform locations map.

Created with:
gclient setdep -r src/third_party/angle@b185002d559b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: geofflang@google.com
Change-Id: I5bce1edb5cc56c063956de25d20a9670d2e2d60f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072313Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744290}

380f5b56

Use GURL for AutocompleteMatch::image_url · a4e7eb85

Michael Thiessen authored Feb 25, 2020

This is just cleanup/readability. No functional changes intended here.

Bug: 783819
Change-Id: I8f0d3a2f812398c3c2cd070aa8b8cc8f9716244d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070841
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744289}

a4e7eb85

OOBE - Improve reset screen confirmation dialog · 8411cc66

Renato Silva authored Feb 25, 2020

- Replace the dialog on the reset screen with the oobe-help-dialog
  that complies with UX specs and reuses available code.

- Refactor the confirmation dialog logic so that it lives in the
  main element 'oobe-reset'.

- Remove the intermediate oobe_reset_screen by using LoginScreenBehavior

- Add a waiter to test::OobeJS for waiting upon the presence of an
  attribute. Such as waiting on the 'open' attribute of dialogs.

- Add constants and modifications to the browser tests of the reset
  screen.

Fixed: 933310
Change-Id: I54001745326b60ab5a0a19519923c54dffa5baec
Bug: 933310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041474
Commit-Queue: Renato Silva <rrsilva@google.com>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Auto-Submit: Renato Silva <rrsilva@google.com>
Cr-Commit-Position: refs/heads/master@{#744288}

8411cc66

[Extensions] Change GetIndexedRulesetPath to return relative path. · 27cdb41a

Istiaque Ahmed authored Feb 25, 2020

This allows ContentVerifier::ShouldVerifyAnyPaths to compare
relative paths against indexed ruleset's relative path in future. This
will obviate the need to construct full path (which can be tricky some
times). Note that this will be done in a follow up.

Bug: 796395
Test: No behavior changes expected.
Change-Id: I05febe27eb52c2c823e6e609f1be6d9803b471bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071335Reviewed-by: Oleg Davydov <burunduk@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744287}

27cdb41a

Enforce bookmark GUID uniqueness as model invariant · e1634397

Mikel Astiz authored Feb 25, 2020

A bookmark's GUID must be unique and otherwise BookmarkModel's invariant
can be considered violated.

In this patch, the invariant is enforced via DCHECKs upon node creation,
which is sufficient because GUIDs are inmutable.

Change-Id: Ia3f48e98027ae9a8468bd0dc578843047af79712
Bug: 978430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031024
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744286}

e1634397

Fix memory leak in chrome.platformKeys · dd8d206c

Omar Morsi authored Feb 25, 2020

SECItem is used a lot for performing NSS operations and it was
documented that to free a SECItem structure, SECItem_FreeItem should be
used. SECItem was usedin platform keys for NSS operation without
SECItem_FreeItem. For more information, please refer to:
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/SSL_functions/ssltyp.html#1030620

This CL utilizes crypto::ScopedSECItem instead of SECItem.

Memory Leaks:

CheckSystemTokenAvailability/EnterprisePlatformKeysTest.Basic/0
Before this change: 10
After this change: 6

CheckSystemTokenAvailability/EnterprisePlatformKeysTest.Basic/1
Before this change: 8
After this change: 6

CheckSystemTokenAvailability/EnterprisePlatformKeysTest.Basic/2
Before this change: 8
After this hange: 6

CheckSystemTokenAvailability/EnterprisePlatformKeysTest.Basic/3
Before this change: 5
After this change: 3

Bug: chromium:1054911
Test: Manual and browser_tests --gtest_filter=*EnterprisePlatformKeysTest*
Change-Id: Ife95c0f84185d0bde9e9c564ba04c30da8aecab3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071017Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Omar Morsi <omorsi@google.com>
Cr-Commit-Position: refs/heads/master@{#744285}

dd8d206c

ui: Fix smoothness report when attaching to compositor late · adecd67f

Xiyuan Xia authored Feb 25, 2020

Smoothness is not calculated correctly when underlying Layer
is attached to a Compositor after the animation starts. One
such case is the "Show" animation of WindowCycleView. It is
always report as 100% incorrectly. Smoothness metric depends
on frame number from Compositor. |start_frame_number_| is
captured when the animation starts. However, if Layer is not
attached, the frame number could be be obtained and stays as 0.
As a result, smoothness is always reported as 100% when the
animation finishes.

Bug: 1053732
Change-Id: I60c750afaf5b4820ad17aebfa9809178399c50f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067674
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744284}

adecd67f

core: spruce up TakeNamedLock and friends · b401fd2a

Elly Fong-Jones authored Feb 25, 2020

TakeNamedLock has a "waiting" mode that works like this:

  for (int i = 0; i < 10; i++)
    if (TryLock())
      break;
    usleep(i * 100);

which means that in "waiting" mode, if the lock is unavailable
for the duration, this function will block the calling thread
(with the message loop not spinning) for up to 4.5 seconds. However,
there are two problems with this design:

* The caller has no way to know whether "waiting" is appropriate or not
* The caller has to handle failure to acquire the lock either way

If retries are needed to deal with external conditions changing that might
have freed the lock up (another process exiting, e.g.) those retries should
be done at higher levels with more context.

More concretely, the only actual production use of this function is in
CloudPrintServiceProcessMain:

    std::unique_ptr<ServiceProcessState> state(new ServiceProcessState);
    if (!state->Initialize())
      return 0;

This change has TakeNamedLock make a single non-blocking attempt to
take the lock, and moves the retry logic up into
CloudPrintServiceProcessMain.

Since I was here anyway, I converted the API to use unique_ptr, since it
returns ownership of the lock if it succeeds.

Bug: 1052430
Change-Id: Ib87b23cc821fe59e69b76ffb3875917027bfdc4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057530Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744283}

b401fd2a

Roll src/third_party/swiftshader e162b023f539..b1dd9acac569 (1 commits) · fa34f142

chromium-autoroll authored Feb 25, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/e162b023f539..b1dd9acac569

git log e162b023f539..b1dd9acac569 --date=short --first-parent --format='%ad %ae %s'
2020-02-25 swiftshader.regress@gmail.com Regres: Update test lists @ e162b023

Created with:
gclient setdep -r src/third_party/swiftshader@b1dd9acac569

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: If55689095438d18f0410582f6ac66d56ca84d5c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072308Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744282}

fa34f142

Roll src/third_party/perfetto 038955dfc94d..5c63cc2bc39b (5 commits) · a305cd3f

chromium-autoroll authored Feb 25, 2020

https://android.googlesource.com/platform/external/perfetto.git/+log/038955dfc94d..5c63cc2bc39b

git log 038955dfc94d..5c63cc2bc39b --date=short --first-parent --format='%ad %ae %s'
2020-02-25 treehugger-gerrit@google.com Merge "client api: Fix a comment in TracingSession."
2020-02-25 ddrone@google.com Merge "Add support for repeated fields"
2020-02-25 fmayer@google.com Merge "Check if app is still running after test."
2020-02-25 hjd@google.com Merge "ui: Fix open trace via File with extensions"
2020-02-25 hjd@google.com Merge "Clean-up packet_writer_unittests.cc"

Created with:
gclient setdep -r src/third_party/perfetto@5c63cc2bc39b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Icee90b73232605d2d9aa797d2ff0abf5334270be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072310Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744281}

a305cd3f

LayoutNG: Remove content_size parameter from Resolve{Min,Max}BlockLength · 4f053eae

David Grogan authored Feb 25, 2020

All the cases that needed content_size were short-circuited when
https://chromium-review.googlesource.com/c/chromium/src/+/1599691 made
{min,max}-height: {min,max,fit}-content behave as auto.

Change-Id: Icafee2c35598d92c95703c3eb16e0d43eecde48d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069506Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744280}

4f053eae

Add WithFeatureOverride to base/test · 09e26995

Olivier Li authored Feb 25, 2020

This class simplifies the process of running tests with a feature both
activated and deactivated.

Change-Id: I9a4b0457c8e48fd7ba0a8a2f9ef3ff6e271de000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050829Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744279}

09e26995

Allow customizing tabindex for <cr-button> · 021cb257

Maksim Ivanov authored Feb 25, 2020

This adds a Polymer property to the <cr-button> element that allows the
host to specify the custom value of the "tabindex" attribute.

Before this CL, the <cr-button> element was handling this attribute
itself: it was forcing it to "-1" when the button is disabled and to "0"
when the button is re-enabled. Also a few already existing examples in
the code base are configuring the "tabindex" directly at the <cr-button>
element, but it's fragile (and buggy in some cases), because this
value gets overwritten as soon as the "disabled" property gets changed.

After this CL, the more robust alternative appears:

  <cr-button custom-tab-index=...>

Bug: 1043194
Test: add element '<cr-button custom-tab-index="-1">' to a Polymer page, verify that it's not tabbable
Change-Id: Id5e79737f2bc9ac049ea1f2372ec160aac36d9c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069144
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744278}

021cb257

Roll src/third_party/devtools-frontend/src 384e239655c4..0fc949c8b168 (2 commits) · 79583355

chromium-autoroll authored Feb 25, 2020

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/384e239655c4..0fc949c8b168

git log 384e239655c4..0fc949c8b168 --date=short --first-parent --format='%ad %ae %s'
2020-02-25 wolfi@chromium.org Delete local overrides via context menu button
2020-02-25 szuend@chromium.org Prepare various test utilities for asynchronous source mapping

Created with:
gclient setdep -r src/third_party/devtools-frontend/src@0fc949c8b168

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1016501,chromium:1032016
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib25ce193daeedf0a5a100376ef1f2a262fa27450
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072304Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744277}

79583355

Mirgrate references to androidx. · be629773

Ben Joyce authored Feb 25, 2020

Bug: 1052460
Change-Id: I1d026d1ded59304050451d175c1a97909ee8cc26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070828Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744276}

be629773

Roll src-internal b5cd962aec5d..ec2fa5bb56bb (1 commits) · 5560fb87

chromium-internal-autoroll authored Feb 25, 2020

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b5cd962aec5d..ec2fa5bb56bb


Created with:
  gclient setdep -r src-internal@ec2fa5bb56bb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1049638
Tbr: jbudorick@google.com
Change-Id: Iff516692959d3c2083336794f627daa21ed8c739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072303Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744275}

5560fb87

testing: Chromium Goma RBE Android builders build 'all' · a97fad2d

Simon Que authored Feb 25, 2020

This is to make them consistent with android-archive-rel and
android-archive-dbg.

Bug: 726475
Change-Id: Id74b695f419caf17b115e731a5b7f21cb4a5821c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071681
Auto-Submit: Simon Que <sque@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744274}

a97fad2d

[STTS] fix crahing bug with MRU erasure · b74eb493

Jeffrey Cohen authored Feb 25, 2020

Bug: 1054551
Change-Id: Ied951dec94c6d1d38610deaf61d3842741f38e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067191
Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744273}

b74eb493

Drop SVGResource::HasClients · b9dcd09f

Fredrik Söderquist authored Feb 25, 2020

This method is largely an artifact remaining from when earlier resource-
handling cleanups/refactoring. At the moment it's only used for some
premature optimization, so remove it and also clean up a redundant
null-check.

Bug: 1028063
Change-Id: I9eb6ad52c9bf24265e06d723a5611a8b9beab579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072219
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#744272}

b9dcd09f

Drop the SVGResourceClient::kParentOnlyInvalidation flag · f835b447

Fredrik Söderquist authored Feb 25, 2020

The only times it's actually used is to mask it off. Theoretically it
will also partake in the |completed_invalidations_mask_| in
LayoutSVGResourceContainer, but it doesn't look like that is actually
happening (i.e the flag isn't actually being set at all).
Replace it with a plain zero (0).

Bug: 1028063
Change-Id: If93a9fe27b2848ff83ee352a2f855b595e34a94b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071886
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744271}

f835b447

Hold onto UserMediaRequest strongly in UserMediaProcessor · cb9a4b5a

Antonio Gomes authored Feb 25, 2020

... when dispatching callbacks that pass UserMediaRequest instances.

This CL switch from using WrapWeakPersistent to WrapPersistent in
UserMediaProcessor code, when dispatcking callback calls passing
UserMediaRequest as parameters.

This is a follow up of https://crrev.com/c/2064748.

BUG=1054999, 704136
R=guidou@chromium.org

Change-Id: I5696b1efdae769382d61d9dfb2652ccdcd3f3a55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070228
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#744270}

cb9a4b5a

Refactor BinaryUploadService::Result -> string code · 11a9b47a

Dominique Fauteux-Chapleau authored Feb 25, 2020

Change-Id: I3f47dadec2c1619ed4b4a3131c52fe1a6bef7d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068053
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744269}

11a9b47a

Fix an InstantService unittest when the system is in dark mode. · 90dcda95

Peter Kasting authored Feb 25, 2020

Bug: none
Change-Id: I4b03c12917149585ff8e47f497ad2cdb75531e0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070971
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744268}

90dcda95

Roll src/third_party/skia a6572f78d084..c8d092a060ad (1 commits) · 0f840ff0

chromium-autoroll authored Feb 25, 2020

https://skia.googlesource.com/skia.git/+log/a6572f78d084..c8d092a060ad

git log a6572f78d084..c8d092a060ad --date=short --first-parent --format='%ad %ae %s'
2020-02-25 bsalomon@google.com Revert "Revert "Remove copies for wrap modes in GrTextureProducer.""

Created with:
gclient setdep -r src/third_party/skia@c8d092a060ad

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jlavrova@google.com
Change-Id: Id74be906e00769d5ffdcda25b7bfd21756bf361a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072305Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744267}

0f840ff0

Replace .mojom.h includes with .mojom-forward.h in //chrome/browser (3/n) · 916ee9f4

Gyuyoung Kim authored Feb 25, 2020

This CL replaces .mojom.h includes with .mojom-forward.h in some
sub-directories of chrome/browser to reduce the pre-processed size
of header files and shorter build time. The sub-directories are following,

  - chrome/browser/resource_coordinator
  - chrome/browser/safe_browsing
  - chrome/browser/serial
  - chrome/browser/signin

This CL has no behavior changes.

Bug: 1001360
Change-Id: I58cff9508b8dca43563b92399b77921374445740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071676
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744266}

916ee9f4

[iOS] Have BVC get webStateList from Browser. · b4c8e137

Mark Cogan authored Feb 25, 2020

Greatly reduces BVC's dependence on TabModel by getting WebStateList
from Browser instead. This makes cleanup of various unit tests simpler,
as well as contributing to the removal of TabModel.

Remaining uses of TabModel in BVC all use TabUsageRecorder.

Bug: 1045575
Change-Id: I6850cd1b933b596b974e35cb535bee5db6f986ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068605Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744265}

b4c8e137

Roll src/third_party/perfetto b9ee1cfe480f..038955dfc94d (1 commits) · 2a74073d

chromium-autoroll authored Feb 25, 2020

https://android.googlesource.com/platform/external/perfetto.git/+log/b9ee1cfe480f..038955dfc94d

git log b9ee1cfe480f..038955dfc94d --date=short --first-parent --format='%ad %ae %s'
2020-02-25 ilkos@google.com Merge "Java heap stats and histogram"

Created with:
  gclient setdep -r src/third_party/perfetto@038955dfc94d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I6ca4f10922daff31f2cff5525303a71746d8d58c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072300Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744264}

2a74073d

Update V8 to version 8.2.170. · 81448984

v8-ci-autoroll-builder authored Feb 25, 2020

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/156331ab..aec8893e

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I73534a7e69ae74fd9c6a38048d494e6abd88e8bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071956Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744263}

81448984

[base] Make CancelableTaskTracker metrics more useful. · 54d16230

Wez authored Feb 25, 2020

- Log a single TaskStatus indicating both whether a task is same- or
  off-sequence, and whether it is canceled or live.
- Log independent duration metrics for same- and off-sequence tasks.

Bug: 1025372, 1053628
Change-Id: I377f71e91c67306a947d9a8b43a9eb71aedd00de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066539
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744262}

54d16230

[iOS] Prepare tests for BVC being contained · 55e8e988

Gauthier Ambard authored Feb 25, 2020

This CL make sure that the existing test will be passing once BVC is
contained instead of presented.

Bug: 1038034
Change-Id: I5f1afda124e5aaa6ed4e76191737b18302b1f511
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070161
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744261}

55e8e988

Roll Fuchsia SDK from 0.20200225.0.1 to 0.20200225.1.1 · d1cc79bf

chromium-autoroll authored Feb 25, 2020

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ie72c3a3e8525590e9b4035b4b0ca44f159dcd0fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072301Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744260}

d1cc79bf

Refresh My Accounts page when account becomes unauthenticated · 15120f50

Andrew Solovey authored Feb 25, 2020

Chrome OS Account Manager's UI does not automatically refresh itself
for newly unauthenticated accounts. This makes re-auth inconvenient
for users who may have Account Manager's UI already open and will
not see a re-auth button for newly unauthenticated accounts.
Observe |signin::IdentityManager::Observer::
OnErrorStateOfRefreshTokenUpdatedForAccount| to refresh accounts
settings UI.

R=sinhak@chromium.org

Bug: 1053993
Change-Id: Ia1558e67eeb781f9a011ffd4503f3eca007dc867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066761
Commit-Queue: Andrei Salavei <solovey@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744259}

15120f50

Return WebFrameWidget from WebView MainFrameWidget method. · f4a4ec0a

Dave Tapuska authored Feb 25, 2020

This will allow us to move some methods to WebFrameWidget that don't
really belong on the WebWidget.

Change-Id: I1b04bbb638a9d0f089ab85748e6445e7c148af00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070835Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744258}

f4a4ec0a

Do not fill field if it contains filled value. · b186361a

Vadym Doroshenko authored Feb 25, 2020

Before this CL, if a field contains value X, and Password Manager wants
to fill the same value X, Password Manager sets this field in the state
Autofilled. Setting the field to be autofilled is not necessary, since
it doesn't add new information. Moreover it destroys information, that
this information came from website, not from Password Manager.

This CL makes Password Manager skips setting such field in Autofill
mode. More details how it breaks accounts.google.com on the bug.

Bug: 1055275

Change-Id: I741ec23b7947c3322fe719b256d94f7c00dd3a6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072178
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744257}

b186361a

Roll src/third_party/angle 4dc19c38c0c5..aa09ca69e417 (1 commits) · e1d61e44

chromium-autoroll authored Feb 25, 2020

https://chromium.googlesource.com/angle/angle.git/+log/4dc19c38c0c5..aa09ca69e417

git log 4dc19c38c0c5..aa09ca69e417 --date=short --first-parent --format='%ad %ae %s'
2020-02-25 jmadill@chromium.org Vulkan: Update ContextVk command buffer access methods.

Created with:
gclient setdep -r src/third_party/angle@aa09ca69e417

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: geofflang@google.com
Change-Id: I210534a9899c7c268a2bf612887ceb65697ebefe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072297Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744256}

e1d61e44

Roll src/third_party/devtools-frontend/src 585ded41b502..384e239655c4 (1 commits) · d7725d85

chromium-autoroll authored Feb 25, 2020

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/585ded41b502..384e239655c4

git log 585ded41b502..384e239655c4 --date=short --first-parent --format='%ad %ae %s'
2020-02-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

Created with:
gclient setdep -r src/third_party/devtools-frontend/src@384e239655c4

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ic897e6f7b22195e9d4b49ab04d2307b00a6fcb99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072156Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744255}

d7725d85

[tools/perf] Remove browse:tools:earth story · ba420a19

Mythri A authored Feb 25, 2020

Google earth is now using a WASM version and hence the old version
is no longer very useful as a representative of real world. This
story is also flaky on certain platforms.

Bug: chromium:1050636
Change-Id: If53246f9722030c6afe07150a55c7415a7282c2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061809
Commit-Queue: Mythri Alle <mythria@chromium.org>
Auto-Submit: Mythri Alle <mythria@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744254}

ba420a19