GitLab

Intrinsic sizing for multicol used to be defined in the intrinsic and
extrinsic sizing CSS spec, but it must have been removed at some point.

All we have for inspiration now is the implementation in the legacy engine,
which landed with https://chromiumcodereview.appspot.com/23763002 back in 2013.
That, and common sense. :) The principles of min/max width calculation are,
after all, quite simple:

1. Figure out how much width we need to prevent avoidable overflow (min)
2. Figure out how much width we need to prevent avoidable soft wrapping (max)

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Id465449369d0227883e08228ce33346eb5b5cdba
Reviewed-on: https://chromium-review.googlesource.com/700460
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506680}

The profile_ member in TriggeredProfileResetter is not read by 
any code so let us remove it for platforms where it is not used.
This warning appeared in jumbo build
experiments (jumbo builds give the compiler more information which
triggers warnings that were not there before).

Bug: 770625
Change-Id: I4fd04d3147b01d0cf853b34c01ac7aa03fbd7d14
Reviewed-on: https://chromium-review.googlesource.com/695102
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506679}

Recently, Mojo wire format change was introduced
for native structure.
https://chromium.googlesource.com/chromium/src/+/fd907634b5ea956b34bd1672c084089aad2150cd
It causes a protocol mismatch between ARC and Chrome.
Unfortunately, rolled libmojo is too old, so we cannot
use values.mojom now. As its workaround,
this CL stringifies the JSON value if necessary,
and use it for the communication.

Note that this is breaking change. Though, the protocol is already
broken, so we don't much care about it.

BUG=767313
TEST=Ran CTS.

Change-Id: Iaaf28065aa7cde0ce17d7231da0571312f23772d
Reviewed-on: https://chromium-review.googlesource.com/691495
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506678}

Currently the stylesheet_contents_fuzzer, which fuzzs CSS stylesheet
parsing, has no dictionary, which means most of the inputs are garbage
and will be ignored at the parsing level. This patch adds some common
strings seen in CSS stylesheets, which would hopefully produce more
valid tokens that can expose more bugs at the parsing level.

Bug: 752194
Change-Id: Ibf596a0a78c5b1bfb042f2c9e952ebdc07790a42
Reviewed-on: https://chromium-review.googlesource.com/696441Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506677}

This CL moves ownership of ISensorManager to sensor thread, so that
ISensorManager is initialized when new sensor is created or in use,
and destroyed when there are no sensors. Before this CL, ISensorManager
could have been reset from IO thread.

Bug: 765527
Change-Id: I579f06dfd4cec7b678fe0080fe99cc6b182de27c
Reviewed-on: https://chromium-review.googlesource.com/699759Reviewed-by: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com>
Cr-Commit-Position: refs/heads/master@{#506676}

Bug: 700245
Change-Id: Id316cb680cecc5755ab52026ccff790e12d1d133
Reviewed-on: https://chromium-review.googlesource.com/702019Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506675}

When FetchEvent.respondWith() is called with a rejecting promise in a service
worker and if OnFetchEventFinished() of ServiceWorkerSubresourceLoader is called
before OnResponse(), OnFallback() passes |url_loader_client_| to the network
loader factory, and the renderer process crashes while calling
OnReceiveResponse().

  OnFetchEventFinished()
   => OnFallback()
     => std::move(url_loader_client_)

  OnResponse()
   => StartResponse()
    => DeliverErrorResponse()
     => CommitResponseHeaders()
      => url_loader_client_->OnReceiveResponse() (* crash here)


OnFetchEventFinished() should not call OnFallback() when |status| is
ERROR_EVENT_WAITUNTIL_REJECTED. And also, we don't need to fallback to the
network because it's for main resource load when FetchEvent failed.

Bug: 715640
Change-Id: I78d31c118ad9169740e3db4c561aa25e2dbae83e
Reviewed-on: https://chromium-review.googlesource.com/700276Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506674}

https://chromium.googlesource.com/catapult.git/+log/63a614b75273..f8ebe0eae6cb

$ git log 63a614b75..f8ebe0eae --date=short --no-merges --format='%ad %ae %s'
2017-10-03 benjhayden Refactor histogram-set-view API.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I06ff71f6464041fbbcdd9cd5d789c28501f8900b
Reviewed-on: https://chromium-review.googlesource.com/701665
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506673}

seek

Add UseCounter to check if setting playbackRate causes a compensatory
seek forcing a change in start_time_. This is as we want to spec this
behaviour on an API level.

Bug: 
Change-Id: Ic6ab06bb482b4e086d2559904bd4f6f4ccdd52eb
Reviewed-on: https://chromium-review.googlesource.com/700057
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: dstockwell <dstockwell@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506672}

Using wpt-import in Chromium 276f6dd9.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2562

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: Ic70765d2b8a02216acdbfa784e4342770ab7d4f7
Reviewed-on: https://chromium-review.googlesource.com/701800
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506671}

For cleanup, this CL moves InstalledScriptsManager access from
WorkerThread::InitializeOnWorkerThread() to
ServiceWorkerGlobalScope::EvaluateClassicScript() because only ServiceWorker
needs to access the manager and placing it in EvaluateClassicScript() looks more
natural like importScripts().

<Motivation>

My final goal is to remove script evaluation code from WorkerThread and leave it
up to each owner of WorkerThread so that WorkerThead is no longer concerned with
how to evaluate scripts (i.e., "classic", "module", lazy eval for worklets).

For example, for DedicatedWorker, DedicatedWorkerMessagingProxy may post a task
to call WorkerGlobalScope::EvaluateClassicScript() or
WorkerGlobalScope::ImportModuleScript() (to be added later) based on
"WorkerType"[1] after initializing DedicatedWorkerThread.

[1] https://html.spec.whatwg.org/multipage/workers.html#workertype

Bug: 680046, 753350, 755054
Change-Id: I546cbda16f09da66c3f94c319e498055e1f9d05b
Reviewed-on: https://chromium-review.googlesource.com/701854
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506670}

This fixes a problem where navigating after tab reparenting could cause
WebappActivity's TabObserver to interact with destroyed activity and
crash Chrome due to NPE.

Bug: 771174
Change-Id: I0231ff3c50ebebd8341e5826e3fb6e1a12b69627
Reviewed-on: https://chromium-review.googlesource.com/702075Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506669}

Destroying PaintLayer would cause its CompositedLayerMapping and
composited layers to destroyed immediately. The layer destructor
automatically detach it from the layer tree, but auxiliary layer
pointers such as scroll/clip parent could dangle if compositing
update were omitted. This CL forces a one time compositing update
when a PaintLayer is removed.

BUG=769185

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I97946ac5047a5b1f1bc925a6c42509ed6f915655
Reviewed-on: https://chromium-review.googlesource.com/699192
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506668}

Previously we would call SeekTask for every
completed read. This often cause us to seek
to somewhere and change our mind a very
short time later. By delaying our seeks and
batching them together, we can reduce the
number of times this happens.

I've tested this on a a bunch of badly muxed
videos, and generally got improvements. For
my primary test video, the number of connections
went from ~110 to ~70. As far as I can tell,
this has no impact on well-muxed videos.

Bug: 765313
Change-Id: I1cfdd803e9cda8fd45fae30ec2c0343f08a79edd
Reviewed-on: https://chromium-review.googlesource.com/690978
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506667}

I noticed this during my mash-related ImeController refactoring while
updating both locations.

Bug: 
Change-Id: I2fea8d237a325f64f619378b3db4776c4a47feb4
Reviewed-on: https://chromium-review.googlesource.com/700136
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506666}

GN should generate projects for Visual Studio 2017 by default since this
is the default compiler now.

Bug: 683729
Change-Id: I560983cf4c228a785e0ed2648567c7e0f07584d4
Reviewed-on: https://chromium-review.googlesource.com/700258Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Cr-Commit-Position: refs/heads/master@{#506665}

This feature is now ramping up to 100% in all channels. Flipping default to ensure it remains enabled in future clank releases.

A cleanup CL will follow up, to get rid of this flag entirely.

Bug: 718475
Change-Id: I96fbe835db9d6189cae557cf534217f12f5c45b8
Reviewed-on: https://chromium-review.googlesource.com/700004
Commit-Queue: Luis Barguñó <lbargu@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506664}

Change-Id: I639f16620a84a2b2aff827c38dd901bba73d37d0
Reviewed-on: https://chromium-review.googlesource.com/702095
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506663}

EncryptedMedia is more consistent with the rest of the code.

Bug: 689802
Change-Id: I990212b8e3972ee1c2581ed1237d15321628fab5
Reviewed-on: https://chromium-review.googlesource.com/596617Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506662}

https://skia.googlesource.com/skia.git/+log/e5ccb29e1eca..1ea81e766e1a

$ git log e5ccb29e1..1ea81e766 --date=short --no-merges --format='%ad %ae %s'
2017-10-05 angle-deps-roller Roll skia/third_party/externals/angle2/ c1abf9178..ce8602ab7 (1 commit)
2017-10-05 mtklein Revert "Don't execute onFlush op lists until after GPU data is uploaded"

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I4ceb94eec294a2e70b0fd6804956cdb33b8bbfa6
Reviewed-on: https://chromium-review.googlesource.com/701587Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506661}

Comes with a test that catches the bug.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib2e7434108d0e9825c812e37d5dd2b51f55f57ac
Reviewed-on: https://chromium-review.googlesource.com/702094Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506660}

BUG=771191
R=thakis@chromium.org

Change-Id: I7f29c4d0951ee4ec253261a39c2f87640156ef59
Reviewed-on: https://chromium-review.googlesource.com/701643Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506659}

This reverts commit c536e658.

Reason for revert:
This is failing the Google Chrome Win bot:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/22616

Error log:
../..\chrome/common/chrome_features.h(14): fatal error C1083: Cannot open include file: 'device/vr/features/features.h': No such file or directory

Original change's description:
> [vr] Add a flag for experimental VR features
> 
> Having this flag will allow VR feature work without putting the shipping
> code at risk. Having it available via about:flags makes for much easier
> use on Android.
> 
> Bug: None
> Change-Id: I12cf3edaad80f9129fe4b00fcbf630f71b5e0b53
> Reviewed-on: https://chromium-review.googlesource.com/700477
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506646}

TBR=vollick@chromium.org,sky@chromium.org

Change-Id: I82a0a817772a5b5e26ad9a94d3e5431165efdab4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/701956Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506658}

This patch adds better documentation/comments to these functions:
- IsVisuallyEquivalentCandidateAlgorithm
- CanBeBackwardCaretPosition
- CanBeForwardCaretPosition

So that we have better understanding of them, and can implement
InlineBox-free canonicalization with LayoutNG easier.

NOTRY=TRUE

Bug: 771398
Change-Id: I6b117656658b3db9059156426efbf44ad62979bc
Reviewed-on: https://chromium-review.googlesource.com/701836Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506657}

Adding tests so we could test |should_shrink_next_tap_|, which is
going to be added in http://crrev.com/c/653432.

Also did a line reorder in this CL.

Bug: 703884
Change-Id: If0d90219de85fbcfa64004abf6b8e420ad17d968
Reviewed-on: https://chromium-review.googlesource.com/701281
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506656}

Replace 1x SkBitmaps in shelf mojo structs with ImageSkia.
Fixes shelf item icons and icons in application menus.

Revise unit tests to support the new handle-bearing struct.
(add a test service to echo ShelfItem for struct traits)

Bug: 655874, 771311
Test: Shelf icons look good with --ash-host-window-bounds=1000x1000*2
Change-Id: I646b9c3f5cdb1aac1413a26f166e401968cec865
Reviewed-on: https://chromium-review.googlesource.com/699417Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506655}

HidService will be internal of device service,
so remove all references that outside of //device.

BUG=728223

Change-Id: I9e89c45db947f59d92c3f4a36f1317222b86b5d7
Reviewed-on: https://chromium-review.googlesource.com/700618
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506654}

1. Extract not LayoutText branch to function head.
2. Define const unsigned offsets.

This patch improves readability and is ready for introducing
 Option<int> offset type.

Bug: 739062
Change-Id: Ia1abddcda7aeaff88b8d3d834f5a1c59ec72b59d
Reviewed-on: https://chromium-review.googlesource.com/700155Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506653}

https://chromium.googlesource.com/catapult.git/+log/120c1cb3fd18..63a614b75273

$ git log 120c1cb3f..63a614b75 --date=short --no-merges --format='%ad %ae %s'
2017-10-05 shimazu Factored out EnsureCacheTemperature into each temperature

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: If46bad86450040a8ffec85650ef62644552994bc
Reviewed-on: https://chromium-review.googlesource.com/701586
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506652}

TBR=peria@chromium.org
NOTRY=True

Change-Id: I67b8255871066f725f63069c0d002b11e17f49b1
Reviewed-on: https://chromium-review.googlesource.com/702179Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506651}

TBR=peria@chromium.org

Change-Id: I2df1b960d4fea915777c1aa9039d4b64844f5b9e
Reviewed-on: https://chromium-review.googlesource.com/702178Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506650}

To avoid introducing dependency on //content in //device/u2f, the client of
//device/u2f is responsible for connecting the device service and passing a
service_manager::Connector raw pointer.

After this converting, all clients of device::HidService have been converted
to use the hid mojo interface. So we move the device::HidService to be owned
by HidManager which is owned by service device.

Make sure all the u2f unittest pass after this converting.

BUG=728223

Change-Id: I141a88c6480937e344d2ad3a73bb2e92a24c323c
Reviewed-on: https://chromium-review.googlesource.com/667801
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506649}

It is possible to receive a capture-lost message while destroying a
WindowTreeHost. Make sure the code works correctly if that happens.

BUG=770670

Change-Id: Idc176e7df5c9b9516264379cd086d441b71c4460
Reviewed-on: https://chromium-review.googlesource.com/696846
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506648}

The default background of notification has vertical gray line for some reason
and the background sometimes appears during expanding animation for a short
time. This is not good look so this CL overdraws it with a blank background.

Bug: none
Change-Id: Icf046a8e66c2091b0698850391871087a01118ef
Reviewed-on: https://chromium-review.googlesource.com/618530
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506647}

Having this flag will allow VR feature work without putting the shipping
code at risk. Having it available via about:flags makes for much easier
use on Android.

Bug: None
Change-Id: I12cf3edaad80f9129fe4b00fcbf630f71b5e0b53
Reviewed-on: https://chromium-review.googlesource.com/700477
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506646}

Bug=None

Change-Id: Ie7434c1f64cf98509b7986bef00dc88f380546a4
Reviewed-on: https://chromium-review.googlesource.com/697245
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506645}

for snake_case.

Bug: 770603
Change-Id: I6a7aafad637f0d3fcecf447e9e0bf0e853c00498
Reviewed-on: https://chromium-review.googlesource.com/701954Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506644}

This change reverts 7875d555.

Currently we only defer images for async decoding if they are on a tile
that is required for activation, which effectively means images coming
into the viewport from a compositor scroll would always be sync decoded.
Since this can lead to excessive checkerboarding in some cases,
eliminate this veto.

This veto condition was initially added to avoid overhead of creating
pending trees for pre-paint/pre-decode checker-imaged tiles. Follow up
changes should still attempt to minimize this overhead.

Also note that comparing the UMA data for
CheckerboardedNeedRasterContentArea for the CheckerImaging experiment on
canary, async decoding on the active tree shows an overall decrease in
checkerboarding. For a 28-day aggregation:

1) Async decoding without activation veto
0-1 pixels/frame : 99.608% for checkerimaging group compared with
99.567% for control.

2) Async decoding with activation veto
0-1 pixels/frame : 99.19% for checkerimaging group compared with
99.176% for control.

R=vmpstr@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I79aed0a7b3c4b14b50ff54c6237839c23d1ff5c1
Reviewed-on: https://chromium-review.googlesource.com/698875
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506643}

This is a follow up to
https://chromium-review.googlesource.com/c/chromium/src/+/619252

BUG=None

Change-Id: I8ede7cbf035fec5cba4884a4078b025e54e07cd3
Reviewed-on: https://chromium-review.googlesource.com/701694
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506642}

https://skia.googlesource.com/skia.git/+log/98156c4592d9..e5ccb29e1eca

$ git log 98156c459..e5ccb29e1 --date=short --no-merges --format='%ad %ae %s'
2017-10-04 angle-deps-roller Roll skia/third_party/externals/angle2/ 10d4026b3..c1abf9178 (2 commits)

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I9b7945011cd1ab8ad46ff46581c10469ed9c5e8d
Reviewed-on: https://chromium-review.googlesource.com/701931Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506641}