- 05 Mar, 2020 40 commits
-
-
Luke Zielinski authored
There is one known precondition failure that is added to WPTOverrideExpectations. Others will be added in a follow-up Cl. Also expands unit tests to check that we're parsing trailing comments into annotations properly. Bug: 937369 Change-Id: I325272eee364b8cae9ef7739ff9333b829f9f041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088234 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#747269}
-
Morten Stenshorne authored
Probably due to NGFragmentItem improvements. TBR=kojii@chromium.org Bug: 982194 Change-Id: I49fe42fda825b175abd9c158c389a1a03c5efa06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089693Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#747268}
-
sandromaggi authored
In crrev/c/2074499 the argument was raised, that the current handling of call arguments is not too readable (very verbose). This CL aims to refactor this slightly, by introducing a new helper function. Bug: none Change-Id: I98eb6045eb2600dd05501f6fcc6b918ced50bda5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081428 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#747267}
-
Monica Basta authored
|GAIAInfoUpdateService| do not need to listen on PrimaryAccount* events anymore, it is sufficient to listen to |OnUnconsentedPrimaryAccountChanged| since the sync consent is not a point of interest to this service. Change-Id: I4199f2451c5aa9ef75a89d3ca0870138778ee146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087394Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#747266}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/16ddae924efb..3c91b31162b8 git log 16ddae924efb..3c91b31162b8 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 titovartem@google.com Fix potential deadlock during release of quality analyzing codecs 2020-03-05 jonaso@webrtc.org Make Connection::id() const Created with: gclient setdep -r src/third_party/webrtc@3c91b31162b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6b40984b367d7c3497086934500e0c5ac7d6c229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089577Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747265}
-
Alice Wang authored
This CL removes the unused method of Android Edu support. Bug: 1044616 Change-Id: Idb87677032608785d751a5033a5335917aee62c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088153Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747264}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I8e355c4882766e539c65b870533a9449e1ca5345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088361Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747263}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eda959aeeb18..b0d65f1b3c40 git log eda959aeeb18..b0d65f1b3c40 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 tvanderlippe@chromium.org Extract protocol generation to separate script 2020-03-05 tvanderlippe@chromium.org Update README to recommend the integrated workflow Created with: gclient setdep -r src/third_party/devtools-frontend/src@b0d65f1b3c40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2f8396da770a7548d8b7cf7342464f4c4e2bebba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089578Reviewed-by:
-
Mohamed Amir Yosef authored
For users who haven't opted-in butter, they should go the reauth flow before being able to save passwords in their account. If users have opted-in already or decided to store locally, the credentials are saved directly without invoking the reauth flow. Bug: 1044038 Change-Id: I519e2739d8f87bfc16b84a484c2aa1d522df0b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050280Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#747261}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b583290a6d81..652ee37df0e7 git log b583290a6d81..652ee37df0e7 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 ddrone@google.com Merge "Add more fields to ChromeLatencyInfo" Created with: gclient setdep -r src/third_party/perfetto@652ee37df0e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5a366cd53c3adb2bfe781e7d7bc192bb962b6689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089575Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9eadf87170da..bd1226ba4922 Created with: gclient setdep -r src-internal@bd1226ba4922 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1052505 Tbr: jbudorick@google.com Change-Id: I0cf60f9a648dbcf422f8ae95076a81fbda68572a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089573Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747259}
-
Vasilii Sukhanov authored
Bug: 1049185 Change-Id: I7e912a11b9db0a38fb066722f387703781860c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089672 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#747258}
-
Eric Seckler authored
Makes ProducerClient::IsTracingActive() also consider active local startup tracing sessions, and adds a test that verifies that system tracing doesn't start until after local startup tracing is complete. Bug: 1058461 Change-Id: I59a488e663ad9ac2aaa41ae4fef8990f3268b695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087410 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#747257}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d4ed59c4..4b1eadeb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icb829fe71c85f797f309b804f0cb9afa7e9f66f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089397Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747256}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 39ca5bfe. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools meade@chromium.org: external/wpt/web-animations rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I5ea826ba8026e71e81d1b21d5392f5afac2ec631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089611Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747255}
-
Jose Lopes authored
It seems these methods are not being used at all. This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Idd854549fbd0b87b3ac41990bd98b2afeb8d0636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078011 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747254}
-
Adithya Srinivasan authored
Computes visible text in portal contents (by making the root web area in a portal compute its name from its contents), and uses this text as a name for the portal element if no name is provided. Bug: 1045608 Change-Id: If72acb5c803ab65d7e8d8cb06f6777dd9b3dac47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024110 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#747253}
-
Alex Ilin authored
Reason: many tests are flaky and cause build failures - https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/24498 - https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/31877 TBR: yfriedman@chromium.org Bug: 1058790 Change-Id: I6b2d08fddad4a298082907ef5e75511f08ab4595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089673Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747252}
-
Jose Lopes authored
This is a repeating callback because while video frames are being streamed (which is a repeated operation), this callback may be run to indicate a new target delay. This callback may even run twice in the same method call: * https://cs.chromium.org/chromium/src/media/cast/sender/video_sender.cc?rcl=ef3591b59e679e932cfad02644cec7cfc068a842&l=156 * https://cs.chromium.org/chromium/src/media/cast/sender/video_sender.cc?rcl=ef3591b59e679e932cfad02644cec7cfc068a842&l=219 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ib0e230d2dc5fc0e1ad100a41efdd71be7446e8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074439 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#747251}
-
Krzysztof Kotowicz authored
Context: https://github.com/w3c/webappsec-trusted-types/issues/235 Bug: 739170 Change-Id: I8499534f4351ea2c9f689071f3d6510238382d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089651Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Auto-Submit: Krzysztof Kotowicz <koto@google.com> Cr-Commit-Position: refs/heads/master@{#747250}
-
Maksim Ivanov authored
According to the UX feedback, the "backspace" icon displayed in the Ash PIN keyboard ("LoginPinView" class in the code) should use the "E8EAED" color ("GoogleGrey200" in the code). Bug: 1001288 Test: log in via a smart card and log out, start login again, proceed to the PIN dialog, take screenshot, verify that the "backspace" icon has color #E8EAED Change-Id: If3d9cd2cb245f2d7279042f0829f139f83f06387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089691Reviewed-by:Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#747249}
-
Henrique Ferreiro authored
This typo was introduced in https://crrev.com/c/2052783. Bug: 1040499 Change-Id: Ie3fe43eea175a0e9a03ee6d290a1f253440344a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077720 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#747248}
-
Gauthier Ambard authored
Reland of crrev.com/c/2062979 This enables the flag by default on Canary. The idea is to ship it to 100%, with a kill switch by Finch. Bug: 1038034 Change-Id: Ie62476253d81d9a54a9de0678456d2be1b83f727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080255Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#747247}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6cc841a97e38..eda959aeeb18 git log 6cc841a97e38..eda959aeeb18 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@eda959aeeb18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8468969935ae0091b14e7dfc8e4fa49a4518a033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089572Reviewed-by:
-
Jose Lopes authored
This is a repeating callback because it's used to process multiple audio frames, as documented in: * https://cs.chromium.org/chromium/src/media/cast/cast_receiver.h?rcl=aa9316a8407f234582ccb6395f933c37e22463d3&l=26 This is similar to the video equivalent, which is a repeating callback: * https://cs.chromium.org/chromium/src/media/cast/cast_receiver.h?rcl=aa9316a8407f234582ccb6395f933c37e22463d3&l=37 Example of why this is repeating is because it's called both on StartAudio and also on every decoded audio frame: * https://cs.chromium.org/chromium/src/chrome/renderer/media/cast_receiver_session_delegate.cc?rcl=9fb704a00bb8e7983886654eb4cb7327a1ba36be&l=50 * https://cs.chromium.org/chromium/src/chrome/renderer/media/cast_receiver_session_delegate.cc?rcl=9fb704a00bb8e7983886654eb4cb7327a1ba36be&l=69 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ib336c391989c1f0ff44788a6430748d76c3b862b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074438Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Anastasiia Nikolaienko authored
Add browser proxy to call the EDU account login handler. Bug: 1043108 Change-Id: Ia772b15b73568232ea13e714919adcbe6e98548b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043470 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747244}
-
Rohit Rao authored
Removes these checks from the code that calls OmahaService::Start() and places them in OmahaService::GetInstance() instead. Now, Start() is always invoked but sometimes may do nothing. Callers of GetInstance() are updated to check for nullptr, since that is now a valid return value. Also fixes an issue where loading about:omaha would unconditionally create an Omaha service, even in builds that did not support Omaha. BUG=996148 Change-Id: I12221f537a8640799dff1842953c69438bfe8f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935253 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/99eb20b513da..16ddae924efb git log 99eb20b513da..16ddae924efb --date=short --first-parent --format='%ad %ae %s' 2020-03-05 ivoc@webrtc.org Update Opus tests for Opus 1.3 Created with: gclient setdep -r src/third_party/webrtc@16ddae924efb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie0fd326d6b929ac63da0f903832174d34c3be6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089571Reviewed-by:
-
Takuto Ikuta authored
Bug: 1053958 Change-Id: I4df58a6bc6d8b839239c7d56a7a7db1e54fcfd42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089433 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#747241}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/343ee4e801b1..852653954526 git log 343ee4e801b1..852653954526 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 126720bd2e57..a095711c5d77 (4 commits) 2020-03-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src a6d3a2dd41d4..044ecc0b2c65 (1 commits) Created with: gclient setdep -r src/third_party/angle@852653954526 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Ifdf8d69ec14bac3e1ae375315840e3aa58dedc94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089511Reviewed-by:
-
Christian Dullweber authored
The following tests are failing virtual/form-controls-refresh-disabled/fast/forms/autofocus-opera-008.html - Mac10.13 Tests, Mac10.12 Tests, Mac10.10 Tests - https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/22747 virtual/threaded/fast/scroll-snap/snap-to-target-on-layout-change.html - WebKit Mac10.13 (retina) - https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/25972 accessibility/content-changed-notification-causes-crash.html - WebKit Mac10.13 (retina), Mac10.14 Tests - https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/2203 Mentioning multiple Mac targets in the same line doesn't seem to work, so I split them. Tbr: tkent@chromium.org Bug: 1058203, 1058073 Change-Id: I953c7c23a70f1e7431ba2e21272b314693c1def8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087727Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#747239}
-
Markus Handell authored
Android MediaRecorder choked on receiving frames in PIXEL_FORMAT_ABGR encoding. This resulted in no encoding happening, and consequently ondataavailable callbacks not getting fired. This patch adds support for the format. TESTED=manual appr.tc test hijacking the remote stream and recording it. Bug: 1052298 Change-Id: I6fd4aa4bb0421efbfa7a5892febb95176b9e30e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087770Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#747238}
-
Jose Lopes authored
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#use-and-instead-of-bare TBR=ajwong@chromium.org Bug: 1007806 Change-Id: I64d98168075bca5d54a658f306cb95e959709a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082565 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Also fix an ASAN issue triggered by this test in the fake delegate. Bug: 2078973 Change-Id: I2d98178b4c640b6509a999ef1b910d5490763f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079470Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#747236}
-
Sylvain Defresne authored
When targeting iOS, the host platform is macOS but only tools are built, so unconditionally disable nacl for both the target and the host (i.e. check target_os instead of is_ios). Also move the check for compatibility between the version of the OS used for the build and NaCL from build/config/mac/mac_sdk.gni to components/nacl/features.gni (the error is specific to NaCL, not to any project that want to reuse Chrome build system). Bug: 1049832 Change-Id: Id8efb5b4b271a7a6164333efc09f24804564c7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088102 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#747235}
-
Gyuyoung Kim authored
This CL replaces .mojom.h includes with .mojom-forward.h in some sub-directories of chrome/browser to reduce the pre-processed size of header files and shorter build time. The sub-directories are following, - chrome/browser/ui/app_list - chrome/browser/ui/ash This CL has no behavior changes. Bug: 1001360 Change-Id: Idb2b7b8475d75c5ea7e1c79ee3b6ad2bfe7b3e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087858Reviewed-by:
-
Christian Dullweber authored
This reverts commit 680e3222. Reason for revert: Looks like this broke https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/160982 Original change's description: > Upstream internal DownloadCollectionBridge code > > This will allow download in public chromium build to work on Q with MediaStore. > > BUG=1052490 > > Change-Id: I31476292b92c7a5882fa4ad80cc60b29f6b14dba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057806 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746867} TBR=yfriedman@chromium.org,dtrainor@chromium.org,qinmin@chromium.org,rsesek@chromium.org,gmariani@google.com Change-Id: I1547f1132bbddf575eeacfe2498b97ff1d7cc473 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1052490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089771Reviewed-by:
-
Kenichi Ishibashi authored
This feature was fully launched in M80. Bug: 692909 Change-Id: Ie66c1ac291092cca58c4cab9f291b79b0eae343e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071521Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#747232}
-
Maksim Ivanov authored
This fixes the UX regression from https://crrev.com/c/2066899: the PinRequestView dialog was containing two "submit" ("->") buttons. This regression was affecting (1) parent access code dialog, and (2) smart card PIN dialog on Ash login screen. The fix is to make sure the "submit" button from the PIN keypad is hidden. The dialog's submit button stays intact. The CL also adds a unit test that ensures the correct behavior. Bug: 993653 Test: start login as an existing user via smart card, proceed to PIN dialog, check that only one "submit" ("->") button is shown Change-Id: If2f8661c67a8686858167b242da0d67c3331d293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085072 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747231}
-
Alex Ilin authored
This reverts commit b5018edf. Reason for revert: StatusBarColorControllerTest#testColorWithStatusIndicator() fails on Android L Builder: Lollipop Phone Tester https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester First failing build: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/24496 java.lang.AssertionError: Wrong status bar color for Android L. expected:<-16777063> but was:<-16777216> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:645) at org.chromium.chrome.browser.ui.system.StatusBarColorControllerTest.testColorWithStatusIndicator(StatusBarColorControllerTest.java:149) Original change's description: > [Offline indicator v2] Add Java animations > > This CL implements the color and text transition animations that run when > showing or hiding the status indicator. > > Show: > 1- Transition the status bar color. > 2- Wait for the browser controls animation in cc to finish. > 3- Fade in text. > > Hide: > 1- Transition the status bar and the indicator color. > 2- Wait 2 seconds. > 3- Fade out text, and transition the status bar and indicator color back > to the original status bar color. > 4- Let the browser controls hide animation run in cc. > > Bug: 989148 > Change-Id: If19a51e6c5091436d78e34ef50f11ffa0118ee0d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067095 > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747080} TBR=twellington@chromium.org,mdjones@chromium.org,sinansahin@google.com Change-Id: If1a31818ad5cb887cf44399a8baaaeb56c619d1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089751Reviewed-by:
-
