- 19 Aug, 2020 40 commits
-
-
Yuki Yamada authored
We shouldn't call ProcessSendQueue() in WebSocketChannelImpl::Close() when execution_context_->IsContextDestroyed() returns true. In current implementation, it is guaranteed that execution_context_->IsContextDestroyed() returns false in WebSocketChannelImpl::Close(), but it will return both of true/false with another CL https://crrev.com/c/2359657 Bug: 1116995, 1100257 Change-Id: Id5157f78859e2d9aa5dbd02a7b82bafd58808e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362042 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#799524}
-
Maggie Cai authored
Currently, the specific activity name is not passed from ARC. This causes an issue where if we try to share a file to an app that has multiple activities that can handle the file, it will trigger the disambiguity dialog. This CL pass the activity name with the activity label from ARC to ensure launching the correct activity. BUG=1092784 Test: Manually test with share jpeg file to facebook app. Change-Id: I4290ddce72c80548d23171f020284c39c87ce688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360094Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#799523}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81eabce6a3af..6004bcb3bd06 2020-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from d95180deded1 to b54c82ed3948 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I8ef28bc4beca92bc5c1b1b029909370d267bc87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363501Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799522}
-
Callistus authored
In particular, this affects the "See what's new" button on the Settings About page and the Release Notes notification. - Also added Notification as an App Launch Source. Bug: b/159394556 Change-Id: Icc498f4c571098c922a8da29003fc8780d386ec0 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352459 Commit-Queue: Callistus Tan <callistus@google.com> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Removed the files_password_dialog which was failing to import its dependencies and isn't needed for these tests. Bug: 924873, 1111393 Change-Id: I677db6d25ce1f6701e1b6dbe7e40081b8987b7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362362 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#799520}
-
John Abd-El-Malek authored
Change-Id: I366c1c6040918d6905264ddaa62b340cbe06db2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355002 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#799519}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fb33bb85a9f7..5358c08137f8 2020-08-19 chrche@microsoft.com Fix regression: Tooltip shown even after moving away from labels text If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1023798 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I57cf1218cbc5ef78459fddbe00ce0ebf12ed8b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362338Reviewed-by:
-
Sky Malice authored
This reverts commit 4f081fd8. Reason for revert: Reverted culprit CL, shouldn't have disabled this test. Original change's description: > Disable WebViewThreadTest#testCookieManagerBeforeCreateWebView > > TBR: timvolodine@chromium.org > Bug: 1117683 > Change-Id: Ibb9538fc0530dd48effa973af8628565af639b32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363486 > Reviewed-by: Sky Malice <skym@chromium.org> > Commit-Queue: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799356} TBR=timvolodine@chromium.org,skym@chromium.org Change-Id: I9a70de742d31933e21e49f2e8fc49a5a61641466 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1117683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362971Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#799517}
-
Sky Malice authored
Bug: 1108118 Change-Id: If843abbcd6dd5451775d2d79bc6d55c151552ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344813 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#799516}
-
Eleonora Rocchi authored
This CL adds a view entry to the more menu of a compromised credential. It also adds a test to verify the menu is correctly shown. IDS_PASSWORD_CHECK_CREDENTIAL_MENU_ITEM_VIEW_BUTTON_CAPTION.png https://storage.cloud.google.com/chromium-translation-screenshots/2531deee57820ab74470f0ebbb23616862e03840 Bug: 1117502, 1092444 Change-Id: I6600c78848bb4dadf343c4c9ff60c6a5ba594941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362910Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Eleonora Rocchi <erocchi@google.com> Cr-Commit-Position: refs/heads/master@{#799515}
-
Andrey Kosyakov authored
Bug: 1113558, 1113565 Change-Id: I99f2e030f9a38f1ffd6b6adc760ba15e5d231f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342277 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799514}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/45b753b2d1d2..48b037ba0de5 $ git log 45b753b2d..48b037ba0 --date=short --no-merges --format='%ad %ae %s' 2020-08-13 dalecurtis [mov] See if mfra makes up the difference for an incomplete sidx. Created with: roll-dep src/third_party/ffmpeg TBR=sandersd Fixed: 1107130 Change-Id: I41a9601a86dbe679e33607805bcaea3a20ea429a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364035Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799513}
-
Juliet Levesque authored
Updated the font and fixed a double border problem on the Contacts Tab and the HTTP Messages tab. Font screenshot here: https://screenshot.googleplex.com/8a9a5ca4-623f-4b51-8e79-70da2e23f478 Change-Id: Id202125317b50ee07dd514587f51a785cbd622f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363714 Commit-Queue: Juliet Levesque <julietlevesque@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#799512}
-
Sundoo Kim authored
Explicitly remove the copy constructor and assignment operator with the delete keyword. Bug: 1010217 Change-Id: I05d56372a89033c9e5941c476761dd621497a058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362170Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#799511}
-
Andres Calderon Jaramillo authored
Problem: Videos that are decoded using the new direct VD and that get promoted to a hardware overlay are displayed with non-visible data. This is because we currently use the coded size to create the DRM framebuffer. Solution: This CL simply makes it so that the DRM framebuffer is created using the "usable area." For most videos, this is simply the size of the visible rectangle. However, some H.264 videos specify a visible rectangle that doesn't start at (0, 0). For these videos, the usable area needs to include everything from (0, 0) to the bottom-right corner of the visible rectangle: the client is expected to setup the hardware overlay's crop rectangle in order to exclude the non-visible area on the left and on the top of the visible area (this seems to be currently broken though). This change also means that we need to update the way we detect whether the frames in the pool have to be re-allocated: if the DRM framebuffer will change after a configuration change, the frames should be re-allocated. The unit tests are expanded to more extensively cover this re-allocation logic. Bug: b:162880731 Test: video.Contents.h264_360p_hw on nami Change-Id: I6ed36b9685329fe5f675503c2a9a0b580d6ae696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340115 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#799510}
-
Yue Zhang authored
Since TabGrid/Group is no-op for Tablets, disable both features for Tablets from client-side. Bug: 1108468 Change-Id: I9b26c7ecd4f260b1903a0f40e1e86c985101d8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363644 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799509}
-
danielng authored
Mic permissions for Crostini landed in M84 and hasn't caused any issues. Removing the flag (that was enabled by default) and any code that used it. Tests: Tested on DUT and ran browser tests Bug: 1016193 Change-Id: I4a099791500f9291013c6ee28b9e97548ff0c95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352257 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#799508}
-
Daniel Hosseinian authored
Show a Cloud Print deprecation warning at the top of the destinations dialog if any of the destinations are being deprecated. Screenshot of change: https://imgur.com/GClle7p Bug: 1112581 Change-Id: I42d7086ea0da2f2443d2a59dd540e6aafdf78472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361046 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#799507}
-
Melissa Zhang authored
This CL adds the SetSharesheetSize function to SharesheetController which can be called to resize the sharesheet to a given size. The anchor position in the sharesheet bubble is updated to accommodate the new bubble sizing. Bug: 1097623 Change-Id: I0093c4b7ae69119928d677bed12cd19ca7d64e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362067 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
-
Timothy Loh authored
Bug: 1087726 Change-Id: If56fc0d80ca435e16bc764af49079dd25c6f88e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362053 Commit-Queue: Timothy Loh <timloh@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Timothy Loh <timloh@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This reverts commit ef0ab61f. Reason for revert: The test still fails: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/1158 Original change's description: > Revert "[Sheriff] Disable the test" > > This reverts commit af48c8e6. > > Reason for revert: Test works now. > > Original change's description: > > [Sheriff] Disable the test > > > > Disable the failing test on Linux. > > > > Bug=1108205 > > TBR=miu@chromium.org > > > > Change-Id: Ie388ca75a2fadce937d613994847217e7f9579fc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310271 > > Reviewed-by: Hayato Ito <hayato@chromium.org> > > Commit-Queue: Hayato Ito <hayato@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#790745} > > TBR=miu@chromium.org,hayato@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: I4c43284f7d4a0fec1cd4c05fc375f1f4d406526b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361023 > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: Yuri Wiitala <miu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799428} TBR=miu@chromium.org,hayato@chromium.org # Not skipping CQ checks because this is a reland. Change-Id: Ibc06b68b65131cc9f3220ec36084f89eaf08ce59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362494Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799504}
-
Justin DeWitt authored
This checks for the existence of the file and skips adding it as a parameter if it doesn't exist. Also removes classes from the prebuilt output jar since they cannot be actually included in the build - they are required only for the desugaring step. Bug: 105675 Change-Id: Ib1e86fb25cb4607a18278446c4b35606f179e076 R: agrieve@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363555 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#799503}
-
Hajime Hoshi authored
This test is flaky also on macOS. TBR=clamy@chromium.org Bug: 796135 Change-Id: I8275f5c3267ed072e3eed79e81c93067ecc94c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362052Reviewed-by:
-
Lei Zhang authored
Use back_forward_cache/no-favicon.html as the test page, as favicons are known to cause issues for BFCache tests, as seen with ChromeBackForwardCacheBrowserTest. Fix a few nits along the way. This is a precursor to https://crrev.com/c/2353886, which will trigger flaky behavior without this CL. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android-bfcache-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-bfcache-rel Bug: 956832 Change-Id: I62dbb2c05542a7ed027f400c7000b87f5d64b6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361535Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799501}
-
Daniel Hosseinian authored
Add a deprecation warning message for Cloud and Privet printers under the ChromeOS print preview destination select. Screenshot of change: https://imgur.com/cZqYwba Bug: 1112581 Change-Id: Idffd0ff25f3182db3546dca9f89b0dfd21d4bccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359159 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Maksim Sisov authored
We have a extensions as a source_set, which is included by multiple different places. That results in ODR problem. Here is the error: ninja: Entering directory `out/libfuzzer/' [1/1] Regenerating ninja files [14/16] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x64) FAILED: v8_context_snapshot.bin python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin ================================================================= ==406548==ERROR: AddressSanitizer: odr-violation (0x7ff00fcc6660): [1] size=64 'vtable for ui::WorkspaceExtension' ../../ui/platform_window/extensions/workspace_extension.cc [2] size=64 'vtable for ui::WorkspaceExtension' ../../ui/platform_window/extensions/workspace_extension.cc These globals were registered at these points: [1]: #0 0x55d60fc1539d (/home/msisov/code/chromium/src/out/libfuzzer/v8_context_snapshot_generator+0x3a439d) #1 0x7ff00fca72eb (/home/msisov/code/chromium/src/out/libfuzzer/libozone.so+0x51d2eb) [2]: #0 0x55d60fc1539d (/home/msisov/code/chromium/src/out/libfuzzer/v8_context_snapshot_generator+0x3a439d) #1 0x7ff00a4bc22b (/home/msisov/code/chromium/src/out/libfuzzer/libx11_window.so+0x5a22b) ==406548==HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_odr_violation=0 SUMMARY: AddressSanitizer: odr-violation: global 'vtable for ui::WorkspaceExtension' at ../../ui/platform_window/extensions/workspace_extension.cc ==406548==ABORTING ./v8_context_snapshot_generator failed with exit code 1 ninja: build stopped: subcommand failed. One of the solutions is to switch from source_set to component. However, it looks too much to have a separate component just for that. Instead, squash extensions with platform_window component. Change-Id: I2ac2cf464b64bb863543468438ae81a2032223c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362888Reviewed-by:Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#799499}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I2bfa69d94d6d0be6ae6e0152e0898f651ca53354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363801Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d251f6f077f..cf6f2d3ab620 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hajimehoshi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419,chromium:1105693,chromium:1115361 Tbr: hajimehoshi@google.com Change-Id: I7266089e4fd24f8b0339f0fed8969821eb5866be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363499Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799497}
-
Jit Yao Yap authored
This is a reland of f82a08ba together with a fix for the failing tests. Original change's description: > Add Remote Apps Mojo service > > This CL adds a Mojo service for Remote Apps. The service is a thin layer > which mainly forwards calls to the RemoteAppsManager. > > Only extensions under the imprivata_in_session_extension behavior feature > have access to the API. > > Bug: 1101208 > Change-Id: Ieaf9f6839ba22d86cb3fba8fa64afe49ade8e6ce > DD: go/remote_apps_mojo > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332615 > Commit-Queue: Jit Yao Yap <jityao@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798551} TBR=xiyuan@chromium.org,antrim@chromium.org,rdevlin.cronin@chromium.org,sammc@chromium.org,ortuno@chromium.org Bug: 1101208 Change-Id: If11de6983195af24b404897c0ea87befc8f85f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360067Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#799496}
-
chrome://media-appDavid authored
Prior we re-launched upon a successful rename so the file was reloaded with the correct name. crrev/c/2352586 changes that but we forgot to update it in the untrusted context. Also adds tests for it. Bug: b/165431994 Change-Id: I3b17c88b40ed563e043be7bb0b70c3dc098caeaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362169 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
-
Brian Malcolm authored
This is intended to replace the NativePrintersBulkBlacklist policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. BUG=chromium:1098049 Change-Id: I473dbe34e2d4de7ffcd91b5254b6414a4364357d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341218Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium de77910b. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ia5fdd50bb49f0b2c48f88279cadab7e41aa16067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362631Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799493}
-
Hajime Hoshi authored
TBR=jkrcal@chromium.org Bug: 1021930 Change-Id: I3d542632c89a5834d5339a6a9d488dfb8d62eba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362363Reviewed-by:
-
Hajime Hoshi authored
This reverts commit c8d093ac. Reason for revert: Test failures on ChromeOS https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/7829 Original change's description: > ambient: Use different backend servers > > This patch configs the dev channel to use testing server. But users can > overwrite it with a flag. > > Bug: b/148692733 > Test: manual > Change-Id: I967281bc1421c37d9c1ff74a0815d6a6da570da3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342134 > Commit-Queue: Tao Wu <wutao@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799318} TBR=xiyuan@chromium.org,xiaohuic@chromium.org,wutao@chromium.org Change-Id: Ic364ef7c1f701b7a36b6503e8d330995de5dcecb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/148692733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363508Reviewed-by:
-
Andrew Grieve authored
When chrome_public_smoke_test has a crash, our test runner does not notice and so does not collect tombstones. This changes the "are there tombstones" logic to look for a tombstone message in logcat rather than looking to see if any tests crashed. Bug: 1117540 Change-Id: Ic0594f0d8dcb2cb8c7280ade9d8d5133c890614f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363075Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#799490}
-
Richard Li authored
Although Intel's driver supports RGB10A2 overlay format, driver problems still exist in checking overlay's capability, which blocks playing hdr video through overlay. This CL adds a workaround for Intel's hardware (Icelake or later), to ensure play hdr video through RGB10A2 overlay. In future, this workaround could be remove if overlay capability checking bugs are fixed in Intel's driver. Bug: 1062184 Change-Id: If18383edb0339c3c7701febdb34bdd7d736f323a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340414Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Richard Li <richard.li@intel.com> Cr-Commit-Position: refs/heads/master@{#799489}
-
Xiaodan Zhu authored
Bug: 1110661 Change-Id: Ie74c57d6221407e8583790ad9e1108bcb3875e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363298 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#799488}
-
Daniel Hosseinian authored
Add a deprecation warning message for Cloud and Privet printers under the destination select. Note: This change is only for non-CrOS desktop. CrOS changes will be applied in a chained CL. Screenshot of change: https://imgur.com/cZqYwba Bug: 1112581 Change-Id: I2057cab0daa8d6f169ae6255172970a84b2803f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353731 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Makes V8ContextSnapshotImpl not depend on unnecessary code and data if !defined(USE_V8_CONTEXT_SNAPSHOT). Bug: 839389 Change-Id: I349292e52b465e5836e8ade7791be24a1e39af78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362066Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#799486}
-
rbpotter authored
Adding closure compilation for: link_container_test media_size_settings_test margins_settings_test Bug: 1000989 Change-Id: Ie7b2a06e157591e3a27eec9d46933ae8853237ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360502 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799485}
-
