GitLab

In the context menu, disabled items are not required so can be removed
instead of disabling them, so user donot tap on it.

BUG=395551

Review URL: https://codereview.chromium.org/494093003

Cr-Commit-Position: refs/heads/master@{#291861}

This test was flaky because it modified system properties. Moving it to
interactive_ui_tests should allow it the system control guarantees it
needs to complete successfully.

BUG=396344

Review URL: https://codereview.chromium.org/492623003

Cr-Commit-Position: refs/heads/master@{#291860}

BUG=397393
TEST=manually tested

Review URL: https://codereview.chromium.org/506583002

Cr-Commit-Position: refs/heads/master@{#291859}

BUG=398959

Review URL: https://codereview.chromium.org/489643002

Cr-Commit-Position: refs/heads/master@{#291858}

TBR=vogelheim@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/503053004

Cr-Commit-Position: refs/heads/master@{#291857}

Previously, AppListViewDelegate manually parsed the manifest. We now
have a proper parser class that generates appropriate errors for invalid
launcher_page fields in a manifest, with full valid and invalid unit
tests.

BUG=399131

Review URL: https://codereview.chromium.org/489753002

Cr-Commit-Position: refs/heads/master@{#291856}

This CL makes the DummySearchBoxBackground the standard SearchBoxView
background when using the experimental app list.

BUG=406222

Review URL: https://codereview.chromium.org/493293003

Cr-Commit-Position: refs/heads/master@{#291855}

This CL makes the app list contents view scroll vertically for the
experimental app list rather than horiztonally.

BUG=406222

Review URL: https://codereview.chromium.org/504033002

Cr-Commit-Position: refs/heads/master@{#291854}

Linux: install-debian.wheezy.sysroot.py should use build/detect_host_arch.py to detect the host architecture.

Review URL: https://codereview.chromium.org/505933002

Cr-Commit-Position: refs/heads/master@{#291853}

Currently AppListViewDelegate can hold on to references to a destroyed
Profile*. It's managed to escape crashing in most cases so far because
the LocalState pref is updated for the next time the app launcher is
shown. However, if the profile the app launcher is first created for is
ever deleted in the same session, then a crash usually follows (but
doesn't always create a crash dump, due to a corrupt stack).

This decouples the Profile from the AppListViewDelegate constructor to
make it clear the lifetimes are not in step. Then "SetProfile" correctly
tears down any references to an old profile, before setting a new one.

When the app list's active profile is deleted, the AppListViewDelegate
is destroyed by forcibly closing/destroying the AppList's widget via a
new method AppListServiceImpl::DestroyAppList().

BUG=392763, 403647, 373689, 405827
TEST=(windows) Show the app list, right-click an app and "uninstall".
Leave the uninstall dialog open. Switch to a chrome://settings in a
browser and delete the profile being shown in the app list. App list
should close.

Review URL: https://codereview.chromium.org/492163002

Cr-Commit-Position: refs/heads/master@{#291852}

BUG=407467
TBR=bshe@chromium.org

Review URL: https://codereview.chromium.org/502183003

Cr-Commit-Position: refs/heads/master@{#291851}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/508433002

Cr-Commit-Position: refs/heads/master@{#291850}

This CL fixes font rendering for experimental app list tiles by setting
a background.

BUG=406989

Review URL: https://codereview.chromium.org/499983002

Cr-Commit-Position: refs/heads/master@{#291849}

Display the results for the individual benchmark suites, this is
acheived by storing the full results set and quering it after
the benchmark has finished.

BUG=389257

Review URL: https://codereview.chromium.org/503053005

Cr-Commit-Position: refs/heads/master@{#291848}

BUG=407452
TBR=xhwang@chromium.org

Review URL: https://codereview.chromium.org/501283002

Cr-Commit-Position: refs/heads/master@{#291847}

- Revived AsyncUtil.Aggregation, which was used to aggregate consecutive run requests into one.
- Aggregated consecutive re-scan request using the aggregator described above.

BUG=316050
TEST=confirmed manually

Review URL: https://codereview.chromium.org/488043003

Cr-Commit-Position: refs/heads/master@{#291846}

BUG=401028
TEST=browser_tests

Review URL: https://codereview.chromium.org/489333002

Cr-Commit-Position: refs/heads/master@{#291845}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/508513002

Cr-Commit-Position: refs/heads/master@{#291844}

Add OpenDevToolsWindow() and IsCurrentChannelOlderThanDev() to AppsClient.

BUG=387288

Review URL: https://codereview.chromium.org/494483006

Cr-Commit-Position: refs/heads/master@{#291843}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/502173004

Cr-Commit-Position: refs/heads/master@{#291842}

This class is simply unnecessary.

BUG=None
R=oshima@chromium.org
TEST=athena_unittests passes

Review URL: https://codereview.chromium.org/501183002

Cr-Commit-Position: refs/heads/master@{#291841}

This makes it harder to accidently use the wrong
macro.

Also, removes the D* variants of the macros and
associated DebugNow() function. These were rarely
used and removing them removes clutter from the
header file. Existing uses converted to be behind
NDEBUG ifdefs.

No functional changes except for a fix to the
code in content_based_thumbnailing_algorithm.cc
which was incorrectly using a ternary operator for
the histogram name (which doesn't work since the
macros cache the histogram object) and removal
of local histograms Spellcheck.SuggestTime and
Spellcheck.InitTime per groby@.

Since this is an API rename, TBR'ing downstream
owners.

BUG=311349
TBR=groby@chromium.org,zea@chromium.org,jeremy@chromium.org,reveman@chromium.org,agl@chromium.org,jam@chromium.org

Review URL: https://codereview.chromium.org/484603006

Cr-Commit-Position: refs/heads/master@{#291840}

This delegate isolates SearchProvider from chrome dependencies

Add AutocompleteProviderDelegate and its chrome implementation ChromeAutocompleteProviderDelegate.

BUG=388515
TBR=blundell@chromium.org for the new DEPS line

Review URL: https://codereview.chromium.org/500023002

Cr-Commit-Position: refs/heads/master@{#291839}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/503903004

Cr-Commit-Position: refs/heads/master@{#291838}

BUG=

Review URL: https://codereview.chromium.org/504003002

Cr-Commit-Position: refs/heads/master@{#291837}

BUG=407080

Review URL: https://codereview.chromium.org/473683005

Cr-Commit-Position: refs/heads/master@{#291836}

Crash reports indicate that the WindowAndroid's Compositor may be NULL
during |RenderWidgetHostViewAndroid::SetContentViewCore()|. While this
is a somewhat surprising result, it is in theory possible and should
probably not be fatal. Avoid creating the overscroll effect in this
case, instead creating it after the compositor is (re-)attached.

BUG=407208

Review URL: https://codereview.chromium.org/503813003

Cr-Commit-Position: refs/heads/master@{#291835}

Note that the Match() function copies the data into a memory blob.  This is of course only for demo purposes. This will soon be changed to use a streaming API. See bug 403493.

BUG=392621

Review URL: https://codereview.chromium.org/465463002

Cr-Commit-Position: refs/heads/master@{#291834}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/502203003

Cr-Commit-Position: refs/heads/master@{#291833}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/502123003

Cr-Commit-Position: refs/heads/master@{#291832}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/501263002

Cr-Commit-Position: refs/heads/master@{#291831}

of the previous CongestionFeedback Timestamp frame.
Adds QUIC_VERSION_23. Deprecate CongestionFeedbackFrame

1 bytes - num_received_packets
First packet:
1 byte - distance from the largest observed in sequence number space.
4 bytes - mod of microseconds since the connection's creation when the
  packet arrived.  (1.1hrs in us)
Every other packet:
1 byte - distance from the largest observed in sequence number space.
2 bytes - mod of microseconds since the previous timestamp

Merge internal change: 73740829

The following are chromium specific changes:
+ Changed ACK frame not to send CongestionFeedback frame
+ Added received_packet_times to ACK frame.
+ The timestamp that is sent is relative to creation time, thus passed
  MockClock's now() as argument to AckFrame and it is used to pass
  QuicFramer's creation time and received_packet_times.

R=cyr@google.com, ianswett@google.com, rch@chromium.org

Review URL: https://codereview.chromium.org/478153003

Cr-Commit-Position: refs/heads/master@{#291830}

The GPU command buffer client uses Rect/RectF from gfx.
RectBase and friends have an extern template declaration which means that
instead of inlining the x(), y(), width() and height() methods (e.g. where they
are used in the header and in gles2_implementation.cc), an external
reference is generated instead. Unlike in Chromium, the NaCl IRT build does
not build/link with the gfx/geometry implementation, which means that
these references never get defined.

So do not use the extern template declarations for NaCl.

R=bbudge@chromium.org (GPU untrusted build), danakj@chromium.org (graphics primitives OWNERS)

TEST= NaCl IRT build with no optimization
BUG= https://code.google.com/p/chromium/issues/detail?id=388035

Review URL: https://codereview.chromium.org/503953002

Cr-Commit-Position: refs/heads/master@{#291829}

1) Image parsing missed one nesting level of dictionaries, and so
   always failed.
2) Images are returned without a scheme prefix - prepend that.

R=mpearson@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/470403003

Cr-Commit-Position: refs/heads/master@{#291828}

Picks up:
r291620 vpx: Simplify intrinsic gypi files.
r291625 Attempt to let libvpx's SSE files build with clang-cl.

BUG=82385
TBR=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/502323002

Cr-Commit-Position: refs/heads/master@{#291827}

This CL allows the extension action context menu to use the new embedded
extension options feature. If the enable-embedded-extension-options flag
is enabled, instead of opening an extension's options page in it's own
tab, it will open chrome://extensions, scroll down to the correct
extension, and then open the embedded options page popup.

The context menu opens a link to chrome://extensions/ with the query
string ?options=|extensionId|. This query string is appended and
removed whenever the embedded extension options popup is opened or
closed.

BUG=386842

Review URL: https://codereview.chromium.org/484033003

Cr-Commit-Position: refs/heads/master@{#291826}

This check turns out to be fairly expensive on Windows (~150ms), and having
it at import time means we're taking the hit every time we launch
memory_cache_http_server. We only need to do this if the Python files have
changed, so move it to runhooks.

The reason this check exists in the first place is that we've had problems in
the past where e.g. someone renames foo.py to foo/__init__.py. foo.pyc remains
on the filesystem of every Chromium checkout and causes a name conflict in
Python imports - foo can refer to the compiled module or the package.

BUG=388256
TEST=git rm a file in src/tools that has a .pyc; git commit; gclient runhooks; ensure .pyc doesn't exist; undo commit

Review URL: https://codereview.chromium.org/489693002

Cr-Commit-Position: refs/heads/master@{#291825}

TBR=stgao@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/501153004

Cr-Commit-Position: refs/heads/master@{#291824}

This was causing a DCHECK as ToolbarView::Observe both didn't handle the
asked-for notification and DCHECKed on unhandled notification types.

BUG=407124
TEST=NONE

Review URL: https://codereview.chromium.org/503783002

Cr-Commit-Position: refs/heads/master@{#291823}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/503083003

Cr-Commit-Position: refs/heads/master@{#291822}