GitLab

We add WebGLImageConversionTest in blink_platform_unittests.
This covers following conversion tests:
- ConvertRGBA4444toRGBA8
- ConvertRGBA5551toRGBA8
- ConvertRGBA8toRA8
- convertBGRA8toRGBA8
- ConvertRGBA8toR8
- ConvertRGBA8toRGBA8
- ConvertRGBA8ToUnsignedShort4444
- ConvertRGBA8ToRGBA5551
- ConvertRGBA8ToRGB565

R=kbr@chromium.org
BUG=642653

Review-Url: https://codereview.chromium.org/2333233002
Cr-Commit-Position: refs/heads/master@{#418486}

The problem was that the path to the filter is different depending on whether the test is swarmed or not. Also make sure to send the filter file for the tests as part of the isolate data.

BUG=645983
TBR=scottmg@chromium.org

Review-Url: https://codereview.chromium.org/2337383002
Cr-Commit-Position: refs/heads/master@{#418485}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b86cfef4b9da..c42044026b81

$ git log b86cfef4b..c42044026 --date=short --no-merges --format='%ad %ae %s'
2016-09-13 benjhayden Add BarChart.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2333373005
Cr-Commit-Position: refs/heads/master@{#418484}

Also, perform some clean-up.

BUG=592873

Review-Url: https://codereview.chromium.org/2338803003
Cr-Commit-Position: refs/heads/master@{#418483}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/72ed9eb5..0ea5d982

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2339063002
Cr-Commit-Position: refs/heads/master@{#418482}

BUG=621841
TEST=dbus_unittests
TBR=steel@chromium.org for device/bluetooth/dbus

Review-Url: https://codereview.chromium.org/2337893002
Cr-Commit-Position: refs/heads/master@{#418481}

Update recent QUIC flag changes.

Deprecate FLAGS_quic_limit_frame_gaps_in_buffer.

Merge internal change: 132467804
https://codereview.chromium.org/2341483002/

Deprecate flag FLAGS_quic_sequencer_buffer_retire_block_in_time.

Merge internal change: 132461150
https://codereview.chromium.org/2331343003/

Make DiversificationNonce a std::array

Changing a char[32] to a std::array<char, 32>.  No functional change
intended, not flag-protected

Merge internal change: 132456567
https://codereview.chromium.org/2340583002/

remove unused methods: num_early_frames_received() from the shared code which was used by chromium only.

Triggered by ref chromium cl: https://codereview.chromium.org/2250713004.

Merge internal change: 132449425
https://codereview.chromium.org/2337063004/

Use unique_ptrs to manage callback lifetimes in some QUIC code

Follow-up to cl/132102408.

This CL eliminates the self-deleting callback pattern from a chunk of
QUIC code and replaces it with explicit unique_ptr ownership of all
callbacks.

Replace self-deleting callbacks with unique_ptr owned callbacks in some
QUIC code.  No functional change intended, not flag-protected.

Merge internal change: 132439857
https://codereview.chromium.org/2339433004/

Simplify lifetime management of ValidateClientHelloResultCallback::Result objects

The lifetimes of ValidateClientHelloResultCallback::Result objects are
managed by bare new/delete.  These objects are also passed around by
pointer which gives no indication as to who is managing the lifetime,
and many methods are passed both a pointer to a Result object as w
ell as a reference to a sub-object.  This CL eliminates these patterns.

Migrating from bare pointers to unique_ptr in some quic codepaths.  No
functional change intended, not flag-protected.

Merge internal change: 132359769
https://codereview.chromium.org/2338013004/

Use the largest received packet instead of the most recently received packet to calculate the sequence number from.

Merge internal change: 132350039
https://codereview.chromium.org/2333153003/

Deprecate FLAGS_quic_close_stream_after_writing_queued_data

Merge internal change: 132335255
https://codereview.chromium.org/2338713003/

Deprecate FLAGS_quic_remove_obsolete_forward_secure.

Merge internal change: 132331281
https://codereview.chromium.org/2336803004/

Deprecate FLAGS_quic_change_alarms_efficiently.

Merge internal change: 132330925
https://codereview.chromium.org/2338013003/

deprecate FLAGS_quic_enable_app_limited_check

Merge internal change: 132318066
https://codereview.chromium.org/2340563002/

Review-Url: https://codereview.chromium.org/2334363002
Cr-Commit-Position: refs/heads/master@{#418480}

BUG=646683

Review-Url: https://codereview.chromium.org/2334243003
Cr-Commit-Position: refs/heads/master@{#418479}

Refactor disk_mount_manager_unittest by replacing gmock with a dedicated mock class of DiskMountManagerObserver.

This change is based on
https://codereview.chromium.org/2292473002/
which was once merged but reverted by
https://codereview.chromium.org/2340433002/

BUG=641943

Review-Url: https://codereview.chromium.org/2333983004
Cr-Commit-Position: refs/heads/master@{#418478}

DOMError is only used in quota, so may as well move it there
while waiting for the deprecated parts of quota to be removed.
This patch also removes unneeded DOMError includes.

BUG=460725

Review-Url: https://codereview.chromium.org/2335073003
Cr-Commit-Position: refs/heads/master@{#418477}

TBR=lazyboy@chromium.org
BUG=632548,636222,638621

Review-Url: https://codereview.chromium.org/2332313003
Cr-Commit-Position: refs/heads/master@{#418476}

Android’s InputConnection API specifies a way to commit (confirm) the
current composition and move the cursor at the same time:
https://developer.android.com/reference/android/view/inputmethod/
InputConnection.html#commitText(java.lang.CharSequence, int)

Currently, commitText doesn't conform to the documentation nor to
Android TextView's behavior when newCursorPosition is not 1.
newCursorPosition
is a relative value that depends on the location of the text being committed.

When |newCursorPosition| < 1, the cursor should move to the left of
the committing text by |newCursorPosition| characters. If the cursor
exceeds the left boundary, it will clamp to  the left boundary.

When |newCursorPosition| >= 1, the cursor will move to the right of
the committing text by |newCursorPosition - 1| characters. If the cursor
exceeds the right boundary, it will clamp to the right boundary.

(Rebased version of yabinh@'s http://crrev.com/1995333002 which received
lgt'ms from TBRed reviewers below, I'm landing this on his behalf.)

TBR=tkent,yosin,changwan,sievers,yabinh
NOTRY=true
BUG=570920

Review-Url: https://codereview.chromium.org/2339793002
Cr-Commit-Position: refs/heads/master@{#418475}

Cr-Commit-Position: refs/heads/master@{#418474}

It was causing an invalid cast and was the reason for
'CFI Linux Full' bot being red.

BUG=646615

Review-Url: https://codereview.chromium.org/2339563003
Cr-Commit-Position: refs/heads/master@{#418473}

This extends the time that WebMediaPlayerImpl::hasSingleSecurityOrigin()
returns true from "until the data source exists" to "until the data source is
initialized". I've verified (by source code inspection) that every existing
caller is safe with respect to races here. It seems to be an undocumented
rule followed by Blink developers.

BUG=638763

Review-Url: https://codereview.chromium.org/2341483003
Cr-Commit-Position: refs/heads/master@{#418472}

WebGLExtension, WebGLObject and WebGLRenderingContextBase are now declared non-copyable

BUG=613450
R=bajones@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2001503002
Cr-Commit-Position: refs/heads/master@{#418471}

BUG=587527

Review-Url: https://codereview.chromium.org/2343503002
Cr-Commit-Position: refs/heads/master@{#418470}

Cross-platform node.js script to automatically find Chrome Canary (in Mac and Windows)
and launch it with debug flags.

I've updated README which explains the workflow for users.

Workflow commands (from /devtools):
* npm start - starts Chrome and development server
* npm run chrome - starts Chrome browser
* npm run server - starts development server

BUG=629914

Review-Url: https://codereview.chromium.org/2337713002
Cr-Commit-Position: refs/heads/master@{#418469}

Bind the GpuServiceInternal request on the gpu thread, instead of in the
main thread. This means it is possible to service a request from the host
without thread hopping between the main and gpu threads.

BUG=643746

Committed: https://crrev.com/9894bae5c1e1f03ab2b14f7b2325296587002a58
Review-Url: https://codereview.chromium.org/2329043002
Cr-Original-Commit-Position: refs/heads/master@{#418275}
Cr-Commit-Position: refs/heads/master@{#418468}

BUG=561209

Review-Url: https://codereview.chromium.org/2274283003
Cr-Commit-Position: refs/heads/master@{#418467}

When I added it in this CL:
https://codereview.chromium.org/2325313002/

…it worked for 10.11 (coincidentally) but not for the 10.12 SDK.

BUG=642155

Review-Url: https://codereview.chromium.org/2339563004
Cr-Commit-Position: refs/heads/master@{#418466}

https://chromium.googlesource.com/skia.git/+log/21cc9950c4b4..7e3ba9f88d64

$ git log 21cc9950c..7e3ba9f88 --date=short --no-merges --format='%ad %ae %s'
2016-09-13 reed change write-image to use pipeverbs like everyone else, and add test

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2336043005
Cr-Commit-Position: refs/heads/master@{#418465}

Extract the text tapped on to use as a signal in Tap Suppression.
The text is extracted before any UX is displayed in order to allow the
tap to be totally ignored when appropriate.  Feeding the surrounding
text into the logic of TTS will be done separately.

This adds several files that are part of the 2016-refactoring.
See crbug.com/624609 and go/cs-refactoring-2016.

This CL is part of the refactoring-2016 effort, see go/cs-refactoring-2016
for details.

BUG=634136, 624609

Review-Url: https://codereview.chromium.org/2211353002
Cr-Commit-Position: refs/heads/master@{#418464}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1d2ebc4608d2..b86cfef4b9da

$ git log 1d2ebc460..b86cfef4b --date=short --no-merges --format='%ad %ae %s'
2016-09-13 nednguyen Revert of Revert "[telemetry] Wire TsProxy through telemetry's network stack." (patchset #1 id:1 of https://codereview.chromium.org/2267613002/ )
2016-09-13 benjhayden Fix value-set-table.

BUG=639632

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2340463003
Cr-Commit-Position: refs/heads/master@{#418463}

Revert "Reland of Check that all shared workers are terminated. (patchset #2 id:170001 of https://codereview.chromium.org/2254963002/ )"

This reverts commit d1109b15.

The crash rate is too high and polluting crash report data.
I'll reland it when the fix lands.

BUG=636377
TBR=jam

Review-Url: https://codereview.chromium.org/2338113002
Cr-Commit-Position: refs/heads/master@{#418462}

https://pdfium.googlesource.com/pdfium.git/+log/63f545c485c0..2ca2da505ba7

$ git log 63f545c48..2ca2da505 --date=short --no-merges --format='%ad %ae %s'
2016-09-13 dsinclair Sort include entries.
2016-09-13 tsepez Add check for trivial string equality
2016-09-13 tsepez Remove inner FX_DATETIME struct from CPDFSDK_DateTime

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2332383003
Cr-Commit-Position: refs/heads/master@{#418461}

Removes QUIC flag and code that shifts cubic epoch on quiescence, since it's buggy and should not be used.

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2335283002
Cr-Commit-Position: refs/heads/master@{#418460}

clang-cl make .o as an object file, which is also COFF format file.

BUG=439737

Review-Url: https://codereview.chromium.org/2337013002
Cr-Commit-Position: refs/heads/master@{#418459}

BUG=646443, 623700

Review-Url: https://codereview.chromium.org/2338893003
Cr-Commit-Position: refs/heads/master@{#418458}

Looks like unified logcat of the results causes exception on the bot.

BUG=angleproject:1471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2343493002
Cr-Commit-Position: refs/heads/master@{#418457}

PrinterSpecifics will sync Printer device information for Chrome OS.
This just adds the proto.  Actual syncing will follow.

BUG=616862
TEST=Unit tests pass.

Review-Url: https://codereview.chromium.org/2306763002
Cr-Commit-Position: refs/heads/master@{#418456}

Ninja complains with:
expected depfile 'foo.d' to mention 'bar', got 'baz'

Running ninja twice now reports "no work to do" again.

This change required updating all calls to build_utils.WriteDepFile() so
that the output is passed in. While doing this, I also made the helper
add in GetPythonDependencies() by default.

build/android/gyp/ant.py I just deleted rather than updating since it's
GYP-only.

BUG=646165

Review-Url: https://codereview.chromium.org/2336173003
Cr-Commit-Position: refs/heads/master@{#418455}

This adds an (i) button to top right of the page which, when clicked,
shows the 'Showing results from all your signed-in devices' message. The
message can be dismissed by clicking anywhere or pressing escape. It
will only show up for users with history sync enabled, on the main
history page.

BUG=622055
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2270993003
Cr-Commit-Position: refs/heads/master@{#418454}

Made ElementRareData store ComputedStyle on LayoutObject of it's base
class NodeRareDataBase if it has a LayoutObject.
Otherwise it is stored on the ComputedStyle member of ElementRareData.

The reason for this is to make it consistent with storage of
ComputedStyle on Node, which stores a union that can be one of:
1) a ComputedStyle
2) a LayoutObject (ComputedStyle can be stored on this)
3) a NodeRareData (LayoutObject can be stored on this which stores
ComputedStyle or if no LayoutObject ComputedStyle can be stored
directly on ElementRareData)

This patch encapsulates the logic of where to store the ComputedStyle
on the ElementRareData so that it doesn't need to be done at the call
site (e.g. in new method Node::setComputedStyle from
https://codereview.chromium.org/2001453002)

The clearComputedStyle method is special and only clears the
ComputedStyle member as its current use is not intended to clear a
LayoutObject's ComputedStyle.

BUG=595137

Review-Url: https://codereview.chromium.org/2293713002
Cr-Commit-Position: refs/heads/master@{#418453}

The prefix is redundant with the class name. TYPE_ cannot be stripped
because the members like "2G" wouldn't be a proper identifier.

BUG=629299
R=xunjieli

Review-Url: https://codereview.chromium.org/2341443002
Cr-Commit-Position: refs/heads/master@{#418452}

The filter fix temporarily uses the slow path before we have full
support of filter in paint property tree.

Test: run-webkit-tests --additional-driver-flag=--enable-blink-features=slimmingPaintInvalidation paint/invalidation
Ran 838 tests. 2 crashes, 99 failures. (55 less failures/crashes than
https://codereview.chromium.org/2334113002/).

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2332353003
Cr-Commit-Position: refs/heads/master@{#418451}

Reverted by:
https://codereview.chromium.org/2340673002/

Reason for reland:
Now gn gens for enable_resource_whitelist_generation = true

Main motivation for this is to more easily add per-target
repack_whitelist.

TBR=michaelbai@chromium.org,thakis@chromium.org,sdefresne@chromium.org,estevenson@chromium.org,rsesek@chromium.org,brettw@chromium.org
BUG=645716

Review-Url: https://codereview.chromium.org/2339783002
Cr-Commit-Position: refs/heads/master@{#418450}

BUG=640996

Review-Url: https://codereview.chromium.org/2337343002
Cr-Commit-Position: refs/heads/master@{#418449}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/bde91cb96f13..1d2ebc4608d2

$ git log bde91cb96..1d2ebc460 --date=short --no-merges --format='%ad %ae %s'
2016-09-13 benjhayden Fix metrics-side-panel

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2339603003
Cr-Commit-Position: refs/heads/master@{#418448}

BUG=643016
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2307703002
Cr-Commit-Position: refs/heads/master@{#418447}