- 25 Jun, 2019 40 commits
-
-
Lucas Tenório authored
Bug: 977566 Change-Id: I697e026c9b2574b7d4e5b8491709b98da5919525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673018 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#672054}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96f6f7f65b3c..cc84ea1d6c32 git log 96f6f7f65b3c..cc84ea1d6c32 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 borenet@google.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/skia@cc84ea1d6c32 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@google.com Change-Id: Iefe845301ed6153bc3583941043738b1dd387bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676070Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672053}
-
Allen Robinson authored
Bug: 934451 Change-Id: I62b2969964b1f38d1e066f842ef5635286dcea27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671407Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Allen Robinson <arobins@chromium.org> Auto-Submit: Allen Robinson <arobins@chromium.org> Cr-Commit-Position: refs/heads/master@{#672052}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/90c6d1bdc321..2308bb223ef2 git log 90c6d1bdc321..2308bb223ef2 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 mbonadei@webrtc.org Switch rgba_to_i420_converter to ABSL_FLAG. 2019-06-25 mbonadei@webrtc.org Reland "Switch frame_analyzer to ABSL_FLAG." Created with: gclient setdep -r src/third_party/webrtc@2308bb223ef2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2e0d07842fbe833629404d6f1398c78018626260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676224Reviewed-by:
-
Christian Dullweber authored
When third party cookies are managed by enterprise policy, the cookie controls preference needs to be forced to be disabled. Bug: 967668 Change-Id: I68a78d083157c63fa9cfe088b097c73f9f3f1ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658156 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#672050}
-
Alexander Griboedov authored
NonMainThreadTaskQueue holds ptr of the voter. Task voter in its turn holds refptr of TaskQueue it was created by. This results in a leak of the both instances. According to other usages of the voter, its ptr should be held by owner of the task queue. As a result, voter ptr and setPaused method is moved to a shared owner. Change-Id: I055bb82db2c1906eb3fd4c5c3329484f07f3b09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670870 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#672049}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/994a35dedd23..dcd49b01615f git log 994a35dedd23..dcd49b01615f --date=short --no-merges --format='%ad %ae %s' 2019-06-25 ilkos@google.com Merge "Add pprof to headers" 2019-06-25 treehugger-gerrit@google.com Merge "Remove unneeded code." Created with: gclient setdep -r src/third_party/perfetto@dcd49b01615f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I2f9f345296f7c2b285361c7c53f73d3db9d92e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676071Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/67ad8746..0f67ee5f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8d41b61e09b4d2d284a3a9e62999b132bb2f805d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675365Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672047}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c1090f3e3087..45f99e2caaf7 Created with: gclient setdep -r src-internal@45f99e2caaf7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=reillyg@google.com,yhirano@google.com,futhark@google.com Change-Id: I45bb7176f663b3b88adaf33a8949ff20b4166f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676069Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672046}
-
Rune Lillesveen authored
TBR=vakh@chromium.org Bug: 978405 Change-Id: Ie54327a833a55add5ee6882ce2ae2d93eb0a8ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675670Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#672045}
-
W. James MacLean authored
It appears that AccessibilityMsg_HitTest is no longer used, having been replaced by calling AccessibilityMsg_PerformAction with an action of Action::kHitTest. Bug: 977381 Change-Id: I888cb1767ab5a3fb85e6fdb17f895cee25e87b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674344Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#672044}
-
BUG=762641 TBR=alemate@google.com Change-Id: I29bbb5a57e8aad4b2123c851cd59788599328d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676084Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672043}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib39f168b97b50190303f1f8022bc8325063d8905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676068Reviewed-by:
-
Wei Lee authored
This CL fills android.sensor.timestamp field for reprocess request. Bug: None Test: cros_camera_service \ --metadata_inspector_output=/dev/stdout \ --metadata_inspector_whitelist='timestamp' Change-Id: Id23890e7752dd51374801048185ddf059dc8e5b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652753Reviewed-by:Ricky Liang <jcliang@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#672041}
-
Benoît Lizé authored
It is not necessary to kill the entire process group to dump it, and it is not required to ptrace() it. Fix the first one, and document why ptrace() may still be useful. Reported by bgeffon@google.com. Bug: 845459 Change-Id: I9f08e7208cfcfdec00bcaf80f83c585f1d4ea195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675649Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#672040}
-
Tanmoy Mollik authored
Sync and Signin files in preferences directory currently does not have an owner. We want to move these files to a dedicated folder for sync so that reviewers have a better context about cls. Bug: 928406 Change-Id: I8137dfbf3f2861ad8507bd1f6843c616e3ab1201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657900Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#672039}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2923d768f010..90c6d1bdc321 git log 2923d768f010..90c6d1bdc321 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 mbonadei@webrtc.org Revert "Switch frame_analyzer to ABSL_FLAG." Created with: gclient setdep -r src/third_party/webrtc@90c6d1bdc321 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I11bdeae8ccc63e6801a1722cba9207bb18fd8236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675474Reviewed-by:
-
Pâris MEULEMAN authored
This is a reland of bfe02993 This was reverted in https://crrev.com/c/1674250 following conflict with https://crrev.com/c/1673453 PS2 fixes that. Original change's description: > Create ChromeSigninManagerDelegate JNI > > This introduces the Jni counterpart of the java > ChromeSigninManagerDelegate. This interface will provide access to android > specific dependencies on //chrome/browser to the componentized java > SigninManager. > > This first iteration creates the new objects and implements > stopApplyingCloudPolicy, fetchAndApplyCloudPolicy, isAccountManaged and > getManagementDomain. > > As discussed in CLs on the java counterpart (bug 963400) this object > will hold pointers to singletons such as the ActiveUserProfile. > The native object is created by the java object. > > details in document: > https://docs.google.com/document/d/18887XeZNJ9pmoTdJducssk5_yVU2CQ3EqaRFoMqWCCk/ > > Bug: 963402 > Change-Id: Iccbb6b30d23f26fc5960b5d9db9c122df3e589f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642547 > Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671684} Bug: 963402 Change-Id: Ie0f03bb07e722ef2858a5eaee427c7620e4c157f TBR: tedchoc@chromium.org, sdefresne@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675426 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8db999ee35ff..bd9775167ba8 git log 8db999ee35ff..bd9775167ba8 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 perezju@chromium.org [dashboard] Update doc on dashboard data formats Created with: gclient setdep -r src/third_party/catapult@bd9775167ba8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:976257 TBR=zhanliang@google.com Change-Id: I17f813461effa56c88eca7eb8ee34a136259b245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676064Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/967947db0661..994a35dedd23 git log 967947db0661..994a35dedd23 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 chiur@google.com Add trace processor for GpuCounterEvent Created with: gclient setdep -r src/third_party/perfetto@994a35dedd23 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I451dd1e3b401f5c71efc456330001d2bd76593e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676066Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e9f36981. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 845a980a "KV Storage: add timeout=long and reenable disabled test" 74cc6972 "[Navigation Timing] secureConnectionStart should be non-zero" 73b57b36 "Add sec-metadata test when updating a service worker" 58b8718f "KV Storage: update to match IDL" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I6e4ea8ed8ca23959b5714002c0de798a122b12a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675227Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672034}
-
Roman Aleksandrov authored
Move recommended timer to the desktop build because its usage in Chrome OS was deleted. Update comments. Bug: 963883 Change-Id: I05ece8ac88d5209b812f6a27bd72e69b96052705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674545 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#672033}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cf17e9d9c020..c1090f3e3087 Created with: gclient setdep -r src-internal@c1090f3e3087 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=reillyg@google.com,yhirano@google.com,futhark@google.com Change-Id: Id4805c87850eaa40d6b132731ea0d6ff74094896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675728Reviewed-by:
-
Lutz Justen authored
Stores the active Kerberos account in a user pref variable. Restores Kerberos credentials on startup. In case there is no KerberosAccounts policy and the daemon still sleeps, the call to restore credentials also wakes it up, which might trigger an update of credentials. BUG=chromium:952244 TEST=Manually tested on device Change-Id: I08d0fc84646313851db5325ae59c7654416a5a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660856 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#672031}
-
Shik Chen authored
Bug: chromium:978278, b:135894873 Test: Passes CameraDeviceDelegateTest.StopBeforeOpened 100 times in a row. Change-Id: I83fed9f89580aefca4501c2030bbeec2814e246b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675354Reviewed-by:
-
Richard Knoll authored
This removes the final keyword before parsing the annotations to support the following (valid) method signatures: @CalledByNative void Foo(final @Bar int value); @CalledByNative void Foo(@Bar final int value); @CalledByNative void Foo(@Bar final @Baz int value); Bug: 977593 Change-Id: I7ef87dc7c16353ab74bf7cca533bc893dbebe7fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670891Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#672029}
-
Mugdha Lakhani authored
This adds a BackgroundTaskScheduler task to wake up Chrome to process Periodic Background Sync registrations. The logic to actually schedule this task will be added in follow-up CLs. Bug: 925297 Change-Id: Id8a3b8804b2b6f66bbb206832318fada8bffc3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663495 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#672028}
-
Yuta Kitamura authored
crrev.com/c/1648311 added the code that associates Document's microtask queue to LocalWindowProxy. However, this seems premature since we're not ready to run context-associated microtask queues yet. The change had little effect, though, because the changed code path was rarely executed (we usually create V8 context from snapshot). We'll make this change again when we are ready to use proper microtask queues in Blink. Bug: 961186 Change-Id: I2820f15c59c602ca503ff9ef35f3162f0f71dd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675644Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#672027}
-
Yutaka Hirano authored
system_health.memory_desktop/browse:news:flipboard:2018 Bug: 978358 Change-Id: Id9328fb1d053f6284b5ed5c05cbf41764d877017 Tbr: perezju@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675687 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#672026}
-
Alex Ilin authored
This CL removes two more values from GoogleServiceAuthError::State enum that are no longer used based on UMA stats. Enum values being removed: - ACCOUNT_DELETED - ACCOUNT_DISABLED Bug: 956567 Change-Id: I1aaa2c342ed9a89574bd1031949d2147574d4faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655533Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#672025}
-
Raphael Kubo da Costa authored
Follow-up to commit a572c15d ("Report the latency increase of pipeline stages in missed frames compared to not missed frames"), which ended up reverting commit aeed4d1f ("libstdc++: do not assume unique_ptr has ostream operator"). A call that looks like DCHECK_NE(foo, nullptr); where |foo| is a std::unique_ptr fails with libstdc++ because there is no operator<< overload for std::unique_ptr until C++20 (libc++ just happens to have it): ../../cc/scheduler/compositor_frame_reporting_controller.cc:60:3: error: no matching function for call to 'MakeCheckOpValueString' DCHECK_NE(reporters_[PipelineStage::kBeginMainFrame], ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../base/logging.h:851:31: note: expanded from macro 'DCHECK_NE' ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../base/logging.h:822:29: note: expanded from macro 'DCHECK_OP' EAT_STREAM_PARAMETERS << (::logging::MakeCheckOpValueString( \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../base/logging.h:635:18: note: candidate function not viable: no known conversion from 'std::unique_ptr<CompositorFrameReporter>' to 'std::nullptr_t' (aka 'nullptr_t') for 2nd argument BASE_EXPORT void MakeCheckOpValueString(std::ostream* os, std::nullptr_t p); ^ ../../base/logging.h:596:1: note: candidate template ignored: requirement 'base::internal::SupportsOstreamOperator<const unique_ptr<CompositorFrameReporter, default_delete<CompositorFrameReporter> > &>::value' was not satisfied [with T = std::unique_ptr<cc::CompositorFrameReporter, std::default_delete<cc::CompositorFrameReporter> >] MakeCheckOpValueString(std::ostream* os, const T& v) { ^ ../../base/logging.h:606:1: note: candidate template ignored: requirement 'base::internal::SupportsToString<const unique_ptr<CompositorFrameReporter, default_delete<CompositorFrameReporter> > &>::value' was not satisfied [with T = std::unique_ptr<cc::CompositorFrameReporter, std::default_delete<cc::CompositorFrameReporter> >] MakeCheckOpValueString(std::ostream* os, const T& v) { ^ ../../base/logging.h:619:1: note: candidate template ignored: requirement 'std::is_function<typename std::remove_pointer<unique_ptr<CompositorFrameReporter, default_delete<CompositorFrameReporter> > >::type>::value' was not satisfied [with T = std::unique_ptr<cc::CompositorFrameReporter, std::default_delete<cc::CompositorFrameReporter> >] MakeCheckOpValueString(std::ostream* os, const T& v) { ^ ../../base/logging.h:630:1: note: candidate template ignored: requirement 'std::is_enum<unique_ptr<CompositorFrameReporter, default_delete<CompositorFrameReporter> > >::value' was not satisfied [with T = std::unique_ptr<cc::CompositorFrameReporter, std::default_delete<cc::CompositorFrameReporter> >] MakeCheckOpValueString(std::ostream* os, const T& v) { ^ Bug: 957519 Change-Id: Icbc23eb23b4641a64dfeb00d27ea1d393dda232a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672860 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#672024}
-
Tsuyoshi Horo authored
Even if the SecurityStyle is Authenticated, SecurityDetails is not set while loading "chrome://" URL resources. In that case, checking SecurityStyle in inspector_network_agent.cc is not sufficient. Thic CL changes ResourceResponse::security_details_ to use base::Optional. So, we can check whether SecurityDetails is set or not. Bug: 976192 Change-Id: Iae112de8121ed4e6a95bbb9aacd93a27623ffefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675466 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Add an observer class that allows other components of Chrome to know when a signature is successfully generated via the chrome.certificateProvider API. This will be used in follow-up CLs for implementing the smart card based user login feature: this observer will be used to detect the fact of the smart card being used during the sign-in, and to obtain the actual certificate blob. Bug: 826417 Test: unit_tests --gtest_filter=*CertificateProvider* Change-Id: I745463a470d1c697682c5d76da17b52a40a24cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666628 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
TBR=pkasting@chromium.org Bug: 976791 Change-Id: I1fade73275eb19cee8341d87015489bae6030c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675350Reviewed-by:
-
Mugdha Lakhani authored
Change-Id: Idfb261ee92614c3c746066e2ed0c310a2a151fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675352Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#672020}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ca0e0f9c. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 845a980a "KV Storage: add timeout=long and reenable disabled test" 74cc6972 "[Navigation Timing] secureConnectionStart should be non-zero" 73b57b36 "Add sec-metadata test when updating a service worker" 58b8718f "KV Storage: update to match IDL" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jsbell@chromium.org: external/wpt/IndexedDB meade@chromium.org: external/wpt/web-animations mstensho@chromium.org: external/wpt/css/css-multicol rego@igalia.com: external/wpt/css/css-grid skobes@chromium.org: external/wpt/css/css-scroll-anchoring NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ie5a6bba9f8b442ab860c61922468b7a8ea38601e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675277Reviewed-by:
-
Rune Lillesveen authored
TBR=pkasting@chromium.org Bug: 976927 Change-Id: I3bd2b5f344f49186ce8c94f1000e69e9137b01c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675805Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d3a6eb96..67ad8746 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I46f16f2c0e1b22a1290db550abd4957e63a493c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675585Reviewed-by:
-
Dominic Battre authored
This CL introduces a sequence of metrics representing the autofill funnel as well as a set of key feature metrics to judge the success of autofill. These together are intended to serve as a long term set of metrics to guide our feature development. This CL has a major effect on the existing Autofill.FormEvents.Address.* metrics: In the past, everything that was not a credit card, was considered an address form (i.e. also password forms). This changes with this CL. Only forms that contain an address field are considered an address form. Bug: 966475 Change-Id: Ifb3f64a16988ed7939e76cad2dd3b58aad64d9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628607 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#672016}
-
Matthew Cary authored
ProcessMitigationsWin32KDispatcher uses a raw handle to open a shared memory region containing certificate data. This CL uses the new shared memory region API to open region. In keeping with current semantics, it is opened writable. This should introduce no functional change. Bug: 795291 Change-Id: I1d7bdeb0220a1deaaff8c65e9bc0e457df78057b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657897Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#672015}
-
