- 03 Mar, 2018 23 commits
-
-
Wez authored
The Shutdown() API was added to RenderProcessHost with parameters reflecting those of the underlying base::Process::Terminate() API, which include a synchronous |wait| option. We never use Shutdown(.., wait=true) in production code, and in tests we can instead use a RenderProcessHostObserver to wait for a process to crash or exit, so we can remove the |wait| parameter and simplify both callers and the implementation. Bug: 806451 Change-Id: I2aeae32a3d20488b4970cf96959eaa287642b7ed Reviewed-on: https://chromium-review.googlesource.com/936450 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#540713}
-
Andrii Shyshkalov authored
R=jchinlee No-Try: True Bug: 731545 Change-Id: I4655d2aaa1f78ff350336743b19627bd4cfc1e2d Reviewed-on: https://chromium-review.googlesource.com/947572 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#540712}
-
Fan Yang authored
In QUIC, replace ack_frame with largest_acked and ack_delay_time in QuicSentPacketManager::MaybeUpdateRTT. No functional change expected. Merge internal change: 187224206 R=rch@chromium.org Change-Id: Ibdae257e3b57c85a828f14a2e97df7869eade34a Reviewed-on: https://chromium-review.googlesource.com/946268Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#540711}
-
https://chromium.googlesource.com/angle/angle.git/+log/888081d59aae..b27b03a2c9ea $ git log 888081d59..b27b03a2c --date=short --no-merges --format='%ad %ae %s' 2018-02-19 lfy GLES1: caps: GLES1-specific context limits 2018-02-26 xinghua.cao ES31: Implement memoryBarrier on D3D backend 2018-02-28 jmadill Rename signal utils to Observer. 2018-02-27 jiawei.shao ES31: Add link validations on geometry shader uniforms Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I80cd4b6ae98bd0f4490701c5c8b762a2a7dd8355 Reviewed-on: https://chromium-review.googlesource.com/946884Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540710}
-
Alex Moshchuk authored
After this CL, certain cross-site, main frame, browser-initiated navigations will use a new BrowsingInstance. This includes navigations initiated from the address bar (typing in the URL or searching) and bookmarks. Note that this works even if the navigated frame has an opener, since these user-initiated navigations indicate that it's ok to break the opener relationship. This change helps avoid unneeded process sharing. For example, after being on a A-embed-B page, any future browser-initiated navigation to B would've stayed in the same BrowsingInstance, SiteInstance, and process as the B subframe on the old page, and if the subframe reused another tab's process due OOPIF process reuse policy, this resulted in both tabs unnecessarily ending up in that process. Bug: 803367 Change-Id: I3a2461a67cb626329c20a887f993d4c9a1494236 Reviewed-on: https://chromium-review.googlesource.com/881836 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540709}
-
agrieve authored
This reverts commit f0d1cf1e. Reason for revert: Breaking bots with: C 1086.301s Main [FAIL] org.chromium.chrome.browser.offlinepages.OfflinePageApiFunctionTest#testError: C 1086.301s Main java.lang.VerifyError: org/chromium/chrome/browser/ClassRegister C 1086.301s Main at org.chromium.chrome.browser.init.ChromeBrowserInitializer.onStartNativeInitialization(ChromeBrowserInitializer.java:381) Original change's description: > [Android] Pass SurfaceView to HandleObserver for Chrome. > > Since Chrome uses SurfaceView for compositing, we will get nothing from > the ContentView passed to |SelectionPopupController| in > |HandleObserver|. > > In this CL, we are passing SurfaceView to HandleObserver from > |CompositorViewHolder| through |WindowAndroid| if it's Chrome's case. > > Bug: 805531 > Change-Id: I7dbf1bd16387eec76dc69031037530b3cb00e753 > Reviewed-on: https://chromium-review.googlesource.com/923021 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Commit-Queue: Shimi Zhang <ctzsm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540675} TBR=mthiesse@chromium.org,boliu@chromium.org,dtrainor@chromium.org,yusufo@chromium.org,changwan@chromium.org,ctzsm@chromium.org Change-Id: Ia7a183e28b05e5dd2f2156fcd3b956e8986686dc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 805531, 818370 Reviewed-on: https://chromium-review.googlesource.com/947602Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#540708}
-
Matt Wolenetz authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/9ca66eafaf6f..ef99a5d2520f $ git log 9ca66eafa..ef99a5d25 --date=short --no-merges --format='%ad %ae %s' 2018-03-02 wolenetz ffmpeg: Initialize a potential gap in ctts_data in mov_build_index 2018-02-26 dalecurtis Revert "Change the way the ffmpeg_branding gets its defaults." Created with: roll-dep src/third_party/ffmpeg BUG=816787,570754,795935 Change-Id: I44bcdd293b786cdc4e754f81e82695578b0ba6c3 Reviewed-on: https://chromium-review.googlesource.com/947386Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#540707}
-
Xianzhu Wang authored
Now we always report the following metrics: - paint_op_memory_usage: Total memory used by cc::DisplayItemList - painter_memory_usage: Total memory used by blink::PaintController. - paint_op_count: total op count of cc::DisplayItemList. This is useful to evaluate efficency of PaintChunksToCcLayer. Removed total_size_of_pictures_in_piles which didn't look useful. (paint_op_memory_usage + painter_memory_usage) seems the better metric for total memory usage. R=vmpstr@chromium.org TBR=# passive changes and cleanups under tools/perf/measurements Bug: 803867 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I64a0fce5ef83d3d9812f0c9446989ffa1b700968 Reviewed-on: https://chromium-review.googlesource.com/944421 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#540706}
-
Andrii Shyshkalov authored
R=jchinlee Bug: 731545 Change-Id: Ieeb3df10e3649063679cf66a8b9231813714b34b No-Try: True Reviewed-on: https://chromium-review.googlesource.com/947566 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Update chrome/test/data/extensions/permissions_increase/* to manifest v2. This required changing background_page to background. Bug: 816679 Change-Id: I99afd26749acf1c7d8bf9b737200370de5324ba5 Reviewed-on: https://chromium-review.googlesource.com/946549Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540704}
-
Bailey Forrest authored
BUG=b/74038945 TEST=Manual Change-Id: Ia61729fa620e90ae6147ca426e433b78dd48c32e Reviewed-on: https://chromium-review.googlesource.com/947032Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#540703}
-
Andrii Shyshkalov authored
Also, stop experimenting with mac_chromium_dbg_ng. R=jchinlee Bug: 731545, 731476 No-Try: True Change-Id: I89d3b7eb95f4ec76909101e802f70d2627cf4602 Reviewed-on: https://chromium-review.googlesource.com/947469Reviewed-by:
-
Eugene But authored
Install button is shown if download is sucessfully completed and Google Drive app is not installed. UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2eee39b982_0_0 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib884a37a54ac77e22ff30c8c22a3cfaa530343f0 Reviewed-on: https://chromium-review.googlesource.com/938497 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#540701}
-
John Abd-El-Malek authored
Bug: 787614 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib78db05aabb5502977a8b08e2aee72a8481ca572 Reviewed-on: https://chromium-review.googlesource.com/946851Reviewed-by:
Chong Zhang <chongz@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#540700}
-
James Hawkins authored
Bug: none Test: none Change-Id: I8a53e499f6c574b82f617092d91daa8fbfa3e2c7 Reviewed-on: https://chromium-review.googlesource.com/947322Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#540699}
-
Avi Drissman authored
This moves the various parts of the speech code to be frame- attached rather than view attached. It also moves responsibility for observing the lifetimes of the various page objects from the Chrome delegate to the manager itself. This is a resurrection of the CLs: Part 1: https://codereview.chromium.org/636863002/ Part 2: https://codereview.chromium.org/636863003/ Part 3: https://codereview.chromium.org/752303003/ and has additional changes. BUG=390749 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib85fd652d88ae9dc7ba1295eb23932dc1e8250fc Reviewed-on: https://chromium-review.googlesource.com/919309 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#540698}
-
Joshua Bell authored
Ensure coverage for these cases: * API exposure in a Dedicated Worker, inheriting the OT token from the page. * API exposure in a Service Worker, OT token served via PHP header. * API exposure in a Service Worker, no OT token. It ensures the feature is not available in the virtual test suite for origin trials that disables experimental features, and is skipped otherwise. Also, add a basic Service Worker interface test with the other locks tests as well. Bug: 161072,804548 Change-Id: I2ec5ae5c7c0a5a7e72978c08e06368cf760eb92e Reviewed-on: https://chromium-review.googlesource.com/944787 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#540697}
-
Scott Violet authored
This finishes components. Targets go from foo_features to foo_buildflags And similarly the header now has buildflags in the name. BUG=814485 TEST=covered by build TBR=dcheng@chromium.org Change-Id: I109f65c850229fc381ee70db2a6075f7fea05f31 Reviewed-on: https://chromium-review.googlesource.com/946519 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Yusuf Ozuysal authored
For cases where the experiment is enabled, don't create new child tabs if there are already tabs with the same urls. This avoid opening unnecessary tabs. BUG=814533 Change-Id: I76ed8d6e64049d76bfbd810169fb17ffe870f1ff Reviewed-on: https://chromium-review.googlesource.com/946894 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#540695}
-
David Bokan authored
This patch fixes compositor-touch-hit-rects-fullscreen-video-controls when run with root layer scrolls. This test was added for crbug.com/372314. An explanation of that is helpful to understand the fix here: When Blink calculates the touch event handler rects it has a special optimization when the document has a handler. In that case, it doesn't bother checking anything else and places a content- sized rect onto the document layer. However, in the case of an Android fullscreen video, the compositor detaches the document layer hierarchy and attaches the video and its controls. Because of the optimization above, the compositor doesn't bother calculating touch handler rects on these new layers, but because the document layer is detached it seems as though there aren't any touch handler regions at all. The fix in that bug was to disable the optimization when a fullscreen video overlay is active to force computing rects from the media control layers. This test uses Internals::touchEventTargetLayerRects to calculate the rects on the layer tree. This method uses PaintLayerCompositor::RootGraphicsLayer as its starting point. Pre-RLS, this would be the overflow controls host layer in the PLC. This was ok because the document layer was connected to it's descendants and disconnected when an overlay video was attached. With RLS, RootGraphicsLayer returns explicitly the graphics layer for the LayoutView which may not be attached at all. Thus the test was seeing that a handler still existed on the document because that's where it would start its search. The fix is to start the search from the painting root which is above the PaintLayerCompositor and thus, wont descend into the detached document layer. I don't think this test is a good guard against the regression. Since the document layer is detached we don't actually check that we correctly calculate the touch rects on the video controls. It appears that they've since been modified to not require touch handlers and the expectation reflects that. As such, this test can't tell the difference between the controls not having touch handlers and Blink failing to calculate touch handler rects. I've filed https://crbug.com/818330 for this problem. Bug: 816957 Change-Id: I088f960edb47af2d6d539e50a21b7e39067efb5f Reviewed-on: https://chromium-review.googlesource.com/947052Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#540694}
-
Eric Roman authored
Adds NetLog instrumentation for how the network adapter list was read on Windows: * The enumerated network adapters * How long it took to schedule the task to worker thread * How long it took to schedule the reply task to origin thread * How long it took to query the adapters * Which "adapter fetcher" won the overall race for WPAD Subsequent CLS will add more logging for the individual "adapter fetchers". TBR=stevenjb@chromium.org Bug: 770201 Change-Id: I9f704614e4a991e9a56879fc81637d41782dce1f Reviewed-on: https://chromium-review.googlesource.com/876921 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#540693}
-
Vladimir Levin authored
This patch ensures that if we remove a child frame's graphics layer from its parent, that we reattach its (possibly new) root graphics layer back to the parent it had before. The parent does not change during this, because we're in a stack processing the child frame, and the parent would reference the parent frame that is currently paused. This mimics pre-RLS code path where the child frame always had a parent accessible directly from the compositor (ie root_content_layer_), except here we save off whatever we were attached to already. R=chrishtr@chromium.org, skobes@chromium.org, pdr@chromium.org Bug: 815121 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9e63d2d513df24eaa13a30ee36582b5c807f4aff Reviewed-on: https://chromium-review.googlesource.com/946566 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#540692}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d5002715..e1de5c82 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I815c21c9c5938ae9a33ee872f3c6ed6fb488aee4 Reviewed-on: https://chromium-review.googlesource.com/946270Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#540691}
-
- 02 Mar, 2018 17 commits
-
-
Benjamin Shaya authored
Loading the on-device cast_audio.json with test flags results in a crash in CTOR. Move the CHECK until Start(). Bug: b/72821844 Test: cast_audio_backend_unittests Change-Id: I33bd1f5357e4e81c1053e15e4bdd7f61ac7610fe Reviewed-on: https://chromium-review.googlesource.com/936047 Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#540690}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/8df8e64205d0f8334ee4d403306bfcd4287004b0..f8058d41147543d6ad9a5ae5d70e7d19198bbe33 BUG=none Change-Id: Ibea6ba7dbaab1d5564f2f2d24b67f0a9fcc936d8 Reviewed-on: https://chromium-review.googlesource.com/946949 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#540689}
-
Scott Violet authored
BUG=714018 TEST=none Change-Id: Ia0dadc31d6713b3df042d5f434bfa2165146b072 Reviewed-on: https://chromium-review.googlesource.com/946855Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#540688}
-
Chris Harrelson authored
Squashed layers determine their position within the squashing layer backing by trampolining through their transformed ancestor. Currently the scroll offset of this ancestor is included (including for the LayoutView if RLS is on), but this is not necessary, as the offsets up and down the layout tree cancel each other. This change should not have any user-visible or bugfix impact by itself, but will unblock no longer updating compositing state on root scroll. Also changed callsites to all use the pre-computed TransformAncestor method rather than a PaintLayer tree walk. Bug:814615 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5b59333f8ae33123a6f74f83ce0c7d0cc78f33fc Reviewed-on: https://chromium-review.googlesource.com/946560Reviewed-by:
-
Francois Doray authored
We will sum the values in each of the 3 histograms for a given time interval to determine what percentage of the time is spent in each visibility state. That will help us assess the importance of reducing resource consumption in hidden and occluded tabs. Bug: 668690 Change-Id: I18d3f5c93de105fda83ae6d362f4677ed86a5937 Reviewed-on: https://chromium-review.googlesource.com/946673 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#540686}
-
Mike Wittman authored
Execution profiles of the IO thread in the browser and GPU processes is in place. This change extends profiling to the IO thread in the renderer process. Bug: 795672 Change-Id: I11a79822713486ae4f26b34fe733121164322655 Reviewed-on: https://chromium-review.googlesource.com/946648Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540685}
-
Jun Cai authored
This CL renames ResourceDispatcherHostLoginDelegate to LoginDelegate since it is not only used for ResourceDispatcherHost. Bug: 809819, 783990 Change-Id: If07153ffa903c754f0ea5198745a560b266829ad Reviewed-on: https://chromium-review.googlesource.com/907319 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
-
Antoine Labour authored
Includes the following commit: 92521a7 Update GLDEBUGPROCARB to the latest spec version Bug: 788949 Change-Id: I89e981718b42e375db7c2d4eb236643631d80c44 Reviewed-on: https://chromium-review.googlesource.com/946903Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540683}
-
CrystalFaith authored
This article serves as a central location for steps developers should take to keep user information private. Bug: Change-Id: I4236b7eb1ef05d8bfcb0a35e249dc1fdcfab8f6b Reviewed-on: https://chromium-review.googlesource.com/818447 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
-
Dan Harrington authored
Change-Id: I0ee9ca1b2bd652c4a2de9fd65ba9ee2eb8d1da1c Bug: 778813 Reviewed-on: https://chromium-review.googlesource.com/946449 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#540681}
-
CrystalFaith authored
This document updates the current OAuth Tutorial. It specifies OAuth2 with Google and the Identity API. Example extension will connect will request access to user's contacts then display contact photos in a div. Bug: 486948, 306867, 127559, 126010 Change-Id: Iba3efd91ef894064398921d6bcc538e04e366398 Reviewed-on: https://chromium-review.googlesource.com/865459 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
-
Christian Fremerey authored
Also rename and struct_traits -> mojom_traits therein. As per updated naming conventions. See https://bugs.chromium.org/p/chromium/issues/detail?id=806965 TBR=jam@chromium.org Bug: 806965 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ice0b7599f1a2232d89ce7df389d091e8878df2df Reviewed-on: https://chromium-review.googlesource.com/922452Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#540679}
-
Thomas Anderson authored
This reverts commit 46b3460f. Reason for revert: Broke Google Chrome Win build: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/27650 Original change's description: > Detect application removal for the Incompatible Applications subpage > > This change adds a class to detect when a registry key is deleted, > meaning that the associated application was deleted. > > The javascript receives the event via a Web UI callback and removes > the application from the list. > > Also added a section that indicates to the user that there isn't any > applications in the list. > > Finally fixed ThirdPartyConflictsManager to wait until the > ModuleDatabase is idle before initializing the InstalledPrograms > instance. > > Bug: 717696 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I8cf6ea948d63dd38fe6bae9969f103b5b22ab513 > Reviewed-on: https://chromium-review.googlesource.com/942375 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540670} TBR=dpapad@chromium.org,pmonette@chromium.org,grt@chromium.org Change-Id: If224020b66a87a05b7373eb28810ca16b5c34247 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 717696 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/947231Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#540678}
-
Reilly Grant authored
These tests should pass now that WPD is installed on the Win10 GCE bots. Bug: 756986 Change-Id: Ic6f89ac9f7e30c9a0dfb2207b60d5534094c5d7d Reviewed-on: https://chromium-review.googlesource.com/922904Reviewed-by:
smut <smut@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Eric Seckler authored
Adds a command line flag that disables resetting image animations to their beginning to avoid skipping frames. This is needed to make image animations work correctly with virtual time progression for headless's deterministic rendering mode. Bug: 646774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I3f39352950ca7608f6cb6dd20267fac0e57ee774 Reviewed-on: https://chromium-review.googlesource.com/946372Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#540676}
-
Shimi Zhang authored
Since Chrome uses SurfaceView for compositing, we will get nothing from the ContentView passed to |SelectionPopupController| in |HandleObserver|. In this CL, we are passing SurfaceView to HandleObserver from |CompositorViewHolder| through |WindowAndroid| if it's Chrome's case. Bug: 805531 Change-Id: I7dbf1bd16387eec76dc69031037530b3cb00e753 Reviewed-on: https://chromium-review.googlesource.com/923021Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#540675}
-
Candice Sy authored
When Downloads Home is first launched, DownloadUIAdapter retrieves offline page requests from the request queue store via RequestCoordinator. PendingState, which is not saved in the store, must be added to the request before it is shown on the UI. Bug: 818262 Change-Id: I9237b5f6e8fada835c8b120a74c81fdb3fe4a29b Reviewed-on: https://chromium-review.googlesource.com/946682 Commit-Queue: Candice Sy <cmsy@google.com> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#540674}
-
