- 06 Aug, 2018 40 commits
-
-
chrome://flagsSebastien Seguin-Gagnon authored
That field should not get autocomplete suggestions. Change-Id: Ie711c8d15cffb612e55dfcc057db8a7a4ef8eb19 Reviewed-on: https://chromium-review.googlesource.com/1156912Reviewed-by:
Grace Kloba <klobag@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#580881}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2e77f54f46e8..12fb9cfeee07 git log 2e77f54f46e8..12fb9cfeee07 --date=short --no-merges --format='%ad %ae %s' 2018-08-06 ethannicholas@google.com added SkSL saturate() function Created with: gclient setdep -r src/third_party/skia@12fb9cfeee07 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I5aed12e5730e3cae7d9dae34c106ef25694b2fb4 Reviewed-on: https://chromium-review.googlesource.com/1163114Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580880}
-
Owen Min authored
Screenshot: https://drive.google.com/file/d/1ipME4JlplC_99fQzx6lukvmHUyA3MUfG/view?usp=sharing Bug: 856242 Change-Id: I5f70c8b697de5b310019258ad79c27f975b7ce36 Reviewed-on: https://chromium-review.googlesource.com/1162342Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580879}
-
Manuel Rego Casasnovas authored
Two of the failures are related to stacking contexts: * external/wpt/css/css-contain/contain-paint-021.html * external/wpt/css/css-contain/contain-layout-016.html The other one was a mistake that has been already fixed in WPT (see https://github.com/web-platform-tests/wpt/pull/12314): * external/wpt/css/css-contain/contain-paint-001.html TBR=eae@chromium.org BUG=870811,868102,870157 Change-Id: I60e89decd2f939d1d9a850a1b8b556d31658e872 Reviewed-on: https://chromium-review.googlesource.com/1163673Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#580878}
-
Andrii Shyshkalov authored
R=maruel@chromium.org Expand-Timezone-Coverage: Yes No-Try: True Change-Id: I420e4e804ec107b079187f23acec18516052714a Reviewed-on: https://chromium-review.googlesource.com/1163636Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#580877}
-
Daniel Vogelheim authored
These tests follow the format currently under discussion here: https://github.com/WICG/origin-policy/pull/39 Bug: 751996 Change-Id: Ief33c794498cb3ed84dac670ecff4ddc366b9592 Reviewed-on: https://chromium-review.googlesource.com/1130531Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#580876}
-
Peter Beverloo authored
Change-Id: Ib7db0bbf5298c9b3bde3a6d949df92de3daad6e2 Reviewed-on: https://chromium-review.googlesource.com/1163606Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#580875}
-
Balazs Engedy authored
The test is flaky on Mac as well. Bug: 704980 Change-Id: I6d56312bd8ffb8fffe6911535a0029d95a27812a TBR: mseaborn@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1163676 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580874}
-
Kevin Bailey authored
Spacebar normally inserts a space into the Omnibox. If the cursor (or selection) is at the end of the text and the tab switch button is "focused", instead activate the button. Bug: 780835 Change-Id: I121f72bf3a979213d0506da1168a7658be84e706 Reviewed-on: https://chromium-review.googlesource.com/1160597Reviewed-by:
Justin Donnelly (OOO until Aug 13) <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#580873}
-
Hirokazu Honda authored
This CL does (1) remove unused RenderingHelper::GetGLDisplay(), (2) move local static functions to noname namespace, (3) omit RenderingHelperParams' constructors and desturctor. BUG=chromium:834170 TEST=VDA unittest at kevin Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibe5b2207c3eb794266f6cbc5d4796debefe165ad Reviewed-on: https://chromium-review.googlesource.com/1126742 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#580872}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/46671402fff3..15f0a12b8309 git log 46671402fff3..15f0a12b8309 --date=short --no-merges --format='%ad %ae %s' 2018-08-06 sakal@webrtc.org Allow releaseCallback to be null in JavaI420Buffer#wrap. Created with: gclient setdep -r src/third_party/webrtc@15f0a12b8309 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ica16ef226bbba659684029768a075bab43fb97a2 Reviewed-on: https://chromium-review.googlesource.com/1163111Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580871}
-
Elly Fong-Jones authored
If a menu has rounded corners, the vertical margin should always be exactly the radius of that corner, to avoid visual glitches when the top or bottom items are highlighted. Bug: 868037 Change-Id: Iab35de0b5be4152da1f24927c4a7f6bdef92a0d9 Reviewed-on: https://chromium-review.googlesource.com/1161101Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#580870}
-
nednguyen authored
Bug: 870673 Change-Id: I024d5bcad65d4d714c38066c71fcca352d21fda9 Reviewed-on: https://chromium-review.googlesource.com/1163623 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580869}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/64f2b4dce29f..5968caf4e5f6 git log 64f2b4dce29f..5968caf4e5f6 --date=short --no-merges --format='%ad %ae %s' 2018-08-06 primiano@google.com Add interactive trace_processor_shell + fix mac build 2018-08-06 fmayer@google.com Do not compile memory profiler for Chromium. 2018-08-04 michaschwab@google.com Add brushing via scrollwheel on overview timeline 2018-08-04 michaschwab@google.com Add DragGestureHandler, use in Overview and PanAndZoomHandler 2018-08-04 michaschwab@google.com Merge "Reduce passing sizes, more styling in CSS" 2018-08-03 primiano@google.com Merge "perfetto-ui: Remove the special mechanism for local files" 2018-08-03 treehugger-gerrit@google.com Merge "Fix compilation error for Chrome" 2018-08-03 primiano@google.com Merge "trace_processor: Refactor in order to implement global ordering." 2018-08-03 dproy@google.com Draw gridlines in core code and remove width from extension 2018-08-03 treehugger-gerrit@google.com Merge "Add StringInterner for heapprofd." 2018-08-03 hjd@google.com perfetto-ui: Fix up/down icons 2018-08-03 hjd@google.com Merge "perfetto-ui: Rename MithrilEvent to RedrawableEvent" 2018-08-02 michaschwab@google.com Fix Cpu Slices Width 2018-08-02 michaschwab@google.com Improve Design, Move Towards Mock 2018-08-02 primiano@google.com Merge "Add reorder track buttons" 2018-08-02 primiano@google.com Merge "Allow brushing everywhere instead of only via handles" 2018-08-02 primiano@google.com Merge "Remove backend directory" 2018-08-02 dproy@google.com Merge "[perfetto-ui] Remove backend directory" 2018-08-02 dproy@google.com Delete virtual canvas context 2018-08-02 dproy@google.com Plumb published track data to track frontend 2018-08-02 treehugger-gerrit@google.com Merge "Add record reader for heapprofd." Created with: gclient setdep -r src/third_party/perfetto@5968caf4e5f6 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id7c30a61b3f20eb864057470e612ba8776ee34f6 Reviewed-on: https://chromium-review.googlesource.com/1163113 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580868}
-
Hans Wennborg authored
Bug: 746975, 869850 Change-Id: Ic8c2b3be2b20dd07494a25641dee2634322dad14 Reviewed-on: https://chromium-review.googlesource.com/1163662 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Nico Weber authored
Bots seem to not use it, and humans can look at tools/determinism/deterministic_build_whitelist.pyl directly. Bug: 314403,664868 Change-Id: I286b28bb622df8d1910fa75f24bcf61439a3fe60 Reviewed-on: https://chromium-review.googlesource.com/1163317 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#580866}
-
Jochen Eisinger authored
BUG=801973 R=msarda@chromium.org Change-Id: Ic139c3dcab4299bc7c9f8c8f174262ae9c706272 Reviewed-on: https://chromium-review.googlesource.com/1163516Reviewed-by:
-
Hirokazu Honda authored
RenderingHelper::CreateTextureRef should encapsulate creating TextureRef, not only creating texture id. Thanks to this, RenderingHelper don't need to publicize a function to close a created texture. BUG=chromium:834170 TEST=VDA unittest on veyron_minnie and eve Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I21db66ef8505bd5ae67c0546ed2fd84890b011eb Reviewed-on: https://chromium-review.googlesource.com/1122071 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Rohit Rao authored
The underlying password store no longer allows adding duplicate blacklisted forms. BUG=871223 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2ad4f530bcdf600c683f7a48264263212a7b9b65 Reviewed-on: https://chromium-review.googlesource.com/1163629 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580863}
-
Che-yu Wu authored
Remove the #define which enables NOUNCRYPT by default. Correct the value of rest_read_compressed when decompressing an encrypted zip. Bug: crbug.com/869541 Change-Id: Ia86c1d234a8193f405147d35ad05c29fe86f812d Reviewed-on: https://chromium-review.googlesource.com/1161109Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Che-yu Wu <cheyuw@google.com> Cr-Commit-Position: refs/heads/master@{#580862}
-
Jan Wilken Dörrie authored
This reverts commit c62545a1. Reason for revert: https://crrev.com/c/1161883 fixes the device_unittests breakage triggered by a CL this one depended on. Original change's description: > Revert "[Bluetooth][WinRT] Implement Subscribing to Notifications" > > This reverts commit 43db955e. > > Reason for revert: Broka device_unittests on Win10 Tests x64 (dbg) crbug.com/870208 > > Original change's description: > > [Bluetooth][WinRT] Implement Subscribing to Notifications > > > > This change implements subscribing to Gatt Notifications for WinRT and > > enables corresponding tests. > > > > Bug: 821766 > > Change-Id: I805d17d25dc8749cdd34c926a86046cb207ec5c7 > > Reviewed-on: https://chromium-review.googlesource.com/1156686 > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580279} > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org > > Change-Id: I8db3ae54ee129c51522a879bff6cad32431b6cb6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 821766,870208 > Reviewed-on: https://chromium-review.googlesource.com/1161661 > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580437} TBR=reillyg@chromium.org,ksakamoto@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 821766, 870208 Change-Id: Ic15f662b5c221d675edad297224a8643d52f496a Reviewed-on: https://chromium-review.googlesource.com/1162123Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#580861}
-
Han Leon authored
BUG= Change-Id: I3a7cbfbf5b7ca1b3a9567f685c476a9385bffa37 Reviewed-on: https://chromium-review.googlesource.com/1163295Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#580860}
-
Balazs Engedy authored
This reverts commit 9c6c7b84. Reason for revert: Breaks continuous builder `ios-simulator-full-configs` at step ios_chrome_settings_egtests, due to failing test case: PasswordsSettingsTestCase/testDuplicatedBlacklistedFormDeletionInDetailView See: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator-full-configs/8679 Original change's description: > Prevent adding blacklisted duplicates > > Just before a form is going to be added to LoginDatabase a more check have to be made for blacklisted sites. If the site is already blacklisted by user then the new form will not be added. > > Also, a histogram is added to know how many duplicates are in the LoginDatabase at every startup. This histogram has the role to inform us when the code that do the de-duplication can be deleted. > > Bug: 862930 > Change-Id: Id256b6dc1c4995636c7281392bd1cb34af4ab5bc > Reviewed-on: https://chromium-review.googlesource.com/1151636 > Commit-Queue: Narcis Gemene <gemene@google.com> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580836} TBR=vabr@chromium.org,vasilii@chromium.org,bcwhite@chromium.org,jdoerrie@chromium.org,gemene@google.com Change-Id: I06c5272bf5ce355f40f58a3075bba9a5794d4ee6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862930 Reviewed-on: https://chromium-review.googlesource.com/1162023Reviewed-by:
-
Alexander Timin authored
Record UKM for tasks on dedicated worker threads and move shared UKM triggering logic into ThreadSchedulerImpl. R=eseckler@chromium.org,haraken@chromium.org,asvitkine@chromium.org Change-Id: Ia18f8b0493fd8e4ab7451fa56d14126e8ca2ad64 Reviewed-on: https://chromium-review.googlesource.com/1151989 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#580858}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/12c70426..973f34ce Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idced62d8f4e855f762a40432e971e6a84da31c2d Reviewed-on: https://chromium-review.googlesource.com/1163537Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580857}
-
Marina Ciocea authored
Temporary disable feature until fixing regression reported in linked bug. Bug: 870171 Change-Id: I043a03831cca4ae5463ef14eb2a4a85f880817ff Reviewed-on: https://chromium-review.googlesource.com/1163248Reviewed-by:
-
Eric Willigers authored
The ServerTimer API shipped to stable in M65 https://chromium-review.googlesource.com/656303 https://www.chromestatus.com/features/5695708376072192 BUG=702760 Change-Id: Ia3d3f7ade161e441a0bc1e93e02a2a18207f804d Reviewed-on: https://chromium-review.googlesource.com/1163222 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#580855}
-
Eric Willigers authored
HTMLMediaElement.captureStream() shipped in M62 https://chromium-review.googlesource.com/544899 https://www.chromestatus.com/feature/5522768674160640 Also removed the TODO comment regarding captureStreamUntilEnded as this has been removed from the spec. BUG=619625 Change-Id: I27a45e8d9eba5b3376efba3b1276cad6a299b2d3 Reviewed-on: https://chromium-review.googlesource.com/1163058Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#580854}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fe60316384dc..79eccf98e8fd git log fe60316384dc..79eccf98e8fd --date=short --no-merges --format='%ad %ae %s' 2018-08-06 nastasoiuf@google.com Filtering and selection updates Created with: gclient setdep -r src/third_party/catapult@79eccf98e8fd The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I5e3f399fafb883f1f16ec5ab8653b3f3b0770c3a Reviewed-on: https://chromium-review.googlesource.com/1163109Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580853}
-
Takuto Ikuta authored
Let me add more files to be checked for test execution caching on swarming. Linux deterministic builder is only the tree closer, so I updated whitelist of linux only in this CL. Bug: 869348 Change-Id: I390af4d5899acb7dc2a3f311870b135e036e4854 Reviewed-on: https://chromium-review.googlesource.com/1163583 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Balazs Engedy authored
Bug: 870293 Change-Id: I66e5eb92c688d2330050e54b104e8d6f76f164aa Reviewed-on: https://chromium-review.googlesource.com/1160535Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
-
Han Leon authored
This CL is the 3rd step of the plan below aiming to eliminate the native struct content::ServiceWorkerResponse defined in content/common/service_worker/service_worker_types.h. Note: Actually after this CL we can remove the Mojo method content.mojom.ServiceWorkerFetchResponseCallback.OnResponseBlob by using OnResponse instead, but to avoid a too big CL I'd like to do that with a follow-up CL. 1st step: https://chromium-review.googlesource.com/c/chromium/src/+/1134731 - Remove the typemapping of blink.mojom.FetchAPIResponse. The mojom struct blink.mojom.FetchAPIResponse describes a Response in terms of the concept from the Fetch spec, currently it's defined under blink/public/platform/modules/fetch/ and is used only by Cache Storage API implementation (by both Browser and Renderer code), as this struct meets the 2 conditions below, it should be fine to go into blink/public/mojom/: - it is expected to be used by both Browser and Renderer code. - it is expected to be passed over Mojo between Browser and Renderer (Blink). But, currently for Chromium Mojo binding variant it is typemapped to content::ServiceWorkerResponse being used in content/browser/cache_storage/, this blocks it being moved to blink/public/mojom/. So we need to remove this typemapping first, this removal also helps reduce 1 user of content::ServiceWorkerResponse. 2nd step: https://chromium-review.googlesource.com/c/chromium/src/+/1149706 Now we can just move blink.mojom.FetchAPIResponse into blink/public/mojom/fetch/, which makes the next steps possible. 3rd step: (this CL) - Use blink.mojom.FetchAPIResponse to represent the response a service worker provides to FetchEvent#respondWith. Specifically, use this mojom struct to replace the existing [Native] mojom struct content.mojom.ServiceWorkerResponse in content/common/service_worker/service_worker_fetch_response_callback.mojom. Thus we can reduce another 1 user of content::ServiceWorkerResponse. More importantly, this makes it possible for us to move service_worker_fetch_response_callback.mojom into blink/public/mojom/service_worker/ in future. 4th step: - Use blink.mojom.FetchAPIResponse to represent responses to background fetches. Specifically, use this mojom struct to replace the existing [Native] mojom struct content.mojom.ServiceWorkerResponse defined in content/common/service_worker/service_worker.mojom. Thus we can reduce the last 1 user of content::ServiceWorkerResponse. 5th step: - Remove content::ServiceWorkerResponse and do any left cleanup. BUG=789854 Change-Id: I8c5740abf5e78d1d9b6e716ad692e33addb80e56 Reviewed-on: https://chromium-review.googlesource.com/1155999Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#580850}
-
Keishi Hattori authored
This reverts commit d92ab8be. Reason for revert: causing chromium.linux bots to fail Original change's description: > Oilpan: Enable incremental marking by default > > PSA: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9YCeDToqDU8 > > Bug: 757440 > Change-Id: Id13ec3a8aa0c6a134a83acffd9811e2eee99fd2b > Reviewed-on: https://chromium-review.googlesource.com/1125892 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579746} TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 757440 Change-Id: I997d18b640ce20d9db5ba7ca8ce5928f4dfe71c4 Reviewed-on: https://chromium-review.googlesource.com/1163421Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580849}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dcad4e0851e4..069210aacb13 git log dcad4e0851e4..069210aacb13 --date=short --no-merges --format='%ad %ae %s' 2018-08-06 tikuta@chromium.org lddtree: invoke actual clang compiler in relative path Created with: gclient setdep -r src/third_party/chromite@069210aacb13 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I853640925beb236a8e988ecf6075083405fd99b9 Reviewed-on: https://chromium-review.googlesource.com/1163104Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580848}
-
Nico Weber authored
(Note that they currently are only deterministic with symbol_level=0; this will hopefully improve soon.) Bug: 330260 Change-Id: I8b77ccc106e87057c27a198247b180601fcb447e Reviewed-on: https://chromium-review.googlesource.com/1163173Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580847}
-
Nico Weber authored
- remove code that skips part of coff headers if timestamps are different; no longer an issue after #580585 - remove blacklist code; the blacklist is empty now Bug: 314403 Change-Id: I3e6c1eea3fea321c63c4081002931eb8a4a7ca12 Reviewed-on: https://chromium-review.googlesource.com/1163177Reviewed-by:
-
Gabriel Charette authored
When this CL is approved I will rebase it on top of tree and mass migrate all callers in a new patch set (TBR'ed change). TBR=robliao@chromium.org (for mass migration of existing callers) Bug: 867421 Change-Id: I41092bbc4824964ee047e0bf53e972c8f6e896a4 Reviewed-on: https://chromium-review.googlesource.com/1161116 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#580845}
-
Michael van Ouwerkerk authored
Bug: 853221 Change-Id: I97e5be56c747eeba543e5a3d7e98c7a03884e4e7 Reviewed-on: https://chromium-review.googlesource.com/1160847Reviewed-by:
-
Marc Treib authored
and GetState() to GetTransportState(). After https://crrev.com/c/1148392 (if the feature SyncStandaloneTransport is enabled), GetState() refers to Sync-the-transport, not necessarily to Sync-the-feature. TBRing updates to call sites - trivial rename, no functional changes. TBR=sky Bug: 856179 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib9364e51270a877d448d9a7d0db82dcd722cb8e4 Reviewed-on: https://chromium-review.googlesource.com/1161935 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580843}
-
Han Leon authored
This CL removes one usage of content::ServiceWorkerResponse by using blink.mojom.FetchAPIResponse directly. BUG= Change-Id: I8f52aa854107e17134622254a8f438853cb35a44 Reviewed-on: https://chromium-review.googlesource.com/1163535 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#580842}
-
