GitLab

Error messages like "Requested to remove an unknown match rule:
type='signal', interface='...'" were emitted at shutdown of Bus
object if an object proxy was connected to more than one signal of
the same interface.

TEST=changed the end_to_end_async_unittest to reproduce this bug, and confirm that the error messages were gone after fixing object_proxy.{cc,h}
BUG=chromium-os:23382

Review URL: http://codereview.chromium.org/8681002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111423 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111422 0039d316-1c4b-4281-b951-d872f2087c98

more robust by using time rather than bytes downloaded to determine when to fire another event.
BUG=none
TEST=manual, working on an example.
Review URL: http://codereview.chromium.org/8548018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111421 0039d316-1c4b-4281-b951-d872f2087c98

Without this, building with ninja fails because the libppapi_cpp.a library is put in a different path under PRODUCT_DIR than it would be with make, and ppapi_tests was hard-coded to expect that path.

TEST=Building with 'ninja all' doesn't give dependency errors.


Review URL: http://codereview.chromium.org/8673007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111420 0039d316-1c4b-4281-b951-d872f2087c98

Fixes problem of Sad Tab appearing before window has a chance to animate offscreen.

BUG=105144
TEST=Open a panel and close it. Ensure no sad tab appears before window disappears.


Review URL: http://codereview.chromium.org/8676016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111419 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105234

Review URL: http://codereview.chromium.org/8662029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111418 0039d316-1c4b-4281-b951-d872f2087c98

Move sensors interface into content/public/browser (since it's only used by browser directory). Move everything into the content namespace and make the enums conform to the Content API convention.

BUG=98716
Review URL: http://codereview.chromium.org/8678019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111417 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105046
TEST=none


Review URL: http://codereview.chromium.org/8678015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111415 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8662023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111414 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8681014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111413 0039d316-1c4b-4281-b951-d872f2087c98

Commit bot does not like polina@google.com.
Review URL: http://codereview.chromium.org/8662027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111412 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8684001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111411 0039d316-1c4b-4281-b951-d872f2087c98

This is only for a build time stress test only. I will revert back to 6 after getting the data.

11 allows for binding of 11 arguments to a function, and 10 arguments to
a method. 10 seemed like a nice round number to try (MSVC's tr1::bind() only supports 10).

Template Growth rate (n == arity):
bind.h: n
bind_internal.h: (n^2 + 20n)/2
bind_internal_win.h: n
callback.h: n

Template growth equation: (n^2 + 26n) / 2

Template growth: 96 -> 203 types

BUG=98542
TEST=try bots.  Then we get to watch the bot cycle times.

Review URL: http://codereview.chromium.org/8682015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111410 0039d316-1c4b-4281-b951-d872f2087c98

Had to convert ViewCacheHelper at the same time.

BUG=none
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/8680015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111409 0039d316-1c4b-4281-b951-d872f2087c98

Parse and Store the throttled datatypes and the unthrottling time, which is obtained from the server response, in the sync_session_context. 

This is the first patch for per datatype throttling feature. The next patch would consume this data to decide what items to commit.

BUG=104819
TEST=sync_unit_tests.exe, sync_integration_tests.exe, unit_tests.exe


Review URL: http://codereview.chromium.org/8595023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111408 0039d316-1c4b-4281-b951-d872f2087c98

I left a few unconverted in this one, because they made my head hurt.

BUG=none
TEST=base_unittests


Review URL: http://codereview.chromium.org/8653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111407 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105306
TEST=NONE
TBR=jamiewalch
Review URL: http://codereview.chromium.org/8676021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111406 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=willchan@chromium.org

Review URL: http://codereview.chromium.org/8677015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111405 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a subtle behavior that drops RemoveObserver operations when the
current() loop is NULL. Now those operations will always succeed.

BUG=104826
TEST=base_unittests

Review URL: http://codereview.chromium.org/8635002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111404 0039d316-1c4b-4281-b951-d872f2087c98

Applied patch from http://codereview.chromium.org/8665006/


BUG=none
TEST=duh
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/8677014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111403 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91241
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111254

Review URL: http://codereview.chromium.org/8587023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103032
TEST=none


Review URL: http://codereview.chromium.org/8566026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111400 0039d316-1c4b-4281-b951-d872f2087c98

Make sure that:
- shebang is only present for executable files
- __main__ is only present for executable files
- file's executable bit is coherent

Also fix EOF LF to be only one.

* Doing it separately since the CQ cannot process it.

TBR=robertshield@chromium.org
BUG=105108
TEST=

Review URL: http://codereview.chromium.org/8662025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111399 0039d316-1c4b-4281-b951-d872f2087c98

... for real this time! Problem is the first (.*) is greedy, so it gobbles up all but the last digit.
Review URL: http://codereview.chromium.org/8672009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111398 0039d316-1c4b-4281-b951-d872f2087c98

Patch by henrika@chromium.org:
http://codereview.chromium.org/8678007/

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111397 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tony@chromium.org
BUG=105299

Review URL: http://codereview.chromium.org/8677017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97768
TEST=Preferences / Under the hood / Content Settings / Mouse Lock should exist and function similar to Location


Review URL: http://codereview.chromium.org/8549011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111395 0039d316-1c4b-4281-b951-d872f2087c98

link to -lXcomposite and add third_party/angle/include to
include_dirs because they are both needed in case X11 is used

BUG=
TEST=


Review URL: http://codereview.chromium.org/8676009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111393 0039d316-1c4b-4281-b951-d872f2087c98

Plumbs the partial swap through on platforms that support it (currently just Linux GLX).

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8513013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111392 0039d316-1c4b-4281-b951-d872f2087c98

A string class variable in netflix.py is named starting with the substring
'test', which is being interpreted as a test case when pauto is invoked with
suite CHROMEOS_PERF (since that suite runs perf.py on ChromeOS, which in turn
imports from netflix.py).  This CL changes the name of that class variable
to avoid this problem, and also includes a few minor, related edits.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8677013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111391 0039d316-1c4b-4281-b951-d872f2087c98

Apparently doing it on FILE thread causes a race, which causes crbug 83153.

In order to move back to UI thread, we have to drop chrome channel support in GPU blacklist (it's a FILE operation); also, we have to move the collection of ATI driver version in linux to GPU process.

Note that this is the minimum change required for the move.  Further cleanup will follow once this is merged safely back to M16.

BUG=97535
TEST=unittest
Review URL: http://codereview.chromium.org/8670004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111390 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111389 0039d316-1c4b-4281-b951-d872f2087c98

exception in checklicenses.py. licensecheck.pl needs to understand the
Bison "special exception".

BUG=105232
TEST=ran checklicenses.py
Review URL: http://codereview.chromium.org/8677001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111388 0039d316-1c4b-4281-b951-d872f2087c98

Marking ProfileManagerBrowserTest.DeleteAllProfiles as flaky on mac.

BUG=BUG=104851
TEST=NONE
TBR=jamiewalch

Review URL: http://codereview.chromium.org/8662016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111387 0039d316-1c4b-4281-b951-d872f2087c98

There are a few relevant histograms that I annotated with the field trial name, and I added a new AddPage histogram.



TEST=none

BUG=none
Review URL: http://codereview.chromium.org/8379009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111386 0039d316-1c4b-4281-b951-d872f2087c98

Make sure that:
- shebang is only present for executable files
- shebang is #!/usr/bin/env python
- __main__ is only present for executable files
- file's executable bit is coherent

Also fix EOF LF to be only one.

TBR=michaelbai@chromium.org
BUG=105108
TEST=

Review URL: http://codereview.chromium.org/8667008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111385 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105025

This CL includes additions to webkit/tools/layout_tests/test_expectations.txt
which can be removed once http://trac.webkit.org/changeset/101075 is rolled
into Chrome.
Review URL: http://codereview.chromium.org/8632012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111384 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=existing tests

Review URL: http://codereview.chromium.org/8566034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111383 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105046
TEST=none

Review URL: http://codereview.chromium.org/8676012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111382 0039d316-1c4b-4281-b951-d872f2087c98

This change goes with r110241.

BUG=none
TEST=broker ui test passes


Review URL: http://codereview.chromium.org/8591008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111381 0039d316-1c4b-4281-b951-d872f2087c98