GitLab

There were three minor bugs left in the implementation:

  - We threw on lists-in-custom-iterators instead of just ignoring them.
  - We returned all properties on the keyframe rather than just those
    defined on the keyframe itself (e.g. we would include prototype
    properties, against spec).
  - We didn't access the properties in ascending unicode order.

Bug: 827573
Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88
Reviewed-on: https://chromium-review.googlesource.com/989261Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550641}

Also refator CdmService so that we can override service release delay for
testing.

Bug: 826039
Change-Id: I595a26c019ee760c49a2bac638c4f928101f6423
Reviewed-on: https://chromium-review.googlesource.com/1011404Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550640}

dma-buf memory mapping is supported upstream, so there is no longer any
need to check for this on non-ChromeOS platforms.

Bug: b/72096671
Test: Ran on non-ChromeOS device and ensured DCHECK isn't hit.
Change-Id: Id0a1d35207c40167dfa765c89d4e75db79f171f6
Reviewed-on: https://chromium-review.googlesource.com/1012142Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550639}

Change-Id: I32144548e5427a1e50491259dadf729a743a54df
Bug: 831610
Reviewed-on: https://chromium-review.googlesource.com/1000134Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550638}

Replace UpdatePrintedDocument(nullptr) with ClearPrintedDocument().
The two methods are simpler to understand than the existing combined
method.

Also get rid of all "new" uses in PrintJob.

Change-Id: I55a51233b0cc9f30c45301703e57b311738f3891
Reviewed-on: https://chromium-review.googlesource.com/1000956Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550637}

arraysize is already exposed via including base/macros.h in the
std_lib_extras.h header file. So it makes no sense to reimplement
WTF_ARRAY_LENGTH.

Replaced via
git grep -l WTF_ARRAY_LENGTH | xargs -x sed -i "s/WTF_ARRAY_LENGTH/arraysize/g

BUG=None

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1aa659bb689605d878c09f83ca0d4857baebe683
Reviewed-on: https://chromium-review.googlesource.com/1012125Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550636}

- Creates a helper class that manages the creation and parsing of
a compound file_system_id.
- Switches to these functions.

Bug: chromium:757625
Change-Id: I611cfdf213da104f1dc63ce7ba442298bd362f41
Reviewed-on: https://chromium-review.googlesource.com/990580
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550635}

* Adds --tokenize-by-character
  * This is useful for eg. the blink refactor where fooBar got changed to
    foo_bar.
* Adds --tokenize-whitespace
* Adds --skip-visualization
  * Added this because it was useful for testing.
* Ran yapf
* Small refactor.

BUG=773350
R=dpranke

Change-Id: I7596f670ce640ed6bd367dee995628edc13dd6f2
Reviewed-on: https://chromium-review.googlesource.com/1010798Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550634}

Turning down obsolete experiment, so cleaning up references.
No code changes (and OmniboxRichEntitySuggestions remains.)

Change-Id: I67282f51d4a5c6763551d7b050c156e4ceb143b8
Reviewed-on: https://chromium-review.googlesource.com/1010263
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550633}

Manifest v1 extensions have been deprecated for a long time.
Stop loading these extensions unless a special (existing) commandline
flag is present. There are a few straggling tests (which rely on
packaged extension resources, like .crx files) that still need to be
updated; use the commandline flag (or a runtime variant) in those tests.
These will be cleaned up in follow-up CLs.

Reland note: This was reverted because of a conflict with
https://crrev.com/fef93a84a5b56945d02cada97f4ec886ae34c0e2. This has
been fixed.

TBRing original reviewers:
TBR=lazyboy@chromium.org
TBR=pastarmovj@chromium.org
TBR=qinmin@chromium.org
TBR=stevenjb@chromium.org

Bug: 831909
Change-Id: I9141db4a15452c9cd601b279f7880e10a08c0a8c
Reviewed-on: https://chromium-review.googlesource.com/1011572Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550632}

Remove flaky expectation for layout test
virtual/mouseevent_fractional/fast/events/mouse-event-buttons-attribute.html
Can't reproduce the failure locally in both Win, Mac and Linux.

Bug: 825046
Change-Id: I529606bed85ddc59e09e9937c0b784af51ffdc5a
Reviewed-on: https://chromium-review.googlesource.com/992891Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550631}

This CL implements logic from GLES2CommandBufferStub::Initialize() in
InProcessCommandBuffer::InitializeOnGpuThread(). Some differences are
not addressed and I've left TODOs instead.

Bug: 832243, 811979
Change-Id: I1139a33f594280ea4c17b3a7223391e33bc15ad6
Reviewed-on: https://chromium-review.googlesource.com/1006038Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550630}

Before this patch, any iframe could install a Payment Handler by calling
`paymentManager.instruments.set()`.

This patch checks for the feature policy "payment" before allowing any
operations on `paymentManager.instruments`.

After this patch, a cross-origin iframe will reject all operations on
`paymentManager.instruments` by default. The parent context can
explicitly allow the iframe to use the Payment Handler API through
feature policy. This can be accomplished via the iframe attribute
`allow="payment"`, for example. Note that the same feature policy
controls access to Payment Request API as well.

Discussion:
https://github.com/w3c/payment-handler/issues/281

Spec change:
https://github.com/w3c/payment-handler/pull/282

Payment Handlers are behind a flag:
chrome://flags/#service-worker-payment-apps

Manual test:
https://rsolomakhin.github.io/pr/apps/iframe/

Bug: 828948
Change-Id: I0259555692fa0b215d3700c233b3687724e665cb
Reviewed-on: https://chromium-review.googlesource.com/1005275
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550629}

This CL fixes the test suite, fixing the test that should pass and
disabling the one for the features not yet implemented.

Bug: 832638
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2138a74a73b18c40ebdee6b22432541d7bc27a91
Reviewed-on: https://chromium-review.googlesource.com/1012104
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550628}

The issues now seem to be resolved.

Bug: 832650
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Id43bc440805fb4ed74d430ed7384eed78bce289f
Reviewed-on: https://chromium-review.googlesource.com/1011678Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550627}

Bug: 812097
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic15ae3735c82875759bf67be8e64bd5beeb7ecb0
Reviewed-on: https://chromium-review.googlesource.com/996301
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550626}

This CL implements the wrapper for the POST request to the FCM server.

BUG=801985

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibba578f7181920e24b39c633111d47b717eb7bb1
Reviewed-on: https://chromium-review.googlesource.com/911108
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550625}

This CL tests that double-click triggers unelision of steady state
elided URLs with the proper portion selected afterwards. This unelision
occurs on the second mousedown.

It also tests that triple-click triggers unelision and ends with
everything selected.

Bug: 797354
Change-Id: I3174242ad5f188ef0808a859a376bc0393a76faf
Reviewed-on: https://chromium-review.googlesource.com/1008866
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550624}

Right now touch_action_browsertest.cc has two tests only, one for auto
which is the default, and one for none.

This CL adds more test cases with janky main thread. There is a special
test case where touch ack timeout is triggered, which should allow all
gesture event.

Bug: 772130
Change-Id: Ifabcb8356cb2526ad55313be01e24ea959ab2330
Reviewed-on: https://chromium-review.googlesource.com/1007864Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550623}

Add an origin access blacklist that takes priority over the origin
access whitelist. If both the blacklist and the whitelist match an
origin, access is not granted.

This will allow us to specify a wildcard whitelist while maintaining
a list of exceptions which will be off-limits.

Add unittests for the same.

Bug: 826946
Change-Id: I651cc1e35d05bf20b8ea6e07f34b4b034c297844
Reviewed-on: https://chromium-review.googlesource.com/1011241Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550622}

Changes from original attempt at https://crrev.com/c/999182:
- fix flakiness in two additional ChromeOS login tests
- fix CSP WPT tests to not depend on ordering between iframe's onload
  and postMessage - see https://crbug.com/832319.

Previously, we sent the IPC to forward a cross-process postMessage
immediately.  This caused a behavioral difference from the
same-process case where the postMessage is always scheduled.  Namely,
in a scenario like this:

  frame.postMessage(...);
  doSomethingThatSendsIPCsToFrame(frame);

the IPCs from JS following the postMessage would've been ordered
incorrectly, causing |frame| to see their side effects after the
postMessage dispatch in the cross-process case, whereas they would be
seen before the postMessage dispatch in the same-process case.  One
example of this is frame.focus(), and another is a frame element
onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
a postMessage dispatched from an inline script while the frame was
still loading.

To resolve these ordering concerns, this CL changes cross-process
postMessage to do a PostTask on the sender side before sending the
message to the browser process.  This improves the current state of
the world, but does not yet achieve a perfect match for the IPC
ordering in the same-process case - see discussion on the bug.

Bug: 828529
Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
Reviewed-on: https://chromium-review.googlesource.com/999182Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550284}
Reviewed-on: https://chromium-review.googlesource.com/1011287
Cr-Commit-Position: refs/heads/master@{#550621}

Make the close buttons appear again in the Print Preview cr-dialogs.

Bug: 827579
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I64999ea9e56ba34509040294dc7178c47facadd3
Reviewed-on: https://chromium-review.googlesource.com/1007626Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550620}

Bug: 832081
Change-Id: I9e14993b3a771657cc4d7dfc43ba518f4d345ebb
Reviewed-on: https://chromium-review.googlesource.com/1010723
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550619}

When reporting an issue, the ReportAnIssue module is taking a screenshot
of the page. The popup menu needs to be hidden before taking this
snapshot.
This CL hides the popup menu before taking the snapshot.

Bug: 831136
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7e908b04359453cf1f3d790c712435b3d27fa6d2
Reviewed-on: https://chromium-review.googlesource.com/1009745
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550618}

Make frequency of status reports upload a parameter of the StatusUploader
to allow easy customization.

Bug: 826894
Change-Id: Id37890fb5e65d83bb9877decdc23a5e1b9d09de2
Reviewed-on: https://chromium-review.googlesource.com/1000415Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550617}

Change-Id: I4cacf95b98f3f4dbe17c49f4ae566849cbafc4b1
Reviewed-on: https://chromium-review.googlesource.com/1002658Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550616}

This CL records the following histograms:
* Signin.SigninCompletedAccessPoint.WithDefault
* Signin.SigninCompletedAccessPoint.NotDefault
* Signin.SigninCompletedAccessPoint.NewAccount

Bug: 832066
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I42ecf6be254dcf51133d565e90df56ae1f69ef93
Reviewed-on: https://chromium-review.googlesource.com/1010362
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550615}

If Abseil is compiled with -fexceptions ABSL_HAVE_EXCEPTIONS will be
defined and Abseil will be able to throw. Since exceptions are
forbidden in Chromium's code, this CL removes the possibility to
enable them.

Abseil automatically sets ABSL_HAVE_EXCEPTIONS here:
https://cs.chromium.org/chromium/src/third_party/abseil-cpp/absl/base/config.h?l=207&rcl=f4f0f0e2af28098ac58f8548b13d1a1f46d7c846

Bug: webrtc:8821
Change-Id: I82e19abbe62f332173d977b5ea93f9040232572b
Reviewed-on: https://chromium-review.googlesource.com/1012074Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550614}

This CL records the user actions:
* Signin_Impression_FromAvatarBubbleSignin.
* Signin_Impression{With|No}Account_FromAvatarBubbleSignin

Bug: 819432
Change-Id: Ica6334eb9fbe63ed9db285379095d7a5613b4370
Reviewed-on: https://chromium-review.googlesource.com/1007442Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550613}

This JSON copy of the data will let us show the current contents of the
Reporting cache in the net-internals page.

Bug: 829353
Change-Id: I005f642e506d9c70e58c1b5799263931327c4a1f
Reviewed-on: https://chromium-review.googlesource.com/996883
Commit-Queue: Douglas Creager <dcreager@google.com>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550612}

Replacing +[UIColor colorWithRed:green:blue:alpha:] by UIColorFromRGB().

It should have been done with: crrev.com/c/995417

Bug: 827072
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie8e0c81c0ce351d24fadf20970a08e27d2a02021
Reviewed-on: https://chromium-review.googlesource.com/1012076Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550611}

Move InProcessContextProvider into viz service directory where it's
used. It didn't belong in components/viz/common. Also rename it
VizProcessContextProvider to better describe the class and to avoid
confusion with the other InProcessContextProvider implementation.

Bug: none
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I2af04eda873d8b157befe2b277186483f583f266
Reviewed-on: https://chromium-review.googlesource.com/1010605
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550610}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/53a115e67e50..54a81e45ddfc

$ git log 53a115e67..54a81e45d --date=short --no-merges --format='%ad %ae %s'
2018-04-12 kkinnunen Add support for downloading Windows VS toolchain from a HTTP URL

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:830569


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I891b5ae2d18128cdd16a03343ea05136c498974c
Reviewed-on: https://chromium-review.googlesource.com/1011666Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550609}

Bug: 828582
Change-Id: I85864722c577268d9c95a0d9c37cf7197b04e5d3
Reviewed-on: https://chromium-review.googlesource.com/1012028Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550608}

Dice Milestone 2 was enabled by default in CL:
https://chromium-review.googlesource.com/c/chromium/src/+/975561

However this is causing issues when signing into Google properties on
the web, because the new server endpoint rejects most of the client IDs.

This restores the previous behavior.

Bug: 829220
TBR: jwd
Change-Id: I3d7c22cb10f0d900c8d897369b063ac236f12146
Reviewed-on: https://chromium-review.googlesource.com/1011620
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550607}

If the default font-size changed, and media queries have font relative
lengths, then media query evaluations may have changed.

Bug: 830119
Change-Id: I912adddcdbd05b729678cff14d16245a35bca3e1
Reviewed-on: https://chromium-review.googlesource.com/1000852
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550606}

Modifies the format types passed to the URL formatter in
GetURLForDisplay() on iOS to trim after host.

Bug: 821801
Change-Id: Ib744a161d0488b5e0f3ee8e0d81947da17bb22cb
Reviewed-on: https://chromium-review.googlesource.com/1007079
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550605}

The browser/ and renderer/ subdirectories no longer exist in
components/task_scheduler_util/. There is no good reason to keep
the common/ subdirectories, everything can be moved directly to
components/task_scheduler_util/.

This is the last phase of the clean up planned in
https://crbug.com/810049

TBR=asvitkine@chromium.org

Bug: 810049
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If5d000edfd1bd689950ab8f8a6992ecbfbb93c78
Reviewed-on: https://chromium-review.googlesource.com/1005788
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550604}

The strings present in kCommandNames needs to be handled in
ExecuteCommands().

Also fix a random typo.

There is a not-landed patch to use the batch mode:
https://codereview.chromium.org/2112013003/

Due to a bug in this patch the command 3 was never passed to cachetool,
and hence this problem was not noticed.

Bug: None
Change-Id: I0f5dbdf96e0e771b265400f5b87eee356722ccd4
Reviewed-on: https://chromium-review.googlesource.com/1010290Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550603}

https://crrev.com/c/980742 replaces EstimatedMemoryFreedKB() with
GetEstimatedMemoryFreedOnDiscardKB() which always returns 0. It confuses
Chrome OS Tab Manager and all tabs except the front tab are discarded.
It's a quick fix to make tab discard work on Chrome OS.

Bug: 832517
Change-Id: Ic72be7a7535bf6e0a48a6f6efa9afc28635813c8
Reviewed-on: https://chromium-review.googlesource.com/1011885
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Cheng-Yu Lee <cylee@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550602}