- 01 Dec, 2020 40 commits
-
-
Josh Nohle authored
Currently, if private certificate data changes, the Chromebook might continue advertising the stale certificate data until periodic advertisement rotation occurs. A symptom could be other devices failing to discover the Chromebook for up to 15 minutes after the Chromebook's initial onboarding, for instance. In this CL, we refresh the advertising data whenever private certificates change. Manually verified that a phone can immediately discover a Chromebook after 1) initial Chromebook Nearby Share onboarding and 2) changing selected contacts on the Chromebook (which results in private certificate recreation). Fixed: 1154064 Change-Id: I4839d7b91df57759382e646fb2db8ee482d53601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566749 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#832228}
-
Alan Cutter authored
This reverts commit 1ca3c153. Reason for revert: Needed to land parent CL revert: https://chromium-review.googlesource.com/c/chromium/src/+/2567511 Original change's description: > Add WebApp.Preinstalled.UninstallAndReplaceCount UMA histogram > > This CL adds metrics for how often preinstalled web apps migrate and > remove an existing app install. > > This data is useful to monitor rollouts of default web apps that are > replacing old Chrome apps to ensure the migration is happening as > expected. > > Bug: 809304, 1058265 > Change-Id: Ie9edb4a1cf89e84d7e56a20bad028dd8ea1aeb07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561999 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832148} TBR=rkaplow@chromium.org,alancutter@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,glenrob@chromium.org Change-Id: I46c1a678e09111d210d1385bdb17ecc4fcabb093 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 809304 Bug: 1058265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567056Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#832227}
-
Andres Calderon Jaramillo authored
This CL changes a couple of DCHECKs to CHECKs as a follow-up to CL:2554180. The reasoning is from the guideline in [1]: Use CHECK() if the consequence of a failed assertion would be a security vulnerability, where crashing the browser is preferable. The CHECKs should not be triggered, but at least one of them is not trivial to reason why from the existing validation. [1] https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#check_dcheck_and-notreached Bug: b:171340559 Test: None Change-Id: I3e35b8f310f76bb74cde515e776b9ae00134df93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566722 Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#832226}
-
Morten Stenshorne authored
We paid attention to block-size and max-block-size, but not min-block-size. Bug: 829028 Change-Id: Iad8920b7d46e3cd6b73645343d85ff9f1ee532dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566750Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#832225}
-
Liquan (Max) Gu authored
Changes: * Creates PaymentNotShownError that can be used to return more error details. Going forwards, this is used to replace the error string return in multiple methods, so that the methods callers can handle errors more flexibly. * Renames disconnectIfNoPaymentMethodsSupported, disconnectForStrictShow. Behavioural changes: * After the change, when disconnectIfNoPaymentMethodsSupported fails, sObserverForTest.onPaymentRequestServiceShowFailed() is invoked. This makes sense because the disconnect method is invoked only after show(). Bug: 1153353 Change-Id: I9ad81fb26b9ffd89aec06eb68072960955626ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562750 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#832224}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/416fe32ce119..0607219d1c67 2020-12-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from d8bb0bb7c735 to a827aa2c29aa (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: If234976eaa35a2fa0354de4b43a7e49559fc0421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567553Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832223}
-
Yutaka Hirano authored
Currently web developers don't know whether the browser is able to send more datagrams. This CL will enable that by providing the backpressure information. Bug: 1150350 Change-Id: I20dad8e8ca0bd1f84c4b9ecf935e14e341af2e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563017 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#832222}
-
Matt Menke authored
This requires making the binder for blink::mojom::ReportingServiceProxy a per-frame binder, instead of a per-process one, so it can retrieve the associated RenderFrameHost to get its NetworkIsolationKey. This CL adds no tests, but there are existing wpt tests that fail without this CL applied when PartitionNelAndReportingByNetworkIsolationKey is enabled, without this CL. Bug: 993805 Change-Id: Ib49960d91083bd1cfe928ffd213adb7fdb56e616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526909Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#832221}
-
Mounir Lamouri authored
Bug: b/170751292 Change-Id: I510d25920515eb568deb3f6316ae4c626950b80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552410 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#832220}
-
Hajime Hoshi authored
We're planning to store pages using WebRTC in the back-forward cache. As a preparation, use broadcast channels as a typical non-sticky forbidden feature for BFcache instead of WebRTC. Bug: 1147741 Change-Id: I94ad9c7b5ce2618e5e2fe5a616977099da4ba766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563529 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832219}
-
Austin Tankiang authored
Before PreferenceWatcher was not created when Drive was disabled by the kDisableDrive pref, which would cause Drive to not start when the pref was changed. Bug: 1110238 Change-Id: Ic96c757ed77a8cb957dc6959f7ea40efb5460b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328544 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#832218}
-
Alex Kalugin authored
Change-Id: Idf6655c59d71b9a70375e651db84d5ddfb7a91b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558280Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Alexander Kalugin <akalugin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#832217}
-
Julian Pastarmov authored
This is still fairly new mechanism and it will be good to continue to observe its adoption for a while longer. BUG=1149512 Change-Id: Ifb651ef0020068d6107353f7e7a1d48cb15ba742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550042 Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#832216}
-
Samuel Huang authored
Previously, files generated using /tools/json_scheme_compiler scripts incorporate file paths (for header includes and "GENERATED FROM" texts) using direct string conversion. On Windows, such strings are rendered using backslashes, leading to incorrect source files. The problem is benign because Windows builds do not use these files. However, these files show up on code search (under out/win-Debug). This CL fixes the issue by converting paths to POSIX style (i.e., use '/' instead of '\\') for generated files. The approach is to perform the substitution prior to string rendering, to create a consistent translation surface. Change-Id: Ia9eb924b8e21a03b2fc3b501c7e8c4f0313f8f5e Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557264 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832215}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f37338cdaa21..42433abb9596 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6e0889e1e09af9030dfefecaeec82aed0774ca18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566716Reviewed-by:
-
Leo Lai authored
We are deprecating tpm status methods by cryptohome. The pre-condition of triggering the clear is also simplified to "when install attributes is ready", which implies TPM ownership. Also, the clear operation is made asynchronous, so it doesn't risk blocking UI thread. FWIW,The follow-up action of the original blocking clear operation doesn't either check or depends on the result of clear, so making it asynchronous is functionally equivalent. BUG=b:172775884 TEST=chromeos_unittests. Change-Id: Ic1239364c6a29f6711dd302f3af40d8c0c9f2203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562619 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#832213}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6a7095d8c753..a827aa2c29aa 2020-12-01 shaobo.yan@intel.com CopyTextureForBrowser: Use large triangle to avoid arithmetic precision 2020-11-30 cwallez@chromium.org Roll glslang and shaderc 2020-11-30 enga@chromium.org Update RenderPassLoadOpTests to use WGSL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I5d03f3f6d8fb2be0fe5f5309e337782852d042d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567550Reviewed-by:
-
Alan Cutter authored
This CL cleans up the implementation of ExternalInstallOptions::operator==() and adds the missing app_info_factory field to the set of comparisons. This is a small tidy up CL with no changes in behaviour. This comparison method is only used by tests. Change-Id: Ie24e479bbc796cac1bf96c1a35e2f19d05077e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563428 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#832211}
-
Liquan (Max) Gu authored
Motivation: This CL lays the preparatory work to create onShowCalledAndAppQueried() which will encapsulate the following methods: - disconnectIfNoPaymentMethodsSupported - showAppSelector - triggerPaymentAppUiSkipIfApplicable Behavioural changes: * When show() is called before app querying is finished, after the CL, notifyPaymentUiOfPendingApps() is triggered, and so mJourneyLogger.setNumberOfSuggestionsShown() get recorded, and so the NEEDS_COMPLETION_PAYMENT event is recorded. Before the CL, notifyPaymentUiOfPendingApps() was not triggered in this condition and setNumberOfSuggestionsShown() was not recorded. * When show() is called after app querying is finished, the CL doesn't change any behaviour (i.e., setNumberOfSuggestionsShown gets recorded). Note that the behavioural change is positive, because after the CL, setNumberOfSuggestionsShown gets recorded regardless of the order of show and app query finishing. The system has less states and thus less complicated. Structural changes: * Whether the payment methods are supported by any payment apps becomes solely decided by BrowserPaymentRequest.hasAvailableApps(). But this will be temporary, because hasAvailableApps() can be further broken down into whether regular apps are available and whether users can manually type in the payment information. * disconnectIfNoPaymentMethodsSupported() is moved together with showAppSelector() so they are ready to be encapsulated by onShowCalledAndAppQueried(). Bug: 1153353 Change-Id: I9ff13fdac6dd07c44b6c6c57d3353b4b5cca2c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562837 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Mounir Lamouri authored
This will complete the flow when calling SignIn() and will allow the UI to be notified if the user signs in or out of the browser. Bug: b/170751292 Change-Id: I64a7a45b50d545596cfafe3b3335a1de8d94f71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551134 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3f564fc76ea8..ff38106d62fc 2020-12-01 cclao@google.com Vulkan: Use specialization constant for halfRenderAreaWidth If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I2f120b4897379388ec3eff2eae02d4d35f5d05dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566877Reviewed-by:
-
Michael Thiessen authored
This reverts commit 7973b6e9. Reason for revert: Didn't work. Original change's description: > Speculative de-flake of TabsOpenedFromExternalAppTest > > It looks like when we send CTA to the background, then call finish() > on it, it doesn't actually get Finished. Likely Android just doesn't > bother actually finishing background Activities right away (maybe > something to do with the launcher)? > > I haven't been able to reproduce the issue, but this appears to be the > commonality between the failing tests, and this should fix it if so. > > If this works, I'll follow up with some infra changes to detect/advise > in this case. > > Bug: 1153712 > Change-Id: Ic46c30c99df390e0cf8c7d732c3a10535dddc2a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565619 > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832044} TBR=yfriedman@chromium.org,mthiesse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ie5de0f86935d1a11cc3c6dd821569d6736c33d08 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1153712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566721Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#832207}
-
Moe Ahmadi authored
Previously, the text selection in the realbox input was being set to the inline autocompletion of the default match (if one existed) assuming the current input contains the previously typed text, thus generating the expected input. This logic can result in undesirable outcomes where the current input does not match the previously typed text. As of this CL no such assumption is made and the input is updated to the previously typed input + inline autocompletion of the default match (if applicable). Fixed: 1152269 Change-Id: I518b2095736c8ef328c820bce2e9682f1b469aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566296Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#832206}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1af7968d686d..6d2a0fef9315 2020-12-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Iadbfb6402544834d61cfe7c7a7a1f3b93ad947dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566509Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ifd43c3f36ce6f736c7f4c58757b76efbc890d74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567552Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 89-4324.9-1606128713-benchmark-89.0.4335.0-r1 to 89-4324.9-1606128713-benchmark-89.0.4337.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8a5011b8d6cb8ce119ae0ce5a9c6dbc1a433748d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567432Reviewed-by:
-
Asami Doi authored
This CL removes ServiceWorkerContext::IsServiceWorkerOnUIEnabled() and the callers of it. There is no behavior change. Bug: 1138155 Change-Id: Id1f01656438811c81b01be5926289c7347303a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557381 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#832202}
-
Takuto Ikuta authored
There is no reference to this script anymore. Bug: 917372 Change-Id: I1c49c3f6b275207b10df0a8793389dc8d8ce547a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567190Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#832201}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I2602e3b6e48939be6dac0001eedbaad02b8b432a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566719Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832200}
-
Eugene But authored
CreateSyntheticCrashReportForUte can be legitimately called with empty breadcrumbs vector, in which case the app should not crash. This CL uses "No Breadcrumbs" signature instead of trying to access the element in an empty vector. Bug: 1154039 Change-Id: I45537944122700c9085c4e824ae9edeafe1c7395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566361 Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#832199}
-
David Munro authored
We were checking for the wrong signal name. In practise we get both or neither signal but still good to clean up. Bug: None Test: CQ Change-Id: Ibe93fe677c9359454e1cd6a88a5c8d3ade9dd199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567053 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#832198}
-
Sammie Quon authored
On clicking, capture mode session will end and we try to snap a deleted window. This CL ignores the capture label window so that the window finder algorithm can find the next top window. That next top window will be the snapped window instead and will persist when capture session gets destroyed. This can happen to any capture session widget/window, but only the capture label is visible or created during window mode. Fixed: 1152938 Test: ash_unittests CaptureModeTest.TabletTouchCaptureLabelWidgetWindowMode Change-Id: I6fe8c2fea34c4738ef41dbafca2609b0b6913589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566450 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#832197}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f37338cdaa21..42433abb9596 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6e1329ccbcc381ca8c5901caffda8b30b4b91ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566357Reviewed-by:
-
Tom Anderson authored
This is needed for [1] which adds the assumption that Chrome makes all requests on the main Xcb connection. This CL simply moves the requests to occur on a separate connection to satisfy this assumption. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2565440 R=penghuang Bug: None Change-Id: Ia85799c460d0fef372121dae3244874130158fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566342 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#832195}
-
Koji Ishii authored
This patch reverts removed `<Item>`s in r816912 <crrev.com/c/2467503> back, because Visual Studio started to fail to parse `natvis` when it has `<Item>`s for anonymous unions. It looks like the issue was fixed in Visual Studio 16.7.7, released on Oct 27th. Developers who have not upgraded will not be able to use DebugVisualizer for |NGFragmentItem|, but can still view the raw view, and will benefit from the DebugVisualizer once they upgraded. Also adds a unit test as suggested by brucedawson@ in <crrev.com/c/2467503>. Change-Id: I4d35ee40a8bbdf2c455f7c4ecf8f8f3b80d1248a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558136 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#832194}
-
David Grogan authored
When using the aspect ratio, we were doing size = large1 * large2 / large3. large1 * large2 was overflowing LayoutUnit. Now we do those calculations with the operands as doubles. We still multiply first because *most* of the time these values will all be integers, and all the integers up to LayoutUnit::Max()*LayoutUnit::Max() can be exactly represented with double precision. Change-Id: Id714f38493554c5f1b7e4dfe56bdaa6742f3d8a5 Fixed: 1151608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564199 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
-
Nancy Wang authored
This CL implements the restore notification on startup after crash, based on the ui review deck go/cros-full-restore page 9. There will be some follow up CLs to add the reading restore settings, and other full restore notifications implementation. BUG=1146900 Change-Id: I194b1e794e08c4afca556fe2307b804e1184b135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554717 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#832192}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f37338cdaa21..42433abb9596 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If6692b2103f62e67270834b7852c8bd76c43fdb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566298Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c6f57a23e63..416fe32ce119 2020-12-01 bungeman@google.com Ensure variable font from data created at default. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Id5926fbf29aca89e1979b80ccabc048231181e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566972Reviewed-by:
-
Andrew Xu authored
Bug: 1152815 Change-Id: Ic21c07a055043a2fd6fbd908ad8e27f99b78b041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561026Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832189}
-
