- 24 Oct, 2019 40 commits
-
-
Rohit Rao authored
Mirrors the division we have for EG1 tests. BUG=987646 Change-Id: Id0d57402b5241799f376eb60f440e3fa53caae2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869330Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#709013}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e8843ab060ac..137a46738b35 git log e8843ab060ac..137a46738b35 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 eseckler@google.com processor: Move proto_trace_parser/tokenizer to importers/proto/ Created with: gclient setdep -r src/third_party/perfetto@137a46738b35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:141459049 Change-Id: Iff5df44d20e66076eaea49c136521a7c4f0404e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877606Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709012}
-
Elly Fong-Jones authored
This change adds a browser test (actually an interactive ui test) that ensures that flags that expire actually end up hidden in the UI. To avoid depending on the real flag metadata, this change also adds flags::testing::SetFlagExpiredPredicate to allow tests to control which flags are considered to have expired. Bug: 1010678 Change-Id: If6275735105fa552779429f7978d7bf9e76f3687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876469Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#709011}
-
Miyoung Shin authored
This CL converts AudioLog{Ptr, Request} in content and services to the new Mojo type, and usese pending_receiver<AudioLog> in audio_logging.mojom. Bug: 955171 Change-Id: I34ac38228c93723dc258f87c36aa2938d4d7bc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872090 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#709010}
-
Adithya Srinivasan authored
Previously, in multiple instances, we used a navigation observer to wait for the first portal navigation with the assumption that navigation wasn't already complete. This assumption was incorrect, the portal could navigate before we return from the ExecJs call that initiated the navigation. This CL creates the observer before calling ExecJs Bug: 990717, 998107 Change-Id: I8d73b2c39e343e625fa9423291568af2c69e35cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873239Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#709009}
-
Jérôme Lebel authored
Updating the expiration date from 2019-11-01 to 2020-11-01. Bug: 1006978 Change-Id: Ia60beec8b686a681d36ba390e4076592b904d26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878407 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709008}
-
Yi Su authored
Bug: 991763 Change-Id: Ic08d8e45714b9503bb26dc1ad85687e4bddba1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878410Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#709007}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e8d14c45f873..7c8a7000517d Created with: gclient setdep -r src-internal@7c8a7000517d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I2bc16ed41632f7c295ba1f9e99213c2059fdc581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877461Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709006}
-
Peter Wen authored
Since bundletool does not produce hermetic zip files (apks files), extract and re-zip so builds become deterministic again. Also localize temp file/dir usage as much as possible. Add .apks as a valid build artifact extension. Fixed: 1008664 Change-Id: I72b237e49670c83c1aa48aa06795fb6d72dd43ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877150 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709005}
-
Henrique Ferreiro authored
Convert the implementation and all users of the chromeos::device_sync::mojom::DeviceSyncObserver and DeviceSync interfaces. Bug: 955171 Change-Id: Ic5550b1e42d977c35c082f35eb86e3e024e62327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856970 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#709004}
-
Marina Ciocea authored
Verify that: - the infobar buttons start/stop tab sharing. - the infobar has the correct layout (icon, label, buttons and button labels) on the shared tab and on other not shared tabs. - the infobar doesn't have a share button if sharing is not allowed. - multiple infobars can be added to the same tab. - infobar is not dismissed on navigation. Bug: 996722 Change-Id: I809bcc04380017d8d0f27095c257431df4619db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847220Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#709003}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d113ee326ba5..eec39190ce14 git log d113ee326ba5..eec39190ce14 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 perkj@webrtc.org Remove trial WebRTC-Bwe-ProbeRateFallback Created with: gclient setdep -r src/third_party/webrtc@eec39190ce14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I0d9847a24016a23821a48d742b453933f2a692f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877459Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709002}
-
Anton Bikineev authored
This is motivated by incremental marking tasks, which are non-nested and required to be cancelable. Bug: 1002998 Change-Id: Ie02b1ee71a3289eb69a4fcebb5bd9edbc1fae9d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876927 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#709001}
-
David Roger authored
Change-Id: If839d05b61b61021d8e1db46d60163aef121d4c6 Bug: 1015388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862928Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#709000}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bf69ed0d31f4..3c19bdb0a8ce git log bf69ed0d31f4..3c19bdb0a8ce --date=short --no-merges --format='%ad %ae %s' 2019-10-24 perezju@chromium.org [Telemetry] Use mock_config in parser tests Created with: gclient setdep -r src/third_party/catapult@3c19bdb0a8ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:990395,chromium:799950 Change-Id: I94cc3c4acdd851b30f5acda51e56b0512c7730f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877457Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708999}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/883e817b14bf..09b50796402d git log 883e817b14bf..09b50796402d --date=short --no-merges --format='%ad %ae %s' 2019-10-24 paulthomson@google.com Add LESS_DEBUG_INFO CMake option Created with: gclient setdep -r src/third_party/swiftshader@09b50796402d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/142862126 Change-Id: Iecb06b74b3a7cf2a3e0699d88b52358ef169a469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708998}
-
Stephen McGruer authored
This is flaking too heavily on those targets and causing CQ pain. TBR=skau@chromium.org Bug: 1015949 Change-Id: I39590be8207e67aca6f1718259802f2a02b569a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878168Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708997}
-
Anatoliy Potapchuk authored
These code duplications will produce even more code duplication in the future(e.g. splash screens). Bug: 1015383,1006230 Change-Id: I0920d2251f24b199316a9ff341b81ad63d41ca5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871694 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708996}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=chfremer@chromium.org Bug: 891670 Change-Id: Ic9261b3931c4a01b8bde09d5d9c57d64ccaf8762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878193 Commit-Queue: Carlos Caballero <carlscab@google.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#708995}
-
Mihai Sardarescu authored
This CL removes the pre-UnifiedConsent strings that are now obsolete. Bug: 1015805 Change-Id: I3c99acd5ee823ce1bdce6ae60d798b5fd675882d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869411 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#708994}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ca0cdfbf..2c6f0545 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7e9ddb524214112456e96dd5a9cefd12ec3ac2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877375Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708993}
-
Antonio Gomes authored
BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I07db63725f503c3483f4d52fef62a5228fc596ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874425 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#708992}
-
Christian Dullweber authored
This reverts commit d4365c02. Reason for revert: Suspected to break lots of tests in https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/57830 Original change's description: > Add browser process Metal shader compile histogram > > We are already doing this in the GPU process as the histogram > Gpu.Metal.TestShaderCompileSucceeded. That histogram indicates that > we fail to compile the shader from the GPU process within 6 seconds 2% > of the time. > > The new histogram Browser.Metal.TestShaderCompileTime histograms the > shader compile time, up to 1 minute, whereupon it uses the max bucket > (3 minutes). > > Also add a DumpWithoutCrashing on timeout. This will have to be removed > after one promotion to dev (to not drown out real crashers), but will > help gather more information about crashing machine profiles. > > Move the test shader code into the metal_util component so that it can > be used by both locations (the previous implementation was in /viz/). > > Bug: 974219 > Change-Id: Ieeac67d7dcbef53d7e3cc257eca6ba9fccf94286 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872624 > Commit-Queue: ccameron <ccameron@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708870} TBR=avi@chromium.org,ccameron@chromium.org,isherman@chromium.org Change-Id: I8c737c18e8e56d851e71474e27877a0f7333c7a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 974219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878375Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#708991}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/806747e03674..56d4da0510a5 git log 806747e03674..56d4da0510a5 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 7738ed713e7b..883e817b14bf (1 commits) Created with: gclient setdep -r src/third_party/angle@56d4da0510a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None Change-Id: I520f5fd85037910d59226726c1f422b071334201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877456Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708990}
-
Stephen Nusko authored
We also solve two issues that we saw: 1) Increased memory usage, this was caused because the original try used a single value for all ValueTypes which increased empty strings even if not used. We address this with allowing every ValueType to have its own value. Some memory increase is expected (but won't be the +7% we saw) and is only while tracing is active. We expect to see memory regressions of some small percetange as the pinpoint perf below shows. 2) Return only valid indexing iids, originally we searched the whole array but that included default initialized values and thus we assigned invalid index iids. This is address by keeping track of how much of the array has been used. This changes CPU overhead by ~2% (-5% to +2% at 95% confidence). Results here: https://docs.google.com/spreadsheets/d/1SIFHwNexnHHn4AELV0ZktHav_Ni7AtohVycKWWwMNEI/ Google internal: CPU profile with MRUCache https://pprof.corp.google.com/user-profile?id=df279687f82a1b1ae910d3805c631a5e&showfrom=.*%5BTt%5Drac%5Bie%5D.* CPU profile with std::array https://pprof.corp.google.com/user-profile?id=7adaf0baf6c45b9bc9e00aeabb5e4ced&showfrom=.*%5BTt%5Drac%5Bie%5D.* Bug: 1012257 Change-Id: I3b627cb0b3c2f814ecf6f2106c32b8b439a2f522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849679Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#708989}
-
Dominique Fauteux-Chapleau authored
Bug: 1008510 Change-Id: Ib6d4e68972c6287539bf5a59e768b31103683bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855679Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708988}
-
Omer Katz authored
When this check is called from the mutator thread it does not need to be atomic. Adding a template layer between MarkingVisitorBase and (Concurrent)MarkingVisitor to choose the right access mode to use Evaluated this change on the regressed metrics from https://crbug.com/1005476. The metric rendering.mobile/queueing_durations/balls_css_key_frame_animations was reduced from 5.9 to 4.5 and jank dropped by 2 (see pinpoint job 1644ff41c20000). Bug: 986235, 1005476 Change-Id: I767f1be9a3d387d63d49ec4643e90f3022c608b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872100 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#708987}
-
Yi Su authored
URL spoofing may happen when: 1. A web page is loaded then trying to load a new URL every 10ms by JS; 2. The user starts a new navigation, which is never actually started because WKWebView is overwhelmed by JS; 3. No WKNavigationDelegate callback of the new navigation is invoked, so our current code doesn't emit any WebStateObserver event; 4. LocationBarMediator depends on WebStateObserver callbacks to update the URL, so the URL is never updated but WKWebView is still displaying the old page, thus the URL spoofing happens. This can be solved by 2 steps: 1. Update WebStateImpl.IsLoading inside the KVO callback of WKWebView.loading. This ensures that WebStateObserver::DidStopLoading is emitted when user's navigation is halted by WKWebView; 2. In GetVisibleItem of CRWSessionController/WKBasedNavigationManager, only return the pendingItem if WKWebView.loading=YES. Bug: 991763, 247693 Change-Id: Icb2a0a6ce8aa896f500a5b9a67ff793548784e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778864 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#708986}
-
Carlos Caballero authored
MessageLoop is going away soon. Bug: 891670 Change-Id: Id1ef32b04e087514454f3d76b5aeff7ff0d51f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876391 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#708985}
-
Kuo Jen Wei authored
Bug: 1017570 Test: Verify, on HALv3 device, the the photo mode preview resolution slightly larger than screen size is selected. Change-Id: Ibd6afd65d63c80990b92972e78310f32287c13c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877334Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#708984}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bd2007738e5a..d113ee326ba5 git log bd2007738e5a..d113ee326ba5 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 srte@webrtc.org Removes deprecated WebRTC-Bwe-AimdRateControl-NetworkState trial. Created with: gclient setdep -r src/third_party/webrtc@d113ee326ba5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I815f6124aad2b9cfd3fc2a2a08c54e0709d26841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877621Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708983}
-
Takashi Toyoshima authored
This patch updates the WebRequestCORSWithExtraHeaders test run with various configurations, based on kOutOfBlinkCors base::Feature, policy::CorsLegacyModeEnabled, and policy::CorsMitigationList. Bug: 1002884 Change-Id: I8929b588f6999ccec3bcf011cd019211c9fc256a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862356 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708982}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/402fbcca936b..20b416235aa6 git log 402fbcca936b..20b416235aa6 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 ppluciennik@opera.com Move ldflags (Metal dependency) to libdawn_native. Created with: gclient setdep -r src/third_party/dawn@20b416235aa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:1003381 Change-Id: I306a0a9c77c4c84f2d94344b4bae54284f51391e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708981}
-
Chromium WPT Sync authored
Using wpt-import in Chromium eccefc6f. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Icbb0d6f50e1529dd4fcfe0d261043fa2a61f80a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877374Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708980}
-
Joel Hockey authored
TerminalPrivateApi registers as a CrostiniRestarterObserver and prints out information about each stage of startup. Terminals currently rely on having a unique ID which is passed from chrome to the JS code in the callback to openTerminalProcess. This ID allows terminals to know which instance the onProcessOutput is meant for. Since this ID is not set for the startup text, terminal JS code will generate a random ID and pass it as a startup_id param in openTerminalProcess. This will be used to send startup text, but this switch is not passed on to vsh process creation. Bug: 1016680 Change-Id: Ibd0417f18f05f505b68f8f3f23ad23cb584dac0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876292 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#708979}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/d45051a43c..b186cfaa74 TBR=bmeurer@chromium.org Change-Id: I32eb41caa1007eac3a5ed334bdfa335d0d5e221d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878188Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#708978}
-
Arthur Hemery authored
Cleanup after enabling PerNavigationMojoInterface by default. This CL removes the old DroppedNavigation and AbortNavigation IPCs, that were replaced by disconnect handlers on the mojo interface. Bug: 784904 Change-Id: Ib6ce003398834f694e516b91386781d48e7e9892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810529Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#708977}
-
Richard Knoll authored
To match the updated mocks we need to show the initiating origin below the list of apps and devices. This also updates the paddings to match the mocks. Screenshot: https://imgur.com/mFoeyfg Bug: 1011286 Change-Id: Id35fa58658364cc20f93181ebbc5651ee456c05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878189 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#708976}
-
Gustaf Ullberg authored
This change switches to the StreamConfig versions of ProcessStream and AnalyzeReverseStream. This is part of the preparations for multichannel audio processing. It also means that Chromium no longer uses deprecated WebRTC APIs for audio processing. Bug: chromium:1016708 Change-Id: I105a1a434d081879f31efa8703f994e4111c0f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875261Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Gustaf Ullberg <gustaf@chromium.org> Cr-Commit-Position: refs/heads/master@{#708975}
-
Victor-Gabriel Savu authored
Add additional options for DeviceRebootOnUserSignout to allow rebooting after a virtual machine (crostini or plugin VM) has been started. Design Document: https://docs.google.com/document/d/1cIZsPD6rwm6ca5r8GCXUqr2gT1axsoGe0S0Hl2-OgCE Bug: 986755 Change-Id: Ida2a73e4d38897d13ddeeba53eb25c4311f2459d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840634Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#708974}
-