- 25 Jun, 2018 40 commits
-
-
Mitsuru Oshima authored
The capture window will not receive events while locked because there is an extra mechanism to block events in locked state, but having capture window in locked state will make lock UI unusable by mouse/touch. Explicitly release capture so that mouse/touch event works when locked. BUG=788782 TEST=covered by unittest Change-Id: I01849f71ec0f059a21b433295fbdf816962d44d4 Reviewed-on: https://chromium-review.googlesource.com/1112938Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#570100}
-
Jialiu Lin authored
Since now we need to prepare password hash for both sync, other gaia and enterprise passwords, we should rename the function as PasswordStore::PreparePasswordHashData(..) and don't gate on empty sync username. Also fix minor UMA logging issue in PasswordStore::SaveProtectedPasswordHashImpl Bug: 830998 Change-Id: I26cb613babcdd0268785e61b52c021aa9f343cb5 Reviewed-on: https://chromium-review.googlesource.com/1112586Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#570099}
-
Ryan Sturm authored
Because other features (capping heavy pages in particular) wish to us incredibly similar functionality as the previews opt out blacklist, this should be moved to a component. components/blacklist will be a component for consumable blacklists and opt_out_blacklist is a sub directory of one such blacklist. TBR=pwnall@chromium.org Bug: 852593 Change-Id: I1b0b041eac6a715c70eaa3cf24542f63977caa50 Reviewed-on: https://chromium-review.googlesource.com/1109035 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570098}
-
Xianzhu Wang authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic7258e4b4e03988344412e2e15893ea30f68ae38 Reviewed-on: https://chromium-review.googlesource.com/1112939Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570097}
-
Chris Mumford authored
The extensions network throttle (ExtensionThrottleManager) used to use the net::NetLog to log throttling activity. Logging was only done if ExtensionThrottleManager::set_net_log was called, but that was removed nearly four years ago in refs/heads/master@{#298862} (https://codereview.chromium.org/631203003). This change removes the logging implementation as these classes will soon be moving to the render process. Bug: 784576 Change-Id: I1025dd6f3134d438e549165f5b7045b3ecf2dc61 Reviewed-on: https://chromium-review.googlesource.com/1113899 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570096}
-
Nicolas Pena authored
This CL changes the |origin_time_| and |zero_time_| of DocumentTimeline to TimeTicks. Change-Id: Idd51311085539cf5ed4c8a5b2e1b9bb21187be65 Reviewed-on: https://chromium-review.googlesource.com/1110956Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#570095}
-
Ryan Tseng authored
bug: b/110702574, 855396 Change-Id: I3be9d02d2ed07b39bfa10535f3cafee86e01d044 Reviewed-on: https://chromium-review.googlesource.com/1112871 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570094}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8498e15ed6611c2fc853e0aff3e0c97ca8a94516 Reviewed-on: https://chromium-review.googlesource.com/1114000Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#570093}
-
Avi Drissman authored
WebContents::GetURL() is deprecated because there's no way to know *what* URL it's giving you. In this particular case, it pulled a URL from the *future* of a page's navigation history, which caused a loop to not terminate properly. (And all the metrics are wrong :( ouch ) BUG=854430 TEST=as in bug Change-Id: I798af0278ffde3421fa933644513fafba8bd0b2d Reviewed-on: https://chromium-review.googlesource.com/1113660Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#570092}
-
Kyle Horimoto authored
Bug: 824568 Change-Id: Ia0c761353aff3ca86848e36ec90f85d6a7ff7373 Reviewed-on: https://chromium-review.googlesource.com/1112953Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#570091}
-
Andres Calderon Jaramillo authored
This CL modifies the V4L2JpegDecodeAccelerator::ConvertOutputImage method to pass the coded size of the output VideoFrame to libyuv instead of passing the size of the V4L2 output buffer. The motivation is that the coded size of the V4L2 can be larger than the coded size of the VideoFrame. For example, on an elm (CrOS 10802.0.0), decoding a 41x22 image causes the V4L2 buffer to be 64x24 while the coded size of the VideoFrame is 42x22. So, it doesn't seem safe to pass 64x24 to the libyuv conversion routines assuming that the VideoFrame is backed by memory that's only enough for a 42x22 frame. This doesn't fix the referenced bug, but it should make copies safer even for even-sized images. I tested one of the modified paths on an elm (when output_buffer_pixelformat_ == V4L2_PIX_FMT_YUV422M and the output_buffer_num_planes_ != 1) to make sure the tests still pass. I couldn't find a device to test the path when output_buffer_pixelformat_ == V4L2_PIX_FMT_YUV420M and output_buffer_num_planes_ != 1, so relying on automated testing. Bug: 852236 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id0acef8f6f6c5e144ff4d6620dd3db3b53bff415 Reviewed-on: https://chromium-review.googlesource.com/1111247Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#570090}
-
Peng Huang authored
This reverts commit 8fe6701f. Reason for revert: webkit_unit_tests failing on chromium.mac/Mac10.13 Tests Original change's description: > Scheduler: Bug in FrameAndTaskPriorityExperiment. > > LowPriorityForSubFrameThrottleableTask study isn't using is_subframe > signal. That is, all throttleable tasks are assigned low priority > regardles of the type of the frame. > > Change-Id: I1e924ef483b458a9b0d21e81a91d275901b9cb37 > Reviewed-on: https://chromium-review.googlesource.com/1112248 > Commit-Queue: Farah Charab <farahcharab@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570043} TBR=altimin@chromium.org,farahcharab@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 856255 Change-Id: I0236f77b0f551610fca97a93c148c9016d8f7bb9 Reviewed-on: https://chromium-review.googlesource.com/1113838Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570089}
-
Max Morin authored
Drive-by fix some lint. Bug: 851940, 856176 Change-Id: Ia42c0902b58cd278afc2c4703a50982204ef75b8 Reviewed-on: https://chromium-review.googlesource.com/1099235 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#570088}
-
Alexandr Ilin authored
This CL removes the copy constructor from the gfx::GpuMemoryBufferHandle replacting it with move operations. This is preparatory step to make GpuMemoryBufferHandle using the new shared memory classes that are move-only. GpuMemoryBufferHandle holds a system resource that should be properly closed after use. Move semantics allow to introduce the more clear ownership model and prevent resource leaks. Bug: 854594 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I27907d7a8b09aa4003de2c846966bf7d97aaa30c Reviewed-on: https://chromium-review.googlesource.com/1109972Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570087}
-
Daniel Nicoara authored
Allows the Cast display configurator to configure the lookup tables for degamma and gamma. BUG=b/109942195 TEST=Compile Change-Id: I9d3f738ca9024060484dd5eef8202884b38cc3b8 Reviewed-on: https://chromium-review.googlesource.com/1113803Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#570086}
-
Yi Su authored
Add feature flag for copying image to system clipboard. Bug: 163201 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8110f65f739891b01b82b866215b122dd93ac0aa Reviewed-on: https://chromium-review.googlesource.com/1112661 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#570085}
-
bsheedy authored
Adds two workarounds for Chrome being resumed or started too early when entering VR. These can be removed if/when the platform-side issue that causes these issues is fixed in VrCore. Bug: 854327, 762724 Change-Id: If9645c58e9d208a734582992aad5c85d378f5f40 Reviewed-on: https://chromium-review.googlesource.com/1112761Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#570084}
-
Lindsay Pasricha authored
Bug: 844670 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icd830a0791b891393f2608aa11c487639d6a9a72 Reviewed-on: https://chromium-review.googlesource.com/1095734 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570083}
-
Orin Jaworski authored
The G is made 16x16 within a circle of diameter 24. This icon is used for default and knowledge graph answer results. Bug: 855723 Change-Id: Ia8b48837208606b4dcf515412b642ad780e16718 Reviewed-on: https://chromium-review.googlesource.com/1112643 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#570082}
-
Hongchan Choi authored
CallbackBufferSize() were scattered around many classes for no specific reason. This CL cleans them up and contains it to DefaultAudioDestinationNode. Bug: 854229 Change-Id: I9116cf8ecd9398108fcdcac89cbbfb8c42de957e Reviewed-on: https://chromium-review.googlesource.com/1112072 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#570081}
-
Koji Ishii authored
This patch removes U+FFFC from characters to have zero-width. LayoutNG does not have this specialization, and Edge and Gecko do not make U+FFFC zero-width either. As part of the investigation, zero-width-characters.html was changed to testharness.js. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I278778bd030d87f6691de0e217b53e5cd62287a1 Reviewed-on: https://chromium-review.googlesource.com/1110182Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#570080}
-
Florent Castelli authored
Bug: 803494 Change-Id: Ie8e7d6b4cf14be21cecc4e0b9bd6f808cef487c4 Reviewed-on: https://chromium-review.googlesource.com/1102436Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570079}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/29f3b8927f88..7d423fc5614b git log 29f3b8927f88..7d423fc5614b --date=short --no-merges --format='%ad %ae %s' 2018-06-25 perezju@chromium.org [Telemetry] Remove workaround for closing browser before tracing stops Created with: gclient setdep -r src/third_party/catapult@7d423fc5614b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:854212 TBR=sullivan@chromium.org Change-Id: I3c562b6ca2fdc6a3d7c2c758c0f1e4dde5b70e8e Reviewed-on: https://chromium-review.googlesource.com/1113478Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570078}
-
Becca Hughes authored
Adds logic to DisplayCutoutHostImpl to only use the viewport fit value from the current fullscreen frame. If there is no fullscreen frame then we should default to auto. Also renames a mojo call from ViewportFitChanged to NotifyViewportFitChanged to avoid a naming collision with WebContentsObserver. BUG=838400 Change-Id: I78498db747739b5def5f19b70563d9ea18612700 Reviewed-on: https://chromium-review.googlesource.com/1105510Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#570077}
-
Theresa authored
BUG=854866 Change-Id: Icb0b087efca580ca640a346ed916103b36c50bff Reviewed-on: https://chromium-review.googlesource.com/1113797Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#570076}
-
Michael Thiessen authored
Simplifies testVrIntentStartsVrShell and test2dIntentExitsVrShell. Change-Id: I9a8b6413741afab62f03ffb667969c30821f93a3 Reviewed-on: https://chromium-review.googlesource.com/1113757Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#570075}
-
David Reveman authored
Use a map to track pressed keys. The key for the map is the physical code that was pressed and the value is a potentially rewritten code. This allows us to generate appropriate release events when physical keys are released, while still allowing the event rewriting logic to work as expected. Note: Exo clients will always see a release for the same code as the code that was generated when the physical key was pressed. This is necessary in order to not break client side keyboard state tracking and might not match the events that are generated internally. That is because event rewrite logic is usually not rewriting both the press and the release events, often just the press event. Bug: 847500 Test: exo_unittests --gtest_filter=KeyboardTest.OnKeyboardKey Tbr: hidehiko@chromium.org Change-Id: I23240304bd377e3855971edd079ade1b537a74f9 Reviewed-on: https://chromium-review.googlesource.com/1112967Reviewed-by:
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/82901f0040da..c6347f057d3a git log 82901f0040da..c6347f057d3a --date=short --no-merges --format='%ad %ae %s' 2018-06-25 lalitm@google.com trace_processor: fix memory leaks in sched slice tests 2018-06-25 treehugger-gerrit@google.com Merge "trace_processor: add unit and integration tests for sched slice table" 2018-06-25 treehugger-gerrit@google.com Merge "trace_processor: fix gcc build" 2018-06-25 lalitm@google.com trace_processor: add unit and integration tests for sched slice table 2018-06-25 lalitm@google.com trace_processor: fix gcc build Created with: gclient setdep -r src/third_party/perfetto@c6347f057d3a The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:80416541,chromium:80416541,chromium:80416541 TBR=perfetto-bugs@google.com Change-Id: I22d8e88796ae0c26c571b4e169f2f220799dfdf1 Reviewed-on: https://chromium-review.googlesource.com/1113818 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570073}
-
Ella Ge authored
RenderWidgetHostViewAura should use IsMouseLocked instead of mouse_locked_ because the locked state is stored in RWHV_event_handler. Remove mouse_locked_ from the base class to prevent misuse. Bug: 812964 Change-Id: I5201c7b6d77d1e52f9da2344899b6ab293e44f86 Reviewed-on: https://chromium-review.googlesource.com/1102911Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic96ed128f4925cf32c3028932dca369033eec300 Reviewed-on: https://chromium-review.googlesource.com/1112952 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570071}
-
stkhapugin@chromium.org authored
Update the location string, not only the security icon, when the security state changes to indicate correct URL on interstitials. Bug: 853332 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3ba5e7dcaf26945f394892354127be01fa9564a7 Reviewed-on: https://chromium-review.googlesource.com/1113744 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Tom Sepez authored
Describe what makes a good report. Change-Id: Ia76e5eea68cd4ed490d0282662db432c7167cab3 Reviewed-on: https://chromium-review.googlesource.com/1110274 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#570069}
-
Mounir Lamouri authored
Bug: 855883 Change-Id: I208dab13ef989714b5385b92a70fb70155bddf3c TBR: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1113897Reviewed-by:
-
Michael Spang authored
Rather than waiting for the page flip event to return the status, return it right after it's determined, which is immediately after submitting the page flip to the kernel. This requires splitting the page flip callback into two callbacks, one that takes the status and one that takes the presentation feedback. This should be familiar as the GLSurface API has exactly the same separation. This does not actually change when GbmSurfaceless passes the ACK along, so there should be no visible change. Changing when the ACK is returned from GbmSurfacless can be done but would also require changes to viz::BufferQueue. Bug: 851997 Test: unit tests, CrOS still renders Change-Id: Ided422ca3065e431ca8c9a5909b3faae72d97cc5 Reviewed-on: https://chromium-review.googlesource.com/1104863Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570067}
-
Koji Ishii authored
This tests when the inline-size is [min-content]: * A `­` produces a break opportunity when computing the min-content inline size. * The hyphen character generated by `­` is included into the min-content inline size. Originally developed in [CL:1111895]. [min-content]: https://www.w3.org/TR/css-sizing-3/#valdef-width-min-content [CL:1111895] https://chromium-review.googlesource.com/c/chromium/src/+/1111895 Bug: 636993 Change-Id: Ib492b2db023a5169247ca00e5b745e42ec33d197 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1113085 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#570066}
-
Leonard Grey authored
Consider two views: A and its child view B. The "Views::Layout" trace event for B is currently emitted when A calls B's Layout as part of A's Layout. This is less intuitive than calling it in B's Layout, but is better because it can capture an event for a B which doesn't call through to the base class Layout implementation in its Layout. Unfortunately, this still leaves many gaps: 1) Layout managers 2) Views whose *parents* don't call the base class implementation 3) Layouts triggered by bounds changes 4) Probably some more I can't think of right now. This change adds extra trace events to address #3 from the list above. Bug: 850128, 835983 Change-Id: I135ac0e8b2c6b9e277dce6da06e9d0aeae7dfbd1 Reviewed-on: https://chromium-review.googlesource.com/1112466 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#570065}
-
Philip Rogers authored
This patch removes an optimization added in [1] to not invalidate graphics layers when the offset from layout object changes. This offset is no longer used for scroll offset so the original intent no longer applies [2]. Removing this optimization causes an additional invalidation in a rare case (vertical writing mode scroll origin changes) but reduces complexity in a difficult area of code. This patch also removes a SetNeedsDisplay of the scrolling contents when the scroll layer's offset changes. The scrolling contents layer is now only invalidated if the offset actually changes. No tests were affected by this change. In addition, all callsites were setting the offset_from_layout_object_ to an IntSize, so the type has been updated from DoubleSize to IntSize. [1] https://trac.webkit.org/changeset/134628/webkit [2] https://chromium.googlesource.com/chromium/src/+/0241ab94255bdc1fcb0c84b6cd2a0937ecf9fb90 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib359ad5e3c8dda61a06b5050625f99f204b558cc Reviewed-on: https://chromium-review.googlesource.com/1112916Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570064}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3ecec176a825..8396e3498fd4 git log 3ecec176a825..8396e3498fd4 --date=short --no-merges --format='%ad %ae %s' 2018-06-25 aleloi@webrtc.org Remove APM limiter in Audio Mixer. 2018-06-25 minyue@webrtc.org Adding jitter buffer plots for all SSRCs in event log visualizer. 2018-06-25 titovartem@webrtc.org Extract third party part of g722 codec into separate target Created with: gclient setdep -r src/third_party/webrtc@8396e3498fd4 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3dd1ca3fdf095e61da98ab391ed06554b55d0bdf Reviewed-on: https://chromium-review.googlesource.com/1113817Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570063}
-
Sam Maier authored
Bug: 853329 Change-Id: Icde8c71cd03fcec6bf2c4d2b97cca580fdc98c52 Reviewed-on: https://chromium-review.googlesource.com/1103060Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#570062}
-
Koji Ishii authored
ShapingLineBreaker handles trailing spaces at the end of wrapped lines. But when the line ends with hard break or at the end of a block, NGLineBreaker needs to remove the trailing spaces. When the trailing space is not safe-to-break; e.g., the font has kerning pairs between the last non-space character and the trailing spaces, this patch ensures that the line width is correct by reshaping the end. Not doing so caused min-content and max-content differ when there are no break opportunities, because trailing spaces for min-content is handled by ShapingLineBreaker while for max- content is handled by NGLineBreaker. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If8c810b7e4cfccfd7a35f6dd48d15ce67b98c036 Reviewed-on: https://chromium-review.googlesource.com/1111749 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
