- 30 Oct, 2020 40 commits
-
-
Nico Weber authored
Bug: 1143700 Change-Id: If1110313fda223d83d17db5600f2041c3e1f6f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510229 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#822644}
-
Mark Yacoub authored
Refactor: Move finding a primary plane for Test Modeset or Commit Modeset early on so the plane args could be extended and manipulated in tests, and test would fail quick on failure to find a plane. BUG: 979736 TEST: Test & Commit succeeds. Change-Id: I88de210a59dba67912227a94f542ccff7f771e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505938Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#822643}
-
Nate Fischer authored
No change to logic, only docs. This changes the "Android 10" section to be "Android 10 and later" since Trichrome still applies in R (and will continue to be the format for the foreseeable future). Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ia3fc77f32a778be7845ef3afba1215d5d5d5fe75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508317 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#822642}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: Ia59d2a208d9fcbf371ad8fd2ed59e5cdb865df64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507690Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#822641}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c21902c0d3cc..9615bcf71f2a 2020-10-30 johnstiles@google.com Revert "Moved SkSL data back into node classes" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I821185422830b55d0300198a9cbd2d3fa80effd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510122Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822640}
-
Chris Sharp authored
Change-Id: I6141c37d1a380aa354c6fac7310564a86bfc0b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509991Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#822639}
-
Esmael El-Moslimany authored
When a user chooses to hide shortcuts, the most-visited element should have zero height and width. Bug: 1144029 Change-Id: I3cd1b1e02c6d283229ae058e08ca7ca557cbeac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508880 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#822638}
-
sandromaggi authored
This refactors |WebController::GetElementRect| to take an |ElementFinder::Result| instead of a |Selector|. Bug: b/168107066 Change-Id: I0cbe7b12c95a92dac14c992017e41e3b0301f5e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505650 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#822637}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604037316-5cbbc085308516b08a183c882c2ebb61cfb969d4.profdata to chrome-linux-master-1604059108-a438e57d21f2dfad804e970e84edcffc08a2b95c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I40d145981440379d1f3ca7d1e8a1f63c9109815f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510309Reviewed-by:
-
Michele Mancina authored
Scripted delay time, active processing time and passive wait time are now recorded and sent back to the backend. Bug: b/170722915 Change-Id: I057e53e559767a575a2ffda12f835cee75f8462c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489885 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#822635}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f5e8f808975b..e184bf1e5f83 2020-10-30 yangguo@chromium.org [ts] Typecheck LayerViewHost.js 2020-10-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-30 janscheffler@chromium.org [TypeScript] Move DebuggerPlugin.js to TypeScript 2020-10-30 alexrudenko@chromium.org Enable TypeScript for SoftContextMenu.js [part 1] 2020-10-30 changhaohan@chromium.org Move CSSAngle-related files from elements/ to inline_editor/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1126178 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I706e0981a9ef33d4e3e7ff0483d6185cb8989d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510117Reviewed-by:
-
Clemens Arbesser authored
New protos as per the design doc linked in the bug. Bug: b/171776026 Change-Id: I50cfdfe790d0d37f206bca1166d6597b749af79d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502201 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Alex Rudenko authored
This CL adds the possibility to disable image formats (AVIF and WebP) in order to test fallback scenarios. Design doc: https://goo.gle/devtools-image-fallback Frontend CL: crrev.com/c/2505785 Test command: `third_party/blink/tools/run_web_tests.py http/tests/inspector-protocol/emulation/emulation-set-disabled-image-types*` Bug: 1130556 Change-Id: If442365212750995d10cb5a5d9650738ed44fddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470663 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822632}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: If158a4378ff6ce28c3d95824e15c30c2a0ed4f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510109Reviewed-by:
-
Jan Scheffler authored
Bug: chromium:1144127 Change-Id: I2fc34e51d9f6f36b3fa71f64e745b1d30bec2c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509579 Auto-Submit: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#822630}
-
Matt Menke authored
This allows signed exchange certificate transparency checks to look up information learned from previously observed Expect-CT headers. Bug: 1087091 Change-Id: Ie1675dad10a89d751797786dbb31d65b0a177dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500562 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#822629}
-
Matt Menke authored
This prevents cross-site leaks when a failed CT check uploads a report. It also means we'll actually be able to check Expect-CT headers using the correct key - without this, we'd only send a report if we've seen an Expect-CT header when using an empty NIK, which isn't terribly likely (or if there's a match in the static global CT tables). Bug: 1087091 Change-Id: I71199464f54110e5d09262edcf0a1dbaa79691e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462387 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Use common code for highlighting style of ::selection and ::target-text. Bug: 1136817 Change-Id: I42ba2a508f07c25e636c04c93c91d3e724151f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504309 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822627}
-
Bill Budge authored
- Removes tests that depended on the existence of the Flash plugin. Bug: chromium:1143546 Change-Id: Ib5dc2035f303cc3510db52d491813759123e7b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508009 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#822626}
-
Andrew Grieve authored
Bug: 1122182 Change-Id: I29b579cf7c5e7eb6d2528a6fad28562059698bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508342Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#822625}
-
Mikel Astiz authored
Sample failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/60367 Bug: 1144142 TBR=nator@chromium.org Change-Id: I9acdc89728509c2af01f51d2071b3b7f3f909c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509513Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#822624}
-
Oriol Brufau authored
Both GridTrackSizingAlgorithm::ResolveIntrinsicTrackSizes and IndefiniteSizeStrategy::FindUsedFlexFraction have a vector of track indices and want to iterate the grid items in these tracks. But they only want to do the work once for each item, even if it spans multiple cells in one of these tracks, or it spans multiple of these tracks. What they used to do was to insert the items provided by NextGridItem into a HashSet, and check whether it was a new entry or it was already there. Instead, this patch modifies ListGridIterator::NextGridItem so that it skips items already processed in an earlier cell of that track, and adds a IterateGridItemsInTrackIndices helper function which takes care of creating the iterators, calls NextGridItem, and skips items already processed in an earlier track. The already processed items are detected looking at their indices, so the HashSet is no longer used in release builds. It's only kept in debug builds to ensure that the logic is solid. This should have no effect in practice, other than better performance: the nested-grid-lots-of-tracks perf test improves by ~26%, and the nested-grid, auto-grid-lots-of-data and auto-grid-lots-of-spanning-data improve by 5-7%. On the other hand, fixed-grid-lots-of-data and fixed-grid-lots-of-stretched-data worsen a bit by 2-3%. Change-Id: Ibedbfa48c8825cff129797ba759dc22cf6972017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508472Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#822623}
-
Nico Weber authored
Apparently git footers need to be in one paragraph. Bug: none Change-Id: I7048bf7fc21c5f52cd9d9ac31de08a0ad81d4dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510189 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
cfredric authored
Bug: 1129506 Change-Id: I9364116e4f210dcfdcfa0e4a6902deb828381565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503492Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#822621}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e6c9497255c6..1459d852b166 2020-10-30 jari.komppa@siru.fi Add check for vtable in memset template If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3a88b86605e44a57d7cca3a9fca46ec4a9bb7a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510089Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/257b9ad9fed6..a8c01862f57f 2020-10-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c1839ee3cedd to e6c9497255c6 (4 revisions) 2020-10-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 80c364fa to 1e88b939 (901 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I89926df2827b6235878d946775a86e309df49be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510112Reviewed-by:
-
Friedrich Horschig authored
(This CL doesn't change behavior.) An internal/ target should not depend on chrome_java. Therefore, this CL tries to remove it and replace it with direct dependencies, e.g. to resources. Bug: 1101256,1092444 Change-Id: Id6c1ecef944222ab7d85e850f5ec819273c2ca2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315147Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#822618}
-
Luciano Pacheco authored
Add a new PAK file for resources in Files app and companion apps like Audio Player, to host the generated JS modules. Change ChromeComponentExtensionResourceManager to also load the resources from this new PAK file. This is a preparation for converting these apps to JS modules. Bug: 1133186, 1030998 Change-Id: I00b650d271e758e0cad82a8b4c109f128d0285d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503909 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#822617}
-
Kuo-Hsin Yang authored
These benchmarks are not used anymore. Change-Id: I1e1aed69eb108217afe2886491cd8675878a819a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503532Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#822616}
-
Alfonso Castaño authored
Now the description for Trusted Type objects is generated in Blink rather than in V8 what makes it simpler and safer. The description will be generated from the original toString() method, avoiding calling into potential redefinitions of toString() by the user. Corresponding V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/2502342 Follow-up V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/2502869 Screenshot: https://i.imgur.com/tDZoRtv.png Bug: chromium:1048143 Change-Id: I3254e97f0cdc967e51a6d06b2460cc140066be08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502589 Commit-Queue: Alfonso Castaño <alcastano@google.com> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#822615}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2df07dc6650..e96b7cfe71db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mastiz@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mastiz@google.com Change-Id: I59ebfdfff941c4d2631a79e2af1b94ec97dda7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510114Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Gauthier Ambard authored
This CL adds the plumbing to be able to use the native ContextMenu on the WebView. Bug: 1140387 Change-Id: Ib30e294dd91161d070793c49a261fe9ab3d7cd24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505771 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#822613}
-
Prashant Nevase authored
The DecodeImageIfNecessary() is modified to take care of applying dark mode before creating DecodedDrawImage. The result of dark mode is plumbed on DecodedDrawImage which will be used during rasterization. Bug: 1094005 Change-Id: I8e362f357743208141c3aecf1612fdf4123ed3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482562 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#822612}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/20088de02e9a..f5e8f808975b 2020-10-30 alcastano@google.com Fix dark theme in Devtools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1143923 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I52981a60c2caa12d843b56ae1520a1e9bfa64c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510110Reviewed-by:
-
Wei Lee authored
This is for SWA version to control its window state just as we did in Chrome App Window API. Bug: 980846 Test: Tested with previous CLs to make sure the window state is controllable in the SWA version of CCA. Change-Id: Ib757e78ed0d9a9bec23f1e78c5a257d6e312bc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257084 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#822610}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/75ae62960411..c7be37e12173 2020-10-30 sdefresne@chromium.org Ping mac_toolchain to 6e584bf785867bc3b340f82bb2f7a6cd42ba22a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1143664 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I5cbdfe4479ed2b106895e64488e793ef4fac2664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510111Reviewed-by:
-
Saurabh Nijhara authored
We can get different error codes if the extension installation fails due to crx install error. We want to add crx install error detail event to the existing events for the event based reporting for force installed extensions so that these error codes can be recorded. Bug: 1048640 Change-Id: I9a984d960c540087e8c211515c944ade444e8374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469556 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#822608}
-
Yuki Shiino authored
malloc_size is provided only on macOS/iOS (the counterpart on GNU/Linux is malloc_usable_size) and the argument type is |const void*| [1]. This patch fixes the argument type. [1] https://opensource.apple.com/source/Libc/Libc-825.26/include/malloc/malloc.h.auto.html Change-Id: I62e57d4f7bae1098db92ede760a1fdf44746d4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505334 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#822607}
-
Igor Britsky authored
For GCC 8.4.0 is important to get all the first initializer in designated init-list in case of implicit construction. Correct compile if use explicit construction. Error example (GCC 8.4.0): In file included from ../../gpu/vulkan/x/vulkan_surface_x11.cc:9: ../../ui/base/x/x11_util.h: In function 'bool ui::GetArrayProperty( x11::Window, x11::Atom, std::__1::vector<_Tp>*, x11::Atom*, size_t)': ../../ui/base/x/x11_util.h:149:73: error: no matching function for call to 'x11::Connection::GetProperty(<brace-enclosed initializer list>)' Bug: 819294 Change-Id: I1f10321d1c162d955c5a85834bf5878a3cfa3d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505978Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#822606}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1603983512-c60ff6e0a6baf9584b1a93640671c446cc84aec9.profdata to chrome-win64-master-1604026576-08f66091b769bbb2281c77ed5a9c423e18843d7c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If829a4167f1555204e31a89fcbefbfef2310bdcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508657Reviewed-by:
-
